- 15 Sep, 2020 40 commits
-
-
Ian Clelland authored
This reverts commit 1cb4c9a7. Reason for revert: Test failures on MacOS 10.14 and 10.15 bots seem to be caused by this CL. See https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests/4038 (https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests/4037 included the change, but failed for an unrelated reason) and https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/8410 (and subsequent builds on both bots) Layout test failure example: https://test-results.appspot.com/data/layout_results/Mac10_14_Tests/8416/blink_web_tests/layout-test-results/results.html This looks like it is just a test result that needs to be updated, but it's also possible that the new breaking algorithm is incorrect in this case. Reverting since the original change landed within the last few hours. Original change's description: > New TextBreakIterator's default behavior breaks after space run > > Before this change, we were considering breaking opportunities before > space runs. This approach allowed us to avoid re-shaping in many cases, > which has an important advantage in terms of performance. > > However, the Unicode spec (UAX#14) state that breaking before a space > character is not allowed [1], so we had to implement this logic after > our TextBreakIterator had already determined the best breaking > opportunity. This approach has been working fine so far for regular > spaces (white-space, tabs, ...), but it doesn't work correctly for > other BA [2] class characters; in the CSS Text specification, these are > known as "other space separators" [3]. > > In order to implement the correct behavior for any kind of space, we > would need to change our TextBreakIterator implementation so that > matches the Unicode rules, considering breaking opportunity after > space runs. This change should also consider the performance impact > of the extra re-shaping operations required to deal with trailing > spaces. > > In order to prevent performance regressions, we'll store the position > of the 'end of non-hangable run', which will be used in case of items > with styles dictating rules to collapse trailing spaces. > > [1] https://unicode-org.atlassian.net/browse/ICU-20843 > [2] https://www.unicode.org/reports/tr14/tr14-39.html#BA > [3] https://drafts.csswg.org/css-text-3/#other-space-separators > > Change-Id: Ie4a3890c75a3faff1a0155d4a40bcaa85bc6ac06 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047943 > Commit-Queue: Javier Fernandez <jfernandez@igalia.com> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806928} TBR=jfernandez@igalia.com,kojii@chromium.org Change-Id: I79a3c7f20064ecc4f5c995f35027c730eb7c409d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412131Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#807019}
-
Sadrul Habib Chowdhury authored
After the removal of 'universal' metric, we no longer need to separately report the metrics for 'slower thread'. So it is removed. BUG=1122176 Change-Id: I7d0cb19614fbebf0b21decc0b982b080b139e7f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410917 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#807018}
-
Thomas Tellier authored
Bug: 1043903 Change-Id: Ie5cf4ce7f0465e538b077e25b472d545014eb9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403285Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#807017}
-
Vladimir Levin authored
This patch ensures that when we consider whether or not to create pending tree tiles, we always do so if the LCD state or the raster transform change. This is required since if any of those change, then we remove the whole active tree tiling before activating the pending one. This means that if the pending tree tiling does not have the tile (because it thought the active tree one would remain), we can encounter flickering due to missing tiles. R=wangxianzhu@chromium.org Bug: 1127803 Change-Id: I45ad2c591de7c215f73f7081ad2e2e5be9d68925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411492Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#807016}
-
Boris Sazonov authored
Changes sign-out flow logic in PrimaryAccountManager: 1. Allows sign-out flow even if there's only an unconsented account and adds a test for this. 2. Adds "if !defined(OS_ANDROID)" to DICE-specific PrimaryAccountManager & PrimaryAccountMutator tests. Bug: 1095128 Change-Id: I0d5b5e804b360ff2ea5c4bf7c6e3add07a21d835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391237 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#807015}
-
Greg Thompson authored
This mitigates a potential DLL search order hijack for processes that don't implement their own mitigation. BUG=1126506 Change-Id: I26d88354c6b4f8ce42eab0a3ba49eca6313611fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410030Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Eric Lawrence [MSFT] <ericlaw@microsoft.com> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#807014}
-
Fergus Dall authored
This reverts commit e1df5c80. Reason for revert: Breaks the chrome on cros bots until the cros CL gets pulled in Original change's description: > Remove all references to StartVmConcierge > > With CL:2398353 debugd will no longer control the lifetime of > concierge. Instead, concierge will start on the login screen and stop > on session exit. Therefore, all references to starting and stopping > concierge in the chrome browser should be removed. > > Bug: 1126268 > Change-Id: Icc4ec0f1e893c0bf226613163a6e5f07f17054dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402858 > Commit-Queue: Fergus Dall <sidereal@google.com> > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806837} TBR=achuith@chromium.org,hidehiko@chromium.org,dominickn@chromium.org,joelhockey@chromium.org,sidereal@google.com,iclelland@google.com Change-Id: I1d20c91cd5cc4fa573de12395a9c800e8cb973f6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1126268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412005Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#807013}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bc83da97d26c..8b068ffba19b 2020-09-15 tvanderlippe@chromium.org Remove initialization of globals in Runtime 2020-09-15 tvanderlippe@chromium.org Generate HTML entrypoints dynamically 2020-09-15 pfaffe@chromium.org Fix and reenable variable hover testcase If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1126475,chromium:1127785,chromium:1127902 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I19f7b53bdf01b9849781c890eaad5708d441f208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412078Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807012}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600148958-bab2bda8659b635656decb925279e513cc814d66.profdata to chrome-linux-master-1600171148-66b09300985d04c4504d7b1ddf5998f31579a7e2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I15e7860d0123665c21194530d66829b05b762c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412080Reviewed-by:
-
Christian Biesinger authored
R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1083010 Change-Id: If6735fc29c476703eaeb443860d5d6e8338fe7d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408722 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#807010}
-
Oleh Lamzin authored
Change-Id: I9331bbcdc43c7fadb0f266dd0f8685bdb7e5a9ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356486Reviewed-by:
Polina Bondarenko <pbond@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#807009}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I7c27f7c62dd15e645e38e3bdba4c7e0ef8d8fcc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412129Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#807008}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c852aafe897d..68241d4f5af5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC poromov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: poromov@google.com Change-Id: I3f26716d8370064965a17956807fdbf8e1df2c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412077Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807007}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/346ff6a4d7b2..b0a548c7e6b6 2020-09-15 fmayer@google.com macOS linker does not have -Wl,--build-id. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I006a53ab0f4685b12f75d7b2a5e36d84efd361c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412076Reviewed-by:
-
Javier Ernesto Flores Robles authored
This is a step in supporting Android passwords, which depend on the affiliation matcher being available. However the matcher might not be available if the user disables Sync, after saving Android passwords. Deleting by the recordIdentifier allows deletion of Android passwords without creating a valid Credential. Bug: 1090776 Change-Id: Iec8010f3c1514e6b59a1052db590bcaaaf83d8e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410250Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#807005}
-
Sigurd Schneider authored
The overlay agent is keeping a map from documents to a corresponding AXContext, but is holding on strongly to documents. This causes windows to not be flagged as detached (because the retaining chain through the inspector agent looks like it is alive). Bug: chromium:1110817, chromium:1112066, chromium:1128371 Change-Id: I7c3930f42e29a01634731379f7717257569303c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410864 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#807004}
-
Tanmoy Mollik authored
If MOBILE_IDENTITY_CONSISTENCY is on, the positive button in SyncErrorInfoBar should open ManageSyncSettings page instead of SyncAndServicesSettings page. Bug: 1126842 Change-Id: I9d446933b5319e85ae6812f28b732443c3814f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401470Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#807003}
-
Clovis PJ authored
Currently the data manager has a bind, making the test component unusable when we have separate UI, IO threads, and the service worker is running on the UI thread (under flag `kServiceWorkerOnUI`). As the bind must happen on the IO thread, but `BackgroundFetchContext::InitializeOnCoreThread` which calls this, must happen on the UI thread. This CL opens the issue up for discussion, to highlight the problem. But the fix is not intended to be a solution. Change-Id: I8565247dcd524336b725105cc83d2ddcb9ece1aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404793 Commit-Queue: Clovis PJ <clovispj@google.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#807002}
-
Andrei-Laurențiu Olteanu authored
Remove urandom routine from getAvailableRoutines. Bug: b:168283428 Change-Id: I01b57aad92f9bab755a741a9551177e3aed8071a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404791Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Cr-Commit-Position: refs/heads/master@{#807001}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I2283339e957edfcdc0d47b019131419f68c673d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412071Reviewed-by:
-
Mariam Ali authored
This CL offers both singular and plural options for the close button string in guest mode to allow translation as mentioned in b/168224245. Bug: none. Change-Id: I6b3c0d0e4bbd77e2e37035e62d7068358278ebe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410031Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Mariam Ali <alimariam@google.com> Cr-Commit-Position: refs/heads/master@{#806999}
-
Jamie Madill authored
With the additional functionality added to test_runner.py these now run correctly. Bug: angleproject:3162 Change-Id: I6c5ade3110f127714d86653d7293f21ca1b3ae32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408692Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#806998}
-
Alice Wang authored
This CL fixes the click to open incognito interstitial in AccountPickerBottomSheetRenderTest. Bug: 1127676 Change-Id: Ib6f8dcd60593240cf1e15b1ef2fe8d91698e1c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411929Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#806997}
-
Carlos Caballero authored
We are not going to use this feature in the near future as there are some bugs that make renderers send messages while cached. One of the issues we are seeing is that in processes with active and cached pages we can not guarantee that no messages are sent for the cached ones as some of the task queues are shared between pages. Until we have dedicated queues (the Multiple Blink Isolates project should help here) we should not consider a message unexpected if it comes from a process with non cached pages. We only have one compositor task queue and currently it is only frozen if all pages in the renderer are frozen, so if there is an active page it can still process tasks for the frozen page. This is what is causing the flakes in BackForwardCacheBrowserTest.WindowOpen Also input task queues are not frozen when the page freezes so that is causing flakes in BackForwardCacheBrowserTest.NavigateBackForwardRepeatedly so this patch disables the check for unexpected message in that test until the issue is fixed. Bug: 1116023 Bug: 1099395 Change-Id: Ibe4c89f14f828d581c1156fa2d1e8e63eeac1e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397698 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#806996}
-
Sergey Poromov authored
This reverts commit 969db5bf. Reason for revert: Seems to cause failures of CrExtensionsShortcutInputTest.Basic test on Mac: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/54723 Original change's description: > Extensions: Restore focus after clearing keyboard shortcut. > > Fixed: 1065659 > Change-Id: I39f314af200c8256eb31a6ffe20b7210dd9ac5a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392997 > Auto-Submit: dpapad <dpapad@chromium.org> > Reviewed-by: John Lee <johntlee@chromium.org> > Commit-Queue: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806929} TBR=dpapad@chromium.org,johntlee@chromium.org Change-Id: I5d28c60960278b83d2c8ce55ee507be89b27c24f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410245Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#806995}
-
Jose Dapena Paz authored
GCC cannot map passing directly curly braces notation for x11::shm::PutImageRequest parameter of the PutImage call. We need to initialize it first to an instance and pass it to PutImage. Bug: 819294 Change-Id: I809c714aafec4978fba8cd35b9850373b6d246ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394162Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#806994}
-
Yuki Shiino authored
Uses info.This() and info.Holder() appropriately according to v8::FunctionCallbackInfo and v8::PropertyCallbackInfo in bindings::V8SetReturnValue. Bug: 839389 Change-Id: I4b43f945fc5ff2952620cfc869e32e91398b3086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409877Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#806993}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/594b592fd9d9..bc83da97d26c 2020-09-15 alexrudenko@chromium.org Color picker for Layout pane If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1109177 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I05a9f0814f9398be02c805bea184076809d60700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412074Reviewed-by:
-
Oleh Lamzin authored
Change-Id: I80946f9a4b1e2524cf19f39c24cb16025b0aca49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356485Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#806991}
-
Sorin Jianu authored
The issue here is that the nullptr returned from the function creates an error path which the caller must handle, or else the code crashes. In the updater, a null version and an empty version mean the same thing, therefore, this CL replaces the nullptr with "". There is an unrelated change to reduce the verbosity of logging for a repeating callback. Bug: 1128195 Change-Id: I94a8853306edf7bb6eaddfe5ac0807ccaf9e0a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411551 Auto-Submit: Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#806990}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I64492b7124f903cf60076dc655f7cd4c93e83d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412069Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/069f3d3b8ab2..c852aafe897d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC poromov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: poromov@google.com Change-Id: Id34707eadc45c91874a572f722059237b099dc44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412070Reviewed-by:
-
Alex Danilo authored
Bug: 1097252 Change-Id: I97d977c6017d5ea4be6175484ed1707281892770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397044Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#806987}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/53913fb84ad3..346ff6a4d7b2 2020-09-15 hjd@google.com Merge "ui: Upgrade immer from 1.12.0 -> 7.0.8" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5007ebf82d98487a64961f0ddf2976e95a34b61f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412067Reviewed-by:
-
Friedrich Horschig authored
Although username fields are detected and offers the regular fallbacks, the toggle to recover from "never save" wasn't displayed yet. This CL allows to enable password saving if the selected field is for usernames. Screenshot in the bug. Bug: 1097722 Change-Id: I45c7dde4f591167c934ec840be368915c66b74a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409990 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#806985}
-
Peter E Conn authored
Change-Id: Ic3ee243f1f49f406f8ee634b45a3870f34407e44 Bug: 1127885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409940 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#806984}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I54d99ae6cb4aab52465265fd8d90e65056d8e0e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412068Reviewed-by:
-
Adlai Holler authored
The replacement is SkSurface::recordingContext()->asDirectContext(). Change-Id: I83eccf75f46b3d84f5461cf2c52773529a43ba97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410719Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Adlai Holler <adlai@google.com> Cr-Commit-Position: refs/heads/master@{#806982}
-
Sami Kyostila authored
Make it possible to configure the priority of a tracing session client. Currently multiple concurrent sessions aren't supported, so higher priority clients may preempt sessions from lower priority ones. Depends on https://android-review.googlesource.com/1426068 Bug: 1058632 Change-Id: I6dc3c92aa440e984c68bc83a88e36898033493a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404936Reviewed-by:
oysteine <oysteine@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#806981}
-
Sergey Poromov authored
This reverts commit e4eacd09. Reason for revert: Suspect for lacros test failures: https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/2227 The only lacros-related change in diff with the previous success run. Original change's description: > [lacros] Make test runner supports lacros_chrome_browsertests > > This CL makes test runner supports lacros_chrome_browsertests by: > 1. Appending necessary args to establish mojo connections. > 2. Always use '--test-launcher-jobs=1' to run tests serially because > multiple clients crosapis are still not supported yet. > > Bug: 1120582 > Change-Id: I865ace26aa4a86c83912c6660bc433d79e43ef76 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410350 > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Sven Zheng <svenzheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806903} TBR=erikchen@chromium.org,liaoyuke@chromium.org,svenzheng@chromium.org Change-Id: Ie630ade531428e78718127792c4f6ab6b0d55025 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1120582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410246Reviewed-by:
-
