- 05 Nov, 2018 40 commits
-
-
Friedrich Horschig authored
Bottom containers and snackbars try to infer on their own how large the keyboard is. This CL makes them consider extensions and replacements as well -- long-term, we probably want to use a keyboard delegate there. Bug: 898468 Change-Id: Iae8a68b2f868015f64d8e1361fe46b1d7740921f Reviewed-on: https://chromium-review.googlesource.com/c/1309791Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#605307}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9f878f6e97fa..e7547d55453e git log 9f878f6e97fa..e7547d55453e --date=short --no-merges --format='%ad %ae %s' 2018-11-05 nisse@webrtc.org Move MemoryStream to separate source files, and to a test target. Created with: gclient setdep -r src/third_party/webrtc@e7547d55453e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I46796fae4cfca5ce2758d2faf17f8a22d3f9eff2 Reviewed-on: https://chromium-review.googlesource.com/c/1317178Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605306}
-
Bruce Dawson authored
SimpleThreadImpl::thread_manager_ is initialized in its thread's Run function which means that it is racy in relationship to the use. This change doesn't fix the raciness but it does initialize thread_manager_ to nullptr in the class declaration which is a good practice. Fixing the code to not use SimpleThreadImpl until Run() has completed the initialization is left for the owner. Bug: 897872 Change-Id: I50d38f10d4297334ae02698ecd43a0fbf44db374 Reviewed-on: https://chromium-review.googlesource.com/c/1316657Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605305}
-
Mario Sanchez Prada authored
Migrated to the IdentityManager by relying on IdentityTestEnvironment, so that we can use MakePrimaryAccount() without needing to explicitly pass a ProfileOAuth2TokenService and a SigninManagerBase. Bug: 890825 Change-Id: I20e228e7d9f5d2c2154666d264e31b5154bdcff8 Reviewed-on: https://chromium-review.googlesource.com/c/1314635 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#605304}
-
BUG=762641 TBR=alemate@chromium.org Change-Id: I1c86a91b4dde77faf157c08f9be2406c64cd06b4 Reviewed-on: https://chromium-review.googlesource.com/c/1317378Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605303}
-
Xi Cheng authored
Change-Id: Ifd612cc9b4370c4fb2a9f7be54fd6528f7b4cda5 Reviewed-on: https://chromium-review.googlesource.com/c/1316711 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#605302}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fad38646..062174e3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I84145a1a8ffb72b8e6594425a41d643d06f22caf Reviewed-on: https://chromium-review.googlesource.com/c/1316344Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605301}
-
Andy Paicu authored
Spec: https://w3c.github.io/webappsec-csp/#dictdef-securitypolicyviolationeventinit Bug: 897646 Change-Id: Id4c4947455a095c09aa34d16c7ff298ba4ba046e Reviewed-on: https://chromium-review.googlesource.com/c/1292566 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#605300}
-
Greg Thompson authored
This reverts commit e2a95639. Reason for revert: This breaks tests on account of fooling the Windows loader. See https://bugs.chromium.org/p/chromium/issues/detail?id=900121#c6 for details. Original change's description: > win: Make chrome.7z generation more deterministic. > > mini_installer.exe embeds chrome.7z, and chrome.7z contains timestamps > of all files in the archive. To make chrome.7z more deterministic, give > all files in it deterministic timestamps. > > Bug: 330260 > Change-Id: Ia251dd38177acbebdde288b86826986f441b2d4d > Reviewed-on: https://chromium-review.googlesource.com/c/1302393 > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603171} TBR=gab@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 330260 Change-Id: I261401c27226ab9e0cf30bc07a47ecf8399f491b Reviewed-on: https://chromium-review.googlesource.com/c/1317569Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#605299}
-
Marc Treib authored
This is the USS version of AutofillProfileDataTypeController. It is very similar to AutofillWalletModelTypeController, and only implements one bit of custom logic: Notifying the SyncService when autofill::prefs::kAutofillProfileEnabled changes, so that syncing of addresses will get turned on or off as appropriate. Bug: 895824 Change-Id: I932794f8a2d1c3556bdc1b7125743a2154eaf997 Reviewed-on: https://chromium-review.googlesource.com/c/1310393 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#605298}
-
Justin Cohen authored
This is now required after dropping 32-bit. Bug: 894099 Change-Id: Ib2d546b8b862f9a0f123a6b0b46f902dfccb6fb4 Reviewed-on: https://chromium-review.googlesource.com/c/1316108Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#605297}
-
Benoît Lizé authored
Records the size, latency and throughput of parkable strings at compression and decompression time. As these values are correlated, recording separate histograms is necessary, and as not all compressed strings are decompressed, separate histograms for compression and decompression are required. Bug: 877044 Change-Id: Iec53e6d4f249e109165b0b3be6e2e245fc2bfd40 Reviewed-on: https://chromium-review.googlesource.com/c/1307440Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#605296}
-
Leszek Swirski authored
This reverts commit c564235f. No changes from the original, VR flakes are caused by issues with loadUrl and have been deflaked (see 894796 for details) Original change's description: > Revert "Reland "[blink] Control ScriptStreamer with ScriptResource"" > > This reverts commit dd9df78c. > > Reason for revert: Makes VR tests flaky (https://crbug.com/894796) > > Original change's description: > > Reland "[blink] Control ScriptStreamer with ScriptResource" > > > > This is a reland of 7bd91635 > > > > No changes from the original, revert reason is fixed with > > https://chromium-review.googlesource.com/c/1283037 > > > > Original change's description: > > > [blink] Control ScriptStreamer with ScriptResource > > > > > > Move the ScriptStreamer control logic from ClassicPendingScript to > > > ScriptResource. In the future, this will allow us to start streaming > > > a ScriptResource before the ClassicPendingScript is available, e.g on > > > preload. > > > > > > The ClassicPendingScript now only sends one "finished" callback, from > > > ScriptResource. This callback is either when the streaming completes, > > > or when there is no streaming and the ClassicPendingScript has told > > > the ScriptResource that it doesn't intend to start streaming. In the > > > long run, we want all scripts to go through the streaming interface, > > > and we want ScriptResource to control when streaming starts, so the > > > "no more streaming" call will disappear -- however it is necessary to > > > maintain the current behaviour, and be able to control it with a > > > runtime flag. > > > > > > Bug: chromium:865098 > > > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e > > > Reviewed-on: https://chromium-review.googlesource.com/c/1181430 > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#599148} > > > > TBR=kouhei@chromium.org,kinuko@chromium.org > > > > Bug: chromium:865098 > > Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c > > Reviewed-on: https://chromium-review.googlesource.com/c/1286450 > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#601143} > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: chromium:865098 > Change-Id: Ibdbd7e80d0fcfacc84a73e83d165581c7f1d02d2 > Reviewed-on: https://chromium-review.googlesource.com/c/1297138 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602310} TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:865098 Change-Id: I9794fe5366aa8cfc9291d53271ed680465b29a76 Reviewed-on: https://chromium-review.googlesource.com/c/1317566Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#605295}
-
Justin Cohen authored
Bug: 894963 Change-Id: Id9ca2253208fc77672d05d037e7f777b89d15770 Reviewed-on: https://chromium-review.googlesource.com/c/1306236Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#605294}
-
Alexander Timin authored
- Implement DeletePendingTasks method. - Implement HasTasks method. - Implement SetTaskExecutionAllowed and IsTaskExecutionAllowed methods. - Allow TCwMP::SetTaskRunner to be called multiple times. - Reduce the frequency of ScheduleDelayedWork calls. R=alexclarke@chromium.org,skyostil@chromium.org BUG=891670 Change-Id: Ia5eaa7e7ec32e499b6c7e772f391144c2d836746 Reviewed-on: https://chromium-review.googlesource.com/c/1308194 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#605293}
-
Anders Hartvoll Ruud authored
Custom properties can currently not be represented by any subclass of CSSProperty, because we have no strategy for creating any such instances dynamically. (They all reside in static memory). This CL proposes a solution to this problem---hopefully ushering in a new and glorious era of code clean-ups and simplifications. In short, to obtain a CSSProperty reference for some property (be it standard property, custom property, or registered custom property), create a CSSPropertyRef object. This object will either point to one of the static instances (for standard properties), or will point to the embedded CustomProperty object (for both kinds of custom properties). For now, just IsInherited and the name functions have been implemented in CustomProperty. The plan is to complete the rest incrementally. Change-Id: I6905cbb23f67d0a3c1de0ecba03c9f0a18cb278c Reviewed-on: https://chromium-review.googlesource.com/c/1262638 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#605292}
-
Pavol Marko authored
If two exension managed schema policy properties (at different hierarchy levels) have the same id, the ADMX generator should not generate the same name attribute for the corresponding ADMX elements. If the name is reused, the GPO editor rejects the ADMX file. Use 'full name's instead, which are built from the names of all hierarchy levels. Bug: 900517 Test: manual Change-Id: Ief2edeb71defb15a768ea7df9e7366796bab728e Reviewed-on: https://chromium-review.googlesource.com/c/1311353Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#605291}
-
Jordan Demeulenaere authored
This CL replaces ObjectAnimators by ValueAnimators for the progress bar animations, allowing us to remove the properties introduced in http://crrev/c/1312477. Change-Id: I45565b4aa863880e8a16522b9160dc2c8d0c4559 Reviewed-on: https://chromium-review.googlesource.com/c/1314630Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#605290}
-
Andy Paicu authored
When setting the eval flag for a worker context, report only policies were treated as enforcing. Because AllowEval with supress reporting does not take into account the ReportOnly state of the policy because it calls CheckEval directly. AllowEval: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/frame/csp/content_security_policy.cc?g=0&l=603 CheckEval is called here: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/frame/csp/csp_directive_list.cc?g=0&l=712 Bug: 777076 Change-Id: I80994553037d29c9301aff1ea845386c776c6837 Reviewed-on: https://chromium-review.googlesource.com/c/1301439 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c26971222e50..f6ff6ce4e89d Created with: gclient setdep -r src-internal@f6ff6ce4e89d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9e2d162e7a89d009ee15eb455eb8efeb94fa6b75 Reviewed-on: https://chromium-review.googlesource.com/c/1317176Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605288}
-
Jordan Demeulenaere authored
Change-Id: I7728cd4d3f8b22027b1461f611271f9358443a75 Reviewed-on: https://chromium-review.googlesource.com/c/1314528 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
disk_cache::Entry::GetDataSize() can return zero. If the size of side data is zero, it doesn't make sense to try to read side data. Call ReadSideDataCallback with an empty vector when the size is zero. I don't expect this improves performance in general though. Change-Id: I07237a1b41a4b95349a430806122270084f8b55d Reviewed-on: https://chromium-review.googlesource.com/c/1307029Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605286}
-
Niels Möller authored
This is a step towards deleting the rtc::PacketTime class. Bug: webrtc:9584 Change-Id: Iaae4dd05d398fc6ea67d63981277fb84859b5c21 Reviewed-on: https://chromium-review.googlesource.com/c/1313931Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#605285}
-
David Jean authored
When going from bookmarks root to another folder through search (we replace the controller stack) the search bar was at different height (on iOS 11), resulting in a kink in the animation. This solves it by moving to small title before the animation. Bug: 893559 Change-Id: I74424e25ae475ea493a967f49c89eb0d5cc96242 Reviewed-on: https://chromium-review.googlesource.com/c/1304514Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I5b45ab29f46c7e4a7451b04ea7e7da60173c1aa5 Reviewed-on: https://chromium-review.googlesource.com/c/1317358Reviewed-by:
-
http://crrev.com/c/1288350Shu Chen authored
Bug: 900124,856135 Change-Id: Ie11ad406bd1ea383dc2a83cc8661076309154865 Reviewed-on: https://chromium-review.googlesource.com/c/1317010Reviewed-by:
Lan Wei <azurewei@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#605282}
-
Yoshisato Yanagisawa authored
Change-Id: I960d10e7c83169918e49bf923c6c32d6ffa1b5f7 Reviewed-on: https://chromium-review.googlesource.com/c/1317111 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#605281}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8cd3016c5e3b..c26971222e50 Created with: gclient setdep -r src-internal@c26971222e50 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0f5c5410edba3acf070317f4b3bd4684be8171f5 Reviewed-on: https://chromium-review.googlesource.com/c/1317175Reviewed-by:
-
Tatsuhisa Yamaguchi authored
Add the full name of current IME as the tooltip and the accessible name for the IME indicator icon. This change also revises the TrayItemView by extending the views::Label class. We are using some text like "US" or "あ" (the first hiragana alphabet of Japanese language) as the icon, but those should not be read literally like a normal label. Bug: 888072 Change-Id: I2295a15f6891731487f17dac29c8b9886b6c0b4b Reviewed-on: https://chromium-review.googlesource.com/c/1317299Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605279}
-
Kunihiko Sakamoto authored
TBR=nhiroki@chromium.org Bug: 901317 Change-Id: I59e6693ea8999835227f9ade7b922e6ec07e09e8 Reviewed-on: https://chromium-review.googlesource.com/c/1316953Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#605278}
-
Sara Kato authored
String for dialogs was confirmed by jonann@, add word 'keyboard' to confirmation dialogs already implemented. Bug: 881929 Change-Id: Ibd3d13e95ff5b56eeabbf24ac1e6ba90fcf456a9 Reviewed-on: https://chromium-review.googlesource.com/c/1316951 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#605277}
-
Hiroki Nakagawa authored
This is a preparation for adding more tests for postMessage to worker clients. Bug: n/a Change-Id: I9e20b04fd86ad27faaecd7d592cac6dfa5ae16b1 Reviewed-on: https://chromium-review.googlesource.com/c/1317067 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#605276}
-
Yuta Kitamura authored
This CL replaces the occurrences of "Platform::Current() ->CurrentThread()->Scheduler()" with "ThreadScheduler::Current()" which has the same meaning. Also, this CL simplifies the code that assumes Platform::CurrentThread() or Thread::Scheduler() can return null, which is no longer true. Bug: 826203 Change-Id: I0a59ef17be978d3a4d8b229dc19069aeb0a4c2f1 Reviewed-on: https://chromium-review.googlesource.com/c/1314084Reviewed-by:
-
Fumitoshi Ukai authored
in chromium.goma, mac goma staging runs on 4 cores mac vm, which runs ninja -40 by default. it would take ~2 hours for full builds (cache misses cases). let's run ninja -j80 to mitigate such cases. Bug: 901699, b/115585306 Change-Id: I1bc637c29cd47c339af1148ed5f7e36dc857021d Reviewed-on: https://chromium-review.googlesource.com/c/1317220Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#605274}
-
Yuta Kitamura authored
The virtual function IdleTaskRunner() defined in WebThreadScheduler is not used by anybody except the scheduler internal code, so it should be defined in ThreadSchedulerImpl instead. Along with that function, the header for SingleThreadIdleTaskRunner is moved to scheduler/common, as it's only used in combination with IdleTaskRunner(). SingleThreadIdleTaskRunner uses base::RefCountedThreadSafe which is banned, but this can't be replaced with WTF::ThreadSafeRefCounted, because MainThreadSchedulerImpl having a SingleThreadIdleTaskRunner is instantiated before PartitionAlloc is initialized. The presubmit script is modified so it would allow the usage of base::RefCounted just for this file. Bug: 826203 Change-Id: I2ddcbe9a9a1af6bce5cd87e9d097be86641703fe Reviewed-on: https://chromium-review.googlesource.com/c/1306951 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0a8b4e1acbd6..51916083e752 git log 0a8b4e1acbd6..51916083e752 --date=short --no-merges --format='%ad %ae %s' 2018-11-05 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-11-05 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@51916083e752 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: Id7d6b2a118f8616356a7e9dc2baad02cdb98730b Reviewed-on: https://chromium-review.googlesource.com/c/1317174Reviewed-by:
-
Yuta Kitamura authored
This CL replaces the occurrences of "Platform::Current() ->CurrentThread()->Scheduler()" with "ThreadScheduler::Current()" which has the same meaning. Also, this CL simplifies the code that assumes Thread::Scheduler() can be null, which is no longer true. Bug: 826203 Change-Id: I994db5b3be6e5e0f29cfe346dac15b49ca40394e Reviewed-on: https://chromium-review.googlesource.com/c/1314079Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Anand K. Mistry authored
BUG=791396,855197 Change-Id: I4e4602e3748247c6bd0d1973c368467e1dc057fc Reviewed-on: https://chromium-review.googlesource.com/c/1309387 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#605270}
-
BUG=762641 TBR=oshima@chromium.org Change-Id: Ia19d30eb1b996d3dfda03d8f12e3c227f6f46c60 Reviewed-on: https://chromium-review.googlesource.com/c/1317347Reviewed-by:
-
Kunihiko Sakamoto authored
This reverts commit aa69df1c. Reason for revert: culprit for flakes of - SystemDisplayApiTest.SetDisplay (crbug.com/901586) and - HeadlessBrowserTest.CreateAndDestroyBrowserContext (crbug.com/901637) Original change's description: > Perfetto: Unify TraceEventAgent classes > > This unifies the Perfetto and non-Perfetto TraceEventAgent classes, so > that it's possible to use Perfetto directly even when it's not enabled > as the default TraceLog backend. > > Also moved the Mojo bindings of ProducerHost into a StrongBindingSet of PerfettoService > so they get cleaned up if the service gets shut down. > > Already reviewed as part of https://chromium-review.googlesource.com/c/chromium/src/+/1161541 > > Change-Id: I3070d69e92778de8e3b5e33957ab4f4694b782af > Reviewed-on: https://chromium-review.googlesource.com/c/1307998 > Commit-Queue: oysteine <oysteine@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605060} TBR=oysteine@chromium.org,skyostil@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 901586,901637 Change-Id: I45f18d58e6355722c124ee753de5021e1d965da5 Reviewed-on: https://chromium-review.googlesource.com/c/1317298Reviewed-by:
-
