GitLab

- |SVGAnimate{Motion,Transform}Element::isSupportedAttribute| is only
called from |SVGAnimate{Motion,Transform}Element::parseAttribute|. Inlined.

BUG=397902

Review URL: https://codereview.chromium.org/424733002

git-svn-id: svn://svn.chromium.org/blink/trunk@179118 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=301515

Review URL: https://codereview.chromium.org/400153002

git-svn-id: svn://svn.chromium.org/blink/trunk@179117 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=397440
R=yurys

Review URL: https://codereview.chromium.org/416363002

git-svn-id: svn://svn.chromium.org/blink/trunk@179116 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Supply row height corresponding to current data grid style.

BUG=316092

Review URL: https://codereview.chromium.org/420183003

git-svn-id: svn://svn.chromium.org/blink/trunk@179115 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL updates the templates we use for generated code to use |blink| rather
than |WebCore|. I've also updated a number comments and such that weren't
caught by my Python renaming script.

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/424983002

git-svn-id: svn://svn.chromium.org/blink/trunk@179114 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All the tests were adjusted to the buffered mode.
Console.timeline also records timeline in buffered mode.

BUG=361045
R=yurys@chromium.org

Review URL: https://codereview.chromium.org/399043002

git-svn-id: svn://svn.chromium.org/blink/trunk@179113 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=340522

Review URL: https://codereview.chromium.org/412143002

git-svn-id: svn://svn.chromium.org/blink/trunk@179112 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Mark 63 inspector/ tests as flaky on Linux ASAN (https://codereview.chromium.org/407113002/)

Reason for revert:
Since patch https://codereview.chromium.org/399383005 has been successfully landed, lets try revert this one, test should be ok now

Original issue's description:
> Mark 63 inspector/ tests as flaky on Linux ASAN
> 
> (and clean up old expectations for these tests)
> 
> BUG=395997,395676
> TBR=sergeyv@chromium.org
> NOTRY=true
> NOTREECHECKS=true
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178638

TBR=johnme@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=395997,395676

Review URL: https://codereview.chromium.org/413473002

git-svn-id: svn://svn.chromium.org/blink/trunk@179111 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=vsevik

Review URL: https://codereview.chromium.org/414013002

git-svn-id: svn://svn.chromium.org/blink/trunk@179110 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Send async stack trace for Network.Initiator to frontend, and show it in console
and popover in the Network panel.

BUG=169721
R=eustas, apavlov

Review URL: https://codereview.chromium.org/416843002

git-svn-id: svn://svn.chromium.org/blink/trunk@179109 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch separates style used for error message repeat count bubble
in console. The style is already used in Resources panel, and will be
used later for editor errors.

BUG=397217
R=vsevik, apavlov
NOTRY=true

Review URL: https://codereview.chromium.org/428563002

git-svn-id: svn://svn.chromium.org/blink/trunk@179108 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this CL, SVGAnimationElement derived SVGTests.
However, given that SVGDiscardElement, which also derives SVGSMILElement
need SVGTests support too, this CL changes SVGTests to be inherited in
SVGSMILElement.

Before:
class SVGSMILElement {}
class SVGAnimationElement : SVGSMILElement, SVGTests {}
class SVGDiscardElement : SVGSMILElement {}

After:
class SVGSMILElement : SVGTests {}
class SVGAnimationElement : SVGSMILElement {}
class SVGDiscardElement : SVGSMILElement {}

BUG=397991

Review URL: https://codereview.chromium.org/427613006

git-svn-id: svn://svn.chromium.org/blink/trunk@179107 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is to replace the existing |SVGElement::parseAttribute| implementation,
but as there are many callers, we would like to proceed this incrementally.
a) Introduce |SVGElement::parseAttributeNew| *LANDED*
b) Convert all overrides |SVGElement::parseAttribute| to
   a |parseAttributeNew| call. <-- This patch
c) Replace existing |parseAttribute| with |parseAttributeNew|, and remove all
   overrides simply calling |parseAttributeNew|

This patch is (b).

Bonus: Remove {parseAttribute,isSupportedAttribute,svgAttributeChanged} on SVGGElement which was a noop.

BUG=397902

Review URL: https://codereview.chromium.org/420193011

git-svn-id: svn://svn.chromium.org/blink/trunk@179105 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes uses of the WebCore namespace that have crept in during the
transition.

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/426863003

git-svn-id: svn://svn.chromium.org/blink/trunk@179104 bbb929c8-8fbe-4397-9dbb-9b2b20218538

'rem' and 'ch' units were unrecognized when used inside MQs/sizes, since they were not in the unit table.
I've added them and fixed another bug related to CH and MQs.

I've also added the 'fr' and 'turn' units to the unit table, even though there aren't valid MQs that can use them,
since some other code may use the unit table in the future, and they should be there for completeness.

BUG=398185

Review URL: https://codereview.chromium.org/427683002

git-svn-id: svn://svn.chromium.org/blink/trunk@179103 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since the size of ScriptWrappableBase is zero, this change will not increase the size of CSSValue, etc.

BUG=235436

Review URL: https://codereview.chromium.org/424783002

git-svn-id: svn://svn.chromium.org/blink/trunk@179102 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to the CSS3 standard calc() expressions can contain time,
angle and frequency values. (http://www.w3.org/TR/css3-values/#calc).
The patch implements this feature.

The patch is partially based on http://trac.webkit.org/changeset/168685
and http://trac.webkit.org/changeset/170544 (Patch by Martin Hodovan,
reviewers were: Darin Adler and Simon Fraser)

R=mikelawther@chromium.org,alancutter@chromium.org
BUG=390566

Review URL: https://codereview.chromium.org/345903005

git-svn-id: svn://svn.chromium.org/blink/trunk@179101 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Mark http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_mark.html as flaky on debug Windows

TBR=simonjam@chromium.org
NOTRY=TRUE
BUG=398295

Review URL: https://codereview.chromium.org/422223004

git-svn-id: svn://svn.chromium.org/blink/trunk@179100 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=340522

Review URL: https://codereview.chromium.org/415013003

git-svn-id: svn://svn.chromium.org/blink/trunk@179099 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Introduces ScriptWrappableBase class in order to provide the internal pointer independent from V8Type.

The end to end change will be http://crrev.com/420233002

BUG=235436

Review URL: https://codereview.chromium.org/422873002

git-svn-id: svn://svn.chromium.org/blink/trunk@179098 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In r172647, I changed the AnimationPlayerCountedSet from a HashCountedSet to a HashMap, because at that time Oilpan didn't support a HashCountedSet. Now that Oilpan supports a HashCountedSet, this CL changes it back to a HashCountedSet again.

BUG=340522

Review URL: https://codereview.chromium.org/425903003

git-svn-id: svn://svn.chromium.org/blink/trunk@179097 bbb929c8-8fbe-4397-9dbb-9b2b20218538

    
    Children of flexbox with flex-direction: column/column-reverse
    shrinked their height after applying the overflow: scroll
    style. Children shows an incorrect height. The difference
    in height coming is equal to scrollbarLogicalHeight.
    
    This bug is occuring because we are not taking into
    account the scrollbar height while computing the
    mainAxisExtentForChild. This patch fixes this bug
    by adding scrollbarLogicalHeight while calculating
    mainAxisExtentForChild.
    
    BUG=364977

Review URL: https://codereview.chromium.org/417153003

git-svn-id: svn://svn.chromium.org/blink/trunk@179095 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=179076

BUG=394619
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/422843006

git-svn-id: svn://svn.chromium.org/blink/trunk@179094 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Cast highestEnclosingNodeOfType() return value to tighter type to increase
code readability. This CL also renames the type checking functions passed
to highestEnclosingNodeOfType() to make it clear what type of Node/Element
is returned.

R=leviw@chromium.org

Review URL: https://codereview.chromium.org/417113011

git-svn-id: svn://svn.chromium.org/blink/trunk@179093 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a simple refactoring.
We should use enum instead of '1 /* on prototype */' and '0 /* on instance */'.
There is no change in behavior.

Review URL: https://codereview.chromium.org/425853006

git-svn-id: svn://svn.chromium.org/blink/trunk@179091 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=374343

Review URL: https://codereview.chromium.org/413403010

git-svn-id: svn://svn.chromium.org/blink/trunk@179090 bbb929c8-8fbe-4397-9dbb-9b2b20218538

removed and also release the reference to DrawingBuffer, so that make
sure the DrawingBuffer has a chance to be destroyed.
    
BUG=390960

Review URL: https://codereview.chromium.org/415123002

git-svn-id: svn://svn.chromium.org/blink/trunk@179089 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Fix SharedWorker leak when script load has failed. (https://codereview.chromium.org/424653002/)

Reason for revert:
May cause crash

Original issue's description:
> Fix SharedWorker leak when script load has failed.
> 
> When SharedWorker script load has failed and the |WebSharedWorkerImpl|
> was explicit told to terminate, the |WebSharedWorkerImpl| instance
> was never deleted.
> 
> This CL fixes the issue by invoking "delete this" when a worker thread
> instance does not exist in |stopWorkerThread()|.
> 
> TEST=fast/workers/worker-crash-with-invalid-location.html doesn't leak when --enable-leak-detection
> BUG=364390
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179011

TBR=falken@chromium.org,tkent@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=364390

Review URL: https://codereview.chromium.org/424923002

git-svn-id: svn://svn.chromium.org/blink/trunk@179088 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Make SelectorCheckerContext STACK_ALLOCATED.
- Make FocusCandidate STACK_ALLOCATED.
- Make TreeBoundaryCrossingRuleSetMap a hash map from Member<Node> to Member<CSSStyleSheetRuleSubSet>. This hash map doesn't need to be weak.

BUG=340522

Review URL: https://codereview.chromium.org/423953003

git-svn-id: svn://svn.chromium.org/blink/trunk@179087 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Make StyleResolver's StyleSharingList a HeapDeque of Member<Element>s.
- Make CSSFontFaceSrcValue::m_svgFontFaceElement a Member<Element>.
- Add a FIXME to make ScriptLoader::m_element to a Member<Element>.
Given that ResourceClient is going to be moved to the heap soon,
it would be better to just wait for it rather than making it a Persistent<Element>.

BUG=340522

Review URL: https://codereview.chromium.org/423013002

git-svn-id: svn://svn.chromium.org/blink/trunk@179086 bbb929c8-8fbe-4397-9dbb-9b2b20218538

r174506 replaced toV8Context() with v8::Object::CreationContext(),
and it caused 16% regression in dromaeo.jslibeventjquery.
This is because v8::Object::CreationContext() is slow.

This CL reverts the change.

BUG=383926

Review URL: https://codereview.chromium.org/429433002

git-svn-id: svn://svn.chromium.org/blink/trunk@179085 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=179059

BUG=392794
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/427693006

git-svn-id: svn://svn.chromium.org/blink/trunk@179084 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This constructor has no references to it. Hence, removing it.

BUG=None

Review URL: https://codereview.chromium.org/426573004

git-svn-id: svn://svn.chromium.org/blink/trunk@179083 bbb929c8-8fbe-4397-9dbb-9b2b20218538

CSS3 Text spec about text-align-last has been modified
as the property only can affect to the last line when test-align is justify.

http://www.w3.org/TR/css-text-3/#text-align-last-property

BUG=248839

Review URL: https://codereview.chromium.org/59753002

git-svn-id: svn://svn.chromium.org/blink/trunk@179082 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move Node::enclosingBlockFlowElement() / inSameContainingBlockFlowElement() to
htmlediting.h as this is only needed for editing.

R=leviw@chromium.org, yosin@chromium.org

Review URL: https://codereview.chromium.org/421293004

git-svn-id: svn://svn.chromium.org/blink/trunk@179081 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=340522

Review URL: https://codereview.chromium.org/417953002

git-svn-id: svn://svn.chromium.org/blink/trunk@179080 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL moves SelectorFilter::ParentStackFrame from a private section to a public section to use a WTF_ALLOW_INIT_WITH_MEM_FUNCTIONS macro.

BUG=340522

Review URL: https://codereview.chromium.org/422143005

git-svn-id: svn://svn.chromium.org/blink/trunk@179079 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since the issue was opened, the validity of removing
RenderObject::positionFromPaintInvalidationContainer
was questioned and it was determined that it's
probably not such a good idea anyway.

BUG=368416

Review URL: https://codereview.chromium.org/423943002

git-svn-id: svn://svn.chromium.org/blink/trunk@179078 bbb929c8-8fbe-4397-9dbb-9b2b20218538

During error recovery after failing to start a server, there might actually
not be an error log where we think there should be one.

TBR=eseidel@chromium.org
BUG=378444

Review URL: https://codereview.chromium.org/421413002

git-svn-id: svn://svn.chromium.org/blink/trunk@179077 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The optimization prunes SVG subtree paint invalidation walking if
the container's transform changed. However, the transform changed
flag is only updated during layout causing:
- If multiple layouts before an invalidation, later layouts may
  clear the flag set by previous layout;
- For paint-only invalidation (after we use unified invalidation)
  the flag may remain uncleared if there is no layout causing
  incorrect pruning of tree walking.

SvgCubics doesn't show visible performance change with this patch.

BUG=394619

Review URL: https://codereview.chromium.org/412083003

git-svn-id: svn://svn.chromium.org/blink/trunk@179076 bbb929c8-8fbe-4397-9dbb-9b2b20218538