GitLab

packaging them.

We also special case the common OS X zip dropping "__MACOSX" when
loading extensions.

BUG=23004

Review URL: http://codereview.chromium.org/340018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30312 0039d316-1c4b-4281-b951-d872f2087c98

This asks the toolbar (BrowserActionContainer.GetParent()) to paint when a browser action view has been added & removed.

TEST=Load browser action. Go to chrome://extensions, click "reload". The omnibar should visibly flash large & small as the browser action is loaded and unload, but it should not leave behind any visible "cruft" around the browser action.

BUG=24642

Review URL: http://codereview.chromium.org/341015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30310 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rolandsteiner,kbr
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/339036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30308 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25934
TEST=none
R=darin

Review URL: http://codereview.chromium.org/340016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30306 0039d316-1c4b-4281-b951-d872f2087c98

It looks for binaries built with /NXCOMPAT and /DYNAMICBASE, two important security features for Windows binaries.

BUG=25952
TEST=try running it on the output of /src/chrome/Debug

Review URL: http://codereview.chromium.org/338052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30304 0039d316-1c4b-4281-b951-d872f2087c98

The cause is really subtle.  When I added a db_thread() in BrowserMain, that changed the order that threads were created at.  Since interactive ui tests don't run atexitmanager (I filed a bug to make them do), this cascaded into file_posix.cc's InFlightIO singelton caching the first IO MessageLoop pointer.  By fluke, previously each IO ML would have the exact same pointer value (must be a unique size for the allocator).  My change modified the construction order, so the second run would have a different ChromeThread (file) get the previous IO thread's ML pointer.  That led to the asserts.  I have added code to start the threads in a predictable manner for now.

BUG=25354
TEST=interactive_ui_tests in Linux stop crashing
Review URL: http://codereview.chromium.org/340017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30303 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/345002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30302 0039d316-1c4b-4281-b951-d872f2087c98

The race was specific to unit-test code (see r29826) and should be fixed now.

BUG=22272

Review URL: http://codereview.chromium.org/293042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30301 0039d316-1c4b-4281-b951-d872f2087c98

The load event was changed to canplaythrough.

Review URL: http://codereview.chromium.org/345004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30294 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rolandsteiner
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/341010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30293 0039d316-1c4b-4281-b951-d872f2087c98

Also, re-arranged code to have a class per platform.

Review URL: http://codereview.chromium.org/341009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30292 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/341006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30291 0039d316-1c4b-4281-b951-d872f2087c98

Also, remove several instances of Chrome Frame using wstrings instead of FilePaths.

The main goal of this patch is to move towards ensuring that Chrome Frame and Google Chrome share binary-identical exes and dlls except for setup.exe and mini_installer.exe.

Review URL: http://codereview.chromium.org/338025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30290 0039d316-1c4b-4281-b951-d872f2087c98

BUG=24746

Review URL: http://codereview.chromium.org/339033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30289 0039d316-1c4b-4281-b951-d872f2087c98

This patch changes the call to enableResourceTracking on InspectorController to not trigger a page reload in the enabling of the APU agent.

Patch by Jaime Yap (jaimeyap@google.com)

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/334022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30288 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25826
TEST=none

Review URL: http://codereview.chromium.org/338049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30287 0039d316-1c4b-4281-b951-d872f2087c98

This is a direct copy of the Views fix from r29949.

BUG=24866
TESTED=verified that minimized browser window gets restored under metacity

Review URL: http://codereview.chromium.org/334048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30286 0039d316-1c4b-4281-b951-d872f2087c98

BUG=24355
TEST=NONE

Review URL: http://codereview.chromium.org/337054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30284 0039d316-1c4b-4281-b951-d872f2087c98

added by the merge.  There's no pixel checked in upstream, but we match
except for not showing image placeholders.  The test has the following
images:

<img src="http://">

With GURL, the URL is rejected and it doesn't try to load the image.
In KURL, the URL is "valid", but it fails to load an image so the place
holder image is shown instead.  Since that's not what the test is trying
to test, just rebaseline.

Review URL: http://codereview.chromium.org/342006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30283 0039d316-1c4b-4281-b951-d872f2087c98

FWIW, I tracked down why our tests didn't find this. We do
have coverage for the code path that was getting executed,
but the sandbox is disabled in our browser tests, so it did
not expose this issue.

BUG=25865
TEST=Install any extension that has a content script or icons (test/data/extensions/good.crx is one example). Go to chrome://extensions/. You should see the extension successfully installed.

Review URL: http://codereview.chromium.org/337041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30282 0039d316-1c4b-4281-b951-d872f2087c98

Open all bookmarks in a bookmark menu folder according to the window disposition derived from the event flags. This is currently only possible with a middle click on the top level bookmark bar button. 

BUG=19597
TEST=Control click a folder on your bookmark bar, and thorougly test
bookmark bar, especially with folders.

Review URL: http://codereview.chromium.org/334047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30281 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/330027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30280 0039d316-1c4b-4281-b951-d872f2087c98

LayoutTests\http\tests\security\frameNavigation\xss-DENIED-plugin-navigation.html is no longer timing out.  Rebaseline to match win/linux expectations

BUG=none
TEST=green build

Review URL: http://codereview.chromium.org/345003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30279 0039d316-1c4b-4281-b951-d872f2087c98

These are mostly minor syntax / missing header fixes.

Review URL: http://codereview.chromium.org/338037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30277 0039d316-1c4b-4281-b951-d872f2087c98

Also added underline capability to linux fonts.

Review URL: http://codereview.chromium.org/338029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30276 0039d316-1c4b-4281-b951-d872f2087c98

Adding mapping for third_party/makeself.  This is to complete checkin of http://codereview.appspot.com/132050
Review URL: http://codereview.chromium.org/333016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30275 0039d316-1c4b-4281-b951-d872f2087c98

Adding support for windows safari. This requires registering the o3d plugin with firefox (via registry entries)
and adding Safari to the list of supported User Agents.
Review URL: http://codereview.chromium.org/326001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30274 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30273 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/337034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30272 0039d316-1c4b-4281-b951-d872f2087c98

TBR=estade@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30271 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/330021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30270 0039d316-1c4b-4281-b951-d872f2087c98

JavaScript can close windows while in the event loop processing a
right-click menu.  This change prevents sending messages to the tab
controller after it has been closed.

BUG=25462, 25465
TEST=See bug for test.html.
TEST=Run test.html, right-click tab, after close all items should be grayed out.
TEST=Run test.html, click tab's close button and hold until tab closes.  Should not crash on release.

Review URL: http://codereview.chromium.org/335048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30269 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rolandsteiner
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/337047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30268 0039d316-1c4b-4281-b951-d872f2087c98

BUG=24814
TEST=Keystone-enabled Chrome launches without crashing and is able to check
     for and install updates.
Review URL: http://codereview.chromium.org/329041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30267 0039d316-1c4b-4281-b951-d872f2087c98

TBR=amit

Review URL: http://codereview.chromium.org/340015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30266 0039d316-1c4b-4281-b951-d872f2087c98

Personal crusade.

Review URL: http://codereview.chromium.org/344003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30265 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=markus

Review URL: http://codereview.chromium.org/341003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30264 0039d316-1c4b-4281-b951-d872f2087c98

If a HTTP post to a server returns any redirect code other than 307, then browsers don't preserve the
request method, i.e. they convert the POST request to GET. For 307 redirects browsers preserve redirects.

This CL fixes the following issues :-
1. As per the above description, we reset the method which 
   ensures that we don't generate the post related headers.
   The Post302RedirectGet net test does test this very case.
   However it works correctly as Chrome follows the redirect  
   and reissues the GET request. In this case this does not 
   occur as the only calls which are invoked on the bind 
   status callback after the redirect are GetBindInfo and
   BeginningTransaction where we incorrectly return the post
   related information. Ideally we would want to turn off
   follow redirects in Urlmon or Chrome. I tried the latter
   which has a number of issues. 

2. In debug mode the chrome_frame_net_tests cause a DCHECK 
   to be fired which indicates that the test is not being     
   run on the UI thread.

3. As the Urlmon requests are now destroyed asynchronously 
   having a DCHECK after the Stop call on the Urlmon
   request object in the CleanupAsyncRequests function is 
   incorrect. Removed this DCHECK

Fixes bug http://code.google.com/p/chromium/issues/detail?id=25643

Bug=25643

Review URL: http://codereview.chromium.org/333043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30261 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST= 1.  Enable bookmark syncing on a mac or linux build.
2.  Run chrome with --log-level=0.
3.  Options menu -> Sync my Bookmarks.  Log in.
4.  Check that "XmppSocketAdapter::OnConnectEvent - STATE_TLS_OPEN" appears in the output.

Review URL: http://codereview.chromium.org/340007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30259 0039d316-1c4b-4281-b951-d872f2087c98

Take 2 at this. The only change between this and the first is to add the GetType message to the end of the list and to keep the old message for
creating a new browser as well as adding one that takes the type. To change the params of the message requires updating the reference build. That's best done on a weekend when I'm bored.

Makes session restore on Chrome OS restore popups.

BUG=18862
TEST=none

Review URL: http://codereview.chromium.org/329040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30255 0039d316-1c4b-4281-b951-d872f2087c98