- 14 Oct, 2020 40 commits
-
-
Ben Pastene authored
This reverts commit f98a2005. Reason for revert: suspected to be causing various test failures on win7 See https://crbug.com/1138151 Original change's description: > Updated the OpenXR spec from 1.0.5 to 1.0.11 > > Updated the OpenXR spec which changes the way extension methods are > queried. I separated the extension support enumeration and method > querying. > > Updating the spec retains backwards and forward compatibility with > apps as that is mediated through the loader which is unchanged. > Extension lookup is now dynamic, and after this change, we can > implement AR features on OpenXR (e.g. hand tracking, anchors etc.) > > Change-Id: I8a4ae718ca244c91b85e02f9441525a9b1416b58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406701 > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com> > Commit-Queue: Lachlan Ford <laford@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#816823} TBR=brucedawson@chromium.org,rafael.cintron@microsoft.com,scottmg@chromium.org,martiniss@chromium.org,patrto@microsoft.com,alcooper@chromium.org,laford@microsoft.com Bug: 1138151 Change-Id: Idbd194d1197dd82d02cfd016421637b027520586 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472913Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#817243}
-
Curt Clemens authored
- Fix spacing of share target buttons. - Add "Learn more" link. Link doesn't work, see crbug.com/1138445 - Force long filenames to wrap so that the share target list has enough space. Fix: 1131292 Change-Id: I049fa8e4c8a533773906e32d36c6717c1a9c0adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465808Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#817242}
-
Vadim Shtayura authored
The 30% experiment appears to be fine (based on server logs). R=gbeaty@chromium.org BUG=1136313 Change-Id: I2b841cb31bdb15a3317a5ea43a4736efaf0d33a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472700 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#817241}
-
Bettina Dea authored
Bug: 1138427 Change-Id: Ib1ca6fc6a60ffd3101d7d9a0e0dc995bf600a650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472522Reviewed-by:
Chris Thompson <cthomp@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#817240}
-
Chong Gu authored
Determine which host tools should be added to the isolates through new gn arg test_host_cpu Determine whether emulator related files are needed through new gn arg test_isolate_uses_emulator Bug: 1080854 Change-Id: I5d283a858717162160211f6084a7b4ca167e1215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463846Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Auto-Submit: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#817239}
-
Zhenyao Mo authored
Currently we only allow one GPU process crash per hour. This leads to some users losing GPU acceleration unnecessarily. This CL makes us more forgiving. BUG=1138597 TEST=bots R=kbr@chromium.org Change-Id: I26b0bbc33b69cc81a62d5ce5f31e5c5aa5ce29bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472905Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Auto-Submit: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#817238}
-
Will Cassella authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/e61dd757a8c0..6d9096c9e3f7 $ git log e61dd757a..6d9096c9e --date=short --no-merges --format='%ad %ae %s' 2020-10-02 cassew Roll FFMPEG 2-10-20 2020-09-30 andreas.rheinhardt avformat/movenc: Fix stack overflow when remuxing timecode tracks 2020-09-24 andreas.rheinhardt avcodec/utils: Reindentation 2020-09-26 andreas.rheinhardt avcodec/utils: Also free encoder extradata on avcodec_open2() error 2020-09-24 andreas.rheinhardt avcodec/utils: Don't forget cleaning up when allocating priv_data fails (...) 2020-08-27 onemda avfilter/af_arnndn: use memcpy for copying in compute_rnn() 2020-08-27 onemda avfilter/af_arnndn: use scalarproduct_float() in dct function 2020-08-27 onemda avfilter/af_compensationdelay: always initialize w_ptr with 0 2020-08-27 onemda avfilter/vf_xfade: do not use alpha for average rgb color 2020-08-27 onemda avfilter/vf_xfade: add corner wipe transforms Created with: roll-dep src/third_party/ffmpeg Bug: 1119808 Change-Id: I5a81b04f9f890214b5f7cce5e103d7fbf868d90e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469044 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#817237}
-
Kyle Horimoto authored
This reverts commit dc1d693f. Reason for revert: No longer wanted in M-87 Original change's description: > [CrOS Customization] Update app icons > > Includes icons for the Settings, Wallpapers, and Keyboard Shortcuts > apps. > > Screenshot: https://screenshot.googleplex.com/7KdMiBkMFH7fuxh.png > > Change-Id: I6cf1d45d78f36caeb1429629cc0067b1cbd57daa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429395 > Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: James Cook <jamescook@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810376} Bug: 1138609 Change-Id: Iaa04c22814b3d8cd1ddc06ceb7a7beb14ad8d030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472346 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#817236}
-
Matthew Mourgos authored
This change has the clipboard nudge observe the hotseat state and will animate the bounds of the clipboard nudge so that the nudge is always placed above the hotseat. Bug: 1137019 Change-Id: If00afa1585e0382d7aa41789eca2a981b1323f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469364 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#817235}
-
Oksana Zhuravlova authored
This CL adds AwTracingDelegate overrides for IsAllowedToBeginBackgroundScenario() and IsAllowedToEndBackgroundScenario() which return true to enable background tracing for WebView. Bug: b/170511349 Change-Id: I56e306ac37f6d4055b68bf54a5c009111ce31077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465873 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#817234}
-
My Nguyen authored
OS tests need the flag to be disabled because some routes are conditionally created in os_route and loadTimeData needs to be overridden even before the test suite is started. Browser tests work with just a change in loadTimeData value. Bug: 1097328 Change-Id: If3e1f5914764016ccc96238461ed9ea9923600ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469337Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#817233}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0581509dc2dd..7411aeba4d3b 2020-10-14 treehugger-gerrit@google.com Merge "tracing: Handle producer disconnection" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib83bb37572f9a118e02b15afdff7019c1a0f15ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473019Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817232}
-
Klaus Weidner authored
This is a reland of 2dbccf3e Original change's description: > WebXR: add recommendedViewportScale > > This uses an estimated GPU utilization ratio from ArCoreGl. The goal is > to reduce the recommended viewport scale if the web app is unable to hit > a target framerate due to excessive GPU work, but not do so if it's slow > due to excessive JS computations or similar where reducing the viewport > wouldn't help. This is opt-in, the scale only takes effect if the app > calls view.requestViewportScale(view.recommendedViewportScale) followed > by xrwebgllayer.getViewport(view). > > (Dynamic viewport scaling is only available if WebXRIncubations is > enabled.) > > Spec link for context: > https://immersive-web.github.io/webxr/#dom-xrview-recommendedviewportscale > > Change-Id: I0a8598d8bd03f27fd1d2cc6c542ff79812825d74 > Bug: 1133381 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213113 > Commit-Queue: Klaus Weidner <klausw@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Piotr Bialecki <bialpio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816813} Bug: 1133381 Change-Id: I4c26434250a33b82e8533bfca6c34ec6376382db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472377Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#817231}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4c9f892f0d42..2aaeb81de379 2020-10-14 syoussefi@chromium.org Vulkan: loadOp=DONT_CARE + unused D/S => invalidate D/S 2020-10-14 jmadill@chromium.org Skip two more FBO max samples tests on Win/NV/GL. 2020-10-14 hckim.kim@samsung.com Vulkan: Support OES_texture_cube_map_array extension 2020-10-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 9d4b40ae645e to f121d1252b2a (1 revision) 2020-10-14 jonahr@google.com GLX: Workaround to disable GLX_OML_sync_control support. 2020-10-14 ianelliott@google.com Reimplement WindowSurfaceVkAndroid::getCurrentWindowSize() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1137851 Tbr: ynovikov@google.com Test: Test: dEQP-GLES31.functional.fbo.color.texcubearray.* Change-Id: Id23632dec539f23a7227ce120aae2129facb3df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472657Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817230}
-
Jerome Jiang authored
It's no longer needed since libaom is not going to be used for playback decoding. Bug: 1138574 Change-Id: I7c15c99ef9fb4bc3f0f9b5affed3631e7d2e1893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471839Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#817229}
-
Ted Meyer authored
Bug: 1097029 Change-Id: Ib3105a11e5ad76f7ef22930246014a702e39d0dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436704Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#817228}
-
Zhaoyang Li authored
iOS coverage builder should run the same tests in the same variants as CQ builders. This change aligned the tests. Also added comment lines to remind people keeping them in sync and fixed a typo. Bug: 1090188 Change-Id: Iabd33a1226550ab1a26bc2613f8e707a56f942ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469617Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#817227}
-
Dale Curtis authored
The HtmlVideoElementCapturerSource was unnecessarily rendering media::VideoFrames to a RGBA canvas then converting them back to YUV based media::VideoFrames. We can instead just pass the frame directly through and avoid this process. Clients which need this conversion (e.g., MediaRecorder) already have mechanisms for converting texture backed VideoFrame objects to YUV. They weren't comprehensive, so I've made them so in this change. Future optimizations could be done to allow the encoders to actually handle I422, I44 and HBD content. Right now they are just turned into I420 frames like they were in the capturer. This change also moves the VideoFramePool from the capturer to the encoder where one was missing previously; which should improve allocation efficiency and overhead. This change also fixes some paths of video capture not respecting the no-protected-content capture. Bug: None Test: All existing tests pass. Change-Id: I6f58f80e6137807fbf0be817be20f03928a1da23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464916Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#817226}
-
Ken Rockot authored
This adds a new _webui_js sub-target for any mojom target that explicitly sets webui_module_path in GN. This allows mojom JS modules to work well with WebUI resource URLs, which are typically either a chrome://resources/ URL for shared resources, or a relative path-only URL for resources exclusive to a single WebUI page. Bug: 1004256 Change-Id: I5b8be3f69733239f81b313f882d3185183b72a99 Tbr: dcheng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459393 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817225}
-
Peter Kotwicz authored
BUG=1137405 Change-Id: If6fd7bdb252524ca0d72da4499b5743d477cfc2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468739Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#817224}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/08cdb1c17f2e..3d6e2c46968d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC msw@google.com,ftirelo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: msw@google.com,ftirelo@google.com Change-Id: I8e41b3b9bded2079cabefa9361551fa3bfaa30fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472631Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817223}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/5afb002aa423..ff267ca60e14 2020-10-14 dsinclair@chromium.org [type-determiner] Fixup handling of unknown identifiers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: enga@google.com Change-Id: I7400f13082b952108ff7ce4b9d752a604d2602b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472634Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817222}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/34ddcb84f3c2..c924a88e3349 2020-10-14 reed@google.com SkPath::shrinkToFit() needs to perform copy-on-write 2020-10-14 djsollen@google.com Enable AHB Surfaces with protected context for OpenGL 2020-10-14 mtklein@google.com slightly more complex runtime color filter GM 2020-10-14 adlai@google.com Fix generated files 2020-10-14 ethannicholas@google.com moved SkSL FunctionDefinition data into IRNode 2020-10-14 robertphillips@google.com Revert "Remove GrContext" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: Ie344fc4f715338270b26b46c719849b89379404c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472636Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817221}
-
Thanh Nguyen authored
This CL rename classes and functions used by OS settings so that OS Settings will be unaffected by the change that we made on LSS. After the change is done, we will point OS Settings back to the main code. See go/lss-sandboxing-impl for more details. Bug: 1137560 Change-Id: If56dc5def738508817f4c2fa92a6d822dfdaad48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467161Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#817220}
-
Xianzhu Wang authored
We still have several bugs about transform animation to fix. Bug: 1101002 Change-Id: I8ca37e70fd0391ee3b43c5e63e3436b810e169c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471817Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817219}
-
Eugene But authored
Synthetic crash reports created for UTEs (unexpected termination events) to provide some information about the crash. Synthetic crash reports can contain Breadcrumbs, session uptime, OS version, Device Type and other similar information to understand why app has crashed. Variations will help with slicing crashes by Finch study and look for culprits among launched features. Bug: 1103752 Change-Id: I440d5acaf7fab5b5d81d6137e2ae4603c78e5330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462822 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817218}
-
David Tseng authored
This was done back in https://chromium-review.googlesource.com/c/chromium/src/+/2231660 likely to support sending arrow keys in a prior iteration to support combo boxes. R=dmazzoni@chromium.org Fixed: 1137612 Change-Id: Iaa974ae8eecafc16612df092a5ebba36031a7d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472529Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#817217}
-
Emircan Uysaler authored
This CL adds Scenic commands that present the overlay ViewHolders as a part of the scene graph. This takes scale, translation and blend mode that is decided by the overlay processor into account. We also add a workaround that creates tiny elevation steps to avoid possible z plane errors from Scenic. ViewHolder interactions happen into ScenicSurface and its session. Presenting the view and video content happens through a different channel in ScenicOverlayView class. Bug: 1127984 Change-Id: Ib0cdddf77d3bf068c1ab1dd52974c5b664a374bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450892 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#817216}
-
Mehran Mahmoudi authored
When StartSurface experiment is enabled, it will either: 1. Be shown on startup if a certain condition is met, or 2. Not be shown on startup. Currently, paint preview is not displayed on startup if StartSurface is enabled, regardless of whether StartSurface will be actually shown or not (1 or 2 above). This CL will display paint preview on startup if StartSurface is enabled AND it won't be shown on startup (scenario 2 above). This is done by making sure that ReturnToChromeExperimentsUtil#getTotalTabCount works correctly when it's called pre-native and PAINT_PREVIEW_SHOW_ON_STARTUP experiment is enabled. Bug: 1134752 Change-Id: I4d51396d82bee837184db038198770905a7f972c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472432 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#817215}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602676072-ebb21a5d77144e96fd6267407ee41b0443253d5d.profdata to chrome-linux-master-1602698313-2c5e1ad3bbb75ee9feac0a345669fda97d41b13c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1f012bc29571acf2230a7e215fa0a236fc1511d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472625 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817214}
-
Nicholas Hollingum authored
Based on a discussion with Chrome Sydney C++, it is preferable not to have fine-grained Keyed services, and instead use an approach like the WebAppsPlatform does. Diagram in go/borealis-arch. Reasons given were: 1) Complicated crashes for getting keyed service per Profile-type (incognito OTR. guest, login-porile see http://go/chromium-profile-types) 2) Two-pass shutdown but no symmetric Two-pass Setup (circular deps) 3) The base classes API which you don't own (inability to control it) 4) A dependent KeyedService may enforce the creation of the dependee KeyedService for the unwanted profile type 5) 2 .cc + 2 .h files for each service (instead of simple one .cc + .h pair) 6) Simplicity vs overkill Bug: b/170596931 Change-Id: Iee61e29b5ac29abf1ba9b00b4939ffea65bd8be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465887 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Nancy Wang <nancylingwang@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#817213}
-
Klaus Weidner authored
Update the frame time estimate to take into account ARCore's min/max framerates. Change-Id: I6177adff2093dbf59aabcb6db3bc6fc8ee625bc9 Bug: 1136276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468183 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#817212}
-
Scott Violet authored
It should only be set if overflow: clip is specified along both axis. BUG=1087667 TEST=StyleAdjusterTest.AdjustOverflow Change-Id: I3cddaf8b1b6e5041759762284f150f28b7b7662a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463749 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#817211}
-
Nick Czajka authored
This change sets all DisplayManager.* histograms to have expiry date 2021-07-15 and owners zentaro@chromium.org, cros-peripherals@google.com. This should make auditing easier as all notifications about histogram expirt will be sent to the same people at the same time. Bug: 1088714 Change-Id: Iae992cd4dfcf071447894add22acf7f2bccae1e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468303Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Nick Czajka <czajka@google.com> Cr-Commit-Position: refs/heads/master@{#817210}
-
Emircan Uysaler authored
This CL adds the necessary steps to allow fuchsia video frames that are associated with an independent ImagePipe to be promoted as overlays. This is mostly done though NativePixmap interface. - Note that, "use-overlays-for-video" flag added in a previous CL allows fuchsia to associate video frames with an independent ImagePipe through ScenicOverlayView class. - Adding NativePixmap::SupportsOverlayPlane() to query platform specific instances for overlay support. Fuchsia's SysmemNativePixmap checks for ScenicOverlayView association. - Add OverlayManagerScenic to filter overlay candidates. - Allow access to the underlying pixmap in SharedImageInterface through gpu::VulkanImage. Bug: 1127984 Change-Id: I1f76deb28c4b94e948f600061caf7215f2ee1382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446523 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#817209}
-
Aaron Leventhal authored
Make [de]serialization errors fatal any time DCHECK is on. Bug: None Change-Id: I6edaf9a44fc086916cda04ce353c03e5b50d3d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468238Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#817208}
-
Steven Bingler authored
Also removing obsolete cookie deprecation field trial entry as it is default enabled on ToT. Bug: 1030938 Change-Id: Id77635538483a0b976581b1e56af551003d81ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472344 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#817207}
-
Roberto Moura authored
Change-Id: Ie435c2d1b92b8595e1a8ee8dcdff757b8ca8d0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467880 Commit-Queue: Roberto Moura <mouraroberto@google.com> Reviewed-by:
edchin <edchin@chromium.org> Auto-Submit: Roberto Moura <mouraroberto@google.com> Cr-Commit-Position: refs/heads/master@{#817206}
-
Elaine Chien authored
Bug: 772945 Change-Id: I424e8f9f56737db9bf6deefd9e35d4169523b814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466619 Commit-Queue: Elaine Chien <elainec@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#817205}
-
Prakhar authored
coverage is now enabled on mac-rel Bug: 1024915 Change-Id: If210d6e3cced0be8101be70530940086e979aa73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473077 Commit-Queue: Prakhar Asthana <pasthana@google.com> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Prakhar Asthana <pasthana@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#817204}
-