GitLab

original review page (reverted due to chromeos breakage):
http://codereview.chromium.org/7054012/

BUG=none
TEST=FileSystemOperationTest.*
TBR=ericu

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86588 0039d316-1c4b-4281-b951-d872f2087c98

Make sure user-declared virtual destructors always have the virtual keyword.
The Clang style-check plugin will check for this soon.

No functionality change: virtual is only added
to destructors that are already implicitly virtual.

Also fix a couple of in-line destructor definitions.

BUG=83408
TEST=none

Review URL: http://codereview.chromium.org/7064033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86587 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86586 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=PPAPITest.Transport
TBR=sergeyu

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86584 0039d316-1c4b-4281-b951-d872f2087c98

to make sure the generated tarballs can be built with NaCl support.

export_tarball.py is not the prettiest place for this,
but it's the easiest to modify (public repo),
and can easily be kept in sync with other scripts in the tree
in case anything changes.

BUG=none
Review URL: http://codereview.chromium.org/7066022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86583 0039d316-1c4b-4281-b951-d872f2087c98

Revert 86575 - Revert 86573 - Add separate nonce version of connect calls to ChromotingScriptableObject.

It causes PPAPITest.Transport failure on Vista, but sergeyu told me
PPAPITest.Trasnport is flaky and the failure has nothing to do with
the original CL.

BUG=none
TEST=manual


Review URL: http://codereview.chromium.org/7042022

TBR=garykac@chromium.org
Review URL: http://codereview.chromium.org/7069005
Review URL: http://codereview.chromium.org/7068006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86582 0039d316-1c4b-4281-b951-d872f2087c98

BUG=44850
TEST=None as it isn't yet called anywhere.


Review URL: http://codereview.chromium.org/7065029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86581 0039d316-1c4b-4281-b951-d872f2087c98

Add the "blank page" test, which just scrolls a page with a very large body.
The actual frame rate measurement is based on the webkitRequestAnimationFrame
callback.  The framework records how frequently that API generates a callback.
If it generates a callback at 60 FPS, then we know nothing is slowing us down.
This of course assumes that webkitRequestAnimationFrame is well implemented.

The advantage of this test framework over one that directly reads a framerate
from Chromium is that this one works outside of the test harness.  You can just
navigate your browser to the test file and run the test manually.

R=brettw,nduca
Review URL: http://codereview.chromium.org/7038052

TBR=darin@chromium.org

BUG=none
TEST=none
TBR=

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86580 0039d316-1c4b-4281-b951-d872f2087c98

This functionality was recently broken by this cl: http://codereview.chromium.org/7029019

BUG=none
TEST=build Chrome of Chrome OS and run it on Linux with --stub-cros, no crash should observed

Review URL: http://codereview.chromium.org/6990003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86579 0039d316-1c4b-4281-b951-d872f2087c98

Revert 86577 - Revert 86572 - Revert 86568 - Add initial framework for performance tests that measure frame rate.

Add the "blank page" test, which just scrolls a page with a very large body.
The actual frame rate measurement is based on the webkitRequestAnimationFrame
callback.  The framework records how frequently that API generates a callback.
If it generates a callback at 60 FPS, then we know nothing is slowing us down.
This of course assumes that webkitRequestAnimationFrame is well implemented.

The advantage of this test framework over one that directly reads a framerate
from Chromium is that this one works outside of the test harness.  You can just
navigate your browser to the test file and run the test manually.

R=brettw,nduca
Review URL: http://codereview.chromium.org/7038052

TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/7068005
Review URL: http://codereview.chromium.org/7031043

TBR=ukai@chromium.org
Review URL: http://codereview.chromium.org/7008008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86578 0039d316-1c4b-4281-b951-d872f2087c98

Add the "blank page" test, which just scrolls a page with a very large body.
The actual frame rate measurement is based on the webkitRequestAnimationFrame
callback.  The framework records how frequently that API generates a callback.
If it generates a callback at 60 FPS, then we know nothing is slowing us down.
This of course assumes that webkitRequestAnimationFrame is well implemented.

The advantage of this test framework over one that directly reads a framerate
from Chromium is that this one works outside of the test harness.  You can just
navigate your browser to the test file and run the test manually.

R=brettw,nduca
Review URL: http://codereview.chromium.org/7038052

TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/7068005
Review URL: http://codereview.chromium.org/7031043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86577 0039d316-1c4b-4281-b951-d872f2087c98

TEST=build all locally
BUG=83837
TBR=thakis@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86576 0039d316-1c4b-4281-b951-d872f2087c98

It causes PPAPITest.Transport failure on Vista

BUG=none
TEST=manual


Review URL: http://codereview.chromium.org/7042022

TBR=garykac@chromium.org
Review URL: http://codereview.chromium.org/7069005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86575 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83286
TEST=None.


Review URL: http://codereview.chromium.org/7036019

TBR=shishir@chromium.org
Review URL: http://codereview.chromium.org/6979006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86574 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual


Review URL: http://codereview.chromium.org/7042022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86573 0039d316-1c4b-4281-b951-d872f2087c98

Add the "blank page" test, which just scrolls a page with a very large body.
The actual frame rate measurement is based on the webkitRequestAnimationFrame
callback.  The framework records how frequently that API generates a callback.
If it generates a callback at 60 FPS, then we know nothing is slowing us down.
This of course assumes that webkitRequestAnimationFrame is well implemented.

The advantage of this test framework over one that directly reads a framerate
from Chromium is that this one works outside of the test harness.  You can just
navigate your browser to the test file and run the test manually.

R=brettw,nduca
Review URL: http://codereview.chromium.org/7038052

TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/7068005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86572 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=dpranke

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86571 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82171
TEST=


Review URL: http://codereview.chromium.org/7040021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86570 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83286
TEST=None.


Review URL: http://codereview.chromium.org/7036019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86569 0039d316-1c4b-4281-b951-d872f2087c98

Add the "blank page" test, which just scrolls a page with a very large body.
The actual frame rate measurement is based on the webkitRequestAnimationFrame
callback.  The framework records how frequently that API generates a callback.
If it generates a callback at 60 FPS, then we know nothing is slowing us down.
This of course assumes that webkitRequestAnimationFrame is well implemented.

The advantage of this test framework over one that directly reads a framerate
from Chromium is that this one works outside of the test harness.  You can just
navigate your browser to the test file and run the test manually.

R=brettw,nduca
Review URL: http://codereview.chromium.org/7038052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86568 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=dpranke

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86567 0039d316-1c4b-4281-b951-d872f2087c98

Also ensure the task manager only shows "App" if the process is an app process.

BUG=80621
TEST=AppApiTest.ReloadIntoAppProcess
TEST=TaskManagerBrowserTest.NoticeHostedAppTabs

Review URL: http://codereview.chromium.org/7063015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86566 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83836
TEST=Valgrind/Heapchecker unit tests go green.
TBR=timurrrr
Review URL: http://codereview.chromium.org/6979004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86565 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83835
TEST=none
TBR=timurrrr
Review URL: http://codereview.chromium.org/6979003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86564 0039d316-1c4b-4281-b951-d872f2087c98

 createFromDatabaseIdentifier() returns empty origin urls for them.
Review URL: http://codereview.chromium.org/7053007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86563 0039d316-1c4b-4281-b951-d872f2087c98

Also
1) fixing the position of the checkmark to be in the middle of the checkbox
2) changing the print button border width

BUG=83425, 83148, 83416
TEST=See bug descriptions.


Review URL: http://codereview.chromium.org/7068001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86562 0039d316-1c4b-4281-b951-d872f2087c98

TEST=database_quota_client_unittest.cc
BUG=61676
Review URL: http://codereview.chromium.org/7046019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86561 0039d316-1c4b-4281-b951-d872f2087c98

Enabling MHTML reading on the Chrome side now that the WebKit patch
adding support for MHTML landed in WebKit.
That is necessary for the MHTML layout tests to pass.

BUG=83804
TEST=MHTML layout tests should pass.


Review URL: http://codereview.chromium.org/7064044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86560 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82230
TEST=none
TBR=mark

Review URL: http://codereview.chromium.org/7069003

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/6992053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86559 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82230
TEST=none
TBR=mark

Review URL: http://codereview.chromium.org/7069003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86558 0039d316-1c4b-4281-b951-d872f2087c98

Revert 86551 (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) (turns out testers run `gclient sync` as well, and there are 10.5 testers) - grit_info: Explicitly make __file__ relative to the current directory.

__file__ is relative if grit_info is called like `python ../tools/grit/grit_info.py`,
but not if it's invoked from python code like `import grit_info; grit_info.DoMain()`.
And that confuses the xcode project generator, which will complain about hash
collisions if these paths are serialized in absolute form.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7066030

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/6992052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86557 0039d316-1c4b-4281-b951-d872f2087c98

Revert 86532 - Revert 86517 - Don't terminate plugin processes from the browser during browser shutdown. This is to allow the plugins to
shutdown gracefully, i.e. NP_Shutdown gets called. To ensure that we handle the case of a hung plugin, we handle
the OnChannelError notification in the IPC message filter implementation in the plugin process and post a delayed 
task to kill the process.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=48178

BUG=48178
Review URL: http://codereview.chromium.org/6992006

TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/7065048

TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/7053008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86554 0039d316-1c4b-4281-b951-d872f2087c98

The tests were storing time values in SQLite, and different inserts
were all the same.  Previous version of SQLite was returning them in
the order inserted (test succeeded), current version returns a
different order (test fails).

TBR=kinuko@chromium.org
BUG=83805
TEST=none

Review URL: http://codereview.chromium.org/7067045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86553 0039d316-1c4b-4281-b951-d872f2087c98

__file__ is relative if grit_info is called like `python ../tools/grit/grit_info.py`,
but not if it's invoked from python code like `import grit_info; grit_info.DoMain()`.
And that confuses the xcode project generator, which will complain about hash
collisions if these paths are serialized in absolute form.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7066030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86551 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83827

R=dyu@chromium.org
TEST=
TBR=

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86549 0039d316-1c4b-4281-b951-d872f2087c98

We don't really support those attributes fully, so let's not pay too much
attention to them.


BUG=none
TEST=this test


Review URL: http://codereview.chromium.org/6966044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86548 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83395
TEST=PPAPITest.Transport passes

Review URL: http://codereview.chromium.org/6990064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86547 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73036,73275,80050
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/7066007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86546 0039d316-1c4b-4281-b951-d872f2087c98

http://code.google.com/p/skia/source/detail?r=1405 make SkIntToScalar more strict (it no longer allows double arguments), so the roll requires a minor code change.

BUG=none
TEST=none
TBR=epoger

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86489

Review URL: http://codereview.chromium.org/7067031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86545 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7067041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86544 0039d316-1c4b-4281-b951-d872f2087c98