GitLab

BUG=411648
TBR=hans@chromium.org

Review URL: https://codereview.chromium.org/548083002

Cr-Commit-Position: refs/heads/master@{#293652}

https://skia.googlesource.com/skia/+log/a1ae66d252edf6da932caed1fe43d11216e56c0e..ce23aaee8dfb3dff1acc2294f775e4f3fcf002ba

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/550743002

Cr-Commit-Position: refs/heads/master@{#293651}

In https://chromiumcodereview.appspot.com/473583002/ we removed a
'shadow' element in thumbnail <iframe> to improve customization. A side
effect is that this exposes the thumbnail image, thereby alow the user
to futilely access the chrome-search://thumb/#/# image below. This CL
adds back a transparent "blocker" in front of the thumbnail to restore
old behavior. Also making 2 CSS changes to:
- Fix fake box text positioning for RTL.
- Move top-margin back from #ntp-contents to #logo, for correctness.

BUG=411005

Review URL: https://codereview.chromium.org/542033002

Cr-Commit-Position: refs/heads/master@{#293650}

BUG=411565

Review URL: https://codereview.chromium.org/549723002

Cr-Commit-Position: refs/heads/master@{#293649}

BUG=411473
TBR=rtenneti@chromium.org

Review URL: https://codereview.chromium.org/554453002

Cr-Commit-Position: refs/heads/master@{#293648}

Should help to investigate sandbox failures on user side.
Logs from the attached bug have records about failed start of utility process, but without clues about cause.

BUG=408184

Review URL: https://codereview.chromium.org/546903002

Cr-Commit-Position: refs/heads/master@{#293647}

Content/public/app was messed up and didn't link everything properly, so this separates it out into browser and child like content/app is.

R=jamesr@chromium.org
Reland of https://codereview.chromium.org/545313002/ but with public/utility dependency added

TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/549863004

Cr-Commit-Position: refs/heads/master@{#293646}

Typecheck chrome://help using CompilerPass.java, everything except dependency to options and Element.prototype.contains(Node)

R=dbeam@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/help/compiled_resources.gyp && ninja -C out/Default

Review URL: https://codereview.chromium.org/443553002

Cr-Commit-Position: refs/heads/master@{#293645}

It doesn't need to run in Chrome's unit_tests suite.

BUG=397164
TEST=extensions_unittests

Review URL: https://codereview.chromium.org/546933002

Cr-Commit-Position: refs/heads/master@{#293644}

They don't need to run in Chrome's unit_tests

BUG=397164
TEST=extensions_unittests

Review URL: https://codereview.chromium.org/545293002

Cr-Commit-Position: refs/heads/master@{#293643}

Also ensure that if we don't post the callback to the java side to run the js dialog callback in the embedding app that we run the callback.

BUG=411399

Review URL: https://codereview.chromium.org/545963002

Cr-Commit-Position: refs/heads/master@{#293642}

BUG=405765

Review URL: https://codereview.chromium.org/546673002

Cr-Commit-Position: refs/heads/master@{#293641}

Rename private methods for consistency: Start*() for something that invokes
an async operation and Handle*() for something that gets called back by such
an operation.  That leaves On*() reserved for observers.  Also update some
comments.  Lastly, use the current state key from the parameter passed to
HandleStateKeysResult() instead of requesting it again from the broker (line
222).

EnrollmentHandlerChromeOS and EnrollmentScreen: Don't report metrics on
unreached code paths.  Generally, remove some obsolete instances of
NOTREACHED() after switches over enums:  The compiler ensures that all enum
values are covered, there's no need to complicate the code by checking the
same thing again.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290841

Review URL: https://codereview.chromium.org/465413002

Cr-Commit-Position: refs/heads/master@{#293640}

On android platform, it often fails to fetch searchdomaincheck url right
after network changes because of conflict between DNSObserver::OnDNSChanged
event and NetworkChangeObserver::OnNetworkChanged event.
This patch enables re-fetching when such conflict happens.

BUG=407442

Review URL: https://codereview.chromium.org/544833002

Cr-Commit-Position: refs/heads/master@{#293639}

Currently this is either a list or a string. However, this is causing some problems because templates can't add to the invoker's visibility list without knowing if the original is a string or a list.

In an effort to make this consistent, I'm converting all visibiltiy to be lists, and will remove support for strings in a future build.

This exempts cld from header checking since it was confusing GN's header checker. It adds a ppapi header target as well that will be used by libyuv (that requires a roll).

TBR=scottmg

Review URL: https://codereview.chromium.org/544423002

Cr-Commit-Position: refs/heads/master@{#293638}

chrome.tabs.onUpdated may fire when the listener is not set up yet.

BUG=

Review URL: https://codereview.chromium.org/537953002

Cr-Commit-Position: refs/heads/master@{#293637}

R=dbeam@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/options/compiled_resources.gyp && ninja -C out/Default | grep WARNING

Review URL: https://codereview.chromium.org/517413002

Cr-Commit-Position: refs/heads/master@{#293636}

BUG=411648,82385
TBR=hans@chromium.org

Review URL: https://codereview.chromium.org/550713002

Cr-Commit-Position: refs/heads/master@{#293635}

content: Make sure GpuProcessHost replies to all outstanding CreateGpuMemoryBuffer requests when GPU process dies.

BUG=
R=piman@chromium.org

Review URL: https://codereview.chromium.org/547073002

Cr-Commit-Position: refs/heads/master@{#293634}

BUG=None

Review URL: https://codereview.chromium.org/542413002

Cr-Commit-Position: refs/heads/master@{#293633}

In the SingleThreadProxy+SchedulerClient patch,
LayerTreeHostClient::Layout is now called via DoCommit which is called
via Composite(Immediately).  In no cases should the embedder call
Layout() manually.

R=danakj@chromium.org,piman@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/545343003

Cr-Commit-Position: refs/heads/master@{#293632}

BUG=404893

Review URL: https://codereview.chromium.org/549553002

Cr-Commit-Position: refs/heads/master@{#293631}

To make things simpler, also make congestion control into an interface with
fixed and adaptive implementations.

BUG=405622

Review URL: https://codereview.chromium.org/542883004

Cr-Commit-Position: refs/heads/master@{#293630}

This adds methods to SingleThreadProxy to support impl-side painting
when using the scheduler.  This allows most unit tests to test impl-side
painting classes through both the single and threaded paths.

The biggest caveat to this approach is the "commit waits for activation"
logic that mailboxes want to use.  Because there is no easy way to block
the only thread there is while activation happens, activation always
happens immediately during commit, even if the tree is not ready.  To
cause the tree to wait to draw until it is ready, drawing is prevented
via SetRequiresHighResToDraw.  This prepares the way for the future
where the SingleThreadProxy will likely commit directly to the active
tree.

The synchronous CompositeImmediately function does not support impl-side
painting yet.  This is the path used by everything but unit tests at
this point.

R=danakj@chromium.org
BUG=329553

Review URL: https://codereview.chromium.org/508373002

Cr-Commit-Position: refs/heads/master@{#293629}

Moving WebMediaPlayerImpl and related classes in content/renderer/media to media/blink so that they can be reused by Mojo code.

BUG=408338

Review URL: https://codereview.chromium.org/495353003

Cr-Commit-Position: refs/heads/master@{#293628}

R=dbeam@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . third_party/closure_compiler/compiled_resources.gyp && ninja -C out/Default

Review URL: https://codereview.chromium.org/545303003

Cr-Commit-Position: refs/heads/master@{#293627}

Add an IsPersistent function to mark these resources as non-persistent
so that they will be cleaned up when the extension is suspended. The
default is persistent.

BUG=397234,409759

Review URL: https://codereview.chromium.org/548703003

Cr-Commit-Position: refs/heads/master@{#293626}

This crash would happen if you select a couple of tabs, then click but
don't drag and hit escape or control-w. The crash would occur because
we would end up inserting the tabs a second time even though they are
already in the tabstrip.

BUG=360822
TEST=see bug
R=ben@chromium.org

Review URL: https://codereview.chromium.org/548703002

Cr-Commit-Position: refs/heads/master@{#293625}

Also add an adapter from the Chrome media DemuxerStream
to the CodedFrameProvider.

BUG=408189

Review URL: https://codereview.chromium.org/542893003

Cr-Commit-Position: refs/heads/master@{#293624}

This prevents anything other than device::HidService::Destroyer from
calling the destructor. For example, scoped_ptr, as was the case in
HidConnectionTest.

BUG=

Review URL: https://codereview.chromium.org/542153004

Cr-Commit-Position: refs/heads/master@{#293623}

This placement more closely matches the GN layout.

BUG=None
R=rockot@chromium.org,tfarina@chromium.org

Review URL: https://codereview.chromium.org/526593003

Cr-Commit-Position: refs/heads/master@{#293622}

BUG=279351

Review URL: https://codereview.chromium.org/535283002

Cr-Commit-Position: refs/heads/master@{#293621}

BUG=401559
TEST=Manual, see bug
TBR=sadrul, oshima (TBR for DEPS additions)
NOTRY=true

Review URL: https://codereview.chromium.org/518673007

Cr-Commit-Position: refs/heads/master@{#293620}

* SendDriveFileTransferEvent and onFileTransfersUpdated are not
  necessay to recieve list because this event is always single.

BUG=408482
TEST=manually
1. Copy the local file to drive.
2. Confirm sync status is updated correctly.

Review URL: https://codereview.chromium.org/542573002

Cr-Commit-Position: refs/heads/master@{#293619}

Remove StartProfiling & StopProfiling methods from browser.py.

profiling_controller is owned by platform, so this will allow decoupling lifetime of profilers from browser.
This cannot be achieved yet in this patch since we have some
profilers whose lifetime dependent on the browser, e.g: v8, tracing... To do
this, profilers' APIs should be modified for case browser_backend is optional if
they are not dependent on the browsers (e.g: monsoon, tcp_dump...).
For now, StartProfiling will explode if the number of running browsers is not 1.

BUG=

Review URL: https://codereview.chromium.org/511653002

Cr-Commit-Position: refs/heads/master@{#293618}

This reverts commit e06bd133.

This is a preemptive revert to see whether a pagecycler regression can
be attributed to this change. (Even if it can, we still probably want to
make the change, but it's good to know.)

BUG=409214
TBR=davidben@chromium.org

Review URL: https://codereview.chromium.org/547843002

Cr-Commit-Position: refs/heads/master@{#293617}

This CL fixes a race where the code would call DismissPictureBuffer()
on all output_picture_buffers_ once it detected a resolution change.
However some of those picture buffers had yet to be displayed by the
client. The client code, when asked to dismiss a picture buffer, only
tries to detect if it is currently displaying that frame, and if not
goes ahead and deletes the texture. This patch defers the dismissing
of the picture buffers until the client calls RecyclePictureBuffer
back with that stale buffer ID, meaning that the texture has been
displayed and can be safely deleted.

TEST: navigate to
http://sr-repro.s3.amazonaws.com/gpudecode/repro-gpu-mbr.html, before
CL there may be series of black frames when playing the video and it
switches from 720p to 1080p. After the CL the black frames are gone.
BUG=404817

Review URL: https://codereview.chromium.org/540043003

Cr-Commit-Position: refs/heads/master@{#293616}

Skip resize handling on fullscreen event.

BUG=408409
R=erg@chromium.org

Review URL: https://codereview.chromium.org/542533002

Cr-Commit-Position: refs/heads/master@{#293615}

This fixes crash, because GetProfileByUser is now returning NULL there.

BUG=411216, 410617
TEST=manual

Review URL: https://codereview.chromium.org/543163002

Cr-Commit-Position: refs/heads/master@{#293614}

This GuestView type would be used to render out of process pdf through extension.
This introduces BrowserPluginDelegate in content/renderer,
because we need a way to create a MimeHandlerView guest (extensions/ concept)
from BrowserPlugin (content/ concept).

MimeHandlerView is behind --enable-mime-handler-view flag.

BUG=303491
Test=Apply http://crrev.com/392813003/ on top of this CL,
Launch chrome with --out-of-process-pdf flag and --enable-mime-handler-view flag
Navigate to a PDF
Check PDF is served using BrowserPlugin, probably easier to see process associated with the BrowserPlugin from Chrome's task manager.

Review URL: https://codereview.chromium.org/376033002

Cr-Commit-Position: refs/heads/master@{#293613}