- 26 Jul, 2019 40 commits
-
-
Jérôme Lebel authored
The primary button needs to be updated according to current state of ChromeSigninViewController. Bug introduced with crrev.com/c/1695411 Bug: 987985 Change-Id: Idfbfbaa48b62fead98d23d2ba464fc46c3285e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720836Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#681386}
-
Kevin Ellis authored
PlayStateInternal returns a value for the play state of an animation that is not to spec. It includes a pending state that is not a valid value for the play state. This CL is part of a series of patches to bring the implementation of web animations in line with the spec. Bug: 958433 Change-Id: Ifd189641e83972e63d474cd99db391aad3dff406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715764 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#681385}
-
Daniel Nicoara authored
Depending how early EXO is initialize the Screen object may have already initialized its display state. When CastWMHelper adds its display observer it will not get a OnDisplayAdded() event by default. Query the list and initialize the observer to ensure state is correct. Bug: b/138247323 Test: Manually on device to verify OnDisplayAdded() is called before EXO clients call to ask for display info. Change-Id: I473185fda846e64907eebb808141d51f281fbdde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720993 Auto-Submit: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#681384}
-
Andrew Luo authored
Bug: 924194 Change-Id: Icfaa9d1d9390ec1c3aa524ff4d139cd4959a600a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715772Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681383}
-
Philip Rogers authored
We use cc::Layer::ScreenSpaceTransform() when collecting layer tree for devtools in layer list mode. We need to ensure the screen space transforms are up-to-date before using them. This is a reland of https://crrev.com/671720 which was rolled out in https://crrev.com/677720 due to multiple UpdateLayers calls. Full layer updates (e.g., with invalidation) are not needed for up-to-date to-screen transforms. Bug: 977578 Change-Id: I21a39a4198290c64e315c586c64a4da3a83da83d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720791Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#681382}
-
Sylvain Defresne authored
The test do not need to access IdentityManager, so remove the use of IdentityTestEnvironmentProfileAdaptor as they are still passing without it. Bug: 984487 Change-Id: Ic065b287f23c0f7f77f619bd802c7a318275c507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710324 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#681381}
-
John Abd-El-Malek authored
Bug: 934009 Change-Id: I927eaef2f8ecf515b010a4ce49d05726f915d5d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720735Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#681380}
-
Nico Weber authored
The references bug was closed long ago, and we're on a completely different toolchain now. Bug: 356580 Change-Id: I92b1a0c2ddd33a18775a72347ac996a4320d173c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721249 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#681379}
-
Daniel Bratell authored
In use_jumbo_build=true builds without goma (i.e. chunk size 50) chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc and chrome/browser/android/webapk/webapk_update_data_fetcher.cc will compile in the same translation unit and then their (identical) helper functions DoesAndroidSupportMaskableIcons() then clashed. It would be nice to only have a single implementation of the function but since it's just "return false;" and I don't know where it could be shared I elected to give the functions unique names. Bug: 988037 Change-Id: I058f1db0c0ec6711e42e5ecfff6b3b016c60a1bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720772 Commit-Queue: Daniel Bratell <bratell@opera.com> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#681378}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ic2edb44cb393d31f7c74c22527b448d4dea91f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700860Reviewed-by:
Frank Barchard <fbarchard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Commit-Queue: Frank Barchard <fbarchard@chromium.org> Cr-Commit-Position: refs/heads/master@{#681377}
-
Shouqun Liu authored
As crbug.com/985803 described, there is redundant 'MB' string in Chinese/Korean translations of downloading file dialog. Bug: 985803 Change-Id: I66a254494d749018b33d10896055bf1edeff6bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710081Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#681376}
-
Daniel Rubery authored
Although we don't update the FileTypePolicies often, if the update fails, these metrics will be very important in diagnosing the cause. Because the FileTypePolicies affect which downloads are checked with Safe Browsing, I'd prefer to be able to quickly diagnose the problem. Bug: 975183 Change-Id: Idf97cd15d117703b3d563804fea733964dc089a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719232 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#681375}
-
Ramya Nagarajan authored
Clean up the pref associated with this field trial, with deletion slated after several milestones. More details at http://doc/1rYBoi6Hm270SB1njw3BhM3Qo9puZn3iiINQy-gMaz4I Bug: 988028 Change-Id: I5846351c4d66b0cf04b4f5c92b7de88db5d4e18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689496 Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#681374}
-
Bryan McQuade authored
If we decide that the non-AMP BeforeInputOrScroll variant is useful, we'll want an AMP version to compare it to. This change also cleans up metric descriptions in ukm.xml to no longer refer to 'jank'. Change-Id: Iee0f25b3ded5ce4667cd6c231acf9e7ea2b65515 Bug: 987652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717123Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#681373}
-
Rohan Pavone authored
Creates class for DevTools permission overrides to maintain logic of overrides as they get more complicated. This maintains a mapping from URL (origin only) to PermissionTypes and their corresponding override status. If no override status is defined, the interface indicates this - it is up to the caller to determine what status to give if no override is given. Design doc: go/permission-overrides-refactor Tested: Unit tests. BUG: 986605 Change-Id: I0ec28e08afbcb97fb9e18f8798cf95f8a63f972d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713436 Commit-Queue: Rohan Pavone <rohpavone@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#681372}
-
Tom Anderson authored
This is necessary for DbusMenu to determine which properties were updated. BUG=981201 R=thestig Change-Id: I94f36f1bd76f6a285129aa709ccd6947e84ac728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700687Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f86d0ece2ee1..23a204c3872e git log f86d0ece2ee1..23a204c3872e --date=short --no-merges --format='%ad %ae %s' 2019-07-26 vapier@chromium.org sdk_stages: fix --exclude handling Created with: gclient setdep -r src/third_party/chromite@23a204c3872e The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Icea87984d9f58250486f21d871e090feee5b5b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721014Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681370}
-
Becky Zhou authored
Add a test to verify that a tooltip can be shown on a card. Bug: 971482, 943874 Change-Id: Ic23095df719e3a798db9230e47d591162ffc148b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719890Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#681369}
-
Koji Ishii authored
This patch moves |StringImpl::To{Lower,Upper}Unicode| to |CaseMap|, so that we can share the code when implementing fast code path for |CaseMap|. No behavior changes other than moving and renaming. Bug: 985201 Change-Id: Id4675625f1fc9a5195479ea6dee9ba44bdbb1438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710240Reviewed-by:Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#681368}
-
Kevin Ellis authored
This patch is a step towards refactoring web animations code to use microtasks. Calls to internal API methods were changed to web facing method calls, which have clearly specified behavior. With this change animation code can be updated without breaking a flurry of tests. Only minor changes should be needed as part of the refactor to address fixes where the current behavior is not spec compliant. Bug: 958433, 960944 Change-Id: Ic24dd62f0d5c74f338b7aca5267d902de9130dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710609 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
-
Matthew Cary authored
Change-Id: Ib5223719a273db3025e7352fedd2a32b690d00af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697621 Auto-Submit: Matthew Cary (CET) <mattcary@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#681366}
-
James Forshaw authored
This CL just fixes a few style nits. Bug: 986625 Change-Id: I6832c69bb2d91e5a74a9562738a9ca13bb48de63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720732Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#681365}
-
Maks Orlovich authored
We weren't doing the renderer-side security checks for navigator.cookieEnabled, so they would get rejections browser-side. I am not sure this is the real cause of 983090, but it is a real bug. This became an issue after the big port of document.cookie (and navigator.cookieEnabled) to RestrictedCookieManager, as previously-used RenderFrameMessageFilter::OnCookiesEnabled was missing browser-side checks, while the new RestrictedCookieManager::CookiesEnabledFor has them. Bug: 983090 Change-Id: I12bd582c952691276ed149fb44d1c4a07f564fdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715601 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#681364}
-
Nektarios Paisios authored
A followup patch should use AXID throughout the code base, but that would be a much larger change. Also makes a few cosmetic changes to AXTree to ease understanding. R=aboxhall@chromium.org Change-Id: I78c9843f4b234312b7529ecf832ef41a666caad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696272 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#681363}
-
Dave Tapuska authored
This fundamentally should not change anything currently. All windows that have access to each other share the same agent so this is just an additional constant value to the string. When the agent is different (in a yet to be implemented change) this will fail the token checks even though the sites are the same origin. This matches what is proposed in the https://github.com/whatwg/html/pull/4606 BUG=961448 Change-Id: Ic0be1e1ac5f231589924eab94d409d8a37c5f081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720712Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#681362}
-
John Budorick authored
This reverts commit 572092c3. Reason for revert: still due to https://bugs.chromium.org/p/chromium/issues/detail?id=988010, but needs a compile fix prior to landing. Original change's description: > Reland "[PasswordManager] Stop Using Native Backends on Linux systems" > > This reverts commit 2d82c3a3. > > Reason for revert: revert applied cleanly but didn't compile cleanly :( > > Original change's description: > > Revert "[PasswordManager] Stop Using Native Backends on Linux systems" > > > > This reverts commit 6811de35. > > > > Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=988010 > > > > Original change's description: > > > [PasswordManager] Stop Using Native Backends on Linux systems > > > > > > Recent migrations moved all users who have been using the keying to the > > > LoginDatabase. This CL forces all users to using LoginDatabase > > > instead of native backends on Linux. > > > > > > TBR=pcc@chromium.org > > > > > > Change-Id: Ibac11e68d8f354ecf7f3c9828d95777ea5b3df60 > > > Bug: 950269, 950267 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713560 > > > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > > > Reviewed-by: Peter Collingbourne <pcc@chromium.org> > > > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > > > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > > > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#681042} > > > > TBR=vasilii@chromium.org,pcc@chromium.org,cfroussios@chromium.org,mamir@chromium.org > > > > Change-Id: I2a42c76df8380cdaafb3485576e1efb9735f9d8d > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 950269, 950267 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721073 > > Reviewed-by: John Budorick <jbudorick@chromium.org> > > Commit-Queue: John Budorick <jbudorick@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#681328} > > TBR=vasilii@chromium.org,pcc@chromium.org,cfroussios@chromium.org,jbudorick@chromium.org,mamir@chromium.org > > Change-Id: I4df7c871947ae69a91be947a4665220df7dc1154 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 950269, 950267 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720737 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681334} TBR=vasilii@chromium.org,pcc@chromium.org,cfroussios@chromium.org,jbudorick@chromium.org,mamir@chromium.org Change-Id: I97a0381132675ac70c67eb7fb0af3608d87d360f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 950269, 950267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720738 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Ella Ge authored
This reverts commit 02efc0f4. Reason for revert: [Cherry-picked & WIP] reland with fixing the test. Original change's description: > Revert "Re-write test pointerevent_pointermove_in_pointerlock.html" > > This reverts commit 9b7bafff. > > Reason for revert: Causing leak failures on WebKit Linux Leak bot > > https://luci-milo.appspot.com/p/chromium/builders/ci/WebKit%20Linux%20Leak/2348 > > Original change's description: > > Re-write test pointerevent_pointermove_in_pointerlock.html > > > > The test was failing in wpt because it passing non-integer value to > > test driver. This CL changes it to use "origin" instead. > > This CL rewrites the test to makes it cleaner, instead of adding event > > listener inside event listener. > > This CL also changes the test to send the "move" events after receiving > > pointerlockchange. > > > > Bug: 986277 > > Change-Id: I0f51523c3c90791339877b2e51afa8e9a4cc9d4d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717195 > > Reviewed-by: Lan Wei <lanwei@chromium.org> > > Commit-Queue: Ella Ge <eirage@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#680563} > > TBR=lanwei@chromium.org,eirage@chromium.org > > Change-Id: Ia53d1066363ceaf804f61ada369a4126c859f875 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 986277 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716038 > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680743} TBR=noel@chromium.org,lanwei@chromium.org,eirage@chromium.org Bug: 986277 Change-Id: I9b104597d2965261104e5842855ab235bdec8081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719227Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#681360}
-
mark a. foltz authored
This updates the chrome://cast WebUI to redirect to the same Media Router extension URL that users are sent to when they visit https://www.google.com/chromecast/offers. It doesn't need the logic to redirect to other parts of the extension any more, since support for managing Cast devices via the extension has been removed. Also, this WebUI is only accessible to users who manually navigate to "chrome://cast" via the omnibox, which is a very small number. This removes the last usage of <extensionview> so we can close Bug 982858. It also removes the OWNERS file since sheretov@ is no longer with the Chromium project. Bug: 982858 Change-Id: I46110f41040fb90a84572c37c5cdad9069bb31a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713806 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#681359}
-
Alex Newcomer authored
This reverts commit 62e5b068. Reason for revert: This CL seems to cause symptoms seen in issue 987276, which is blocking beta. Original change's description: > viz: Partial swap without readback > > viz::BufferQueue currently implements partial swap reading back > from the previously swapped buffer contents that are outside the > current swapbuffer damage. > > This introduces a dependency on a GPU API, that we want to get rid > of (crbug.com/958670). > This technique also assumes it is safe to read back from a buffer > that is used from another driver (crbug.com/457511). > > This CL removes the readback and solves the same problem exposing > a rectangle that the compositor needs to redraw to make sure contents > damaged during all the swapbuffers before the current one are > recomposited. > > Bug: 958670, 457511 > Test: BufferQueueTest.PartialSwapCurrentBufferDamage > > Change-Id: I2d4a70b0122f665b68e25e043d57de6044092fc2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685909 > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#676467} TBR=rjkroege@chromium.org,dcastagna@chromium.org,piman@chromium.org,andrescj@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 958670, 457511 Change-Id: I1fb165ab64151be2ec3da13b543d4b48b2636320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719859Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#681358}
-
Alan Cutter authored
This CL disables AnimationDelegateViews from using the compositor driven CompositorAnimationRunner in favour of the legacy base::RepeatingTimer driven runner. We are disabling this due to the ui::Compositor sometimes going away during the browser window's lifetime on Chrome OS resulting in animations not running anymore. Bug: 969788 Change-Id: If2a029764dd471eb91aadd4030f576c3604a6636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715358 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#681357}
-
Sean Kau authored
PrinterInfoStub posts its callback. Post it back to the sequence it was called on instead of an arbitrary sequence. Issue has not been seen in production because the stub is only used on chromeOS on Linux. Bug: 987854 Change-Id: Icca3752ea1a8e6511277ef19d398f28be89e32e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720151Reviewed-by:
Luum Habtemariam <luum@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#681356}
-
Yue Ru Sun authored
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1687059 Change-Id: Ifbe03a84c72d4ae473bad07d61c7b89984c70521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715411 Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#681355}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f002a637743f..0716ce0a2c0c git log f002a637743f..0716ce0a2c0c --date=short --no-merges --format='%ad %ae %s' 2019-07-26 jonahr@google.com Re-add case to blitframebuffer workaround where src is outside of bounds. Created with: gclient setdep -r src/third_party/angle@0716ce0a2c0c The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: chromium:830046 Change-Id: I477b7ef33e008f4df9422988b1e82acb88dd8e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721011Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9a69857888af..d8a18e30c0ce Created with: gclient setdep -r src-internal@d8a18e30c0ce The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I023b32f0f9cddc0b4a9b30d00cc408d7e92a17f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721015Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681353}
-
Sergio Villar Senin authored
After removing all the dependencies and migrating all the affected code we can now safely remove it from the tree. All the Blink code should be using base::Time* classes from now on. Bug: 919383 Change-Id: I3b2b012d2e1592fce45fc1baf9d1e7f9d4a44cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710554 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#681352}
-
John Budorick authored
This reverts commit 7dd2ac40. Reason for revert: landed on top of a change that needs to be reverted for https://bugs.chromium.org/p/chromium/issues/detail?id=988010 Original change's description: > [Password Manager] Restore UMA metric for how many linux users don't have encryption > > The existing UMA uploads don't separate new profiles from existing > profiles which couldn't be migrated. > > Bug: 950267 > Change-Id: I0f8f823e843bd2127a71438c347031f6a7b23346 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720630 > Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> > Auto-Submit: Christos Froussios <cfroussios@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681348} TBR=vasilii@chromium.org,cfroussios@chromium.org Change-Id: Ib6d74e8400e81f0a62160326273abf76dd74dc6d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 950267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721291Reviewed-by:
-
Ken Rockot authored
Gets rid of all Service Manager dependencies from the Unzip service and its client library. Also introduces a Content library under components/services/unzip/content/ for Content embedders to launch new Unzip service processes as needed. Bug: 977637 Change-Id: I7205f15ffcd55921fb0d01689165770281365ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715973 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#681350}
-
Pâris MEULEMAN authored
This merges back SigninManagerDelegate.java into SigninManager.java and likewise for c++ code. This is in the scope of a change of strategy regarding the identityManager implementation on Android, using a layering strategy similar to what was done on iOS. The change consist in: * copy chrome_signin_manager_delegate.* methods to signin_manager_android.* * rename occurrences of ChromeSigninManagerDelegate to SigninManagerAndroid, in Java including JNI invocations and C++. * Directly invoke methods instead of calling mDelegate (java) * Update constructors to include the delegate dependencies. * A significant change that is not an obvious code move is the rollback of SigninManagerAndroid's constructor using SigninClient/PrefService(local_state) to Profile. This makes the remainder of the change much simpler, but does cascade to the factory. The above changes are described in their files in PS3: crrev.com/c/1700210/3 Change-Id: I1b0de2129f3df649fa56d50b8dd191e8e1bb30ab Bug: 985256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700210 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#681349}
-
Christos Froussios authored
The existing UMA uploads don't separate new profiles from existing profiles which couldn't be migrated. Bug: 950267 Change-Id: I0f8f823e843bd2127a71438c347031f6a7b23346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720630 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#681348}
-
John Budorick authored
This reverts commit 3a84c395. Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/1713560 didn't stick, see https://bugs.chromium.org/p/chromium/issues/detail?id=988010 Original change's description: > [Password Manager] Cleanup feature: Migrate Linux to LoginDB > > The migration has been completed and the feature is no longer used. > > Bug: 950269 > Change-Id: I91f79f33ccda95e75d2b6156ade5d44f2e27c0ae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719008 > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681244} TBR=vasilii@chromium.org,cfroussios@chromium.org Change-Id: Ic0733620d3ebca563f5fa0be9f60742770eacd45 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 950269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721290Reviewed-by:
-
