- 08 Mar, 2020 3 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2d30170001a7..0096c57fe62d Created with: gclient setdep -r src-internal@0096c57fe62d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I425b7b8c7feea5ea765b7b078a66768c7e46b2fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093799Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748033}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ib53a742b71fe391fa22e48f6d905901a252387e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093803Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748032}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3034408f4175..2d30170001a7 Created with: gclient setdep -r src-internal@2d30170001a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024588 Tbr: jbudorick@google.com Change-Id: Ib87d580dc324aea9bf16bae8e092017d4b6a8128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093784Reviewed-by:
-
- 07 Mar, 2020 37 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f80046d9872a..3034408f4175 Created with: gclient setdep -r src-internal@3034408f4175 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I3955b1093941b32c5fca5c6c39fcded03773f37b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093773Reviewed-by:
-
chromium-autoroll authored
Roll silvermont AFDO profile from 82-4044.31-1583145468-benchmark-82.0.4077.0-r1 to 82-4044.31-1583145468-benchmark-82.0.4078.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I139a84fe975dc3a07f42a9f357244afba870c577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093782Reviewed-by:
-
Daniel Cheng authored
PassPipe() consumes all state on PendingRemote, including the interface version, so the result of a function call like F(remote.PassPipe(), remote.version()) depends on what order the compiler happens to evaluate the arguments in. In Chrome, most interfaces are unversioned, so this happens to work out the vast majority of the time. Bug: none Change-Id: I6c9e634e27bfa7627540a97dd8ad23927a845277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093396 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#748028}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/03ed5f6c4698..0c9b6abde90c git log 03ed5f6c4698..0c9b6abde90c --date=short --first-parent --format='%ad %ae %s' 2020-03-07 b.schade@samsung.com Skip invalid end2end test for ES2 Created with: gclient setdep -r src/third_party/angle@0c9b6abde90c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: I35b1972e2e859186af224b63ae976e3d0777f044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093655Reviewed-by:
-
Christos Froussios authored
This change makes clicking on the dots icon open a menu with action items for the compromised password. Bug: 1047726 Change-Id: If192af77ca8dc184670d64cbf99322c29f94b42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088151 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#748026}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cf573d844da6..2e19af063bcc git log cf573d844da6..2e19af063bcc --date=short --first-parent --format='%ad %ae %s' 2020-03-07 brianosman@google.com Revert "Move interpreter disassemble to out-of-line member of ByteCode" Created with: gclient setdep -r src/third_party/skia@2e19af063bcc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: Idb69bc7b11b1a651e892e7b9604d482be17c1a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093657Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1ce3e7f2f9a8..f80046d9872a Created with: gclient setdep -r src-internal@f80046d9872a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I8bd5564ef213df7cfc03b9dd8fe297f21db39a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093656Reviewed-by:
-
Nektarios Paisios authored
On platforms that support embedded object characters, such as IA2 and ATK, we were not computing the correct ancestor position when trying to compare two leaf text positions. If the leaf text position is within an embedded object, we need to adjust the ancestor position to point to after the embedded object character, if the leaf position is not at the start of the embedded object. This is per the IA2 Spec. Test steps are in the attached bug. R=dmazzoni@chromium.org, kbabbitt@microsoft.com Bug: 1057831 Change-Id: Iabc44586ae35c4bb927655707366bf3b81b79fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081527 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#748023}
-
Mike West authored
Context: https://github.com/w3c/webappsec-trusted-types/issues/257 Bug: 1058400 Change-Id: Ie91e8ad7e8eff814e3aaa1d940ca0bc1d6c2f09e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089705Reviewed-by:
Yifan Luo <lyf@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#748022}
-
James Hollyer authored
Pointer lock requests were still using the old IPC workflow. This updates the call to use Mojo. Bug: 1042293 Change-Id: I5b3b58b56f37fd8ea3fb5960579340fc0d72514a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028453 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#748021}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7302723c092a..1ce3e7f2f9a8 Created with: gclient setdep -r src-internal@1ce3e7f2f9a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I92707cbd4078b177da19fdd6e208cfd592ee604e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093618Reviewed-by:
-
Rainhard Findling authored
* Prepares extension child for state update in backend (crrev.com/c/2089775). * Updates button relaunches browser. * Password button links to password check page. * Safe browsing button links to security page. * Extensions button opens extensions in new tab. Bug: 1015841 Change-Id: I522ce5080eda92ebcee6ce6d17303eb490a651c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087677 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4af8a9af995e..eefc8a8dd7b8 git log 4af8a9af995e..eefc8a8dd7b8 --date=short --first-parent --format='%ad %ae %s' 2020-03-07 taoalpha@google.com Fix horizontal scroll on Application tab side bar Created with: gclient setdep -r src/third_party/devtools-frontend/src@eefc8a8dd7b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idd2a5fa7f5c14b32f3ec3eaa664139c5c251cdd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093613Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I7222186fa2137f8cf46dbafde9bf8ee8db3b390c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093135Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748017}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/12ec6fce73b0..4af8a9af995e git log 12ec6fce73b0..4af8a9af995e --date=short --first-parent --format='%ad %ae %s' 2020-03-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@4af8a9af995e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibd43ed69659f1dd9b493c8181f80b506dfe884b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092984Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bcc417c0598c..7302723c092a Created with: gclient setdep -r src-internal@7302723c092a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iede51504e54dd95d922088d13e2663ad1ad5fa08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092981Reviewed-by:
-
Ehimare Okoyomon authored
Add new string for incognito NTP toggle on desktop and android. Android: https://screenshot.googleplex.com/0jkU80X35Tn.png Desktop: https://screenshot.googleplex.com/UrfJiLVVfPt.png Bug: 1059186 Change-Id: I8d286725b3241ec41e374514de2294a49682675a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089905 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#748014}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eb391a519902..bcc417c0598c Created with: gclient setdep -r src-internal@bcc417c0598c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I7c6440b3cc51cab163098de9726d7361b35ca8ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092978Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/57d4742bbb10..ffd02955e668 git log 57d4742bbb10..ffd02955e668 --date=short --first-parent --format='%ad %ae %s' 2020-03-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@ffd02955e668 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I76df5dabb59ba8bcc4f8690cf958860181907c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092976Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/11f5795a70a2..eb391a519902 Created with: gclient setdep -r src-internal@eb391a519902 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I7d78597eb62d01b222ca717c3fd10a75a56f2ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092975Reviewed-by:
-
Filip Gorski authored
Bug: 1054072 Change-Id: I5d549d6c9970bad857310b61c30b922ad5f1a5ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087999 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#748010}
-
Andres Calderon Jaramillo authored
This CL fixes a GPU resource leak in the GLOutputSurfaceBufferQueue. Whenever we tell the BufferQueue to free all its buffers, GLOutputSurfaceBufferQueue should delete the corresponding textures and the stencil buffer. This was being done in the case of Reshape(), but not in the case of DidReceiveSwapBuffersAck() with a response of SWAP_NAK_RECREATE_BUFFERS. As a consequence, the underlying buffer was not being freed since there is reference counting in the SharedImage system. An example of this path happens in kukui when the screen is turned off and then on. If this is done many times, eventually too many buffers are allocated and leaked and we run out of memory. /sys/kernel/debug/dri/1/framebuffer Bug: b:149972616, 1054166 Test: turn screen on/off in kukui repeatedly and monitor Change-Id: Idfbd97a470951103e115cc3ecd9e3d2c4c05f6b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093021Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#748009}
-
Rainhard Findling authored
* Splits safety check callbacks into 4 distinct events (one per child). * Aggregates all callback constants on top of safety_check_page.js. * Updates passwords and extensions callback to expect a UI string. Bug: 1032584 Change-Id: Ia10c4809da2331fbc648c628469797eff5dd0504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080266 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/64bb65eb045a..12ec6fce73b0 git log 64bb65eb045a..12ec6fce73b0 --date=short --first-parent --format='%ad %ae %s' 2020-03-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@12ec6fce73b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia3e9d5b5a6109a991fe75826aa6625add054723e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092974Reviewed-by:
-
rajendrant authored
Adds to field trial testing config TBR=tbansal@chromium.org Change-Id: I895e38bdc966ad1dbceaf170861589a4c17f1301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090299Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#748006}
-
Sven Zheng authored
Currently the system make comments on changes which doesn't change pixel output. Bug: 1059469 Change-Id: Id8088fe9d63d1d92b52ed51b7e617db572d4ff37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092554Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#748005}
-
Jinsuk Kim authored
This CL removes OverlayPanel-related classes from Preview Tab implementation. - Some of the operations performed by OverlayPanelContent are now taken care of by EphemeralTab: - EphemeralTabCoordinator creates WebContents/ContentView. - WebContentsDelegateAndroid object is now created and passed to ThinWebView to have it populated when attaching WebContents. - OverlayPanelContent was listening to WebContentsObserver/ WebContentsDelegateAndroid and relays the calls to OverlayContentDelegate/OverlayContentProgressObserver. A new class EphemeralTabMediator takes over all this tasks. - Dependency on ChromeActivity was also removed. Bug: 998826 Change-Id: Idf166b67fa4b7ced94d2bc349d61f7751a49138a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082413 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#748004}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/83e394a59e78..11f5795a70a2 Created with: gclient setdep -r src-internal@11f5795a70a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I15de56796a88ee42d50d38cfff850d940e6d0f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093118Reviewed-by:
-
Toby Huang authored
We want to track how many times custodians grant approval for child users to install extensions. This CL adds UMA histogram and user action metrics for child users using Chrome Web Store. Bug: 1022620 Change-Id: Ia89f38bde97723936fbe287751571dd0afe6351d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904679 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#748002}
-
Filip Gorski authored
Removes the knowledge of ActivityTabProvider class and ChromeActivity#getActivityTabProvider() from: * org.chromium.chrome.browser.toolbar.* * org.chromium.chorme.browser.omnibox.* Bug: 1054072 Change-Id: I362d425b2dd2927a00e0e28d6c641931ddf3f518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080089Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I760a86ee5aa29d3e5ea9fb20190a4890dca9f9ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093134Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748000}
-
Sinan Sahin authored
Disable the test for Android L for now to avoid revert and reland of the previous CL as this test seems to fail on L only. TBR=twellington@chromium.org Bug: 1059421 Change-Id: I2533672b7d584db64af42a178b24df53b5e7ac99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092161 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/97c0ebd7cc1e..64bb65eb045a git log 97c0ebd7cc1e..64bb65eb045a --date=short --first-parent --format='%ad %ae %s' 2020-03-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@64bb65eb045a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I88b22c15915156d74d6c3717c1d75430d3640169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093117Reviewed-by:
-
Mirko Bonadei authored
The usage of all_dependent_configs is considered a GN anti-pattern and it should be used only when the public_deps/deps/public_configs/configs system is not enough. There is no real reason to use all_dependent_configs in //third_party/googletest and since its usage has increased in crrev.com/c/2090420, this CL addresses the problems and removes its usage. Bug: 1059240 Change-Id: I4ff2bd0a19ad2ddd0b25866fcf738ab2d05a523b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091487 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#747997}
-
Kyle Horimoto authored
This CL: (1) Adds a new os_settings_search_tag_strings.grdp file which contains search tags for this effort, and adds a few network-related search tags (see go/cros-settings-search for details). (2) Adds a SearchConcept struct and SearchResultIcon enum used to create metadata for a search result with potential alternate descriptions. (3) Creates an OsSettingsLocalizedStringsProvider class with a few Add*SearchTags() and Remove*SearchTags() functions for the tags added in step 1 above. Bug: 1059099 Change-Id: Ib5a126c3ff0ba16ffb734cb4cf0570500cec3b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086811 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:James Cook <jamescook@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium b32d49ba. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iebc2481d486645cdd42b642bf1347467f133683e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093251Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747995}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0c5c7ea9e66a..c5f5b9e95179 git log 0c5c7ea9e66a..c5f5b9e95179 --date=short --first-parent --format='%ad %ae %s' 2020-03-07 jbudorick@chromium.org devil: don't retry system app modification on timeout. Created with: gclient setdep -r src/third_party/catapult@c5f5b9e95179 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1056214 Tbr: nuskos@google.com Change-Id: I45c2d156d59b32b01593a4a83ffcae2e9be7a8cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093113Reviewed-by:
-
