GitLab

The methods with the 'New' suffix are temporary and will soon be
removed.

BUG=chromium:243605
TEST=manual

Review URL: https://codereview.chromium.org/213413009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260428 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260424 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=170416%3A170423&mode=html

TBR=rafaelw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/218393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260423 0039d316-1c4b-4281-b951-d872f2087c98

They are intentional.

TBR=rafaelw@chromium.org
BUG=358014

Review URL: https://codereview.chromium.org/213833007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260422 0039d316-1c4b-4281-b951-d872f2087c98

> Temporary CHECK version 2 in IPC::Channel::Send() to help track down crash.
> 
> TBR=sievers@chromium.org, cpu@chromium.org
> BUG=357915
> 
> Review URL: https://codereview.chromium.org/218433002

TBR=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/216933007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260419 0039d316-1c4b-4281-b951-d872f2087c98

> Another temporary CHECK to help track down crash in IPC.
> 
> (Grasping at straws here.)
> 
> TBR=sievers@chromium.org, cpu@chromium.org
> BUG=357915
> 
> Review URL: https://codereview.chromium.org/218513002

TBR=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/218573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260418 0039d316-1c4b-4281-b951-d872f2087c98

(Grasping at straws here.)

TBR=sievers@chromium.org, cpu@chromium.org
BUG=357915

Review URL: https://codereview.chromium.org/218513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260408 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sievers@chromium.org, cpu@chromium.org
BUG=357915

Review URL: https://codereview.chromium.org/218433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260399 0039d316-1c4b-4281-b951-d872f2087c98

> Add a temporary CHECK to IPC::Channel::Send() to help track down crash.
> 
> TBR=cbentzel@chromium.org, cpu@chromium.org
> BUG=357915
> 
> Review URL: https://codereview.chromium.org/216293008

TBR=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/217323004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260393 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260392 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=green?

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260391 0039d316-1c4b-4281-b951-d872f2087c98

When Chrome detects it is out of date and the user clicks to reenable
updates, this will shell out to setup.exe, elevate if necessary and
perform the needed actions to reenable updates.

Copied from https://codereview.chromium.org/216153006/ by robertshield@chromium.org.

TBR=sky
BUG=164681, 171271
TEST=Run chrome.exe --simulate-outdated-no-au and click on reenable updates while Omaha group policy to disable updates is applied.
NOTRY=true

Review URL: https://codereview.chromium.org/217533005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260388 0039d316-1c4b-4281-b951-d872f2087c98

Introduces ProtectedPrefStore which delegates to two different backing stores to handle unprotected and protected values.

NOTRY=True
BUG=349158

Review URL: https://codereview.chromium.org/205813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260387 0039d316-1c4b-4281-b951-d872f2087c98

Cause:
This bug only repro on chrome v33 and v34

<div class="vertically-centered">
  <div class="horizontally-centered">
    <div id="video-container">
      <video id="mediasource-video-output"></video>
      <div id="client-plugin-container"></div>
    </div>
  </div>
</div>

Due to a chrome layout bug, the width of video-container collapses to 0 when the zoom level is greater than 100%. As a result, the flexbox defined in horizonally-centered fails to center the element.

Fix:
Set width=100% on video-container so that its width remains valid.  Since video-container now sizes to the parent, we need to move the horizontal-centered flexbox to the children of video-container.

BUG=357114

Review URL: https://codereview.chromium.org/217363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260386 0039d316-1c4b-4281-b951-d872f2087c98

The underlying bug has been fixed (and was not in RenderText).

BUG=348103
NOTRY=true

Review URL: https://codereview.chromium.org/217243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260385 0039d316-1c4b-4281-b951-d872f2087c98

If you're using the --new-profile-management flag, this CL uses a high 
resolution profile avatar, if it can be found. If it doesn't, it remains in the 
present status quo of using the small resolution avatar. If the flag isn't
enabled, the only changes are minor refactors, and no user changes are 
visible.

This is CL #1 of a multi-CL Voltron, that solves the avatar migration
problem as discussed here:
https://docs.google.com/a/google.com/document/d/1KU9gvlXg33rwcvr24NmReXwYRZ1KJhGmiMziyDHyttQ/edit?usp=sharing

TL;DR: the existing avatars are really tiny and can't really be displayed at
a higher size. We will on-demand download them to the user_data dir, and
if available, display them from there.

For testing, you can copy these avatars to user_data_dir/Avatars:
https://drive.google.com/folderview?id=0B1B1Up4p2NRMWE1tcHNsSmtPSlE&usp=sharing

BUG=305048

Review URL: https://codereview.chromium.org/210043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260384 0039d316-1c4b-4281-b951-d872f2087c98

OSX already uses description as display name for printers, so pass printer model instead.

BUG=256223
NOTRY=true

Review URL: https://codereview.chromium.org/214443007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260383 0039d316-1c4b-4281-b951-d872f2087c98

WebGL and Canvas also should draw a fixed VideoFrame showing a Cast logo, which replaces the local video
frames in embedded <video> elements whenever a video is being played remotely.

TEST=Run http://browsertests.herokuapp.com/media/mdn_samples_webgl_sample8/index.html on Nexus 5.
BUG=284478
NOTRY=true

Review URL: https://codereview.chromium.org/212183005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260382 0039d316-1c4b-4281-b951-d872f2087c98

Rather than forwarding the touch event to the input router and incurring the
attendant overhead, short-circuit touch forwarding from ContentViewCoreImpl
when no touch handler exists.  This aligns with existing Aura behavior, and
saves ~20us/event when no touch handler exists.

BUG=341613

Review URL: https://codereview.chromium.org/217253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260381 0039d316-1c4b-4281-b951-d872f2087c98

This is a follow-up to
https://src.chromium.org/viewvc/chrome?revision=256913&view=revision that makes
error messages more descriptive.

It was automatically produced with

git grep -l 'DCHECK(.*CurrentlyOn' extensions chrome/*/extensions|xargs sed -i -e 's/DCHECK(BrowserThread::CurrentlyOn(\([^)]*\)))/DCHECK_CURRENTLY_ON(\1)/' -e 's/DCHECK(content::BrowserThread::CurrentlyOn(\([^)]*\)))/DCHECK_CURRENTLY_ON(\1)/'

Review URL: https://codereview.chromium.org/216513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260380 0039d316-1c4b-4281-b951-d872f2087c98

Remove outdated comment and enable OOM tests under sanitizers. Also, document
the fact that the newly introduced UncheckedMalloc()/UncheckedCalloc() don't
work as intended in sanitizer builds.

BUG=357732
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/217343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260379 0039d316-1c4b-4281-b951-d872f2087c98

This code has been unused for around 2 years.

BUG=355145

Review URL: https://codereview.chromium.org/196173023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260378 0039d316-1c4b-4281-b951-d872f2087c98

DevToolsAgentMsg_PauseWorkerContextOnStart was send to the worker process from the browser process in order to pause the worker context when it starts.
Before http://crbug.com/329786 this message was sent between WorkerProcessMsg_CreateWorker and WorkerMsg_StartWorkerContext.
So the worker was successfully paused before started.
But after http://crbug.com/329786 the worker context may be started before the worker process receives this message because WorkerMsg_StartWorkerContext is no longer sent from the browser process.
So we have to add pause_on_start flag to WorkerProcessMsg_CreateWorker_Params to pause the worker context correctly.

BUG=329786

Review URL: https://codereview.chromium.org/213423008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260377 0039d316-1c4b-4281-b951-d872f2087c98

This cl adds one UMA stats.
- SharedWorker.RendererSurviveForWorkerTime

BUG=327256

Review URL: https://codereview.chromium.org/212403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260376 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cbentzel@chromium.org, cpu@chromium.org
BUG=357915

Review URL: https://codereview.chromium.org/216293008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260373 0039d316-1c4b-4281-b951-d872f2087c98

We can re-enable them after the Shadow DOM construction
dust settles

TBR=rsadam
BUG=357946

Review URL: https://codereview.chromium.org/218333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260370 0039d316-1c4b-4281-b951-d872f2087c98

36 is both the square of 6 and a triangular number, making it a square triangular number. It is the smallest square triangular number other than 1, and it is also the only triangular number other than 1 whose square root is also a triangular number.

36 is the number of degrees in the interior angle of each tip of a regular pentagram..

The number of possible outcomes (not summed) in the roll of two distinct dice.

The number of domino tilings of a 4×4 checkerboard is 36.

The sum of the integers from 1 to 36 is 666.

There are 36 inches in a yard.

36 is the number of characters required to store the display name of a UUID or GUID.

36 is the perfect score on the ACT.

Jewish tradition holds that the number 36 has had special significance since the beginning of time.

36 is the ASCII code for the dollar symbol.

R=dharani@google.com, laforge@chromium.org

Review URL: https://codereview.chromium.org/218183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260368 0039d316-1c4b-4281-b951-d872f2087c98

"Make mediaPlayerRequestFullscreen() user gesture bypass explicit"
(Blink r170080) makes the setting redundant.

BUG=355439

Review URL: https://codereview.chromium.org/212133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260363 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org

Review URL: https://codereview.chromium.org/218043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260362 0039d316-1c4b-4281-b951-d872f2087c98

As of r259048, WebMediaPlayerImpl now notifies the compositor of new
frames directly on the compositing thread. If
VideoFrameProviderClientImpl::DidRecieveFrame() is called before
VideoLayerImpl::DidBecomeActive() is called,
VideoFrameProviderClientImpl may attempt to call
VideoLayerImpl::SetNeedsRedraw() using an uninitialized pointer.

BUG=357145
R=enne@chromium.org

Review URL: https://codereview.chromium.org/214543011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260360 0039d316-1c4b-4281-b951-d872f2087c98

It's impossible for VideoFrameCompositor to know why the compositor may not have requested the frame, so it shouldn't be counted towards dropped frames if the rest of the media stack was capable of producing and delivering frames on time.

BUG=335345
R=xhwang@chromium.org

Review URL: https://codereview.chromium.org/214823005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260358 0039d316-1c4b-4281-b951-d872f2087c98

No functionality change, just moving things around.
- Move functions so that it is more convenient to read .cc file top to bottom.
- replace ANDROID with OS_ANDROID. Looking at other places in the code OS_ANDROID is much more popular way to check for android.

R=rlarocque@chromium.org

Review URL: https://codereview.chromium.org/217653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260357 0039d316-1c4b-4281-b951-d872f2087c98

The Service Worker can reject an install event by passing a promise to
waitUntil that is rejected. This patch allows handling for this situation.

This patch depends on the Blink change:
https://codereview.chromium.org/210833004/

BUG=285976
R=jam@chromium.org, kinuko@chromium.org, tkent@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/205563006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260356 0039d316-1c4b-4281-b951-d872f2087c98

(Explicitly disallow octal and hexadecimal ordinals.)

R=darin@chromium.org

Review URL: https://codereview.chromium.org/217093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260355 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347044
TEST=Manual, see bug.
NOTRY=true

Review URL: https://codereview.chromium.org/213793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260354 0039d316-1c4b-4281-b951-d872f2087c98

Note the missing trailing comma in the second-last entry (invalidating the last
two entries). (zlib is allowed by chrome/browser/DEPS while ui is allowed by
chrome/DEPS.)

R=fischman@chromium.org

Review URL: https://codereview.chromium.org/218063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260350 0039d316-1c4b-4281-b951-d872f2087c98

As we've observed a "cloned install" effect in the wild, 
doing this will de-clone such installs. (Which will work 
in conjunction with other measures to prevent new instances 
of cloned installs appearing). 

Renames client id and low entropy source prefs so that they 
are re-generated the next time Chrome runs. Makes the code 
clear the old prefs, so that they are cleaned up in 
existing local state files (in a future milestone, we can 
remove them completely - http://crbug.com/357704).

(Note: Does not rename kMetricsPermutedEntropyCache as 
that pref is reset when the low entropy id is re-generated.) 

BUG=357618
TEST=Running an UMA-enabled build should result in local state 
getting new values for user_experience_metrics.low_entropy_source2 
and user_experience_metrics.client_id2 and removal of prefs 
low_entropy_source and client_id.
NOTRY=true

Review URL: https://codereview.chromium.org/217083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260349 0039d316-1c4b-4281-b951-d872f2087c98

When a cloned install is detected the metrics client id and low entropy source are reset on the next start of Chrome. This is done by setting a pref in local state. The next time either the client id or low entropy source are loaded from the local state, they are first reset.

BUG=343273
NOTRY=true

Review URL: https://codereview.chromium.org/213363004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260348 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/218023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260347 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260344 0039d316-1c4b-4281-b951-d872f2087c98