- 12 Oct, 2018 40 commits
-
-
Clifford Cheng authored
Added a few more checks to verify the presence of MR dialog before performing different actions. Also, reorder the test case to avoid the failure of terminating tests affect the next run. Change-Id: Id5321e1af99e15863158879d323dcd37419197a2 Reviewed-on: https://chromium-review.googlesource.com/c/1278948 Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#599390}
-
Jacob Dufault authored
Bug: 893386 Change-Id: Id6de56514183945879f4cf6ffdca7ad7beeae3d7 Reviewed-on: https://chromium-review.googlesource.com/c/1279189Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#599389}
-
Eric Stevenson authored
Change-Id: I3527a04050501edc405f7b1a075c52f81901d9ab Reviewed-on: https://chromium-review.googlesource.com/c/1279196Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#599388}
-
Dave Tapuska authored
Use wtf_size_t when dealing with WTF types. BUG=879657 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I473e021de35dd792a5d9522bad146e38a6a334f9 Reviewed-on: https://chromium-review.googlesource.com/c/1274188 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#599387}
-
Clark DuVall authored
Bug: 721403 Change-Id: If3cae7ab4e1122b98411076d3f72c6088f184c71 Reviewed-on: https://chromium-review.googlesource.com/c/1279227Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#599386}
-
Michael Spang authored
When the view properties event arrives before the view metrics event, we get a wildly incorrect surface size due to use of an unitialized scale factor. We're already checking if it's nonzero before deciding the size, so initialize it to zero so that this check can work. Bug: 861853 Test: run_ozone_demo --ozone-platform=scenic --enable-vulkan Change-Id: I6049e05992b1041ee1f63b1f293f1ac2013c82b0 Reviewed-on: https://chromium-review.googlesource.com/c/1279286Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#599385}
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I33c673691866d770feb1ad0e8322d4f1ca144ddc Reviewed-on: https://chromium-review.googlesource.com/c/1279295Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#599384}
-
Scott Violet authored
BUG=none TEST=none Change-Id: If6677be34230f148b0299739325992a174c339ac Reviewed-on: https://chromium-review.googlesource.com/c/1279235Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#599383}
-
Lan Wei authored
After we enabled flag of NoHoverAfterLayoutChangeEnabled, we did not see any improvement of the HitTest count, now we do not update the mouse cursor as well to see if we get any improvement. We will update the hover effect and mouse cursor after the layout is changed in a following patch. Bug: 877132 Change-Id: Ie8e56df652e2b04add2880cb75aa28f52bb92e56 Reviewed-on: https://chromium-review.googlesource.com/c/1274201Reviewed-by:
-
Jacob Dufault authored
This code is only used in OOBE so it is safe to just remove it. Bug: 890367 Change-Id: I54130cc3c115c1a1356a045f443a8a19962686f8 Reviewed-on: https://chromium-review.googlesource.com/c/1279162Reviewed-by:
-
Daniel Murphy authored
Bug: 875439 Change-Id: If6c56a4c634ce685a4e1ab93660ae95db7d90716 Reviewed-on: https://chromium-review.googlesource.com/c/1274599Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#599380}
-
Kelvin Jiang authored
Add an install warning for the case when an extension requests optional permissions that are also listed as required permissions. Currently, only do this for API permissions; a follow-up will handle host permissions. Bug: 859959 Change-Id: Ic9dc1a834e3e597aa12fe4136f4f087c6295400f Reviewed-on: https://chromium-review.googlesource.com/c/1265118 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#599379}
-
Joel Einbinder authored
Bug: 860286 Change-Id: Iec7cf205d6b240cb54b113690e61414e12685df9 Reviewed-on: https://chromium-review.googlesource.com/c/1278160Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#599378}
-
Kristi Park authored
Fix crashes caused by |url_checker_for_testing_| not being initialized properly. Additionally, construct UrlValidityChecker with NoDestructor instead of a global LazyInstance. We prefer to leak singletons to avoid unnecessary work at shutdown. Also simplify UrlValidityChecker by passing TickClock, which provides cleaner timeout and duration testing. Bug: 894742 Change-Id: I468f76e07dc6f551a8515d8416d0c67f5f2035a1 Reviewed-on: https://chromium-review.googlesource.com/c/1277959 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#599377}
-
Adrienne Walker authored
This is a reland of c8d0d447 Original change's description: > Use transfer buffer for small transfer cache entries > > OOP-R in RasterImplementation currently allocates the entire free space > available in the transfer buffer so that it doesn't have to measure > first then serialize and can just optimistically serialize into that > space. This means that other transfer buffer consumers can't use it, > and are instead forced to use mapped memory. This turns out to not > be very efficient for large numbers of small allocations. > > To sidestep this problem, small transfer cache entries are serialized > into the heap when encountered. Then when raster is complete, it > shrinks the transfer buffer down to the correct size and these small > transfer cache entries are added after it. Then the commands for these > entries are submitted first before raster. > > For example, for three transfer cache tasks (A B C) and one raster (R) > the transfer buffer and ring buffer will look like this: > > transfer buffer ring buffer: R A B C > command buffer: A B C R > > This patch also loosens the restriction on gpu::RingBuffer that there > can be only one in use block at any time. This leads to potential > exhaustion issues because the ring buffer won't reallocate while there > are in use blocks. To avoid this, this optimization is only used when > there is room in the ring buffer without waiting. > > An alternative to this patch would have been to have yet another > transfer buffer only for the transfer cache or to rewrite oopr > serialization, but both of those are more invasive solutions. > > On OSX, on the rendering.desktop telemetry benchmark, on the story > web_animation_value_type_path, this results in the following results: > > gpu-r: > raster cpu time: 2.011ms > gpu cpu time: 12.891ms > total time: 14.902ms > > oop-r: > raster cpu time: 7.314ms <- the bug > gpu cpu time: 3.804ms > total time: 11.118ms > > oop-r + this patch: > raster cpu time: 0.812ms > gpu cpu time: 3.901ms > total time: 4.713ms > > Bug: 804380, 877168 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I586cbca2acb13b8de7d3490c5eb5d6b415f6eda5 > Reviewed-on: https://chromium-review.googlesource.com/c/1262955 > Commit-Queue: enne <enne@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597654} Bug: 804380, 877168 Change-Id: I5c7b0d3b43c0c6f57eb7e5a9c43b4b8ecb22518a Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/c/1277949 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#599376}
-
Daniel Murphy authored
It should go away once the "old way" is removed. Binary-Size: Increase is temporary due to a "new way" / "old way" refactoring. Bug: 781870 Change-Id: I0425be19fddd9d198e71ed5e6a884b7077f9ffdf Reviewed-on: https://chromium-review.googlesource.com/c/1263283 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#599375}
-
Xiaocheng Hu authored
This reverts commit 677ab843. Reason for revert: Landing the original rebaseline patch, together with the missing android-specific baselines. Original change's description: > Revert "Layout test text dump rebaseline using Element.innerText part 1" > > This reverts commit 90115af8. > > Reason for revert: caused layout test failures on Android: > > * compositing/geometry/bounds-ignores-hidden.html > * compositing/images/clip-on-directly-composited-image.html > * crypto/random-values.html > * crypto/subtle/importKey-badParameters.html > > Original change's description: > > Layout test text dump rebaseline using Element.innerText part 1 > > > > This patch changes tests in the following directories to use > > Element.innerText for text dump: > > > > accessibility/ > > animations/ > > battery-status/ > > bindings/ > > clipboard/ > > compositing/ > > crypto/ > > > > Most of this patch is mechanical rebaseline, except: > > - Some LayoutNG-specific baselines become redundant and are > > removed > > - One test is turned into failure with LayoutNG flag due to > > LayoutNG innerText bug with ellipsis (crbug.com/873957). > > > > Bug: 887148 > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > > Change-Id: Idf28a2696b4824f3fd845c7392b588544e8de1d3 > > Reviewed-on: https://chromium-review.googlesource.com/c/1239165 > > Reviewed-by: Kent Tamura <tkent@chromium.org> > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#599052} > > TBR=yosin@chromium.org,tkent@chromium.org,xiaochengh@chromium.org > > Change-Id: I0018e928bd9789c95c2d923b35296f1f82fd41c4 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 887148, 894841 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Reviewed-on: https://chromium-review.googlesource.com/c/1278931 > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599255} TBR=yosin@chromium.org,tkent@chromium.org,xiaochengh@chromium.org Change-Id: Id023167a88b7d92fab1fcfd1a51fbd6cfb59ba12 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 887148, 894841 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1279183 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#599374}
-
Lindsay Pasricha authored
This CL replaces internal 664674 Bug: 866147 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ic7099581b50efb59ec71d6efc518ea7a3be15429 Reviewed-on: https://chromium-review.googlesource.com/c/1273821 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#599373}
-
James Darpinian authored
Not a new regression, just the same one from 10.13. TBR: kbr@chromium.org Bug: 871872 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I161690817b84569ff692e374f6d58a26ca1012db Reviewed-on: https://chromium-review.googlesource.com/c/1279160Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#599372}
-
Weidong Guo authored
Bug: 894583 Change-Id: I7c1011ab2f8acffbe93b7523c6839f481f733ae7 Reviewed-on: https://chromium-review.googlesource.com/c/1279203Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#599371}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f9da224859f3..908f8fb5026a git log f9da224859f3..908f8fb5026a --date=short --no-merges --format='%ad %ae %s' 2018-10-12 vapier@chromium.org paygen: paygen_build_lib: convert to gs.LS 2018-10-12 gmx@chromium.org minnie: enable new tcmalloc Created with: gclient setdep -r src/third_party/chromite@908f8fb5026a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ifb6398b0ccdbc291936a10949c55c649ad69d9d1 Reviewed-on: https://chromium-review.googlesource.com/c/1279088Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599370}
-
Tommy Nyquist authored
This CL updates the UI to show a badge icon in the app menu icon whenever the user is running Chrome on a currently unsupported Android version. This badge in the app menu is only displayed once, until the user taps the app menu icon. If the user does in fact get a new version, the badge state is reset, and will be shown again. The current behavior for out of date users stays the same as before (once per cold start). In addition, a new menu item is displayed at the top of the menu that explains that Chrome is unable to update. Nothing happens when you tap the menu item in the case of an unsupported OS version. The new menu item and the new warning message in About Chrome will always be displayed when the user is in this state, regardless of whether the app menu has already been tapped (which removes the badge). This CL also updates the UI in Settings - About Chrome to show a new message and a warning icon when the user is running Chrome on an unsupported version of the Android OS. By default, Jelly Bean is considered unsupported after this CL, but this can be overridden from the variations framework. It is possible to use command line flags or chrome://flags for testing the different states, though that does not impact the About Chrome screen. Binary-Size: This CL adds new assets and the minimal code required. Bug: 847940 Change-Id: If128e1692b66c5804928183718000aaf1e2ffaa6 Reviewed-on: https://chromium-review.googlesource.com/c/1243167 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4bc3c99c2672..5f31aded4251 Created with: gclient setdep -r src-internal@5f31aded4251 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ifa96df39ee76b855b8b35e23d3874070d86b61b2 Reviewed-on: https://chromium-review.googlesource.com/c/1279073Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599368}
-
Ehsan Chiniforooshan authored
Bug: 894622 Change-Id: I26e56c110a35ec21ba34ddc3064a2832184c9c96 Reviewed-on: https://chromium-review.googlesource.com/c/1277690Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#599367}
-
Sorin Jianu authored
This is a mechanical change. It introduces ProtocolParser and ProtocolSerializer abstract classes to allow different protocols in the future. Only the XML implementation of these classes is provided in this changelist. Bug: 848505 Change-Id: I4bda0f92f5b676f0f0eaca7dc841c8dca9c282ad Reviewed-on: https://chromium-review.googlesource.com/c/1278476 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#599366}
-
Andrii Shyshkalov authored
No change in behavior, just making it explicit how CQ is treating this builder. R=ehmaldonado, jbudorick Bug: 893955 Change-Id: I367748688d5eefa69e582c04089191ea9710a842 Reviewed-on: https://chromium-review.googlesource.com/c/1279168Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#599365}
-
John Budorick authored
Bug: 828031 Change-Id: I1d4bdb235ad9d93df0653215c7c5928c471b6c16 Reviewed-on: https://chromium-review.googlesource.com/c/1277693Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#599364}
-
Peter K. Lee authored
This has not been used for a long time and App Store regulations no longer approves of the use of this type of app rating requests. Bug: 863559 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3aa5eb6a190d0577ff202b527c58566702a9ff18 Reviewed-on: https://chromium-review.googlesource.com/c/1278532Reviewed-by:
-
Lily Chen authored
Previously, the HTTP Auth Cache was implemented as a list of auth entries, which was searched linearly for a matching entry upon lookup. This change converts the cache to a multimap keyed on the origin, which is expected to provide faster lookups in cases where there are no matching entries for a given origin (which is the majority of cases). This will also allow for a higher cache size limit without a linear increase in lookup time, hence the cache size limit is raised from 10 to 20. This is expected to lower the rate of evictions upon adding entries. Obsolete histograms which no longer apply to the new implementation are also removed. Bug: 757116, 614108 Change-Id: Iabd2104b2d1c38d474450978a712039819b038e6 Reviewed-on: https://chromium-review.googlesource.com/c/1273820 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#599362}
-
Lindsay Pasricha authored
ios12-beta-simulator.json ios12-sdk-device.json ios12-sdk-simulator.json CIPD packages: infra_internal/ios/xcode/mac 10o35n infra_internal/ios/xcode/ios 10o35n Bug: 894202 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3ef7bd7221911e0759c754f67d5764e66442ca7d Reviewed-on: https://chromium-review.googlesource.com/c/1273822 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
-
Sahel Sharify authored
This is a reland of a12ef847 The reland has the following two fixes: 1- In the added tests, we wait for the ack of the GSB from the parent view to make sure that GFS is processed after GSB has been bubbled to avoid the flakiness. 2- Early return in BubbleScrollEvent to avoid crbug.com/828422 Original change's description: > Fling bubbles from OOPIF properly. > > While we are bubbling a scroll sequence GFS is sent to the fling controllers > of both the oopif and the bubbling target. The fling controller of the oopif > calls progressFling and generates a GSU with inertial phase, the GSU gets acked > immediately before getting sent to the renderer since we are in bubbling mode. > Then the oopif's fling controller receives the unconsumed GSU ack and generates > a GSE to complete the scrolling sequence on the oopif. The bubbling target's > fling controller receives and processes the GFS and generates GSUs which are > sent to the target's renderer. > > If the GSE generated by the oopif's fling controller gets bubbled before > the GFS, the bubbling target gets reset and the target does not receive the > GFS. This cl fixes the issue by making sure that the events generated by the > oopif's fling controller are not bubbled to the target. Also in case of > GFS bubbling, the GFC should also get sent to the bubbling target to make > sure that the fling controller in charge of flinging receives the GFC. > > > Bug: 884728, 249063 > Test: BrowserSideFlingBrowserTest.[Touchpad|Touchscreen]FlingBubblesFromOOPIF > Change-Id: I064944f125bebcb746f329af4cfb117f3be94ff0 > Reviewed-on: https://chromium-review.googlesource.com/c/1274193 > Reviewed-by: Kevin McNee <mcnee@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Commit-Queue: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599001} Bug: 884728, 249063 Change-Id: I1528d904e84ff85f7828392c2b0178a42869d529 Reviewed-on: https://chromium-review.googlesource.com/c/1278963Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599360}
-
James Darpinian authored
GpuCrash_GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash TBR: kbr@chromium.org Bug: 878258 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5ffe0fc31010f48838288a09b434235aedccb49b Reviewed-on: https://chromium-review.googlesource.com/c/1278812Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c97e3f6684c7..79b914075cc5 git log c97e3f6684c7..79b914075cc5 --date=short --no-merges --format='%ad %ae %s' 2018-10-12 geofflang@chromium.org Add an extension for querying esimated GPU memory size of resources. Created with: gclient setdep -r src/third_party/angle@79b914075cc5 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:892288 TBR=fjhenigman@chromium.org Change-Id: Ie496f14e30e485e0989a6c16cd6be3563606d8c7 Reviewed-on: https://chromium-review.googlesource.com/c/1279093Reviewed-by:
-
John Z Wu authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I177e442e2ff39995e10d494b1a99894a5724609e Reviewed-on: https://chromium-review.googlesource.com/c/1278544Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#599357}
-
Daniel Cheng authored
Bug: 879643 Change-Id: I5f61315dc5172d329f9dc94f851d34800ee5f76f Reviewed-on: https://chromium-review.googlesource.com/c/1278062Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#599356}
-
Mikel Astiz authored
The experimental feature is dead code that is recently being cleaned up. Effectively, this patch reverts commit 0b0d3249 and follows up with further cleanup given that it's the last user of disabling dynamic registration for sessions invalidations. Bug: 649880 Change-Id: I8a10c15a71353fd1c9c4bf670719f4a03e7f7a51 Reviewed-on: https://chromium-review.googlesource.com/c/1275847Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#599355}
-
Ned Nguyen authored
I suspect https://chromium-review.googlesource.com/c/1264642 adding load:news:cnn:2018 has made we run out of test timing budget on CQ (16 minutes per shard), and causing failure of telemetry_perf_unittest Since 'load:news:cnn:2018' is to replace 'load:news:cnn', remove smoke testing 'load:news:cnn' to reduce test load TBR=ulan@chromium.org NOTRY=true # CQ flake Bug: 893615 Change-Id: I8488aecf97cb25ff8ec9832c79bce7b10bc93c8d Reviewed-on: https://chromium-review.googlesource.com/c/1277692 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
-
jimmy authored
- Adds a message to provide users with a more detailed error message when SMB mounting to a file server that doesn't support SMBv2 or later. Bug: chromium:887127 Change-Id: I9e2ff3c278bb014c5538082ddcba42c8556ba8f2 Reviewed-on: https://chromium-review.googlesource.com/c/1274608Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#599353}
-
Karan Bhatia authored
This CL make the following changes: - Fixes a potential null-dereference crash when multiple rules couldn't be parsed. - Instead of showing only a single install warning for multiple unparsed rules, show individual warnings. Limit the count to 5 warnings. - The rule count exceeded warning doesn't override the rule unparsed warning now. BUG=894275 Change-Id: Iac8db1cf927a9302ec9295501f84616efafeca4e Reviewed-on: https://chromium-review.googlesource.com/c/1274838 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Scott Violet authored
If root_ was destroyed while MenuPreTargetHandlerAura exists, then MenuPreTargetHandlerAura would set root_ to null. This would result in the pre-target-handler being removed from the wrong env. I don't think this is the result of the bug referenced, but I came across this in looking for bad pre-target handlers. BUG=867035 TEST=none Change-Id: Ic549cf306441e31dcd750665992e41f06416f295 Reviewed-on: https://chromium-review.googlesource.com/c/1279147Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#599351}
-
