GitLab

This follows the pattern of NotificationPermissionClient.

This is part of a series of changes in both Blink and Chromium.

BUG=389194

TEST=PushMessagingBrowserTest*
TEST=LayoutTests/push_messaging/*

Review URL: https://codereview.chromium.org/707833002

git-svn-id: svn://svn.chromium.org/blink/trunk@184923 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=mstensho@opera.com
BUG=386567

Review URL: https://codereview.chromium.org/690133003

git-svn-id: svn://svn.chromium.org/blink/trunk@184921 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In preparation to supporting several occurences of the same node in the DOM tree (e.g. as a distributed nodes)
we want to stop relying on representedObject field that is used as a unique key in treeoutline.js

R=pfeldman

Review URL: https://codereview.chromium.org/702683003

git-svn-id: svn://svn.chromium.org/blink/trunk@184920 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch dependency:
[1] Blink: https://crrev.com/702003004/
[2] Chromium: https://crrev.com/690833004/
[3] Blink: https://crrev.com/708543002/ (THIS PATCH)

BUG=430527

Review URL: https://codereview.chromium.org/708543002

git-svn-id: svn://svn.chromium.org/blink/trunk@184919 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=apavlov

Review URL: https://codereview.chromium.org/704243002

git-svn-id: svn://svn.chromium.org/blink/trunk@184918 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When environment changes triggered an image load, the error event was
wrongfully triggered. This is the wrong behavior for Web compat and
it made related tests flaky.
This CL fixes that.

BUG=410268,411672

Review URL: https://codereview.chromium.org/654253003

git-svn-id: svn://svn.chromium.org/blink/trunk@184917 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Removed explicit 'width' and shortened text lines to make the test
"compatible" with vertical-lr/rl.

R=mstensho@opera.com
BUG=386567

Review URL: https://codereview.chromium.org/698203003

git-svn-id: svn://svn.chromium.org/blink/trunk@184916 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=424001, 357958

Review URL: https://codereview.chromium.org/674513002

git-svn-id: svn://svn.chromium.org/blink/trunk@184915 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of DevTools: don't change current selection on Timeline flame chart when overview window changes (patchset #1 id:1 of https://codereview.chromium.org/695903002/)

Reason for revert:
There is a blocking issue of shift+drag being non discoverable that needs to be addressed first.

Original issue's description:
> DevTools: don't change current selection on Timeline flame chart when overview window changes
> 
> Shift+drag is more convenient for specifying the range of interest it's better to avoid also binding the selection to the current range in the overview pane.
> 
> Waterfall view will still populate its details view with the data for selected range in the overview pane.
> 
> BUG=426152
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184904

TBR=loislo@chromium.org,caseq@chromium.org,yurys@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=426152

Review URL: https://codereview.chromium.org/704233002

git-svn-id: svn://svn.chromium.org/blink/trunk@184914 bbb929c8-8fbe-4397-9dbb-9b2b20218538

FormData::alwaysStream() doen't seem to be used anywhere in Blink.

BUG=

Review URL: https://codereview.chromium.org/662383002

git-svn-id: svn://svn.chromium.org/blink/trunk@184912 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Cached data was turned on by r184826, and it seems we're producing invalid
cached data. Disabling the cached data for now; this needs to be debugged before
enabling it again.

In addition, it can be that we try to invoke streaming for already loaded async
scripts; handle that gracefully too.

BUG=

Review URL: https://codereview.chromium.org/705953002

git-svn-id: svn://svn.chromium.org/blink/trunk@184911 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added DOCTYPE and described pass conditions.

R=mstensho@opera.com
BUG=386567

Review URL: https://codereview.chromium.org/701803002

git-svn-id: svn://svn.chromium.org/blink/trunk@184910 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It was awfully slow because we updated selection and calculated aggregates for every added record.
So the complexity was at least n^2.
I moved the _updateSearchHighlight call to _onRecordingStopped

BUG=

Review URL: https://codereview.chromium.org/703113003

git-svn-id: svn://svn.chromium.org/blink/trunk@184909 bbb929c8-8fbe-4397-9dbb-9b2b20218538

How did we not have a test for this? Crazy.

BUG=429244

Review URL: https://codereview.chromium.org/701013004

git-svn-id: svn://svn.chromium.org/blink/trunk@184908 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes a search shortcut issue.

R=pfeldman, apavlov

Review URL: https://codereview.chromium.org/695323004

git-svn-id: svn://svn.chromium.org/blink/trunk@184907 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch dependency:
[1] Blink: https://crrev.com/702003004/ (THIS PATCH)
[2] Chromium: https://crrev.com/690833004/
[3] Blink: https://crrev.com/708543002/

BUG=430527

Review URL: https://codereview.chromium.org/702003004

git-svn-id: svn://svn.chromium.org/blink/trunk@184906 bbb929c8-8fbe-4397-9dbb-9b2b20218538

"notifySomething" style method naming is often used to notify its
client about completion. This is just for inspector and console logging.
It's surprising that we see a function looks like notifying completion
called inside access control failure path. Use reportSomething that
is often used to methods that report to inspector or writing some log.

R=mkwst
BUG=none

Review URL: https://codereview.chromium.org/700413002

git-svn-id: svn://svn.chromium.org/blink/trunk@184905 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Shift+drag is more convenient for specifying the range of interest it's better to avoid also binding the selection to the current range in the overview pane.

Waterfall view will still populate its details view with the data for selected range in the overview pane.

BUG=426152

Review URL: https://codereview.chromium.org/695903002

git-svn-id: svn://svn.chromium.org/blink/trunk@184904 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this series of patches, registration succeeds even if the worker script
has a syntax error because the installing sequence does not check the result of
the script evaluation.

This adds layout tests for a variety of error cases.

Patch dependency:
[1] Blink: https://codereview.chromium.org/692003002/
[2] Chromium: https://codereview.chromium.org/697593002/
[3] Blink: THIS PATCH

BUG=426344
TEST=run-webkit-tests --debug http/tests/serviceworker/

Review URL: https://codereview.chromium.org/697833004

git-svn-id: svn://svn.chromium.org/blink/trunk@184903 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to Bug 383941, this feature has been stable since mid July.

BUG=402536

Review URL: https://codereview.chromium.org/684913002

git-svn-id: svn://svn.chromium.org/blink/trunk@184902 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=429559

Review URL: https://codereview.chromium.org/671643005

git-svn-id: svn://svn.chromium.org/blink/trunk@184901 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It is possible that termination of worker thread is not triggered by the
time of WebEmbeddedWorkerImpl destruction. We should call
WorkerThread::stop() before waiting for the termination of worker thread.

BUG=426332

Review URL: https://codereview.chromium.org/704063002

git-svn-id: svn://svn.chromium.org/blink/trunk@184900 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/GotqYh_4mFA/KgO0qCCpXcMJ

BUG= 430788

Review URL: https://codereview.chromium.org/690033002

git-svn-id: svn://svn.chromium.org/blink/trunk@184898 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Mac10.6 (deps) is used for all mac ports.

R=dpranke
BUG=none

Review URL: https://codereview.chromium.org/690943002

git-svn-id: svn://svn.chromium.org/blink/trunk@184897 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/692233004

git-svn-id: svn://svn.chromium.org/blink/trunk@184896 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SVGShapePainter is the only class to paint markers so the marker painter
class is all overhead. This patch moves the marker painter code into
SVGShapePainter.

BUG=412088

Review URL: https://codereview.chromium.org/693313003

git-svn-id: svn://svn.chromium.org/blink/trunk@184895 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Remove userPreferredLanguagesOverride().  It's unused.
- Rename canonicalizedLanguageIdentifier() to canonicalizeLanguageIdentifier().
- Make sure that platformLanguage() and userPreferredLanguages() return language
  codes with '-'.
- Optimize platformLanguage().  It shouldn't create a Vector every time.

BUG=

Review URL: https://codereview.chromium.org/703043002

git-svn-id: svn://svn.chromium.org/blink/trunk@184894 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We can remove unnecessary assertions and runtime null checks by this change.

BUG=
TEST=none; No behavior changes.

Review URL: https://codereview.chromium.org/704963002

git-svn-id: svn://svn.chromium.org/blink/trunk@184893 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We are implementing the Streams API. To make back-pressure take effect, we
should allow the resource loading customer such as XHR or the Fetch API
to read the data manually.
This CL adds a WebDataConsumerHandle to didReceiveResponse parameters.
This CL does not change the behavior as of now.

The tricky part is how to deal with a handle. As WebDataConsumerHandle
cannot be shared by multiple clients, we can't add the handle in the
response. Moreover, we assert that handle must be null when more than
one client exists in RawResource.cpp.

BUG=418879

Review URL: https://codereview.chromium.org/603903003

git-svn-id: svn://svn.chromium.org/blink/trunk@184892 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If we are overflow:hidden and have fixed-pos children we would transition
to impl-side scrolling. This was exposing another bug (304810)
where on impl-side where we do not correctly stop body elements from 
scrolling. This lead us to scroll elements on the impl-thread even 
if they need to be main-thread scrolled.

Here we do not short-circuit the main-thread requirements if
the frame is overflow:hidden. This is equivalent to our old
implementation, and lets gmail continue to be on impl-thread,
which is what abarth had originally changed that caused this issue.

BUG=411767
R=vollick@chromium.org

Review URL: https://codereview.chromium.org/699183004

git-svn-id: svn://svn.chromium.org/blink/trunk@184891 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All this does is associate the Range of the result with the start and end
accessibility object anf offset.

BUG=426414

Review URL: https://codereview.chromium.org/696533003

git-svn-id: svn://svn.chromium.org/blink/trunk@184890 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* nextNodeWithGreaterTabIndex:
  Set |currentTabIndex| to |winningTabIndex|
  They are same in the |if| block.  However |currentTabIndex| looks better.

* previousNodeWithLowerTabIndex:
  Remove isNonKeyboardFocusableShadowHost() check.  It's redandunt because
  shouldVisit() contains it.

BUG=
TEST=none; no behavior changes

Review URL: https://codereview.chromium.org/700313002

git-svn-id: svn://svn.chromium.org/blink/trunk@184889 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As getPropertyCSSValue is no longer web-exposed we should stop testing
it so we can delete the interface.

BUG=428595

Review URL: https://codereview.chromium.org/703793002

git-svn-id: svn://svn.chromium.org/blink/trunk@184888 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is in preparation for column-span:all support.

This CL puts basic set renderer insertion needed by column-span:all into
place. Full support for set management (cope with dynamic changes after
inital layout, etc.) and actual support for layout will be introduced in
follow-up CLs. Likewise for layout tests.

Each column-span:all renderer needs a corresponding
RenderMultiColumnSpannerSet. This means that if there's column content
preceding and following the spanner, we need a RenderMultiColumnSet both
before and after it (while, without spanners, there'd never be any need
for more than one column set).

Some extra attention is required when inserting flow thread
descendants now, because we need to figure out if the renderer
inserted should trigger creation of a new column set or a spanner set.

Wrote some unit tests. Layout tests not possible at this time, since this
CL has no (intentional) web-facing changes.

BUG=347325

Review URL: https://codereview.chromium.org/688703003

git-svn-id: svn://svn.chromium.org/blink/trunk@184887 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rather than explicitly catching exceptions and generating promise
rejections, let the bindings code do the work.

R=jkarlin
BUG=392621

Review URL: https://codereview.chromium.org/694083002

git-svn-id: svn://svn.chromium.org/blink/trunk@184886 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add missing cases checking that first-line pseudo-element from ancestors
is ignored inside the grid.

TEST=fast/css-grid-layout/grid-container-ignore-first-line.html

BUG=395788

Review URL: https://codereview.chromium.org/702663002

git-svn-id: svn://svn.chromium.org/blink/trunk@184885 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SkCreateTypefaceFromCTFont implies fonts are non-local
(i.e. serialized as font name only, not the glyphs). This
does not work with the dynamically loaded fonts, so just
keep the SkTypeface we used to create in FontCustomPlatformDataMac
rather than create one from CTFont.

BUG=426088

Review URL: https://codereview.chromium.org/691733004

git-svn-id: svn://svn.chromium.org/blink/trunk@184884 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This assert is causing PPAPI tests to flakily fail on the Linux Chromium
ChromeOS trybot.

BUG=430344
TBR=zeeshanq@chromium.org

Review URL: https://codereview.chromium.org/704673005

git-svn-id: svn://svn.chromium.org/blink/trunk@184883 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We'd like to investigation how many pages will be affected by the feature [1].
This CL also adds counters for <input type=submit>, which is a typical
affected element.

[1] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QpEoCwU0Ttg

BUG=141169

Review URL: https://codereview.chromium.org/706503002

git-svn-id: svn://svn.chromium.org/blink/trunk@184882 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test depends on the exact output of zlib, which may vary depending
on which CPU optimizations it's able to use.

BUG=430557
TBR=vsevik@chromium.org

Review URL: https://codereview.chromium.org/702183002

git-svn-id: svn://svn.chromium.org/blink/trunk@184881 bbb929c8-8fbe-4397-9dbb-9b2b20218538