- 10 Sep, 2019 40 commits
-
-
Mohamed Amir Yosef authored
This is a pure refactoring CL to rename PasswordManagerClient.GetPasswordStore() to PasswordManagerClient.GetProfilePasswordStore() Follow up patches will introduce PasswordManagerClient.GetAccountPasswordStore() TBR=vasilii@chromium.org Change-Id: Ic9e4d44bce0aa019a9ee46eb1ea0f2d868d2a307 Bug: 1002000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795004Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#695174}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f7b1aa440dc0..45b01c7962da git log f7b1aa440dc0..45b01c7962da --date=short --no-merges --format='%ad %ae %s' 2019-09-10 nisse@webrtc.org Delete some dead code in vcm::VideoReceiver and VCMReceiver 2019-09-10 nisse@webrtc.org Move code related to VideoCodingModule to its own build target 2019-09-10 danilchap@webrtc.org Mark test::DriftingClock constants as constexpr 2019-09-10 titovartem@webrtc.org Add ability to disable PSNR and SSIM computation in DVQA Created with: gclient setdep -r src/third_party/webrtc@45b01c7962da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: Iee16eb483973717531465458ae4a9f399d31108a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795883Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695173}
-
Adam Langley authored
This is a prelude to adding v2 elements in a subsequent change. Bug: 1002262 Change-Id: I4313a83d3dd9670ed0a92cd67794e47f0974bf88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785660Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#695172}
-
Jérôme Lebel authored
Adding comment to explain when the SigninInteractionCoordinator needs to be dismissed -[MainController closeSettingsAnimated:completion:]. Related to: crrev.com/c/1788026/4/ios/chrome/app/main_controller.mm#2275 Change-Id: Ie7685cadf00f9d7893ce55fb346667f014272d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795904Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#695171}
-
Ryan Sturm authored
This code was added to remove the page load capping DB from M74-M78, if any clients (that were exposed to the experiment) skipped from M73 to M79+ they will not delete the DB and it will just hang around, but this should be rare as only 1% of certain countries had page capping enabled in Stable. Bug: 937489 Change-Id: Id67670b2d32fbee45a3b0b0097aacfb6784ae42f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793542Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#695170}
-
Anqing Zhao authored
- Timestamp of last reboot. - Timestamp of last update check. - Add a new policy 'ReportDeviceOsUpdateStatus': Report OS update information such as update status, platform version, update check and last reboot. Bug: 983180 Change-Id: Ib296a64863e819e40329305cf85440e8c0037a66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787648Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#695169}
-
Primiano Tucci authored
https://android.googlesource.com/platform/external/perfetto.git/+log/23d211c8..c85e95e7f Catch up with https://android-review.googlesource.com/c/platform/external/perfetto/+/1116517 that removed a method and changed a header location. This is a pure refactoring with no behavioral change. git log 23d211c8..c85e95e7f --date=short --no-merges --format='%ad %ae %s' 2019-09-10 primiano@google.com Fix chrome roll: add PERFETTO_EXPORT to SlicedProtobufInputStream 2019-09-09 primiano@google.com PERFETTO_EXPORT PacketStreamValidator 2019-09-09 primiano@google.com Disable watchdog on OSX using compile-time checks 2019-09-09 primiano@google.com Remove TracePacket::Decode and protobuf dependencies Change-Id: Iac741162bb179d4497407346dd4d9abdbddfc9e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792865 Commit-Queue: Primiano Tucci <primiano@chromium.org> Auto-Submit: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#695168}
-
Miyoung Shin authored
This CL converts BluetoothSystemClient{Ptr, Request} in ash and services to the new Mojo type. Bug: 955171 Change-Id: Ie2628589f4bed2828405ee9f445b8bad680d7505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787667 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#695167}
-
Adithya Srinivasan authored
Reverted the wrong test in https://crrev.com/c/1795627. Undo that revert, and revert the correct test. Bug: 1002488 Change-Id: Id1674227e0db390b5f7bf75755a5bec3cae97042 Tbr: tbarzic@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796044Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#695166}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/image_fetcher. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=skym@chromium.org Bug: 891670 Change-Id: I8736433bb72b9f06daa837f867063d5e0a52b938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787212 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#695165}
-
Robbie Gibson authored
The changes are replacing darker, primary text with kTextPrimaryColor and lighter, secondary text with kTextSecondaryColor. Bug: 1002409 Change-Id: I2a1cfa0eb5907cc1c40b722c2ddbd9285187a56a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794865 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#695164}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3255f493db0d..79ad0411911b git log 3255f493db0d..79ad0411911b --date=short --no-merges --format='%ad %ae %s' 2019-09-10 tobine@google.com Vulkan:Pass through min/max program texel offset Created with: gclient setdep -r src/third_party/angle@79ad0411911b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: None Change-Id: I9951758efd804dc271129cc54e794d66784b0857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795281Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695163}
-
Robert Ma authored
TBR=lpz No-Try: True Bug: 1002514 Change-Id: Ia082b22d887ad6561cfa90e95be2c963547d467a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795483Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#695162}
-
Vladimir Levin authored
This patch ensures that we update layout if the value of content-size changes. R=chrishtr@chromium.org, futhark@chromium.org Bug: 1002231 Change-Id: I68e64b162d936cc45da45d6c0e70c5a5a9de6af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790417 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#695161}
-
Clemens Arbesser authored
This CL will ensure that by default, the most complete contact profile with the same email address as the one provided for the access token is selected. Bug: b/140781117 Change-Id: I6a54ddac7190b6aed2f15b848a1a1ca81c684009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795325 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#695160}
-
Tom Anderson authored
BUG=992948 R=steimel,thestig,hashimoto Change-Id: I39cb1737c914ecb37065f544538113f9b2db7efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778584Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#695159}
-
Antonio Gomes authored
This is phase 4 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I171f2732e318eda664a292132cc8597ed5c42207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792859 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#695158}
-
Mason Freed authored
While the usage of these three features (particularly kHTMLImportsOnReverseOriginTrials) is over the 1% guideline, they are (hopefully) trending toward zero. These three UKMs will allow us to track site usage of these three features more easily, to drive down usage. Bug: 946875 Change-Id: I9b93714c7030a6f00c909b2eaa1db44a53471a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791627 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#695157}
-
Nicolas Ouellet-Payeur authored
It provides an entry-point for anyone who's browsing the source code for LBS, so they can understand what's going on. Change-Id: I209bd799f0079be42208f4231a8d042de760ad36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790546 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#695156}
-
Marc Treib authored
This mostly adds some comments, and inlines a helper function which is critical for understanding the test. It also deletes UserEventCaseChecker (in the same file) which was unused. Bug: none Change-Id: I70b206240d9aa83c486d03115e6ec3aaf4b2be1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795446Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#695155}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/events/gesture_detection. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=nzolghadr@chromium.org Bug: 891670 Change-Id: I3f1e76a565e3cbecb3b5f34e8cb96620fa68df27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787075 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#695154}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/cronet. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=bnc@chromium.org Bug: 891670 Change-Id: I9ffa42cb4538aa0a6758db60606f27fae7f1e08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787065 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#695153}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/events/gestures. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=nzolghadr@chromium.org Bug: 891670 Change-Id: I92843b289dfb872d21b738caf86b7abf07c34db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787204 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#695152}
-
Dave Tapuska authored
Its possible that the frame doesn't have a document loader anymore. Check document loader like other paths do in the History object. BUG=1000206 Change-Id: Idc1eda15c194e26ff818855fc1ac5e595ae693a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791421Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#695151}
-
Adithya Srinivasan authored
Test is flaky, see bug for details. Bug: 1002488 Change-Id: If40538c7e975cde57a86296b2b3e02d0eb7822dd Tbr: xiyuan@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795627Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#695150}
-
Anton Bikineev authored
The test was accidentally added in 39a5bc67. Change-Id: I83df463f76ef21deae85a2dac1e499d0ba62b942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795903Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#695149}
-
Antonio Gomes authored
This is phase 3.8 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ CL moves ipc_network_manager.cc|h|test from content/renderer/p2p to Blink. It places the header temporarily in Blink's exposed API. Last, note that <string> and <vector> STD headers are kept because they are used to interface with third_party/webrtc APIs. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I0743a2b3449c462840646c609c62073bf33dc287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792858 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#695148}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/signin. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=msarda@chromium.org Bug: 891670 Change-Id: I351fe1451797bbecf2b02f2fc8666368c8d9fc73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786801 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#695147}
-
Benoît Lizé authored
It wasn't present in the ARM64 builds, update the build files to fix this. Tested with 'target_cpu = "arm64"'. Bug: 1002141, 979638 Change-Id: I835efc915ce07482aadc83821b74782f921a6115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795443Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#695146}
-
Gabriel Charette authored
Backport some tests in /components/browsing_data/core/history_notice_utils_unittest.cc to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/browsing_data/core/history_notice_utils_unittest.cc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=msarda@chromium.org Bug: 891670 Change-Id: If2a91398d6cb6ef74600738119ed3201df26ea2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786840 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#695145}
-
Colin Blundell authored
IdentityManager has an iOS-specific ForceTriggerOnCookieChange() method. This method makes more sense on AccountsCookieMutator, together with other similar methods (e.g., TriggerCookieJarUpdate()). This change came about while auditing the interface of identity_manager.h. Bug: 930582, 964235 Change-Id: I3a0d023e3f84831a26250177f657e7c2646b8e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791147Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#695144}
-
Dave Tapuska authored
Now that back/forward buttons processing is moved to the browser we can remove the need for the extra IPC variable. All calls now are solely from javascript. BUG=705583 Change-Id: Iec303699cda252501c147c6fb9a310f259de6be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788230Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#695143}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/sync. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=melandory@chromium.org Bug: 891670 Change-Id: I49d147d6d77c9f89f412d922de6f1a805c315419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786846 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#695142}
-
Matt Falkenhagen authored
The thread ServiceWorkerContextCore lives on (the "core thread") will move from the IO thread to the UI thread when ServiceWorkerOnUI is enabled. This makes BrowsingDataServiceWorkerHelper aware of the core thread rather than assuming the IO thread. This enables unit_test "CannedBrowsingDataServiceWorkerHelperTest.*" to pass. Bug: 824858 Change-Id: I6c7e7db1bb0c5f7b9691fef51947304280ad3143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795528Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#695141}
-
Adithya Srinivasan authored
Bug: 1002489 Change-Id: Ie9891d5924601429b4a966ea229a6b7c280a0ef4 Tbr: beaufort.francois@gmail.com No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795845Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#695140}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /services/audio. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=miu@chromium.org Bug: 891670 Change-Id: Ie208338463113dfc3e0542765156760b0aaaf6ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786855 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#695139}
-
Peter Kasting authored
Bug: 1000055 Change-Id: I83e8f73db520df8bb8e1d0b462afe70fd529df2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792956 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#695138}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/01e97ae1b071..f7b1aa440dc0 git log 01e97ae1b071..f7b1aa440dc0 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 mbonadei@webrtc.org Fixing some typos. Created with: gclient setdep -r src/third_party/webrtc@f7b1aa440dc0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I0fdf8951ee03d4c00e2aa33673c178e28e39a06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795624Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695137}
-
Gabriel Charette authored
Backport some tests in /device/gamepad/public/cpp/gamepad_mojom_traits_unittest.cc to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /device/gamepad/public/cpp/gamepad_mojom_traits_unittest.cc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=estark@chromium.org Bug: 891670 Change-Id: Ic5c828e2748caa0f834ac8a6dab5693e1394cb4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787202 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#695136}
-
Thomas Tangl authored
For each selectable profile a button is added to the profile menu. Screenshot: https://drive.google.com/file/d/1ovOWviTlbfqK2PVpMAJhUQehtmD7_J-R/view?usp=sharing Flag: profile-menu-revamp Bug: 995720 Change-Id: I7bbe82651523f092864f50ac36f099ece6405768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795444Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#695135}
-