GitLab

BUG=837684
TEST=covered by tests

Change-Id: I209d2722d8cf5acc09ff51112f69253b9ca0a79c
Reviewed-on: https://chromium-review.googlesource.com/1164417
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581125}

Bug: 868592
Change-Id: Ia1d17f0b1d07d27a1665d6871545f051ee2eed87
Reviewed-on: https://chromium-review.googlesource.com/1164148Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581124}

See crbug.com/869308 for details.

Bug: 869308
Change-Id: Ie83796a1e281dcdc25267637ddfe2d7b1d658da3
Reviewed-on: https://chromium-review.googlesource.com/1164152Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581123}

Currently one can activate the tab switch button with shift-space etc.
This CL restricts it to only space, no modifiers.

Bug: 780835
Change-Id: I49b50d9d693e6201d7c3e74c91929bf71280865f
Reviewed-on: https://chromium-review.googlesource.com/1163991Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581122}

No flag flips this week

Delete QuartcBbrOptions in favor of setting BBR options within QuartcFactory.

Adding options to QuartcBbrOptions is extra boilerplate that doesn't really
serve any good purpose.  For now, we can put all the options in
quartc_factory.cc where they'll be reviewed by the QUIC team.  If this proves
burdensome, we can later move some of the configuration out of
//third_party/quic/quartc by passing a QuicTagVector into QuartcFactory.

Merge internal change: 207318618
https://chromium-review.googlesource.com/c/chromium/src/+/1164000


Use GetCertChain instead of the more expensive GetProof in QuicCryptoServerConfig::EvaluateClientHello. Protected by FLAGS_quic_reloadable_flag_quic_use_get_cert_chain

Merge internal change: 207314454
https://chromium-review.googlesource.com/c/chromium/src/+/1163999


Eliminate a dead code path in QuicCryptoServerConfig::EvaluateClientHello.

There is only one caller of this method, and that caller always clears the proof before calling EvaluateClientHello. So there is no need to handle the case where a valid proof is pass into QuicCryptoServerConfig::EvaluateClientHello.

Merge internal change: 207294767
https://chromium-review.googlesource.com/c/chromium/src/+/1163984


Enable BBR5, BBR8, and BBQ1, 2, and 4.

 - BBR5 sets a longer window length for ack aggregation.
 - BBR8 skips PROBE_RTT if the connection has been app-limited recently.
 - BBQ1 uses a slightly slower STARTUP gain.
 - BBQ2 uses a lower CWND gain during STARTUP.
 - BBQ4 uses gain of 0.75 during DRAIN.

Quality test results look comparable to the config at head:
http://sponge/8034f562-6964-470c-bade-fb1cff737b66

These options should provide a better baseline for Quartc.  They should improve
performance for Quartc's use case through fewer PROBE_RTTs and smoother
STARTUP.

Merge internal change: 207280788
https://chromium-review.googlesource.com/c/chromium/src/+/1163921


Add two new tests in QuicConnectionTest to verify that - when crypot packet is sent, retransmission alarm is set with correct retransmission timeout; - when crypto packet is sent, path degrading alarm is set with correct path degrading timeout.

Merge internal change: 207193472
https://chromium-review.googlesource.com/c/chromium/src/+/1163920


Remove unused 'found_error' argument to QuicCryptoServerConfig::EvaluateClientHelloAfterGetProof (and change callers to not pass it in).

Merge internal change: 207164287
https://chromium-review.googlesource.com/c/chromium/src/+/1163918


Rename IsProbingForMoreBandwidth to ShouldSendProbingPacket in QUIC's SendAlgorithmInterface.

Merge internal change: 207139582
https://chromium-review.googlesource.com/c/chromium/src/+/1163917


Implement a bit to disable retransmission on QuartcStream.

For now, a simple bit to disable retransmission is enough for Quartc.  We only
want to use this for the first iteration of integrating Quartc into the WebRTC
audio path, where retransmissions are not currently used.  We believe this will
be good enough to match WebRTC's current state.

In the future, we may want to upgrade this to something more sophisticated:  a
TTL/deadline or even a callback to evaluate whether a stream should be
retransmitted at the moment it happens.  We will revisit this bit when more
sophisticated controls become necessary.

Merge internal change: 207009357
https://chromium-review.googlesource.com/c/chromium/src/+/1163916


Only skip updating min_rtt_ in BBR if the existing sample has expired

Only skip updating min_rtt_ in BBR if the existing sample has expired, not if the new sample is smaller or 0.  Protected by existing flag FLAGS_quic_reloadable_flag_quic_bbr_less_probe_rtt AND activation by connection options(ie: BBR7) which are only used by Quartc.

Merge internal change: 206990230
https://chromium-review.googlesource.com/c/chromium/src/+/1163915


Split KeyExchange into separate crypto and factory pieces

Currently, KeyExchange encapsulates two separate operations: first, the ability to compute a shared key, and second, the ability to create new KeyExchange objects.  The fact that a KeyExchange object may be passed around solely for the purpose of creating new objects of the sa
me subtype is confusing, and makes it harder to audit the code for uses of the encapsulated private key.

This CL improves things by separating object-creation duties into a separate Factory object, which a given KeyExchange type implements as a singleton.

Code-motion refactoring in QUIC KeyExchange types.  No functional change intended, not flag-protected.

Merge internal change: 206816903
https://chromium-review.googlesource.com/c/chromium/src/+/1163914


StrCat() can now be used with a single argument, so there is no longer any reason to pass a useless empty string.

Merge internal change: 206783905
https://chromium-review.googlesource.com/c/chromium/src/+/1163905


Use unique_ptr to manage lifetimes of KeyExchange objects

Use unique_ptr for memory management rather than bare pointer.  No functional change intended, not flag-protected.

Merge internal change: 206649898
https://chromium-review.googlesource.com/c/chromium/src/+/1163904


Change-Id: If661a73b9f673682a31abb93d9982bacf92f27a4
Reviewed-on: https://chromium-review.googlesource.com/1164001
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581121}

DiskMountManager::Disk is big enough and used in enough places that it
should be standalone.

BUG=None
TBR=tommycli@chromium.org,yusukes@chromium.org


Change-Id: I11edf072fb3f32b55ed7c39887189b40d85e755c
Reviewed-on: https://chromium-review.googlesource.com/1157950
Commit-Queue: Anand Mistry <amistry@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581120}

Bug: b/32781610
Change-Id: I1a244e1ed247913a3829e6efaf15b65a3c03f2cd
Reviewed-on: https://chromium-review.googlesource.com/1161571
Commit-Queue: Jorge Gil <jorgegil@google.com>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: David Jacobo <djacobo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581119}

This CL is a follow-up of
https://chromium-review.googlesource.com/c/chromium/src/+/1155999, after
that we can just transfer the blob body within FetchAPIResponse.blob, so
we no longer need this OnResponseBlob method to transfer the blob body
separately, just OnResponse is enough.

BUG=789854

Change-Id: Id54f5d6ded3576bedc2e7dcf544ed41ac7715069
Reviewed-on: https://chromium-review.googlesource.com/1163288Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#581118}

Crashes with content::GpuProcessHost::OnProcessCrashed on the stack
have become prevalent in Chrome 69.

CATransactionGPUCoordinator was introduced in the first Canary to
exhibit these crashes (https://crrev.com/565687 in 69.0.3455.0).

Disable CATransactionGPUCoordinator to test the theory that it is
responsible for the crashes. This will make window resize slightly
jankier (like -- the window's contents will detach from the window
during resize) while disabled. Note that not all window resize logic
is disabled by this -- just the GPU side (so resize will be reasonable
most of the time, but there will be occaisonal glitches now).

Bug: 871430
Change-Id: Ifec51e511712b9843f15e9b8c43b66d852232b89
Reviewed-on: https://chromium-review.googlesource.com/1164555Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581117}

TBR=dpranke

Bug: 869973
Change-Id: I768bbb4ae73c52d5fbd9d91960add069eefa5fac
Reviewed-on: https://chromium-review.googlesource.com/1164642Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581116}

This patch removes the network-{0,2}-quiet detection logic from
FirstMeaningfulPaintDetector. After this patch, these signals are
notified from IdlenessDetector.

IdlenessDetector excludes task processing time from the network-quiet
time window, so this would fix the issue that FirstMeaningfulPaint is
reported too soon on CPU-heavy pages.

This patch also renames "fmp-network-quiet-timeout" command-line switch
to "network-quiet-timeout". It now controls the network-quiet window of
IdlenessDetector.

Bug: 659021,850403
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I008762a128f2d6243ed50af316a97350bccbea5a
Reviewed-on: https://chromium-review.googlesource.com/1159934Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581115}

Remove Team Drive root from the directory tree when user has no team
drive. Fixes a bug where users could navigate to Team Drive root via
the keyboard even though the root was hidden.

Bug: 864890
Change-Id: I2f6b59ca908ae609302cb873b6b182842cedc1c4
Reviewed-on: https://chromium-review.googlesource.com/1163352
Commit-Queue: Noel Gordon <noel@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581114}

Here's my comment as to why this is ignored:

  // The client is asking to remove focus from a window. This is typically a
  // side effect of the window becoming, or about to become, an unfocusable
  // Window (for example, the Window is hiding). Windows becoming unfocusable is
  // handled locally. Assume the request is for such a scenario and return
  // false to ignore the change.
  //
  // To process null requests conflicts with top-level activation changes. For
  // example, the typical sequence when a window is hidden is to first remove
  // focus, and then hide the window. FocusController keys off window hiding to
  // move activation. If this code where to set focus to null, FocusController
  // would not see the window hiding (because the active window was set to null)
  // and not automatically activate the next window.
  //
  // Another possibility for this code is to handle null as a signal to move
  // focus to the active window (if there is one). I'm going with the simpler
  // approach for now.

BUG=867654
TEST=covered by tests

Change-Id: Iee8efd8895284acca4603ff22bde19adf16d8a7f
Reviewed-on: https://chromium-review.googlesource.com/1164409Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581113}

BUG=none
TEST=covered by test

Change-Id: I1402a8f68f1db6870cf317dc0a7e3ae565927949
Reviewed-on: https://chromium-review.googlesource.com/1164530Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581112}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: I6cdc3d01c4082cca740b9e00e36664cd89146ff3
Reviewed-on: https://chromium-review.googlesource.com/1164643Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581111}

As per the UX, when there is only one image for a date, the image
should span across the full screen width. Using adjustViewBounds property
of ImageView to readjust the height of the image when in full width mode.

Bug: 868567
Change-Id: Ia6ddf860e3168fda49f5bbf6a1043004e91bd663
Reviewed-on: https://chromium-review.googlesource.com/1162625
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581110}

This reverts commit 86ff51d4.

Reason for revert: crbug.com/871587

Original change's description:
> Add ChildMediaLog.
> 
> Users of MediaLog have to be careful about the lifetime of the
> object, since it's passed around as a raw ptr.  For things like
> VdaVideoDecoder, which operate on multiple threads, it requires
> special care that the log isn't used after VdaVideoDecoder is
> no longer allowed to use it.
> 
> ChildMediaLog wraps a MediaLog, and provides an atomic way to
> prevent access to the underlying MediaLog.  For example,
> VdaVideoDecoder can do this when it's Destroy()ed, which is when it
> must stop using the MediaLog that it was given.  Additional calls
> to ChildMediaLog will do nothing.
> 
> The ChildMediaLog itself can be kept around until the other thread
> is definitely done using it.
> 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: If350b2b78da96bf7ba844f582a96661fd0b15ef0
> Reviewed-on: https://chromium-review.googlesource.com/1139219
> Commit-Queue: Frank Liberato <liberato@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580952}

TBR=sandersd@chromium.org,liberato@chromium.org

Change-Id: Ic7457f610907c8e7d89fd26090b815d281b19664
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1164130Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581109}

As we're going to use DesktopStreamRegistry for both desktopCapture
and tabCapture registry, it's important to let getUserMedia() to be
called with corresponding source type, 'desktop' or 'tab', which will
lead to different UI indicator.
This cl is to add the source type at adding/verifying request to
the registry.

Bug: 831722
Change-Id: If53022ec35c3c3b7993e41149e381b96b3e48877
Reviewed-on: https://chromium-review.googlesource.com/1149192Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581108}

This CL adds the following changes:
1 - On prefetch tab, date headers and section headers are not shown.
2 - On chips other than type ALL, section headers are not shown.

Bug: 866307
Change-Id: I0f184f31a80fc1d4e5defab780f430590532f517
Reviewed-on: https://chromium-review.googlesource.com/1162517
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581107}

https://chromium-review.googlesource.com/c/chromium/src/+/1155999
already decoupled service_worker_fetch_response_callback.mojom from
//content/ things, this CL just moves it from
//content/common/service_worker/ into
//third_party/blink/public/mojom/service_worker/.

BUG=789854

Change-Id: Id09ee5beb1086c57853927e2ba37115a55d97464
Reviewed-on: https://chromium-review.googlesource.com/1162991
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581106}

This code was added in r446462 when we were always creating new RequestExtraData. After r456081 we only create one if it's not present, so this code is not needed anymore.

Change-Id: I799afd7ea03a6ef4d3c346aa85cc1d7c34b4d0ba
Reviewed-on: https://chromium-review.googlesource.com/1164400Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581105}

The transition didn't work correctly but no one was using
this transition except pinned mode. This is actually odd
transition, but this should work regardless.

I will look into why pinned mode does this separately.

Bug: b/112240082
Test: covered by unittests
Change-Id: I88db9dfb614895f19951fd822185460bf682948a
Reviewed-on: https://chromium-review.googlesource.com/1164570Reviewed-by: Daichi Hirono <hirono@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581104}

This removes the string parameters from the interfaces.
It also removes the json dictionaries that were representing
  the state.
v8 session continues to be encoded as JSON
  (see inspector_session.{h,cc}).

For reference, the cl that introduced the new way to manage
the agent state was this one (and advantage is that the updates
sent back to the browser process are deltas, not the entire
state):
https://chromium-review.googlesource.com/c/chromium/src/+/1149201
This change can get rid of the old way since all agents have
been migrated to the new way.

Bug: 851762
Change-Id: Ie245c1c073eb006d4db19d819c2882e6a36f5b2b
Reviewed-on: https://chromium-review.googlesource.com/1162931Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581103}

We should stop animations when the layer is no longer visible.

Bug: b:112259562
Change-Id: I108fe2f319913c7c4c11cccef5215a46066acf1c
Reviewed-on: https://chromium-review.googlesource.com/1164069
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581102}

Now that mouse cursor rendering on screen video captures has fully
switched-over to the new VIZ implementation, the old implementation is
dead code and can be deleted.

Bug: 810133
Change-Id: Ic6a480048019d480b90970ab78443cf68fe089c6
Reviewed-on: https://chromium-review.googlesource.com/1162865Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581101}

Change-Id: Ic29cfd608d962feae46400f4ab35c8f6f9e16e7e
Reviewed-on: https://chromium-review.googlesource.com/1164150Reviewed-by: Satoru Takabayashi <satorux@google.com>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Satoru Takabayashi <satorux@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581100}

Replaces paper-item and paper-listbox in media-router/ with iron-selector
and a plain div. Visually matches original code.

Bug: 843350
Change-Id: Ib9a91cd9c804e43e3d99b273332b0192db206c7c
Reviewed-on: https://chromium-review.googlesource.com/1145945
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581099}

|change_work_area| is used to determine whether to change the work area
or not. It is currently set to true when the displaced keyboard bounds
changes and false when the displaced bounds is the same. However, we can
actually set it to true even when the displaced bounds is the same,
because changing the work area to its current value should be a no-op
anyway.

If we make that change, then |change_work_area| is always true, so we
can just remove it from the code.

Bug: 870503
Change-Id: Ia4359211f35f43996efcbd0152b3f4bfa6517caa
Reviewed-on: https://chromium-review.googlesource.com/1160828
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581098}

The AssistantManagerServiceImpl listens to changes in the Assistant
settings/context enabled state, but fails to take into consideration
their values if the preference is not changed. Instead, it defaults
to false (off).

We need to cache the correct initial values.

Bug: b:112262839
Change-Id: I6edcdae9cc71f1ec828ebe70542dd8c34c0af593
Reviewed-on: https://chromium-review.googlesource.com/1163840
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581097}

Replaced existing uiLocationToRawLocation with method that returns all
raw locations.
This helps to resolve some debugger problems:
- ModelBreakpoint can find raw location within its debugger model,
- SourceMapNamesResolver can resolve expression within model for
  current call frame,
- possibleBreakpoints can get start and end location within one model.

DevTools frontend already has similar method for CSSWorkspaceBinding.
Proper behavior of ModelBreakpoint is critical for good breakpoint life
inside environment with a lot of targets, e.g. page with multiple workers,
node app with multiple processes.

R=lushnikov@chromium.org

Bug: none
Change-Id: I5e5c1782ed6b4c46d38cae9e95d642f47fca858a
Reviewed-on: https://chromium-review.googlesource.com/1163076
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581096}

Now that [1] is fixed, we do not need to install the URLInterceptor
as the first thing we do when bootstrap'ing ContentVerifierHashTest.

This CL is a follow up of [2]. It reverts some of the flow changed by
[2] now that we can.

[1] https://crrev.com/c/1117822 (Fix for URLLoaderInterceptor with StoragePartition).
[2] https://crrev.com/c/1076947 (Reland "Migrate ContentHashFetcher to SimpleURLLoader").

BUG=844926

Change-Id: I1f4b2651b3f14196c1523109e8ade5f9cdb3ecac
Reviewed-on: https://chromium-review.googlesource.com/1163862Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#581095}

While here, also slightly reorganize chromium.memory console layout:
- Consistently use OS as toplevel subcategory (so that we don't have
  the cros msan bots under "linux|cros" while the cros asan bots are under
  "asan|cros"
- Order OSs in the same order as the per-os waterfalls appear on
  build.chromium.org: win, mac, linux, cros.

In mb_config.pyl, remove obsolete 'x86' from win/asan config names,
and stop explicitly passing 'x64' (it's the default).

This adds the bot config, but it doesn't add any tests yet. I'll do this
in a follow-up so that I can send try jobs before adding tests. Before
tests are landed, the bot will do nothing.

Bug: 869973
Change-Id: I68a1a401b3fef1532006e42ab7f0e80d1532aa94
Reviewed-on: https://chromium-review.googlesource.com/1163932
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581094}

This CL follows up on a comment [1] and moves a few constant values
out of the ctor initialization list to default member initializers.

This clarifies what initialization must be delayed to ctor time
(because it needs parameters) vs purely constant, and homogenises it.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1159185/16/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.h#715

Bug: 869922
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Icdf567886519853ced6ee88a135fcb85caf1316b
Reviewed-on: https://chromium-review.googlesource.com/1162644Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581093}

Bug: b/111985903
Test: Manual Test
Change-Id: I251f6555d403523346e5e423b83964376a9ca9db
Reviewed-on: https://chromium-review.googlesource.com/1164573Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581092}

Bug: 846917
Change-Id: Ica3471cb3931a7e9368c386aca012674242e60cc
Reviewed-on: https://chromium-review.googlesource.com/1164146
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581091}

Use CompletionOnceCallback instead of CompletionCallback in
//storage/browser/database.

Bug: 807724
Change-Id: I002d97b34d9871d3d5360da200222ccbdc81777b
Reviewed-on: https://chromium-review.googlesource.com/1163312
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581090}

Improves a11y (readability).

Bug: 870937
Change-Id: Id07c24f7661af0139595b59b056cb5d5a2481894
Reviewed-on: https://chromium-review.googlesource.com/1164244Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581089}

Previous change (https://chromium-review.googlesource.com/c/chromium/src/+/1144581) allowed the confirmation dialog to be shown on sign on screen,
however on OOBE screen the dialog needs to be set to be on top of everything else.

Bug: 867478
Change-Id: Ie81e5ad3926c16860f87fb100eb4c0fe7bcba88b
Test: Manual
Reviewed-on: https://chromium-review.googlesource.com/1152329Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Sara Kato <sarakato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581088}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/069210aacb13..f74c888461d6


git log 069210aacb13..f74c888461d6 --date=short --no-merges --format='%ad %ae %s'
2018-08-06 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@f74c888461d6

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I79b38a8aabf92bff8c374c792ba2288d004ea5d3
Reviewed-on: https://chromium-review.googlesource.com/1164126Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581087}

Arc window may be cropped, which can cause showing/hiding
backdrop during the transition, which then may send
unnecessary synthesized mouse move even.

Bug: b/111319005
Test: Covered by unit test. Also tested on play music. See bug for repro step.

Change-Id: Ie030e24095eeadbd549e7cdc8cf7be0438c88d49
Reviewed-on: https://chromium-review.googlesource.com/1162705Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581086}