GitLab

Bug: None
Change-Id: Id47626c66cd4f1f2ac37cea3c273eebb303b5bfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403880Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806629}

As part of
https://chromium-review.googlesource.com/c/chromium/src/+/2225548
I removed an override of onScrollOffsetOrExtentChanged. It turns out
the code was relying on this to be called when the scale factor
changed so that the zoom-controls could be updated.

The fix is to update the zoom-controls when the scale factor
changes.

BUG=1116921
TEST=see bug

Change-Id: Iea87c23e9ea0e6b5934ee568f668388dde489ed6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405645Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806628}

This reverts commit 0f8373b2.

Reason for revert: The cause of the regression is:
https://chromium-review.googlesource.com/c/chromium/src/+/2385929

The test was working correctly, it detected regressions.

Original change's description:
> sheriff: Disable AwContentsTest#testCreateLoadDestroyManyAtOnce
> 
> The test causes webview to crash. It has to be disable until the cause
> off the crash is found.
> 
> TBR=timvolodine@chromium.org
> 
> Bug: 1073077
> Change-Id: I66fb484ad23d33754b5ab841abd4826d3a289b07
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409977
> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806609}

TBR=timvolodine@chromium.org,arthursonzogni@chromium.org

Change-Id: If94228d7e8cd44da735a16385a83f78659590ef4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1073077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409961Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806627}

Roll Chrome Linux PGO profile from chrome-linux-master-1600062449-3179a4da9bad3e513a066b6120519028fcbec2a4.profdata to chrome-linux-master-1600084447-654ce493c2d2b8d13e6243ff3cb852a603e3ef72.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com
Change-Id: I975e40916af0ccad4f64920ba824ccb679437907
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410013Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806626}

Clear CoopAccessMonitor when their reporter are gone. This avoids
accumulating them.
Similarly, because we don't have RenderDocument, the accessing
LocalFrame might host new documents. A new CoopAccessMonitor will be
sent after the commit. The new one must
replace the old one. This will allow the new set or reported URLs to be
reported.

This is a positive change, but still not perfect at all. Ideally, the
CoopAccessMonitor(s) passed into process of the new Document should be
passed along the CommitNavigation IPC.

Bug: 1090273
Change-Id: Ib444e760175207702867f47012fa05bd5e051576
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408752Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806625}

This patch fixes the following points.
- Use info.Holder() instead of info.This() because the callbacks
  must take v8::PropertyCallbackInfo in case of exposed constructs.
- Use V8DOMConfiguration::kReplaceWithDataProperty so that the
  exposed interface objects are cached.

Bug: 1127756
Change-Id: I8da221eaa4d0888658fd9fc6cddccd111114a2d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409732Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806624}

Change Log:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/3c8b5d7587..6af91b3510
Full diff:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/3c8b5d7587..6af91b3510

No changes required to .def files.

Bug: None
Change-Id: Ieb71bd9b716a1d2644e554566766ab83a39871f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408753Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Danil Chapovalov <danilchap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806623}

If a navigation entry is marked as skippable once then it should retain
that flag until user activation even if that entry is reused (due to
back/forward navigations). This is a fix for the intervention
workaround where the following happens without the fix:
1. The initial navigation entries are:
a, b1(skip), b2*
b1 is marked skippable since b2 was added without user activation

2. Once on b2, it immediately calls history.back(). The back() causes a
navigation to b1 which resets its skippable flag to false (This was
being done for all navigations).
a, b1*, b2

3. history.forward() is then immediately called, but b1 doesn't get
marked as skippable because there is no skippable marking logic in
navigating to existing entries. It is also tricky to set because
is_renderer_initiated is not set for history navigations.
a, b1, b2*

4. Now, whenever user presses the back button, it goes to b1 and the
onpopstate handler calls history.forward() to land it on b2, thus making
the user stuck in a loop on b2.

The fix removes the resetting of skippable flag being done in step (2).
This will not cause any issue because if the page gets a user activation
it will be reset anyways.


The reset logic was introduced in the initial CL for the history
intervention:
https://chromium-review.googlesource.com/c/chromium/src/+/1344199
But after that
https://chromium-review.googlesource.com/c/chromium/src/+/1499834 added
the change to reset skippable on user gesture, making the former
redundant.

Bug: 1121293
Change-Id: I291b29d7e4c2adf855c12dc2159f44b9a68af5a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391654Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806622}

Ran `./tools/clang/scripts/upload_revision.py f086e85eea94a51eb42115496ac5d24f07bc8791`.

Bug: 1126953
Change-Id: I5448a7bb6b4a17a8e45da1ab51f53f8dd0122830
Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel
Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel
Cq-Include-Trybots: chromium/try:linux-chromeos-dbg
Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng
Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng
Cq-Include-Trybots: chromium/try:mac-arm64-rel,mac_chromium_asan_rel_ng
Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64
Cq-Include-Trybots: chromium/try:win-asan,win7-rel,win-angle-deqp-rel-32
Cq-Include-Trybots: chrome/try:iphone-device,ipad-device
Cq-Include-Trybots: chrome/try:linux-chromeos-chrome
Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407433Reviewed-by: Hans Wennborg <hans@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806621}

Added generated preference for the notification content setting
and quieter UI preference.

Bug: 1113642
Change-Id: Ifda4dffc809f5bdcf33ac06b22c8ca2ab54d15df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334953Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com>
Reviewed-by: Sean Harrison <harrisonsean@chromium.org>
Commit-Queue: Tymofii Chudakov <tchudakov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806620}

This CL re-enables `testCredentialsChangedByModel` as the problem is
fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2405581

Bug: 1127200, 1127433
Change-Id: I058480287e78b378de023dfe4ca066a944ad26ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408756Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Reda Tawfik <redatawfik@google.com>
Cr-Commit-Position: refs/heads/master@{#806619}

Now the ABNF based checks are fully enabled on the stable.
This is the clean-up change to remove a feature flag.

Bug: 1114019
Change-Id: Id8fde776ed7ae5e6fa0d4d1afc55e20695bfabf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387461
Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806618}

Bug: 1024092
Change-Id: If4adc02e604805b8cf9f312d0c7c931fa0126fa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404934Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806617}

The new page info UI should not show a details string if the connection
is secure. The information will be shown in a subpage instead.

Bug: 1077766
Change-Id: Iee7ef8041ff056d5274f24f5f14901146ba2b754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400500Reviewed-by: Ehimare Okoyomon <eokoyomon@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806616}

Following https://crrev.com/c/2404988, this patch cleans up
named properties' setter implementation.  While the patch
2404988 focused on fixing the issue in M86, this patch is
focusing on a cleaner long-term fix including refactoring.

Bug: 839389, 1126888
Change-Id: Ieae456e342a4fa9b3ac1149210c39c87d81dfca9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404280
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806615}

Bug: 1116418
Change-Id: If435e43ced3287398982aa2bc9719bc5498a40ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401162
Commit-Queue: Yifan Luo <lyf@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806614}

The SignOut operation with Chrome data clearing does not have the
proper conditionals in place to ensure that a subsequent operation
cannot occur while sign-out is in progress.

We suspect this causes a crash on sign-out / sign-in to switch accounts
since the navigation controller that AccountsTableViewController
attempts to perform an operation on may no longer exist.

https://crash.corp.google.com/browse?q=product_name%3D%27Chrome_iOS%27+AND+expanded_custom_data.ChromeCrashProto.channel%3D%27%27+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BHang%5Dweb%3A%3AWebSubThread%3A%3AIOThreadRun%27+AND+%28EXISTS+%28SELECT+1+FROM+UNNEST%28productdata%29+WHERE+key%3D%27breadcrumbs0%27%29+OR+EXISTS+%28SELECT+1+FROM+UNNEST%28productdata%29+WHERE+key%3D%27breadcrumbs%27%29%29&stbtiq=&reportid=&index=0

Bug: 1108310
Change-Id: I66d1852d1071d7acea243005bfabc7797af14dd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408754Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806613}

Updates the color picker border color to Google grey 700.

Bug: 1108289
Change-Id: I596bfa0c914c57fb6807d0e0b76bf8cbbb7a541a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409435
Auto-Submit: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Monica Basta <msalama@chromium.org>
Commit-Queue: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806612}

Replace register and unregister with onAttached and onDetached methods
in SyncPromoPreference

Bug: 1109713
Change-Id: I1bf58fc31e74798a614afdb57179726545ed249d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401522Reviewed-by: Alice Wang <aliceywang@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806611}

The class is called PlatformSensor, not Sensor. No functional changes.

TBR=reillyg

Change-Id: I6cffc3b41190a34aab8fa0b56d79d101851f0c8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409281Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#806610}

The test causes webview to crash. It has to be disable until the cause
off the crash is found.

TBR=timvolodine@chromium.org

Bug: 1073077
Change-Id: I66fb484ad23d33754b5ab841abd4826d3a289b07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409977
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806609}

This is a reland of 45e983ef

Original change's description:
> [Nearby] Use common default device name creation for Windows
> 
> We previously handled default device name creation for Windows
> differently than we did for other non-Chrome OS platforms. The
> underlying reason appears to be that the Nearby Share service unit tests
> were using base::RunLoop().RunUntilIdle() instead of
> task_environment_.RunUntilIdle(). Because the hardware info fetch takes
> longer on Windows than other platforms, I suspect that was the reason
> only Windows was having issues. The correct run loop behavior was fixed
> in a previous CL.
> 
> Fixed: 1127603
> Change-Id: I1f10027696fb47d30ccfe0aa7b2ceb7c85de1393
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407856
> Auto-Submit: Josh Nohle <nohle@chromium.org>
> Commit-Queue: James Vecore <vecore@google.com>
> Reviewed-by: James Vecore <vecore@google.com>
> Cr-Commit-Position: refs/heads/master@{#806466}

Change-Id: I67038737e9d80c557e12fde6dbc567b06c6abe20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408214
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806608}

The test was failing with the following error:
```
../../content/browser/back_forward_cache_browsertest.cc:5429: Failure
Expected: (0.01) > (duration2 - duration1), actual: 0.01 vs 0.011018
```

TBR=altimin@chromium.org,hajimehoshi@chromium.org

BUG=1127833

Fixed: 1127833
Change-Id: Ic0a5c531ab1b9aaa6e9ddac0b009b9add5c72966
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409898Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806607}

This currently asserts the erroneous behavior documented in crbug.com/1124346.
It will serve as proof that the bug is indeed fixed once the code under test is
amended.

Bug: chromium:1124346
Change-Id: Ic8cf6d0ac81e8ae1732981c5a020a6499ad5da47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395779Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Auto-Submit: Titouan Rigoudy <titouan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806606}

SignInPreference class shows the signin promo when there is no primary
syncing account present in chrome. Because the user can now be in
signed in state this can show sync promos and signin promos at the same
time.
SigninInPreference class should instead check for if there is signed in
account in chrome.

Bug: 1126008
Change-Id: I45cd4a80b1206171d1634346865502fc1c94c1cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398542
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806605}

Roll Chrome Win32 PGO profile from chrome-win32-master-1600019602-32c2a84e23bf8e92bb08ca2c2b541f0b03d0321b.profdata to chrome-win32-master-1600062449-2fe327552dcb0c48f221a41ff1f1e25d4acb9926.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: I233bcc6044b31c1a97eb5fc7c9132b13923403b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409377Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806604}

This CL adds a cell in the settings to open Settings.app to set the
default browser.
Launch bug: crbug.com/1126436

Bug: 1127225
Change-Id: I9dea25330f999c0ed76bad6b6635dce1029bee28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400480
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806603}

In particular, the RGBX8 format doesn't seem to be supported. RGBA
ordering support also seems to vary depending on device.

Bug: 1127558
Test: can launch lacros
Change-Id: Iff175b455444b6cfc3cc5c487080b5d42a4b2bc1
Fixed: 2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409532
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806602}

According to MSAN, SurfaceAggregator::has_cached_render_passes_ is
sometimes read without having been initialized.

Default-initialize it (and another bool member) to false, as that seems
to be the expectation.

TBR=kylechar@chromium.org

Bug: 1127818
Change-Id: I34d0a9399fab9b3af70feab14257b82fdb2476d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409697Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806601}

Score of 563 on the flakiness dashboard. The CL disables the test on
every platform except Windows.
https://findit-for-me.appspot.com/p/chromium/flake-portal/flakes?flake_filter=test_type%3A%3Async_integration_tests

Bug: 1126404
Change-Id: I1cffbf8beb44f678c8d60eaecc8936e4ceb77816
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409695
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806600}

Adds the icon for the "New Window" menu item.

Bug: 1119332
Change-Id: I4ef194f49ced3526aa1489c64d6891473ad0b376
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409434
Commit-Queue: Mark Cogan <marq@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Auto-Submit: Mark Cogan <marq@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806599}

This reverts commit 71f44efe.

Reason for revert: Assuming that it causes failures described in https://crbug.com/1127804

Original change's description:
> Add test configs for URL display experiments
> 
> This CL adds test configs for the URL display experiment group that
> launches all three URL display experiments and SafeBrowsing Delayed
> Warnings.
> 
> SafeBrowsingDelayedWarnings was launched standalone for M85. In M86 and
> above, it's launched with the other URL display experiments. It's also
> no longer launched on Android as the URL display experiments aren't
> implemented on Android.
> 
> The CL also removes a couple of obsolete configs so that the bots
> don't hit the command line length limit.
> 
> Bug: 1111429
> Change-Id: I037fb3a456a31d7617516eb7ad554ec1a02f4d6d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399563
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Mark Pearson <mpearson@chromium.org>
> Commit-Queue: Emily Stark <estark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806380}

TBR=mpearson@chromium.org,meacer@chromium.org,tommycli@chromium.org,estark@chromium.org,mahmadi@chromium.org,tiborg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1111429, 1127804
Change-Id: I92d5ecfcc4b8176fa91f31e4e491508d272bb357
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408655Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806598}

Changes: disabled the thread cache on Windows.

Original change's description:
> base/allocator: Add a thread cache to PartitionAlloc.
>
> This CL adds a thread cache to PartitionAlloc. It is optional, only
> applies to thread-safe partitions, and uses the same freelist encoding
> and bucketing as the main allocator.
>
> The thread cache is added "in the middle" of the main allocator, that is:
> - After all the cookie/tag management
> - Before the "raw" allocator.
>
> That is, the general allocation flow is:
> 1. Adjustment of requested size to make room for tags / cookies
> 2. Allocation:
>   a. Call to the thread cache, if it succeeds, return.
>   b. Otherwise, call the "raw" allocator <-- Locking
> 3. Handle cookies/tags, zero allocation if required
>
> On the deallocation side, the process is reversed:
> 1. Check cookies / tags, adjust the pointer
> 2. Deallocation
>   a. Return to the thread cache of possible. If it succeeds, return.
>   b. Otherwise, call the "raw" allocator <-- Locking
>
> The thread cache maintains an array of buckets, the same as the parent
> allocator. A single thread cache instance is only used by a single
> partition. Each bucket is a linked list of allocations, capped to a set
> maximum size. Elements in this "freelist" are encoded the same way they
> are for the main allocator.
> Only the smallest buckets are eligible for caching, to reduce the
> memory impact.
>
> There are several limitations:
> - Only a single partition is allowed to have a thread cache
> - No periodic purging of thread caches is done
> - No statistics are collected
>
> The last two limitations will be addressed in subsequent CLs. Regarding
> the first one, it is not possible to use Chrome's native thread local
> storage support, as it allocates. It is also desirable to use
> thread_local to improve performance.
>
> Bug: 998048
> Change-Id: Ia771f507d9dd1c2c26a4668c76da220fb0c65dd4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375206
> Commit-Queue: Benoit L <lizeb@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#805697}

Bug: 998048
Change-Id: I23b70f6964bb297502921d1a08bf128d9093d577
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404849Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806597}

Discussions on the bug show that OverscrollActionsController's high
memory usage is coming from a large number of small allocations. The
method in question is the initializer, so this implies that a large
number of OverscrollActionsControllers are being initialized. This CL
adds some histograms to verify if this is the case.

Bug: 1102494
Change-Id: Id38c61781a8293a033a77df37227717e2ce7fe56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391232Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#806596}

In order to achieve the right UX in the grid debugging tools in devtools
we need to be able to fill the background of the grid overlay with a
customizable color.

This change adds a new parameter for this in the protocol file.

Bug: 1047356
Change-Id: I4b9cec0017f1cde5f54da95f6f0aa9274375c5b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405997Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#806595}

After refactoring of AccessibilityControllerImpl, we can finally
leverage that modularity by removing tons of identical calls.

Bug: 2390184
Change-Id: I1c42bff577a844af80584ba6acd8da81e7b9b704
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398687
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806594}

- Enable tests with TLA enabled
- Fix top-level error reporting with TLA

Based on the discussions on the spec, we fire error events on rejection
of the result promise:
https://github.com/whatwg/html/pull/4352#discussion_r435178136

Bug: 1022182, 1096455c, 1127215, v8:9344
Change-Id: I16e83cb4e279c1e44be7fa70a51a103ee94aacc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228881
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806593}

Currently the subresource requests which are served from the subresource
Web Bundles can't be interceptable by Chrome extensions. This is because
the requests are handled only inside the renderer process.

This CL introduces UrlLoaderFactoryProxy Mojo interface which can proxy
the URLLoaderFactory for subresource Web Bundles to make the requests
interceptable by Chrome extensions.

This change checks the ENABLE_EXTENSIONS build flag not to increase the
cost of calling IPC for Android where we don't support extensions.

Bug: 1082020

Change-Id: I35efaf5cbb5de4522abd6e5739f265fcfb78dbc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379333
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806592}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/01a6665d9a38..02fad13e1950

2020-09-14 alexrudenko@chromium.org Disable flaky test
2020-09-14 changhaohan@chromium.org Fix background color stuck issue for Computed pane box model

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1124613,chromium:1127785
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I7c8b4c44962d324a2c8da983fc21657e53d64220
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409375Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806591}

Disable this test on Marshmallow, because it it consistently failing
since it was added.

TBR=jds@google.com,dtrainor@chromium.org

Bug: 1127786
Change-Id: Id30d2503395b6e03c9bd42fc2dba9a7fde994f27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408755
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806590}