- 11 Mar, 2020 40 commits
-
-
Ana Salazar authored
Scale the app icon only for transitions between UI_NORMAL and UI_DRAGGING. Bug: 1059884 Change-Id: Ia0fa516ed2ed9517d8ce02fd683ed88864ed5c98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097047 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#749306}
-
Daniel Rubery authored
This reverts commit 3f5e4bb8. Reason for revert: The supported file types were checked in the DownloadItemRequest, but not the FileSourceRequest. In order to accurately check the list of supported file types in M82, we're rolling this back. Original change's description: > Remove DownloadItemRequest > > Start using FileSourceRequest for download deep scanning, since it > achieves most of the same functionality. This CL moves the encryption > checks into the FileSourceRequest, since those are needed by both upload > and download deep scanning. > > Bug: 102710 > Change-Id: I5b4e1983bd108c6454908586e52f8f2ad2dadcb4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095775 > Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org> > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749183} TBR=drubery@chromium.org,domfc@chromium.org Change-Id: Ic66d7ee1d462925a2bfa117be5d502cf8a59bd41 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 102710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099025Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#749305}
-
Scott Violet authored
BUG=1060345 TEST=none Change-Id: Ie7d4594876717aa44e76173c9bf71751e752d9ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097125Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#749304}
-
Jonah Chin authored
Addressing crash caused by missed nullptr check. Bug: 1059223 Change-Id: I13406d6090bfce9f71361e6a8364dafc6b75ac99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097555 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#749303}
-
Raymond Toy authored
Previously, finished_source_handlers_ held raw pointers to AudioHandlers and assumed that active_source_handlers_ also had a copy. But when the context goes away, active_source_handlers_ would be cleared, but not finished_source_handlers_, leaving pointers to deleted objects. So do two things: 1. Change finished_source_handlers_ to hold scoped_refptrs to manage lifetime of the objects 2. Clear finished_source_handler_ in ClearHandlersToBeDeleted() Either of these fix the repro case, but let's do both. Don't want to leaving dangling objects. Manually tested the repro case which no longer reproduces. Bug: 1059686 Change-Id: I2f30c996e8589fa5c3890d32500c4bb4f3bc4286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098260Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#749302}
-
George Burgess IV authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/545152f30278..d2350e1645b5 $ git log 545152f30..d2350e164 --date=short --no-merges --format='%ad %ae %s' 2020-03-10 gbiv suppress -Winline-asm 2020-02-27 jrummell Add configure flag --disable-mips32r6 for Linux MIPS64 builds Created with: roll-dep src/third_party/ffmpeg Bug: 1058218 Change-Id: I2bf37cc1976edd32ec80d30c848b25bda2469f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098500Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#749301}
-
Xiaohan Wang authored
These metrics are still being monitored. Extend the expiry by a year according to the guideline: https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md#Histogram-Expiry Bug: 1053229, 1053010, 1053009 Change-Id: Ib2e21990d9780320aa827405c7b82b6200909082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096909Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#749300}
-
Guido Urdaneta authored
Due to problems with PulseAudio failing to start, tests using audio are flaking. Using fake audio prevents the flakes. Bug: 986021 Change-Id: I17d622637126ad003f5c3f63aaa5559db4bc20b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096768 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#749299}
-
Toby Huang authored
HaTS is currently already enabled for regular users and Googlers. This CL enables HaTS for supervised users, with a survey that only has one multiple choice satisfaction question about their ChromeOS experience. The free form feedback text box in the regular user version has been removed for privacy reasons. Since supervised users can't use incognito mode, supervised users can only view the survey once every 90 days due to cookie settings. This CL implements the HaTS survey for supervised users in the legacy HaTS 1 system. All three surveys will need to migrate to HaTS Next in the near future. Bug: 1050807 Change-Id: I7747569e1f768b85284149db11df752e3b8d0d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095774Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#749298}
-
David Black authored
This included: - Adding an explicit |id| field to AssistantSuggestion. - Moving icon downloading from SuggestionContainerView to each instance of SuggestionChipView. Bug: b:112034793 Change-Id: If1a97e32d438712db003d885299b6a9cb0ab7e8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073219 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#749297}
-
Ayu Ishii authored
Change-Id: I4d416099740777bce8847cc87b7388507ef0d39b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096999Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#749296}
-
Tim Volodine authored
The test is very flaky on android-pie-arm64-dbg. BUG=1060672 TBR=mthiesse@chromium.org,bsheedy@chromium.org Change-Id: If6e1c89f39c02ead5a00dc951603f0bb1d3ba917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095114Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#749295}
-
Junyi Xiao authored
This reverts commit 402e8644. Reason for revert: This changes caused an new bug and a perf regression on startup. Back it out for now, and will try to fix the original bug appropriately later. Original change's description: > WebApps: Remove install pwa icon from toolbar when page crashed > > This change 1. hides the install pwa page action icon in the toolbar > 2. grayed out "create shortcut" and "Install {pwaName}" menu items > when page crashed. > > Bug: 1057526, 1059934, 1059172 > > Change-Id: I63d5e3607e9aff71ab2bd799d792f025b142ec42 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078771 > Commit-Queue: Junyi Xiao <juxiao@microsoft.com> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746305} TBR=pkasting@chromium.org,alancutter@chromium.org,mjackson@microsoft.com,lomitch@microsoft.com,juxiao@microsoft.com,sunggch@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1057526 Change-Id: I69d4e20f4b50c12a56abade08eaf0843c3764d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097540 Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#749294}
-
Mustaq Ahmed authored
Also tweak the existing test for crossorigin user activation visibility. Change-Id: I814cd976f3389c89284d4db2db665464f7ee2689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096900Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#749293}
-
Chong Gu authored
Move telemetry_gpu_integration_test_scripts_only out of chrome. Add fuchsia_telemetry_gpu_integration_test target. Make telemetry_chrome_test_without_chrome not dependent on //chrome, since Fuchsia doesn't use //chrome. Bug: 1058255 Change-Id: I02d560b769c716c4d2554168a9660d2b096289b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097243 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#749292}
-
Michael Crouse authored
This change sets the default ECT threshold for navigation hints fetch to be the maximum, 4G. This enables a race on all known, online connection types. Change-Id: If275721bf7982069d7639016a37204283617ff39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098262 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#749291}
-
Nick Diego Yamane authored
- Update class description - Get rid of deprecated DISALLOW_COPY_AND_ASSIGN macro usage - Remove XWindow::Delegate leftovers R=thomasanderson@chromium.org Bug: None Change-Id: I389c14ef2fb0f6cdfb425ce7e60b7bfb98418554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098463 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#749290}
-
Ben Pastene authored
This reverts commit 6f42f1b7. Reason for revert: "reached max number of active fail fallbacks" errors across CQ eg: https://ci.chromium.org/p/chromium/builders/try/linux-rel/331282 Original change's description: > infra: Migrate builders to Goma RBE (iOS Week 1b) > > These are the remaining iOS builders in Chromium. They are expected to have > under 150 QPS at peak: > https://docs.google.com/spreadsheets/d/1-XKh-CqSoUcXEqCETVywjmIo1C18P0qEBDCY50ozBb0/edit#gid=555424423 > > Schedule of migration: > https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 > > Bug: 950413 > Change-Id: Id11829b5b9b04e2096ddd2d464b63532b69201f1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084035 > Commit-Queue: Simon Que <sque@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> > Reviewed-by: smut <smut@google.com> > Cr-Commit-Position: refs/heads/master@{#749067} TBR=sque@chromium.org,agable@chromium.org,smut@google.com,jbudorick@chromium.org Change-Id: I564fbf11b555efed820b9bd480e3d96f7ff7e5e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 950413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098851Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#749289}
-
George Burgess IV authored
The warning is upset that we're comparing a double, `ConstraintMax(constraint)`, against an enum, `media::limits::kMaxFramesPerSecond`. Casting makes it happy. Bug: 1058218 Change-Id: Ib96907e200228ffc28260d4e3de03e767c9352af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096028Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#749288}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ce25c2d434cf..710f8c3e8de2 git log ce25c2d434cf..710f8c3e8de2 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 capn@google.com Regres: support testlist creation from specified hash Created with: gclient setdep -r src/third_party/swiftshader@710f8c3e8de2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I5339810f02e67bcd30bc955452859f48001b1c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097824Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749287}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/96c9784d1a3d..53effe844c9a git log 96c9784d1a3d..53effe844c9a --date=short --first-parent --format='%ad %ae %s' 2020-03-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@53effe844c9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I13d13ce3d3d13379e3628494c67bfa21ad330c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097825Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749286}
-
Alex Moshchuk authored
Bug: 1053146 Change-Id: I441401d119a0f1fa03aeabecb3d9cde5318faacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098270Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#749285}
-
Robbie McElrath authored
NfcSystemLevelSetting is used by the site settings page, which is being componentized so it can be used by WebLayer. This CL moves the Android portion of //chrome/browser/nfc to the permissions component to to unblock site settings work, but the remaineder of the NFC code will likely need to be componentized at a later date as well. Bug: 1058597 Change-Id: Idd315fe4d82201c7009b6bbb3202a8d3d2241571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090831Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#749284}
-
zhaoyangli authored
This is a reland of dfe67264 - Added an attribute check before trying to access self.use_clang_coverage. This will avoid the errors when the attribute is accessed from a test runner without the attribute, which caused the revert. - Added unit tests in xcodebuild_runner_test.py which will catch similar failures. - Updated existing failing unit tests in xcodebuild_runner_test.py. Original change's description: > [iOS][code coverage]Move raw coverage data to isolated output in test runner scripts. > > - Added function of moving raw coverage data in a new utility file and > corresponding tests. > - Added "use_clang_coverage" arg to run.py and all simulator test > runner classes. > - Added check of the arg and call to the function in TestRunners after > running unit tests and EG tests. > > Bug: 943883 > Change-Id: I5f16c152a38f7a8a3d988aac9e73964d890219b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048851 > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Bug: 943883 Change-Id: I873991f8342431a01528fee075aff985f16e351c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092941 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#749283}
-
Tarun Bansal authored
Also delete some of the mojom bindings related to DRP (Data Reduction Proxy). This effectively disables the DRP proxy. There is a lot more code that can be deleted. This CL is only the first step. Change-Id: I527a02634bb65ddbdb5cf4655a74becb903633b7 Bug: 1048736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095940Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#749282}
-
Shimi Zhang authored
This CL: - Adds necessary serialization and deserialization to AwOriginMatcher, so it can be passed through mojo. - Replaces the usage of ProxyBypassRules to AwOriginMatcher accordingly. - Fix tests for ftp:// scheme loaded with loadDataWithBaseURL(). Bug: 1030110 Change-Id: Iec0fb82a3d603be39cbb3043ef9614bab4f06216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069024Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#749281}
-
Sam Maier authored
Bug: 1059892 Change-Id: Ia8960b95070e34dd8cf0a49d35b2f8df66e57b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097828 Commit-Queue: Sam Maier <smaier@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#749280}
-
Zhenyao Mo authored
They are 0x15d8, 0x15dd There is a crash spike in M80 caused mostly by these two GPUs. It's most likely caused by Chrome enabling hardware overlays for these two GPUs on M80. BUG=625785 TEST=manual R=sunnyps@chromium.org Change-Id: I896d5993818e9b7088f64f6cd974989c8e33c93b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097827 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#749279}
-
ssid authored
Fix tracing delegate browser tests to use proto output. Re enable tests with closed, archived or very old bugs, to see if it is still flaky. Fix trace event data source to not expect perfetto to wait for stop acks. The experiment configs are updated to disable this experiment where needed, the system will upload traces to uma service by default instead of JSON. Change-Id: Id3acb1aa3cdedbcd07c41e18fd0bc66a3cdc1129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088213 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Alexander Yashkin <a-v-y@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#749278}
-
Tim Volodine authored
PrefetchFeedFlowTest#testPrefetchPageReadyLater_FullBrowser is flaky on KitKat Tablet Tester bot. BUG=1060685 TBR=carlosk@chromium.org,harringtond@chromium.org Change-Id: I2e8cf3fac5d74d74c695b0bac474513e30e5d4bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098522Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#749277}
-
John Chen authored
While dispatching an event to a child frame, place a hold on the WebView of the child frame to prevent it from getting deallocated. Bug: chromedriver:3375 Change-Id: I0ff52f6476a2e6767d27c0755a012bdf16dc9c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097538Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#749276}
-
Alexander Cooper authored
https://crrev.com/c/2085847 began showing an appropriate string to users when they denied camera access after granting AR permissions; but missed a few other places to indicate to the user that additional permissions are missing. This change ensures that these warnings appear, similar to the behavior with the camera permission. Note that crrev.com/c/2087704 handles ensuring that the user is prompted for the OS permission when attempting to use the site permission. Bug: 1058055 Change-Id: I26f427c874100b4bfbe52925c3bcded2729591bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090499 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#749275}
-
Clark DuVall authored
The PermissionManagerFactory is kept in //chrome, and an equivalent will be added in //weblayer to initialize permission contexts. The map of permission contexts are now injected into the constructor of PermissionManager. Some unit tests were kept in //chrome which relate to chrome-specific logic in GetCanonicalOrigin(). Bug: 1025609 Change-Id: Id56c6233a65714cb5c68a13223bfc5020d9ac98a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095870 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#749274}
-
Misha Efimov authored
Bug: 1058889 Change-Id: Ie7a3b809c12fcf562332b8723231129fe282c2b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095335 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#749273}
-
Ken Rockot authored
This is strictly a formatting change, generated by manually running yapf over the affected files. It's a precursor to a subsequent move and minor refactoring of this code, as modified files will always get yapf applied and that would otherwise create a lot of noise in the coming CLs. Bug: 1060467 Change-Id: I188ac6cc71fda2cd08a6f4695f67c5c0f04d2737 Tbr: oksamyt@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098265Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#749272}
-
Jeff Yoon authored
ios13-beta-sim has moved to Chromium and utilizes mb_config.pyl. Adding ios_use_goma_rbe=true there. Change-Id: I504bb005e77d7e1b4818e54179a1c46aee3389c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098331Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#749271}
-
Frank Li authored
This CL contains MediaFoundationProtectionManager to be used by MediaFoundationRenderer. MediaFoundationProtectionManager implements IMFContentProtectionManager and ABI::Windows::Media::Protection::IMediaProtectionManager Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/Media/MFCdm/explainer.md Design Doc: https://docs.google.com/document/d/1kXMdmfsSKU3tcwTxG-wFU-MaEA6sN3by45PCGBV8zJU Bug: 999747 Change-Id: Ib6125ac6040798b44c3b10a40851eb852880798f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088682 Commit-Queue: Frank Li <frankli@microsoft.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#749270}
-
Weiliang Chen authored
SkiaOutputSUrface checks the OutputDevice implementation for whether it supports scheduling the primary plane as overlay. This is to match GLOutputSurface's behavior, where only the BufferQueue implementation would return true for IsDisplayedAsOverlay(). This also helps avoid the case where a Surfaceless GLSurface is created for SkiaOutputDeviceGL. R=kylechar Change-Id: Iadfce3551f90e2049db73ed33dfff6ad042c4ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095142Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#749269}
-
Rayan Kanso authored
Change-Id: Iab69731e7c7f13d792b64b0caf7e253417fb756c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097994 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#749268}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c095a02a0ee0..79bf811d23f5 git log c095a02a0ee0..79bf811d23f5 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 skyostil@google.com Merge "docs: Add initial documentation for the Client API" Created with: gclient setdep -r src/third_party/perfetto@79bf811d23f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id3c9a5d4d734fb439c50692bbb9047c4936a3078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097823Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749267}
-