- 27 Mar, 2019 40 commits
-
-
Yeol authored
collection of string vectors. Instead it should take a single vector of expected value structs. FormAutofillTest: :ExpectLabelsAndTypes() took an ever expanding Bug: 896682 Change-Id: I1ddbf1fd27c6f397965292c1685fcceda7c0adae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539326Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Yeol Park <peary2@gmail.com> Cr-Commit-Position: refs/heads/master@{#644650}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c8bd9e358dfd..ffb1c9fdaf5e git log c8bd9e358dfd..ffb1c9fdaf5e --date=short --no-merges --format='%ad %ae %s' 2019-03-27 sadrul@chromium.org telemetry: Fix thread-pool usage on mac. Created with: gclient setdep -r src/third_party/catapult@ffb1c9fdaf5e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:946072 TBR=sadrul@chromium.org Change-Id: I2eb5a949d916d14a696f6f0bd4e68787966ceaf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540717Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644649}
-
Manu Cornet authored
Allow arrow key navigation in the overflow bubble as well, so that app reordering also works and integrates smoothly with keyboard navigation in there too. This does not yet support reordering of app across the "overflow border" (e.g. last app of main shelf with first app of overflow). Also refactor a simple |IsArrowKeyCode| function in a place where it's easy to reuse. Some places in app_list could also use this but that part of the code has a slightly unusual namespace pattern usage and I didn't want to mess with BUILD.gn and deps too much. See this "in action" at: https://bugs.chromium.org/p/chromium/issues/detail?id=888637#c28 Bug: 888637 Change-Id: Icfa22870bd603093cd4889ffdea10d91c01abbc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535304Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#644648}
-
BUG=762641 TBR=malaykeshav@google.com Change-Id: If9f176972e542a5165364b0e75af87b92e4e1b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534415Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644647}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ed0cd5dc2078..261711304bcc Created with: gclient setdep -r src-internal@261711304bcc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:944789,chromium:942819 TBR=sahel@chromium.org,horo@chromium.org,pkasting@chromium.org,andruud@chromium.org Change-Id: I343e495598b70d03a00e9487cd317d6b7be77a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538755Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644646}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5d732177c04f..c74cce1e7a8c git log 5d732177c04f..c74cce1e7a8c --date=short --no-merges --format='%ad %ae %s' 2019-03-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@c74cce1e7a8c The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ic0c65790188506955e20cc60e148cb90105ba3d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538754Reviewed-by:
-
Victor Costan authored
Chrome patches SQLite to remove two features from the FTS3 extension. This CL adds LayoutTests verifying that the features are not available to WebSQL. The tests ensure that we won't accidentally expose the features as we shed our SQLite patches. Bug: 945204 Change-Id: I50364520c33bdfbbbc9b5521fcf6dff37d9fe419 Tested: Ran the blocked commands in a vanilla sqlite3 shell. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538864 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#644644}
-
Luciano Pacheco authored
Currently <cr-menu-item> don't have tabindex at all by default so it can't be focused, making cr.ui.Menu.focusSelectedItem less useful. Tabindex=-1 is focused only via JS not via Tab key, if a tabindex is specified like tabindex=0 which receives focus via Tab key, this value is preserved. Bug: 889153 Change-Id: I32339c936ad01e67d1214bc2f721168ef24219d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535319 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#644643}
-
rajendrant authored
With network-servicification, 407 failures bypass the proxy for a random duration of 1-5 minutes, which leads to drop in data saver usage. This CL reduces that bypass duration. This CL also reduces initial delay for fetching the client config. Bug: 945419 Change-Id: Ifc297a3ee7b681e76ce752612a6b05feba642ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539210Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#644642}
-
Dean Liao authored
TransmissionEncodingInfoHandler is used to handle MediaCapabilities.encodingInfo() API with "transmission" type. Also updates corresponding web_tests. BUG=817382 TEST=Test MediaCapabilities.encodingInfo() API on CrOS devices. Pass content_unittest: out/Debug/content_unittests \ --gtest_filter=TransmissionEncodingInfoHandlerTest.* Pass web_tests: 1. autoninja -C out/Debug blink_tests 2. python third_party/blink/tools/run_web_tests.py --debug \ third_party/blink/web_tests/media_capabilities/encodingInfo.html \ third_party/blink/web_tests/external/wpt/media-capabilities/encodingInfo.html Change-Id: Ideda536f5193d84d5a668445cca9c725b6a2e829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1472410Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Florent Castelli <orphis@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Cr-Commit-Position: refs/heads/master@{#644641}
-
Ehsan Karamad authored
This CL hooks up post messaging API for frame-based MimeHandlerView. A current post message test which runs only for BrowserPlugin version is now modified to run for frame-based MimeHandlerView as well. Bug: 659750 Change-Id: Ie58fa733f463e697e38a100f78e0e50e7431b983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539869Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#644640}
-
Peter Kasting authored
Bug: 946024 Change-Id: I62b07d3899814007a6ba3331c4888b9475f29033 TBR: noel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539133Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#644639}
-
Renjie authored
https://quiche.googlesource.com/quiche.git/+log/60e6ed1b3d4e..9132654c7968 $ git log 60e6ed1b3..9132654c7 --date=short --no-merges --format='%ad %ae %s' 2019-03-25 quiche-dev Use 'bytes' instead of 'string' for holding binary data 2019-03-23 quiche-dev Add a QUIC_BUG to ensure that whenever an ACK cannot be written, the writer is write blocked. Protected by existing flag gfe2_reloadable_flag_quic_use_uber_loss_algorithm. 2019-03-23 quiche-dev Add a test making sure ACK alarm is canceled on write blocked when supporting multiple packet number spaces. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I92ab51e46327e3fce41f6540dcf6382d2f5dbc0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538880Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#644638}
-
Peter Kasting authored
This reverts commit efbe41b8. Reason for revert: Mac bots are failing consistently, see e.g. https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/40949 Original change's description: > Change unoptimized-images feature policy to unoptimized-lossy-images. > > This makes it more clear that this policy applies only to lossy image > types (for now, just JPEG). This patch also makes the implementation > more generic in order to make the policy compatible with parsed > policy values and to pave the way for implementing a > lossless-enforcing version of the unoptimized-images policy as well. > > These changes have been pulled from a larger partially reviewed CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1524869 > > Bug: 942659 > Change-Id: I0242ac900b1653b89d6d8dbd63616003dcaaba62 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531354 > Commit-Queue: Paul Meyer <paulmeyer@chromium.org> > Reviewed-by: Paul Meyer <paulmeyer@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Ian Clelland <iclelland@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644488} TBR=flackr@chromium.org,kenrb@chromium.org,pdr@chromium.org,paulmeyer@chromium.org,iclelland@chromium.org Change-Id: I0dc0449dc2d07c5dafa84c7123ec664c902a73fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 942659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540145Reviewed-by:
-
Brian Sheedy authored
Fixes flakiness in VrBrowserNativeUiTest#testVoiceInputUnavailableIfSiteUsingMicrophone caused by not waiting for residual animations from navigating before attempting to display the permission prompt. Change-Id: Ie530f12d9595869ea56cf351652665043f377d6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540685Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#644636}
-
Xianzhu Wang authored
This reverts commit 24025d13. Reason for revert: crbug.com/945152 has been fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1536992. Original change's description: > Revert "[BlinkGenPropertyTrees] Paint frame overlay in correct property tree state" > > This reverts commit c656dcba. > > Reason for revert: crbug.com/945152 > > Original change's description: > > [BlinkGenPropertyTrees] Paint frame overlay in correct property tree state > > > > Frame overlays should use the device emulation transform node if exists > > as the transform state. > > > > Because the node is ready only after PrePaint, we need to let frame > > overlays update graphics layer status at the end of PrePaint, instead of > > previously unclear (maybe during layout, or paint etc.) > > > > Bug: 934300 > > Change-Id: Ic6e2fe5d29f444dba1a3bf206ffa1775df4adc3d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525199 > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#642184} > > TBR=wangxianzhu@chromium.org,pdr@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 934300, 945152 > Change-Id: Ie50c55532da20dbe44da94c90f93a3ed20bd2a6f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536912 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#643731} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: I2c7b123bdd6ddf0d813008196864425d9daed8e8 Bug: 934300, 945152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537780 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#644635}
-
Matt Menke authored
This CL makes it so that WebSocketTransportClientSocketPool no longer inherits from TransportClientSocketPool. Since it has almost no shared logic, this inheritence was unnecessary and a little confusing. Bug: 944097 Change-Id: I5c70257e3b48bf05bf5e7e9c5732cedb24166904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532919 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#644634}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance using MakeGarbageCollected<Foo> in //third_party/blink/renderer/core/css, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. This CL is the seventh clean up in core/css. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I12a1a76762791edb72c893a4ed73c93ea1a5cf76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539325Reviewed-by:
-
Simon Que authored
Bug: 945731 Change-Id: Iebda88878c34687f4d60172b2ba07141a54d5cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539632Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#644632}
-
Oksana Zhuravlova authored
This change adds annotations for mojom entities in the generated headers. These annotations will be used for creating codesearch-related metadata. They are only generated if enable_kythe_annotations build flag (also added by this change) is true (it defaults to false). Bug: 943856 Change-Id: I94a16fc8fb95045ec80e893157b733b4cb8da0b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534342 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#644631}
-
Yusuf Ozuysal authored
1) Routes swipe down through a delegate OverviewModeController passed during construction in LayoutManagerChrome. This keeps default behavior as is but swipes down to the Grid when Grid or TabGroups is enabled. 2) Gets back swipe to side for both grid and tab groups. This was disabled while looking for a solution to 1) above. Now the only caveat is swipe to side scrolls between tabgroups if there are tabgroups which is WAI. 3) Disables both side swipe and swipe down from the bottom toolbar for the tab groups case where tabstrip needs the swiping gesture as it technically can become long enough that it needs to scroll BUG=941676 Change-Id: I706a3aa778ab08c5e46fbbcaaec40eb7f69c56fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537250Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#644630}
-
Maksym Onufriienko authored
Bug: 912323 Change-Id: I15aa8fe90fff81bdec97ba03eea07b57b4c280e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529622Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#644629}
-
Taylor Bergquist authored
Tabs opened from a link with middle click, shift middle click, or'Open in new tab' from the link's context menu will open in the current tab's group. This CL is part of the prototype of the above-described tab groups feature. The prototype will allow users to create and manipulate groups primarily via tab context menus, and will display tab group affiliation in the tabstrip. Future work will include persisting and syncing groups, manipulating groups via tab dragging, and a dropdown menu for the group headers. See go/chrome-tab-groups-design Bug: 905491 Change-Id: Ibc75d39ca3bfb30bcd0ff34de9db2a8a841d57ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1441493 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#644628}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance using MakeGarbageCollected<Foo> in //third_party/blink/renderer/core/css, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. This CL is the fifth clean up in core/css. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ibf76598bef9077f26622619ad93ca96820acae5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538264Reviewed-by:
-
Peter Kasting authored
Bug: 946023 Change-Id: Ia8873635b8c1363eeca69ab0600eb8a8a656cbc8 TBR: noel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540680Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/de253137e334..1a9f8ed9bf54 git log de253137e334..1a9f8ed9bf54 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 tsepez@chromium.org Tidy some warnings from clang-tidy 2019-03-26 thestig@chromium.org Avoid 0 byte reads in ParseAndAppendCrossRefSubsectionData(). 2019-03-26 thestig@chromium.org Make CXFA_NodeHelper::GetNameExpression() a member of CXFA_Node. 2019-03-26 thestig@chromium.org Make CXFA_NodeHelper::NodeIsTransparent() a member of CXFA_Node. Created with: gclient setdep -r src/third_party/pdfium@1a9f8ed9bf54 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:945624 TBR=dsinclair@chromium.org Change-Id: I7b42a886ae518b8649d6dc4e8365f8960596827c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540537Reviewed-by:
-
Staphany Park authored
Bug: 918293 Change-Id: I4f16640f06feac009d6bbbb624951da6d2669f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488059 Commit-Queue: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#644624}
-
Nico Weber authored
Else they'll hang around and slowly fill up bot disks. TBR=hans Bug: 464945 Change-Id: Iecb8e3b24dd1585e89567025614389296f895d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540481Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#644623}
-
Nate Fischer authored
This adds AllowFileSchemeCookies() to the CookieManager mojo interface to support WebView's #setAcceptFileSchemeCookies() API. This must be a dynamic API instead of a NetworkContextParam because apps may legitimately call the Java API after the NetworkContext has been initialized (so long as they call it before the first use of the underlying CookieStore). We currently accommodate this in the legacy code path by lazily creating the CookieStore the first time it's used. To properly support the corresponding getter API, this CL modifies CookieMonster::SetCookieableSchemes to pass a boolean success value to a callback (which network::CookieManager also exposes as a callback). This adds test coverage for the getter API, including covering the call-after-cookie-store-initialization case, where it's no longer possible to enable file:// scheme cookies. As we haven't yet finalized a solution for using the CookieManager prior to content-layer initialization (http://crbug.com/933461), this CL does not attempt to resolve synchronization issues with that case. Design: http://go/wv-ns-cookie-apis#bookmark=id.hq3jcr72p6ai Bug: 933458 Test: $ run_webview_instrumentation_test_apk \ Test: --enable-features=NetworkService,NetworkServiceInProcess \ Test: -f CookieManagerTest.*FileScheme* Test: $ net_unittests --gtest_filter=SQLitePersistentCookieStoreTest.* \ Test: :CookieMonsterTest.* Cq-Include-Trybots: luci.chromium.try:android_mojo Change-Id: I1c7c9ef3919686df39abc7ac760fddf91e176e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533486 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#644622}
-
Xing Liu authored
On Android Q, Environment.DIRECTORY_DOWNLOADS is an invalid directory, and all disk space queries like getUsableSpace() or getTotalSpace() will return 0, and other related calls may throw exception. This is because we didn't create the directory in external storage. Q basically exposes a bug in our code. This CL adds a utility function to retrieve the directory and tries to create it. Also updates DownloadUtils.isInPrimaryStorageDownloadDirectory to work with content URI file path on Q. Bug: 945028 Change-Id: I22cce2e5ac81bd574eee96719648689c5a8cdbf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538876Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
-
Daniel Bratell authored
The mojo type GpuPreferences did not depend on the implementation classes. Since the implementation classes in turn depends on the mojo bindings, there is a dependency cycle. This patch describes that in the build system in a way that is accepted by gn check --check-generated An example of an error: ERROR at //out/Default/gen/gpu/ipc/common/gpu_preferences.mojom-forward.h:40:11: Include not allowed. #include "gpu/config/gpu_preferences.h" ^--------------------------- It is not in any dependency of //gpu/ipc/common:gpu_preferences_interface The include file is in the target(s): //gpu/config:config_sources which should somehow be reachable. ___________________ Bug: 938893 Change-Id: I18a9c0c8684ffbbdbe5d47573150434de397061f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538423 Auto-Submit: Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#644620}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/45d5f702133e..2b7cca4cd8e4 git log 45d5f702133e..2b7cca4cd8e4 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader cc6473f7d80d..e747b3c3c9d9 (1 commits) Created with: gclient setdep -r src/third_party/skia@2b7cca4cd8e4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Ic17beb077c07e37060cc02046c7461906533726c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540538Reviewed-by:
-
Adam Ettenberger authored
1. Adding or mapping generated events for relevant properties : - ENABLED_CHANGED (IntAttribute::kRestriction) - READONLY_CHANGED (IntAttribute::kRestriction) - VALUE_CHANGED (FloatAttribute::kValueForRange) - VALUE_MAX_CHANGED (FloatAttribute::kMaxValueForRange) - VALUE_MIN_CHANGED (FloatAttribute::kMinValueForRange) - VALUE_STEP_CHANGED (FloatAttribute::kStepValueForRange) 2. Firing UIA Property Changed events : - UIA_IsEnabledPropertyId - UIA_RangeValueIsReadOnlyPropertyId - UIA_RangeValueLargeChangePropertyId - UIA_RangeValueMaximumPropertyId - UIA_RangeValueMinimumPropertyId - UIA_RangeValueSmallChangePropertyId - UIA_RangeValueValuePropertyId - UIA_ValueIsReadOnlyPropertyId - UIA_ValueValuePropertyId 3. Ethan found a bug with AccessibilityEventRecorderUia which was causing event tests with multiple 'go()' calls to timeout. Cherry picked the fix from his CL : https://chromium-review.googlesource.com/c/chromium/src/+/1518407 Bug: 844149 Change-Id: Icf10385faf2ba84a49747298692bed409a862886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534286 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#644618}
-
Bruno Santos authored
Bug: 927809 Change-Id: I0fe5c9c5763e39948d26b6f8d69764a9cd5dd4e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538888 Commit-Queue: Bruno Santos <brunoad@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#644617}
-
Dmitry Gozman authored
We cannot route flatten protocol to node targets, so we should keep wrapping node subtragets with Target.sendMessageToTarget. Bug: 941608 Change-Id: I0b04379e143c32b61c3ede6047d6c967cd96af06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538484Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#644616}
-
Charlene Yan authored
Renamed MenuButtonEventHandler to MenuButtonController since it contains more than just EventHandling logic. Bug: 901183 Change-Id: Ibb983144b9f5713d69298ca5dff13dc3de9d7c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539917Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#644615}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4864e0cd1960..518c679da109 git log 4864e0cd1960..518c679da109 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 jonahr@google.com Clean up test_expectations to merge with angle style/convention. Created with: gclient setdep -r src/third_party/angle@518c679da109 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org Change-Id: I5e563c1e161227952298d438c510900f30789795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538752Reviewed-by:
-
Jun Mukai authored
When the device-scale-factor changes, the change is currently handled in the window server. The server re-generate the local surface id and notifies to the client through OnWindowBoundsChanged. When this mojo call arrives to the client, it's propagated to TopLevelAllocator::OnDeviceScaleFactorChange, and it re-generate again the local surface id, and sends back to the window server through SetWindowBounds(). This causes some troubles. This means that TopLevelAllocator does not have to generate the local surface id on DSF change since it's already handled in the server. This CL skips this regeneration. Bug: 942647 Test: the new test case in aura_unittests Change-Id: I86f9d8952082f1b2e7bb9ab74e38f556783447f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540069Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#644613}
-
Eric Lawrence authored
Updates the network documentation to reflect that the network service may not be running in the browser process. Also, fixes some minor typos. Change-Id: Ie89fe73c55640a404daca618de0f32ef5fa472dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540364Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#644612}
-
Matt Menke authored
A lot of places were using TransportClientSocketPool::SocketParams to refer to the class. Bug: 944095 Change-Id: I4d5638e43a46ced2a3ef1f293b616b2b549fa69e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532913 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#644611}
-
