- 16 May, 2018 40 commits
-
-
Chris Hamilton authored
This moves all of the responsibility for handling PageAlmostIdle to TabLoadTracker. Change-Id: I9325109e896910d76b6aa6a615f9004dc1a4e67d Reviewed-on: https://chromium-review.googlesource.com/1060569 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#559277}
-
Jay Civelli authored
Relanding the move zygote to the service manager. It was causing an TSAN failure that now cannot be reproduced. Original description: "This CL moves the zygote code from content/ to services/service_manager/zygote. This involves moving some switches from content_switches.h to services/service_manager/embedder/switches.h and moving some codes from content/public/common/result_codes.h to the new services/service_manager/embedder/result_codes.h." Tbr: avi@chromium.org Tbr: sky@chromium.org Tbr: scottmg@chromium.org Tbr: rockot@chromium.org Tbr: slan@chromium.org Tbr: eseckler@chromium.org Tbr: rsesek@chromium.org Bug: 831846 Change-Id: Ief3c55a1d76ab0b0ded922770d14402c0c3b37b9 Reviewed-on: https://chromium-review.googlesource.com/1048040Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#559276}
-
Emily Hanley authored
Bug: 840427 Change-Id: I1d658ed8c005ab29ec4754b1586257aec8b2c106 Reviewed-on: https://chromium-review.googlesource.com/1062286Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#559275}
-
Katie D authored
It now matches the name in histograms.xml. TBR=dmazzoni@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8aa7ed7086bc2abbafe68aa2dcc3b75c1c982334 Reviewed-on: https://chromium-review.googlesource.com/1062210 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#559274}
-
Robert Flack authored
It seems to be flaky about 5% of runs since it was added on the Mac10.10 bot. TBR=imcheng@chromium.org Bug: 843599 Change-Id: I94b4dde41e2455af3fa3fe3f4e02f6c3a3a14013 Reviewed-on: https://chromium-review.googlesource.com/1062593 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#559273}
-
Sebastien SG authored
This reverts commit 46a6d04b. Reason for revert: Introduced and inconsistency in how the Sync Payments cards toggle. See crbug.com/839643 Original change's description: > Settings[DICE]: changing sync-everything doesn't impact on-disk prefs > > This CL stops toggling "sync everything" from overriding all individual > prefs' on-disk value with "true" (see reasoning in bug report). > > Bug: 815018 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: If6287376009b200355426113618933af9ad78243 > Reviewed-on: https://chromium-review.googlesource.com/935836 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Commit-Queue: Scott Chen <scottchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542929} TBR=tommycli@chromium.org,dpapad@chromium.org,mastiz@chromium.org,scottchen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 815018,839643 Change-Id: Iba41940bdfde775048553dd4e0abd6c52e85f7bf Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1061893 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#559272}
-
Robert Sesek authored
This increases code coverage based on what is observed in this report: https://chromium-coverage.storage.googleapis.com/reports/558266_tests_only/linux/chromium/src/base/json/json_parser.cc.html Bug: 489301 Change-Id: Ia7f9ef97e93fb92e440717d9463d810dab4f87dc Reviewed-on: https://chromium-review.googlesource.com/1059717 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#559271}
-
Christopher Grant authored
On navigation, or at other times, content was flashing. This was happening because unrelated code presumably mucks with the GL blend mode, and we weren't setting it before drawing content via the new quad-layer mechanism. BUG=838695 Change-Id: I93791ff26cf52d74db410cf1590b9f5baca21765 Reviewed-on: https://chromium-review.googlesource.com/1062196Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#559270}
-
Andrew Grieve authored
Without --local, the dumpsys command changes the memory usage of the app! With --local, we lose: Objects Views: 0 ViewRootImpl: 0 AppContexts: 4 Activities: 0 Assets: 2 AssetManagers: 2 Local Binders: 3 Proxy Binders: 7 Death Recipients: 0 OpenSSL Sockets: 0 Added --query-app flag to get these back. Change-Id: If47994b64620ae266c6109d9747a81aa805b293c Reviewed-on: https://chromium-review.googlesource.com/1062329Reviewed-by:Peter Wen <wnwen@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#559269}
-
Avi Drissman authored
BUG=843075 Change-Id: Iccb161d3d584cf434ae20b5ec91134b04996c999 Reviewed-on: https://chromium-review.googlesource.com/1062411Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#559268}
-
CJ DiMeglio authored
This CL makes software compositing for the cc::Surface for video case by making VideoFrameSubmitter a SharedBitmapReporter. Before we would see blue boxes instead of the video frames. Now we see video frames as they should be. Bug: 807840 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I486456f4d4e96b05317089557084242eeda04455 Reviewed-on: https://chromium-review.googlesource.com/1057962Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#559267}
-
Hans Wennborg authored
Those tests don't pass, but the rest of jingle_unittests seems to do so. Bug: 843104, 840756, 842698 Change-Id: I9895fa88042ec5decdc70e33fceb362d14638f1d Reviewed-on: https://chromium-review.googlesource.com/1059613Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#559266}
-
James Cook authored
Bug: none Change-Id: I520b73ca3732be6a38b941e14a56d7e07e8c2bf3 Reviewed-on: https://chromium-review.googlesource.com/1062718Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#559265}
-
Henrique Nakashima authored
When destroying the page we may need to cancel timers. Currently, the timers will be free'd before the page. This CL changes the destruction order to free the pages before freeing the timers. Bug: 843493 Change-Id: Ic96707bd1dc7510f65218679dc12cd44ba012db8 Reviewed-on: https://chromium-review.googlesource.com/1062195Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#559264}
-
Joshua Peraza authored
9115494e8aa4 fuchsia: Increase timeout for WorkerThread.DoWork test dea8fa51d0b5 fuchsia: Changes to allow analyzer-style exception handling d78bd067c7f3 linux: Initialize a crashing thread's stack from its exception context 75b672be06c5 Fix arm build with glibc 2.27 Change-Id: I1187b6c1f651761dc65818c24441943b25b7519c Reviewed-on: https://chromium-review.googlesource.com/1060117Reviewed-by: -
Moe Ahmadi authored
Replaces the iOS icon with what's being used on Android. Bug: 841758 Change-Id: I31576c9bd4925c91ca28afe46c9071d97cb0ea43 Reviewed-on: https://chromium-review.googlesource.com/1061586Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#559262}
-
Josh Karlin authored
What: 1. Sends a message to the browser part of the subresource_filter component to make it aware of which frames have been identified as ads by the AdTracker. 2. The browser monitors movement of RFHs across processes and copies over the ad_subframe bit to new RFHs in ReadyToCommitNavigation. 3. Simplified OngoingThrottleInfo::is_ad_subframe and renamed it to OngoingThrottleInfo::navigating_to_ad_url. 4. Added tests. Why: Because while the render process knows if a subframe that it creates is an ad frame or not, if the frame changes processes (due to site isolation) the browser has to tell the new process that the frame is an ad. Bug: 993493 Change-Id: I2a17660251cdd238853990e2384a7e287f5c659b Reviewed-on: https://chromium-review.googlesource.com/1044425 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#559261}
-
Lukasz Anforowicz authored
This CL replicates existing test expectations for media/video-controls-focus-movement-on-hide.html into the virtual/video-surface-layer flavour of the test. Before this CL: crbug.com/833658 [ Linux Win Mac ] media/... [ Pass Failure ] crbug.com/841922 [ Mac10.12 Mac10.13 Win7 ] virtual/video-surface-layer/media/... [ Failure Pass ] After this CL: crbug.com/833658 [ Linux Win Mac ] media/... [ Pass Failure ] crbug.com/841922 [ Linux Win Mac] virtual/video-surface-layer/media/... [ Pass Failure ] Bug: 833658, 841922 Change-Id: Ib3de8102f5e947215133f42c2dc522d612394789 Reviewed-on: https://chromium-review.googlesource.com/1062587Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#559260}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/72b67fe2e3ac..d95db22a613c $ git log 72b67fe2e..d95db22a6 --date=short --no-merges --format='%ad %ae %s' 2018-05-15 benjhayden Add app-route to third_party/polymer2. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ic5e25e2af70e188a51c43dbe25b6986ac15dbd0b Reviewed-on: https://chromium-review.googlesource.com/1062205 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559259}
-
Eugene But authored
This data will be passed to DownloadTask so DownloadManagerTabHelper can distinguish downloads requested by the user vs. downloads requested by a web page. DownloadManagerTabHelper drops subsequent downloads requested by the web page to prevent spam. Currently tab helper relies on download task's transition type (which is incorrect). Fixing download transition type is possible, but much harder (see crbug.com/549301). This API mirror's content's NavigationHandle::HasUserGesture Bug: 842828 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I79fc2a57af4594494e27613996c39e0153857e5c Reviewed-on: https://chromium-review.googlesource.com/1060575Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#559258}
-
David Jacobo authored
Removing the namespace preffix since its redundant, also adding comments to the parameters (i.e. "should_persist"). Bug: None Test: Build Change-Id: I266396e75d5d12c86dfd53f0099d1b63c61998b9 Reviewed-on: https://chromium-review.googlesource.com/1059720Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#559257}
-
Sorin Jianu authored
This allows the clients of UpdateClient inspect the error codes when an update is complete. Bug: 843657 Change-Id: I667a58a2723846cdcc4070fc9b103419ea4859d1 Reviewed-on: https://chromium-review.googlesource.com/1060586Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#559256}
-
Bill Budge authored
- This is a speculative fix to address a large performance regression on Android WebView. - Restricts the range on 64 bit ARM Android to 0x20000000 - 0x60000000. Bug: chromium:837640 Change-Id: I913ed62a9d360ae96aeaab80f468c18f357f956f Reviewed-on: https://chromium-review.googlesource.com/1062012Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#559255}
-
Eugene But authored
The test verifies is_post argument passed to WebClient::PrepareErrorPage Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9f5a6035f1c49dc3cc0a1a144b096ff2fc035989 Reviewed-on: https://chromium-review.googlesource.com/1062079Reviewed-by:
-
Bailey Berro authored
This changes adds an SmbMountResult enum to represent the various possible results for attempting to mount an SMB share. This SmbMountResult enum will be mirrored by SmbHandler so that the Smb Shares Settings Page can show the user a more helpful message. Bug: chromium:757625 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2da586c74ba71bf231ff3d5cb572f4a7df26c89e Reviewed-on: https://chromium-review.googlesource.com/1056350 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#559253}
-
Lukasz Anforowicz authored
Bug: 843691 Change-Id: Ic066c88c0c452b1c257f857af694a51ed89cd044 Tbr: brucedawson@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1062197Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#559252}
-
Tom Anderson authored
BUG=591980 Change-Id: I9a16d9a27d909dc696b816ab96e9e154f06d5175 Reviewed-on: https://chromium-review.googlesource.com/1062209Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#559251}
-
Tom Sepez authored
Land this functionality before continuing with the other PDF JS efforts. Split off from https://chromium-review.googlesource.com/c/chromium/src/+/1055773 Change-Id: Ibbcc8598886466126111d3a9f5449bd7412f30c2 Reviewed-on: https://chromium-review.googlesource.com/1060025 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#559250}
-
Derek Cheng authored
This will be used for in-browser DIAL MRP (https://chromium-review.googlesource.com/c/chromium/src/+/1036611) and other future MRP implementations to indicate a MediaRoute already exists when trying to CreateRoute. Bug: 816628 Change-Id: Id43d91be7318362043cc33a3c0500cc9463f5a5d Reviewed-on: https://chromium-review.googlesource.com/1062145Reviewed-by:
Adam Parker <amp@chromium.org> Reviewed-by:
-
Becky Zhou authored
A ModalDialogView might have a different dialog size. For example, the AlertDialog-like dialog view would have width MATCH_PARENT as the Android AlertDialog, and PageInfo would have width WRAP_CONTENT. Bug: 837036 Change-Id: I134862bf61ecc57bdb6b3a2ad6cbafa36c03fab8 Reviewed-on: https://chromium-review.googlesource.com/1058322Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#559248}
-
Mounir Lamouri authored
Previously, the promise was resolved before hitting the IPC to the browser process. This adds an ACK IPC that notifies that the operation is done. Technically, this isn't checking that the window is really closed but instead the ACK is sent after `Close()` is called. Bug: 806249 Change-Id: Ibcae8789275f743a827340d0f22485484cbac5b1 Reviewed-on: https://chromium-review.googlesource.com/1042572Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#559247}
-
Mark Pearson authored
Add advice relating to good engineering practices. Also add a section about interpreting metrics. Change-Id: I3b72f54b8b6807bccaaaa98d4a76513983cb8772 Reviewed-on: https://chromium-review.googlesource.com/1058587 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#559246}
-
Scott Chen authored
The device page was doing quite a lot of work to prevent link-clicking from selecting a radio-button. This CL moves the responsibility to cr-radio-button. Also cleans up key-event handling within cr-radio-button a bit. Bug: 840527 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I86701cd53e1a6794d8661c5ef66ac9d2e0d4f81a Reviewed-on: https://chromium-review.googlesource.com/1060164Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#559245}
-
CJ DiMeglio authored
GPU factories may be null when we ask for it so we should handle it. If GPU factories is null, we should fall back to software compositing. Bug: 843044 Change-Id: I611c19ed1d253c509fca6cb0cf6a69642d9080b9 Reviewed-on: https://chromium-review.googlesource.com/1060615Reviewed-by:
-
David Black authored
Previously, Assistant UI could only be launched via hotword. This meant it was impossible to see Assistant UI if the underlying service was not started. Now, there are non-hotword entry points wired up and it is possible to launch Assistant UI with the underlying service in an unready state. This can happen if the underlying service fails to get a token and bind itself to AssistantController, as happens when logging in without a network connection. Now we will show a toast. Just a generic message for now, need to get final text from UX. Bug: b:79752950 Change-Id: I48ae014e257db0012ac791be40f1245e5c3316b0 Reviewed-on: https://chromium-review.googlesource.com/1060603 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#559243}
-
Esmael El-Moslimany authored
Bug: 832181 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia1f518476fca1e76223ddc072001c91e241dd44c Reviewed-on: https://chromium-review.googlesource.com/1062226 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
-
Moe Ahmadi authored
This only affects Mac and iOS. Android and Linux will keep using the non-title-cased version. Bug: 841758 Change-Id: I82d0c4e6ffc5d6e9975ffd18f33c56957023592e Reviewed-on: https://chromium-review.googlesource.com/1061589Reviewed-by:
-
Majid Valipour authored
The last two values should be optional according to the specification [1]. Added two new factory methods to allow this. To do this cleanly switched WorkletAnimation to have Member<AnimationTimeline> instead of holding onto a DocumentTimelineOrScrollTimeline. [1] https://wicg.github.io/animation-worklet/#creating-worklet-animation TEST: virtual/threaded/fast/animationworklet/worklet-animation-creation.html Bug: 840383 Change-Id: Ida5aa077fbf19b4918652c02e92f40435db4fbb4 Reviewed-on: https://chromium-review.googlesource.com/1047691 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#559240}
-
Esmael El-Moslimany authored
Bug: 832179 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7db70455f9e9a6f72840b51ba8d9f89dab38d406 Reviewed-on: https://chromium-review.googlesource.com/1060472 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 5481 5487 5495 5503 5510 5512 5515 5519 5521 5530 6 lines were removed and 1 lines were deflaked by consecutive results since 5415. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I8425fc95505fb852cbdcce272cae87a4dfc3114e Reviewed-on: https://chromium-review.googlesource.com/1059534 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#559238}
-
