1. 19 Aug, 2011 27 commits
    • caseq@chromium.org's avatar
      Web Inspector: [Extensions API][chromium] webInspector.resources deprecation... · edbdfc24
      caseq@chromium.org authored
      Web Inspector: [Extensions API][chromium] webInspector.resources deprecation warning is given even for extensions that don't use webInspector.resources
      https://bugs.webkit.org/show_bug.cgi?id=66553
      
      Reviewed by Pavel Feldman.
      
      * src/js/DevTools.js:
      (WebInspector.platformExtensionAPI):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93400 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      edbdfc24
    • commit-queue@webkit.org's avatar
      [EFL] Modify type of both col and row parameters for backing store's internal api. · 671301c6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65302
      
      As both col and row parameter's type for both _ewk_tiled_backing_store_item_fill
      and ewk_tiled_backing_store_item_add are different from each other, I modify type of them.
      
      Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-19
      Reviewed by Adam Roben.
      
      * ewk/ewk_tiled_backing_store.c:
      (_ewk_tiled_backing_store_item_fill):
      (_ewk_tiled_backing_store_item_add):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93399 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      671301c6
    • pfeldman@chromium.org's avatar
      Web Inspector: getAttributes should work on a single node, not array. · be64dd3b
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66544
      
      Reviewed by Adam Roben.
      
      * inspector/Inspector.json:
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::getAttributes):
      * inspector/InspectorDOMAgent.h:
      * inspector/front-end/DOMAgent.js:
      (WebInspector.DOMAgent.prototype._loadNodeAttributes):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93398 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      be64dd3b
    • antonm@chromium.org's avatar
      [v8] CSS wrapper objects retention · 30b7aeaf
      antonm@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66377
      
      Reviewed by Pavel Feldman.
      
      Disable object grouping for CSS object wrappers.
      This logic leads to hard to debug use-after-free problems.
      
      Source/WebCore:
      
      * bindings/v8/V8GCController.cpp:
      (WebCore::GrouperVisitor::visitDOMWrapper):
      
      LayoutTests:
      
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93397 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      30b7aeaf
    • pfeldman@chromium.org's avatar
      Web Inspector: introduce NodeId inherited from integer in the DOM domain description. · a1521dc8
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66491
      
      Drive-by rename of couple of DOM domain protocol methods.
      
      Reviewed by Adam Roben.
      
      * inspector/Inspector.json:
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::requestChildNodes):
      (WebCore::InspectorDOMAgent::getAttributes):
      (WebCore::InspectorDOMAgent::requestNode):
      (WebCore::InspectorDOMAgent::buildObjectForNode):
      * inspector/InspectorDOMAgent.h:
      * inspector/front-end/DOMAgent.js:
      (WebInspector.DOMNode):
      (WebInspector.DOMNode.prototype.getChildNodes):
      (WebInspector.DOMAgent.prototype.pushNodeToFrontend):
      (WebInspector.DOMAgent.prototype._loadNodeAttributes):
      (WebInspector.DOMAgent.prototype._setDocument):
      (WebInspector.DOMAgent.prototype._setDetachedRoot):
      * inspector/generate-inspector-idl:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93396 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a1521dc8
    • jochen@chromium.org's avatar
      IDBSQLiteBackingStore::deleteObjectStore should maintain referential integrity. · cf0b05aa
      jochen@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66470
      
      Reviewed by Tony Gentilcore.
      
      * storage/IDBSQLiteBackingStore.cpp:
      (WebCore::IDBSQLiteBackingStore::deleteObjectStore):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93395 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cf0b05aa
    • zoltan@webkit.org's avatar
      [Qt] editing/selection/caret-at-bidi-boundary.html times out after r93369 · 9f2bc91f
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66514
      
      Skip it.
      
      * platform/qt/Skipped:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93394 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9f2bc91f
    • commit-queue@webkit.org's avatar
      [WebSocket] CloseEvent's code and reason properties support. · cb8badea
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66362
      
      Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-19
      Reviewed by Kent Tamura.
      
      Current WebSocket implementation miss code and reason properties
      in CloseEvent. This change expose incoming closing frame's code
      and reason to JavaScript API.
      
      Source/WebCore:
      
      Tests: http/tests/websocket/tests/hybi/close-code-and-reason.html
             http/tests/websocket/tests/hybi/workers/close-code-and-reason.html
      
      * websockets/CloseEvent.h:
      (WebCore::CloseEvent::initCloseEvent):
      (WebCore::CloseEvent::code):
      (WebCore::CloseEvent::reason):
      (WebCore::CloseEvent::CloseEvent):
      * websockets/CloseEvent.idl:
      Add code and reason properies.
      * websockets/ThreadableWebSocketChannelClientWrapper.cpp:
      (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
      (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
      * websockets/ThreadableWebSocketChannelClientWrapper.h:
      * websockets/WebSocket.cpp:
      (WebCore::WebSocket::didConnect):
      (WebCore::WebSocket::didClose):
      * websockets/WebSocket.h:
      Add implement to handle code and reason.
      * websockets/WebSocketChannel.cpp:
      (WebCore::WebSocketChannel::WebSocketChannel):
      (WebCore::WebSocketChannel::didCloseSocketStream):
      (WebCore::WebSocketChannel::processFrame):
      * websockets/WebSocketChannel.h:
      Add closing frame payload parser.
      * websockets/WebSocketChannelClient.h:
      (WebCore::WebSocketChannelClient::didClose):
      * websockets/WorkerThreadableWebSocketChannel.cpp:
      (WebCore::workerContextDidClose):
      (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
      * websockets/WorkerThreadableWebSocketChannel.h:
      Add implement to handle code and reason.
      
      LayoutTests:
      
      * http/tests/websocket/tests/hybi/close-code-and-reason-expected.txt: Added.
      * http/tests/websocket/tests/hybi/close-code-and-reason.html: Added.
      * http/tests/websocket/tests/hybi/close-code-and-reason_wsh.py: Added.
      * http/tests/websocket/tests/hybi/workers/close-code-and-reason-expected.txt: Added.
      * http/tests/websocket/tests/hybi/workers/close-code-and-reason.html: Added.
      * http/tests/websocket/tests/hybi/workers/resources/close-code-and-reason.js: Added.
      (postResult):
      (ws.onopen):
      (ws.onmessage):
      (ws.onclose):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93393 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cb8badea
    • morrita@google.com's avatar
      .: Spell-checking doesn't recognize word boundaries on contests inserted by... · c74b6a4f
      morrita@google.com authored
      .: Spell-checking doesn't recognize word boundaries on contests inserted by execCommand('insertHTML')
      https://bugs.webkit.org/show_bug.cgi?id=65902
      
      Reviewed by Ryosuke Niwa.
      
      Add export for window.internals object.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore: Spell-checking doesn't recognize word boundaries on contests inserted by execCommand('insertHTML')
      https://bugs.webkit.org/show_bug.cgi?id=65902
      
      Reviewed by Ryosuke Niwa.
      
      markMisspellingsAndBadGrammar() was using markSpelling() and markBadGrammar().
      But these are low-level API and caller should take care of word boundary.
      This change replaced these call with overloaded version of markMisspellingsAndBadGrammar(),
      which handles word boundary correctly.
      
      Test: editing/spelling/spelling-insert-html.html
      
      * WebCore.exp.in:
      * editing/Editor.cpp:
      (WebCore::Editor::markMisspellingsAndBadGrammar):
      * testing/Internals.cpp:
      (WebCore::Internals::markerCountOf): Added.
      (WebCore::Internals::markedRangeAt): Added.
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit2: Spell-checking against execCommand() inserted HTML doesn't care word boundary.
      https://bugs.webkit.org/show_bug.cgi?id=65902
      
      Reviewed by Ryosuke Niwa.
      
      Add exports for window.internals object.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests: Spell-checking doesn't recognize word boundaries on contests inserted by execCommand('insertHTML')
      https://bugs.webkit.org/show_bug.cgi?id=65902
      
      Reviewed by Ryosuke Niwa.
      
      Existing expectation was wrong because of some markers on substrings of words.
      With this fix, Editor now rejects such markers.
      
      * editing/spelling/spelling-insert-html-expected.txt: Added.
      * editing/spelling/spelling-insert-html.html: Added.
      * platform/mac/editing/pasteboard/merge-after-delete-1-expected.png:
      * platform/mac/editing/pasteboard/merge-after-delete-2-expected.png:
      * platform/mac/editing/pasteboard/merge-after-delete-expected.png:
      * platform/mac/editing/pasteboard/merge-end-blockquote-expected.png:
      * platform/mac/editing/pasteboard/merge-end-list-expected.png:
      * platform/mac/editing/pasteboard/merge-end-table-expected.png:
      * platform/mac/editing/pasteboard/paste-text-008-expected.png:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93392 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c74b6a4f
    • commit-queue@webkit.org's avatar
      Run-time error fix in WebKit-GTK with video support disabled. · 443ccb11
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66541
      
      Definition of the function extraFullScreenStyleSheet() in webkit-gtk
      lies outside ENABLE(VIDEO) guard, resulting in runtime error while
      trying to launch GtkLauncher with video support disabled.
      
      Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-08-19
      Reviewed by Philippe Normand.
      
      Run-time error fix. No test cases were added.
      
      * platform/gtk/RenderThemeGtk.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93391 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      443ccb11
    • commit-queue@webkit.org's avatar
      input[maxlength=0] should ignore text input. · 14426d87
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65497
      
      Patch by Shinya Kawanaka <shinyak@google.com> on 2011-08-19
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      Changed the valid range of maxlength.
      
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::parseMaxLengthAttribute):
        Changed maxlength check condition.
      
      LayoutTests:
      
      * fast/forms/input-text-paste-maxlength-expected.txt:
        Added a case that maxlength=0
      * fast/forms/input-text-paste-maxlength.html: ditto.
      * fast/forms/script-tests/textarea-maxlength.js: ditto.
      (createFocusedTextAreaWithMaxLength):
      * fast/forms/textarea-maxlength-expected.txt: ditto.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93390 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      14426d87
    • loislo@chromium.org's avatar
      Web Inspector: backend js api: an ability to skip optional arguments in the... · 3f1e785c
      loislo@chromium.org authored
      Web Inspector: backend js api: an ability to skip optional arguments in the middle of the argument list is required.
      https://bugs.webkit.org/show_bug.cgi?id=66482
      
      There are functions in the API with multiple optional arguments.
      When we call it we have to specify an optional argument as 'undefined' if we want to pass non default value for the next one.
      This can be solved with passing the arguments as an object.
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      * inspector/CodeGeneratorInspector.pm:
      * inspector/front-end/RemoteObject.js:
      
      LayoutTests:
      
      * inspector/debugger/debugger-set-breakpoint-regex.html:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93389 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3f1e785c
    • zoltan@webkit.org's avatar
      [Qt] Build fix after r93384. · 75112776
      zoltan@webkit.org authored
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::LineBreaker::nextLineBreak):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93388 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      75112776
    • commit-queue@webkit.org's avatar
      Computing screen-space transform for LayerChromium and CCLayerImpl · 17e2cb03
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66114
      
      Source/WebCore:
      
      Added a data member to LayerChromium and CCLayerImpl that holds
      the screen-space transform.   The transform is computed in
      calculateDrawTransformsAndVisibility(), which is used during
      updating (LayerChromium) and drawing (CCLayerImpl).
      
      Also fixed a FIXME in LayerRendererChromium::drawLayer, which
      was not computing the entire hierarchy of transforms to determine
      back-face visibility.  Now it simply uses the world space transform.
      
      Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-18
      Reviewed by James Robinson.
      
      Test: compositing/backface-visibility-hierarchical-transform.html
      
      * platform/graphics/chromium/LayerChromium.h:
      (WebCore::LayerChromium::screenSpaceTransform):
      (WebCore::LayerChromium::setScreenSpaceTransform):
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      (WebCore::LayerRendererChromium::updateLayers):
      (WebCore::LayerRendererChromium::drawLayersInternal):
      (WebCore::LayerRendererChromium::drawLayer):
      * platform/graphics/chromium/cc/CCLayerImpl.h:
      (WebCore::CCLayerImpl::screenSpaceTransform):
      (WebCore::CCLayerImpl::setScreenSpaceTransform):
      
      LayoutTests:
      
      This case tests if backface visibility properly accounts for a hierarchy
      of transforms.  In particular, this test forces Chromium to create a
      hierarchy of RenderSurfaces.
      
      Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-18
      Reviewed by James Robinson.
      
      * compositing/backface-visibility-hierarchical-transform-expected.png: Added.
      * compositing/backface-visibility-hierarchical-transform-expected.txt: Added.
      * compositing/backface-visibility-hierarchical-transform.html: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93387 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      17e2cb03
    • commit-queue@webkit.org's avatar
      [skia] -webkit-transform breaks -webkit-mask · b86a9ef3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66442
      
      Source/WebCore:
      
      The problem here is that in RenderBox::paintMaskImages, if we are in
      a transform with a rotation, scale or skew we set the composite mode to
      be DestinationIn and then create a transparency layer, then paint the
      mask with SourceOver and end the transparency layer. (The normal case
      is just to use DestinationIn to paint the mask.)
      
      In skia when we create transparency layers we don't pass on the composite
      mode, so when we end the transparency layer it is composited back using
      SourceOver. The fix is to pass on the composite mode when creating
      transparency layers in skia.
      
      Patch by Ben Wells <benwells@chromium.org> on 2011-08-18
      Reviewed by Stephen White.
      
      * platform/graphics/skia/GraphicsContextSkia.cpp:
      (WebCore::GraphicsContext::beginTransparencyLayer):
      * platform/graphics/skia/PlatformContextSkia.cpp:
      (WebCore::PlatformContextSkia::getXfermodeMode):
      * platform/graphics/skia/PlatformContextSkia.h:
      
      LayoutTests:
      
      Patch by Ben Wells <benwells@chromium.org> on 2011-08-18
      Reviewed by Stephen White.
      
      * platform/chromium-linux/fast/css/transformed-mask-expected.png: Added.
      * platform/chromium-linux/fast/css/transformed-mask-expected.txt: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93386 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b86a9ef3
    • hayato@chromium.org's avatar
      Isolate EventDispatchMediator into a separate file. · f4900654
      hayato@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66458
      
      Reviewed by Ryosuke Niwa.
      
      Extracted EventDispatchMediator.h and EventDispatchMediator.cpp
      out of Event.h and Event.cpp Also moved FocusEventDispatchMediator
      and BlurEventDispatchMediator from Event.{h|cpp} to
      EventDispatchMediator.{h|cpp}.
      
      No new tests since this is just refactoring.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * dom/Event.cpp:
      * dom/Event.h:
      * dom/EventDispatchMediator.cpp: Added.
      (WebCore::EventDispatchMediator::create):
      (WebCore::EventDispatchMediator::EventDispatchMediator):
      (WebCore::EventDispatchMediator::dispatchEvent):
      (WebCore::FocusEventDispatchMediator::create):
      (WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
      (WebCore::FocusEventDispatchMediator::dispatchEvent):
      (WebCore::BlurEventDispatchMediator::create):
      (WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
      (WebCore::BlurEventDispatchMediator::dispatchEvent):
      * dom/EventDispatchMediator.h: Added.
      (WebCore::EventDispatchMediator::~EventDispatchMediator):
      (WebCore::EventDispatchMediator::event):
      (WebCore::EventDispatchMediator::EventDispatchMediator):
      (WebCore::EventDispatchMediator::setEvent):
      * dom/EventDispatcher.cpp:
      * dom/KeyboardEvent.h:
      * dom/MouseEvent.h:
      * dom/Node.cpp:
      * dom/ScopedEventQueue.cpp:
      * dom/UIEvent.h:
      * dom/WheelEvent.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93385 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f4900654
    • mitz@apple.com's avatar
      Mid-word break can occur between a character and a combining mark · ea4fd385
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=66529
      
      Reviewed by Simon Fraser.
      
      No test added because I could not find a combining mark with a non-zero advance in
      any of the system fonts and tests fonts. 
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::LineBreaker::nextLineBreak): Disallow a mid-word break before a
      combining mark.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93384 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ea4fd385
    • dpranke@chromium.org's avatar
      new-run-webkit-tests hung while acquiring http lock on snow leopard bots · 8af72e09
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64886
      
      Temporarily disable the http locking to work around the issue.
      I'm not actually sure if this is going to work or improve things
      much.
      
      Reviewed by Ryosuke Niwa.
      
      * Scripts/webkitpy/layout_tests/port/mac.py:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93383 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8af72e09
    • tkent@chromium.org's avatar
      REGRESSION(r90971): Null pointer dereference with placeholder and webkit-scrollbar-corner · 6b9574f6
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66453
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      Test: fast/forms/placeholder-crash-with-scrollbar-corner.html
      
      * rendering/RenderObjectChildList.cpp:
      (WebCore::RenderObjectChildList::removeChildNode): Add a NULL check for owner's layer.
      
      LayoutTests:
      
      * fast/forms/placeholder-crash-with-scrollbar-corner-expected.txt: Added.
      * fast/forms/placeholder-crash-with-scrollbar-corner.html: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93382 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6b9574f6
    • koz@chromium.org's avatar
      Chromium plumbing for webkitRequestFullScreen · 49f6dd83
      koz@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66031
      
      Reviewed by Darin Fisher.
      
      * public/WebView.h:
      * public/WebViewClient.h:
      (WebKit::WebViewClient::enterFullscreenForElement):
      (WebKit::WebViewClient::exitFullscreenForElement):
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::enterFullScreenForElement):
      (WebKit::ChromeClientImpl::exitFullScreenForElement):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::exitFullscreen):
      * src/WebViewImpl.h:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93381 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      49f6dd83
    • jpfau@apple.com's avatar
      New XML parser: scripting support · f1856470
      jpfau@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=66406
      
      Reviewed by Adam Barth.
      
      * xml/parser/NewXMLDocumentParser.cpp:
      (WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
      (WebCore::NewXMLDocumentParser::resumeParsing):
      (WebCore::NewXMLDocumentParser::processScript):
      (WebCore::NewXMLDocumentParser::append): Add support for pausing the parsing
      (WebCore::NewXMLDocumentParser::finish): Add support for pausing the parsing
      (WebCore::NewXMLDocumentParser::notifyFinished):
      * xml/parser/NewXMLDocumentParser.h:
      (WebCore::NewXMLDocumentParser::pauseParsing):
      * xml/parser/XMLTreeBuilder.cpp: Add a shared function between self-closing and end tags
      (WebCore::XMLTreeBuilder::closeElement): Registers scripts and pops the stack
      (WebCore::XMLTreeBuilder::processStartTag):
      (WebCore::XMLTreeBuilder::processEndTag):
      * xml/parser/XMLTreeBuilder.h:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93380 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f1856470
    • ryuan.choi@samsung.com's avatar
      [EFL] Broken rendering occured when resized in ewk_view_single. · 1196fdfc
      ryuan.choi@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=66271
      
      Force rendering when ewk_view resized.
      It's because Evas_Object doesn't generate any rendering request although
      it was changed.
      
      Reviewed by Tony Chang.
      
      * ewk/ewk_view.cpp:
      (_ewk_view_smart_calculate):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93379 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1196fdfc
    • commit-queue@webkit.org's avatar
      Move allocation in constructors into separate constructorBody() methods · 82d6b809
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66265
      
      Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-18
      Reviewed by Oliver Hunt.
      
      Source/JavaScriptCore:
      
      Refactoring to put all allocations that need to be done after the object's
      initialization list has executed but before the object is ready for use
      into a separate constructorBody() method.  This method is still called by the constructor,
      so the patch doesn't resolve any potential issues, it's just to set up the code for further refactoring.
      
      * JavaScriptCore.exp:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * jsc.cpp:
      (GlobalObject::constructorBody):
      (GlobalObject::GlobalObject):
      * runtime/ErrorInstance.cpp:
      (JSC::ErrorInstance::ErrorInstance):
      * runtime/ErrorInstance.h:
      (JSC::ErrorInstance::constructorBody):
      * runtime/ErrorPrototype.cpp:
      (JSC::ErrorPrototype::ErrorPrototype):
      (JSC::ErrorPrototype::constructorBody):
      * runtime/ErrorPrototype.h:
      * runtime/Executable.cpp:
      (JSC::FunctionExecutable::FunctionExecutable):
      * runtime/Executable.h:
      (JSC::FunctionExecutable::constructorBody):
      * runtime/InternalFunction.cpp:
      (JSC::InternalFunction::InternalFunction):
      * runtime/InternalFunction.h:
      (JSC::InternalFunction::constructorBody):
      * runtime/JSByteArray.cpp:
      (JSC::JSByteArray::JSByteArray):
      * runtime/JSByteArray.h:
      (JSC::JSByteArray::constructorBody):
      * runtime/JSFunction.cpp:
      (JSC::JSFunction::JSFunction):
      (JSC::JSFunction::constructorBody):
      * runtime/JSFunction.h:
      * runtime/JSGlobalObject.h:
      (JSC::JSGlobalObject::JSGlobalObject):
      (JSC::JSGlobalObject::constructorBody):
      * runtime/JSPropertyNameIterator.cpp:
      (JSC::JSPropertyNameIterator::JSPropertyNameIterator):
      * runtime/JSPropertyNameIterator.h:
      (JSC::JSPropertyNameIterator::constructorBody):
      * runtime/JSString.h:
      (JSC::RopeBuilder::JSString):
      (JSC::RopeBuilder::constructorBody):
      * runtime/NativeErrorConstructor.cpp:
      (JSC::NativeErrorConstructor::NativeErrorConstructor):
      * runtime/NativeErrorConstructor.h:
      (JSC::NativeErrorConstructor::constructorBody):
      * runtime/NativeErrorPrototype.cpp:
      (JSC::NativeErrorPrototype::NativeErrorPrototype):
      (JSC::NativeErrorPrototype::constructorBody):
      * runtime/NativeErrorPrototype.h:
      * runtime/StringObject.cpp:
      * runtime/StringObject.h:
      (JSC::StringObject::create):
      * runtime/StringObjectThatMasqueradesAsUndefined.h:
      (JSC::StringObjectThatMasqueradesAsUndefined::create):
      (JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
      * runtime/StringPrototype.cpp:
      (JSC::StringPrototype::StringPrototype):
      * runtime/StringPrototype.h:
      (JSC::StringPrototype::create):
      
      Source/WebCore:
      
      No new tests.
      
      Refactoring to put all allocations that need to be done after the object's
      initialization list has executed but before the object is ready for use
      into a separate constructorBody() method.  This method is still called by the constructor,
      so the patch doesn't resolve any potential issues, it's just to set up the code for further refactoring.
      
      * bridge/objc/ObjCRuntimeObject.h:
      (JSC::Bindings::ObjCRuntimeObject::create):
      * bridge/objc/ObjCRuntimeObject.mm:
      * bridge/objc/objc_instance.mm:
      (ObjCRuntimeMethod::create):
      (ObjCRuntimeMethod::ObjCRuntimeMethod):
      * bridge/runtime_array.cpp:
      * bridge/runtime_array.h:
      (JSC::RuntimeArray::create):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93378 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      82d6b809
    • bdakin@apple.com's avatar
      Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=66495 · b7dfd27f
      bdakin@apple.com authored
      Lion-specific scroller SPIs can use forward declaration instead of 
      WebKitSystemInterface
      
      Reviewed by Sam Weinig.
      
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      * platform/mac/NSScrollerImpDetails.h: Added.
      * platform/mac/ScrollAnimatorMac.h:
      * platform/mac/ScrollAnimatorMac.mm:
      (-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
      (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
      (-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):
      (-[ScrollbarPartAnimation setCurrentProgress:]):
      (-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
      (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
      (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
      (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
      (WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
      (WebCore::ScrollAnimatorMac::notifyPositionChanged):
      (WebCore::ScrollAnimatorMac::contentAreaWillPaint):
      (WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
      (WebCore::ScrollAnimatorMac::mouseExitedContentArea):
      (WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
      (WebCore::ScrollAnimatorMac::willStartLiveResize):
      (WebCore::ScrollAnimatorMac::contentsResized):
      (WebCore::ScrollAnimatorMac::willEndLiveResize):
      (WebCore::ScrollAnimatorMac::contentAreaDidShow):
      (WebCore::ScrollAnimatorMac::contentAreaDidHide):
      (WebCore::ScrollAnimatorMac::didBeginScrollGesture):
      (WebCore::ScrollAnimatorMac::didEndScrollGesture):
      (WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
      (WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
      (WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
      (WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
      (WebCore::ScrollAnimatorMac::updateScrollerStyle):
      (WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):
      * platform/mac/ScrollbarThemeMac.h:
      * platform/mac/ScrollbarThemeMac.mm:
      (WebCore::ScrollbarThemeMac::registerScrollbar):
      (WebCore::ScrollbarThemeMac::scrollbarThickness):
      (WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
      (WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
      (WebCore::ScrollbarThemeMac::hasThumb):
      (WebCore::ScrollbarThemeMac::minimumThumbLength):
      (WebCore::ScrollbarThemeMac::updateEnabledState):
      (WebCore::scrollbarPainterPaint):
      (WebCore::ScrollbarThemeMac::paint):
      * platform/mac/WebCoreSystemInterface.h:
      * platform/mac/WebCoreSystemInterface.mm:
      
      Source/WebKit/mac: Reviewed by Sam Weinig.
      
      https://bugs.webkit.org/show_bug.cgi?id=66495
      Lion-specific scroller SPIs can use forward declaration instead of 
      WebKitSystemInterface
      
      * WebCoreSupport/WebSystemInterface.mm:
      (InitWebCoreSystemInterface):
      
      Source/WebKit2: Reviewed by Sam Weinig.
      
      https://bugs.webkit.org/show_bug.cgi?id=66495
      Lion-specific scroller SPIs can use forward declaration instead of 
      WebKitSystemInterface
      
      * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
      (InitWebCoreSystemInterface):
      
      WebKitLibraries: Reviewed by Sam Weinig.
      
      https://bugs.webkit.org/show_bug.cgi?id=66495
      Lion-specific scroller SPIs can use forward declaration instead of 
      WebKitSystemInterface
      
      * WebKitSystemInterface.h:
      * libWebKitSystemInterfaceLeopard.a:
      * libWebKitSystemInterfaceLion.a:
      * libWebKitSystemInterfaceSnowLeopard.a:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93377 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b7dfd27f
    • mitz@apple.com's avatar
      <rdar://problem/9973194> Fonts that specify a positive descender value are... · 37c8a29f
      mitz@apple.com authored
      <rdar://problem/9973194> Fonts that specify a positive descender value are treated as having descenders ending above the baseline
      https://bugs.webkit.org/show_bug.cgi?id=66515
      
      Reviewed by Darin Adler.
      
      No test because none of the system fonts and test fonts have an incorrectly-specified descender value.
      
      * platform/graphics/mac/SimpleFontDataMac.mm:
      (WebCore::SimpleFontData::platformInit): If the font specifies a positive descender, assume that it meant
      the same amount, but negative. This is consistent with what Core Text does.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93376 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      37c8a29f
    • fpizlo@apple.com's avatar
      DFG non-speculative JIT does not inline the double case of ValueAdd · b97c605f
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=66025
      
      Reviewed by Gavin Barraclough.
              
      This is a 1.3% win on Kraken overall, with >=8% speed-ups on a few
      benchmarks (imaging-darkroom, stanford-crypto-pbkdf2,
      stanford-crypto-sha256-iterative).  It looks like it might have
      a speed-up in SunSpider (though not statistically significant or
      particularly reproducible) and a slight slow-down in V8 (0.14%,
      not statistically significant).  It does slow down v8-crypto by
      1.5%.
      
      * dfg/DFGJITCodeGenerator.cpp:
      (JSC::DFG::JITCodeGenerator::isKnownInteger):
      (JSC::DFG::JITCodeGenerator::isKnownNumeric):
      * dfg/DFGNonSpeculativeJIT.cpp:
      (JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
      (JSC::DFG::NonSpeculativeJIT::basicArithOp):
      * dfg/DFGOperations.cpp:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93375 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b97c605f
    • tony@chromium.org's avatar
      [chromium] Fix results. Just copy over the platform independent results. · 30dcc839
      tony@chromium.org authored
      * platform/chromium/fast/frames/frame-set-scaling-rotate-expected.png:
      * platform/chromium/fast/frames/frame-set-scaling-skew-expected.png:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93374 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      30dcc839
  2. 18 Aug, 2011 13 commits
    • fsamuel@chromium.org's avatar
      Added Frame Set Scaling Test Results for WebKit1 Mac and WebKit2 Mac · 66437542
      fsamuel@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66493
      
      The expected results of the layout tests written for
      https://bugs.webkit.org/show_bug.cgi?id=57785
      differ between WebKitt Mac and WebKit2 Mac.
      
      WebKit2 Mac matches the cross-platform results.
      WebKit1 Mac has a special set of test results.
      
      Reviewed by Tony Chang.
      
      * platform/chromium/fast/frames/frame-set-scaling-3d-expected.png: Added.
      * platform/chromium/fast/frames/frame-set-scaling-3d-expected.txt: Added.
      * platform/chromium/fast/frames/frame-set-scaling-centered-expected.png: Added.
      * platform/chromium/fast/frames/frame-set-scaling-centered-expected.txt: Added.
      * platform/chromium/fast/frames/frame-set-scaling-expected.png: Added.
      * platform/chromium/fast/frames/frame-set-scaling-expected.txt: Added.
      * platform/chromium/fast/frames/frame-set-scaling-rotate-expected.png: Added.
      * platform/chromium/fast/frames/frame-set-scaling-rotate-expected.txt: Added.
      * platform/chromium/fast/frames/frame-set-scaling-skew-expected.png: Added.
      * platform/chromium/fast/frames/frame-set-scaling-skew-expected.txt: Added.
      * platform/mac-wk2/fast/frames/frame-set-scaling-3d-expected.png: Added.
      * platform/mac-wk2/fast/frames/frame-set-scaling-centered-expected.png: Added.
      * platform/mac-wk2/fast/frames/frame-set-scaling-expected.png: Added.
      * platform/mac-wk2/fast/frames/frame-set-scaling-rotate-expected.png: Added.
      * platform/mac-wk2/fast/frames/frame-set-scaling-skew-expected.png: Added.
      * platform/mac/fast/frames/frame-set-scaling-3d-expected.png: Added.
      * platform/mac/fast/frames/frame-set-scaling-centered-expected.png: Added.
      * platform/mac/fast/frames/frame-set-scaling-expected.png: Added.
      * platform/mac/fast/frames/frame-set-scaling-rotate-expected.png: Added.
      * platform/mac/fast/frames/frame-set-scaling-skew-expected.png: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93371 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      66437542
    • tony@chromium.org's avatar
      [chromium] Mark editing/selection/regional-indicators.html as timing · 3f1148e1
      tony@chromium.org authored
      out on Linux debug and rebaseline 2 tests.
      
      * platform/chromium-win/fast/frames/frame-set-scaling-rotate-expected.png: Added.
      * platform/chromium-win/fast/frames/frame-set-scaling-skew-expected.png: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93370 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3f1148e1
    • rniwa@webkit.org's avatar
      positionForPoint returns wrong VisiblePosition at bidi boundaries · 594cc6ed
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65356
      
      Reviewed by David Hyatt.
      
      Source/WebCore: 
      
      The bug was caused by RenderText::positionForPoint's assuming that the position will always reside
      inside the inline box that contains the point, which is not true at the boundaries of bidi-runs.
      
      For example, in aDC12BAb where AB12CD is a RTL text, the offset on the right of A is 7 even though
      the inline box for "BA" only contains offsets 1, 2, and 3. We must traverse the bidi-run "DC12BA"
      until the end to obtain the offset 7 from the inline box for "DC".
      
      Fixed the bug by introducing createVisiblePositionAfterAdjustingOffsetForBiDi which traverses runs
      on the left or the right of the position to compute the appropriate offset following the NSTextView convention.
      
      This patch also fixes a regression from r74971 that caret is placed incorrectly between inline boxes of
      LTR or RTL text in a RTL or LTR block respectively.
      
      Test: editing/selection/caret-at-bidi-boundary.html
      
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::offsetForPosition):
      * rendering/RenderText.cpp:
      (WebCore::lineDirectionPointFitsInBox): Takes ShouldAffinityBeDownstream instead of EAfinity.
      (WebCore::createVisiblePositionForBox):
      (WebCore::createVisiblePositionAfterAdjustingOffsetForBiDi):
      (WebCore::RenderText::positionForPoint):
      
      LayoutTests: 
      
      * editing/selection/caret-at-bidi-boundary-expected.txt: Added.
      * editing/selection/caret-at-bidi-boundary.html: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93369 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      594cc6ed
    • xji@chromium.org's avatar
      --webkit-visual-word renaming right/leftWordPositionAcrossBoundary · 01d748d0
      xji@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66436
      
      Reviewed by Ryosuke Niwa.
      
      Rename them to right/leftWordPositionIgnoringEditingBoundary.
      
      * editing/visible_units.cpp:
      (WebCore::leftWordPositionIgnoringEditingBoundary):
      (WebCore::rightWordPositionIgnoringEditingBoundary):
      (WebCore::leftWordPosition):
      (WebCore::rightWordPosition):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93368 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      01d748d0
    • crogers@google.com's avatar
      Implement WebMediaPlayerClientImpl::audioSourceProvider() and interface into chromium · 5189b4c7
      crogers@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=66441
      
      Reviewed by Darin Fisher.
      
      * public/WebAudioSourceProvider.h: Added.
      (WebKit::WebAudioSourceProvider::~WebAudioSourceProvider):
      * public/WebMediaPlayer.h:
      (WebKit::WebMediaPlayer::audioSourceProvider):
      * src/WebMediaPlayerClientImpl.cpp:
      (WebKit::WebMediaPlayerClientImpl::audioSourceProvider):
      (WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::provideInput):
      * src/WebMediaPlayerClientImpl.h:
      (WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::AudioSourceProviderImpl):
      (WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::~AudioSourceProviderImpl):
      (WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::initialize):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93367 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5189b4c7
    • jeffm@apple.com's avatar
      Soft link against AVFoundationCF and CoreMedia · 0829d2de
      jeffm@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=65725
              
      Add new macros to SoftLinking.h to support soft-linking to functions and variables decorated with __declspec(dllimport),
      and use them to soft-link to AVFoundationCF and CoreMedia. I verified that the WebProcess doesn't load these DLLs
      until a media element is used.
      
      Reviewed by Eric Carlson.
      
      No new tests as no change in functionality.
      
      * WebCore.vcproj/WebCore.vcproj: Added AVFoundationCFSoftLinking.h and CoreMediaSoftLinking.h.
      * WebCore.vcproj/WebCoreMediaQT.vsprops: Removed DelayLoadDLLs linker option which is no longer needed.
      * platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Added.
      * platform/graphics/avfoundation/cf/CoreMediaSoftLinking.h: Added.
      * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Stop linking against AVFoundationCF.lib and CoreMedia.lib and include AVFoundationCFSoftLinking.h and CoreMediaSoftLinking.h.
      * platform/win/SoftLinking.h: Added SOFT_LINK_DLL_IMPORT() and SOFT_LINK_VARIABLE_DLL_IMPORT() macros.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93363 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0829d2de
    • commit-queue@webkit.org's avatar
      Chromium Mac: Show scrollbar when doing search · 41584597
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66209
      
      Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-18
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Updated the Lion scrollbar drawing code to force the scrollbar to be visible when we have tickmarks for search results.
      
      No tests because there are no Mac 10.7 chromium bots yet.
      
      * platform/chromium/ScrollbarThemeChromiumMac.h:
      * platform/chromium/ScrollbarThemeChromiumMac.mm:
      (WebCore::ScrollbarThemeChromiumMac::paint):
      (WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
      
      Source/WebKit/chromium:
      
      Fixed a bug in invalidateArea where it wouldn't properly invalidate overlay scrollbars. The problem was that it was assuming that the scrollbar was always to the right of the visible scrollbar. This isn't true for overlay scrollbars.
      
      No tests because there are no Mac 10.7 chromium bots yet.
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::invalidateArea):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93361 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      41584597
    • commit-queue@webkit.org's avatar
      [chromium] Draw the root/"non-composited content" in compositor side · c4ebf0d0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=58834
      
      Patch by James Robinson <jamesr@chromium.org> on 2011-08-18
      Reviewed by Kenneth Russell.
      
      Source/WebCore:
      
      Handle the root or non-composited content with a GraphicsLayer rather than special case logic in
      LayerRendererChromium. This layer's client is the NonCompositedContentHost, which routes the paint callbacks
      through the LayerPainterChromium interface out to the WebView.  The root layer is special in two ways:
      *) The root layer has a scroll offset, which changes how the visibleLayerRect maps to content space and applies a
          draw-time transform.
      *) The root layer masks the alpha channel and disable blending when drawing because of concerns about subpixel
          AA trashing the alpha channel.  The root layer is always opaque so this is fine.
      *) The root layer does not have border texels and does have subpixel AA for text.
      
      Covered by compositing/
      
      * WebCore.gypi:
      * platform/graphics/chromium/ContentLayerChromium.cpp:
      (WebCore::ContentLayerChromium::paintContentsIfDirty):
      * platform/graphics/chromium/ImageLayerChromium.cpp:
      (WebCore::ImageLayerChromium::paintContentsIfDirty):
      * platform/graphics/chromium/LayerChromium.cpp:
      (WebCore::LayerChromium::pushPropertiesTo):
      * platform/graphics/chromium/LayerChromium.h:
      (WebCore::LayerChromium::scrollPosition):
      (WebCore::LayerChromium::setScrollPosition):
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      (WebCore::LayerRendererChromium::initialize):
      (WebCore::LayerRendererChromium::releaseTextures):
      (WebCore::LayerRendererChromium::viewportChanged):
      (WebCore::LayerRendererChromium::updateLayers):
      (WebCore::LayerRendererChromium::drawLayers):
      (WebCore::LayerRendererChromium::drawLayersInternal):
      (WebCore::LayerRendererChromium::getFramebufferPixels):
      (WebCore::LayerRendererChromium::cleanupSharedObjects):
      (WebCore::LayerRendererChromium::layerTreeAsText):
      * platform/graphics/chromium/LayerRendererChromium.h:
      (WebCore::LayerRendererChromium::rootLayer):
      (WebCore::LayerRendererChromium::viewportSize):
      (WebCore::LayerRendererChromium::viewportWidth):
      (WebCore::LayerRendererChromium::viewportHeight):
      * platform/graphics/chromium/NonCompositedContentHost.cpp: Added.
      (WebCore::NonCompositedContentHost::NonCompositedContentHost):
      (WebCore::NonCompositedContentHost::~NonCompositedContentHost):
      (WebCore::NonCompositedContentHost::invalidateRect):
      (WebCore::NonCompositedContentHost::invalidateEntireLayer):
      (WebCore::NonCompositedContentHost::setScrollPosition):
      (WebCore::NonCompositedContentHost::notifyAnimationStarted):
      (WebCore::NonCompositedContentHost::notifySyncRequired):
      (WebCore::NonCompositedContentHost::paintContents):
      (WebCore::NonCompositedContentHost::showDebugBorders):
      (WebCore::NonCompositedContentHost::showRepaintCounter):
      * platform/graphics/chromium/NonCompositedContentHost.h: Added.
      (WebCore::NonCompositedContentHost::create):
      (WebCore::NonCompositedContentHost::graphicsLayer):
      * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
      (WebCore::CCHeadsUpDisplay::draw):
      * platform/graphics/chromium/cc/CCLayerImpl.h:
      (WebCore::CCLayerImpl::scrollPosition):
      (WebCore::CCLayerImpl::setScrollPosition):
      * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
      (WebCore::CCLayerTreeHost::CCLayerTreeHost):
      (WebCore::CCLayerTreeHost::initialize):
      (WebCore::CCLayerTreeHost::invalidateRootLayerRect):
      (WebCore::CCLayerTreeHost::setRootLayer):
      (WebCore::CCLayerTreeHost::setViewport):
      (WebCore::CCLayerTreeHost::reallocateRenderer):
      * platform/graphics/chromium/cc/CCLayerTreeHost.h:
      (WebCore::CCLayerTreeHost::rootLayer):
      (WebCore::CCLayerTreeHost::viewportSize):
      
      Source/WebKit/chromium:
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::paint):
      (WebKit::WebViewImpl::setRootGraphicsLayer):
      (WebKit::WebViewImpl::didRecreateGraphicsContext):
      (WebKit::WebViewImpl::updateLayerTreeViewport):
      * src/WebViewImpl.h:
      
      LayoutTests:
      
      Update pixel baselines that changes due to subtle blending
      differences, primarily on scrollbars. I don't know why these keep
      changing.
      
      * compositing/checkerboard-expected.png:
      * platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
      * platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
      * platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
      * platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
      * platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
      * platform/chromium-gpu-linux/compositing/images/direct-image-background-color-expected.png:
      * platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
      * platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
      * platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
      * platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png:
      * platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
      * platform/chromium-gpu-linux/compositing/webgl/webgl-background-color-expected.png:
      * platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
      * platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
      * platform/chromium-gpu-linux/media/video-zoom-expected.png:
      * platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93360 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c4ebf0d0
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r93354. · 3ad887e7
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/93354
      https://bugs.webkit.org/show_bug.cgi?id=66503
      
      "consensus was not reached" (Requested by senorblanco on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-18
      
      Source/WebCore:
      
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::drawImage):
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::GraphicsContext::drawNativeImage):
      
      LayoutTests:
      
      * fast/canvas/drawImage-clipped-source-expected.txt: Removed.
      * fast/canvas/drawImage-clipped-source.html: Removed.
      * fast/canvas/drawImage-clipped-source.js: Removed.
      * fast/canvas/drawImage-with-invalid-args-expected.txt:
      * fast/canvas/drawImage-with-invalid-args.html:
      * platform/chromium/test_expectations.txt:
      * platform/mac/Skipped:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93359 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3ad887e7
    • commit-queue@webkit.org's avatar
      GestureRecognizer: Update how gesture-scroll works. · 9c38b572
      commit-queue@webkit.org authored
      Source/WebCore:
      
      Instead of just sending a series of 'GestureUpdate' events, send a
      single 'GestureBegin' event, followed by a series of 'GestureUpdate' events,
      and end with a 'GestureEnd' event.
      https://bugs.webkit.org/show_bug.cgi?id=66267
      
      Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-18
      Reviewed by Adam Barth.
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleGestureEvent):
      * platform/chromium/GestureRecognizerChromium.cpp:
      (WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
      (WebCore::InnerGestureRecognizer::appendScrollGestureBegin):
      (WebCore::InnerGestureRecognizer::appendScrollGestureEnd):
      (WebCore::InnerGestureRecognizer::appendScrollGestureUpdate):
      (WebCore::scrollEnd):
      (WebCore::isClickOrScroll):
      (WebCore::inScroll):
      * platform/chromium/GestureRecognizerChromium.h:
      (WebCore::InnerGestureRecognizer::firstTouchPosition):
      
      Source/WebKit/chromium:
      
      Add a unit-test to make sure the correct gesture events are being
      generated.
      https://bugs.webkit.org/show_bug.cgi?id=66267
      
      Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-18
      Reviewed by Adam Barth.
      
      * tests/InnerGestureRecognizerTest.cpp:
      (WebCore::BuildablePlatformTouchPoint::BuildablePlatformTouchPoint):
      (WebCore::BuildablePlatformTouchEvent::BuildablePlatformTouchEvent):
      (WebCore::TEST_F):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93358 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9c38b572
    • rniwa@webkit.org's avatar
      Fix r93349. · 54b825a5
      rniwa@webkit.org authored
      * platform/gtk/Skipped:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93357 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      54b825a5
    • commit-queue@webkit.org's avatar
      Chromium: Update forked ScrollbarThemeChromiumMac.mm · 7420c701
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65555
      
      Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-18
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Merge recent changes to ScrollbarThemeMac.mm to ScrollbarThemeChromiumMac.mm.
      
      * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
      * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
      (wkScrollbarPainterSetEnabled):
      * platform/chromium/ScrollbarThemeChromiumMac.h:
      (WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):
      * platform/chromium/ScrollbarThemeChromiumMac.mm:
      (WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
      (WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
      (WebCore::toScrollbarPainterKnobStyle):
      (WebCore::ScrollbarThemeChromiumMac::updateScrollbarOverlayStyle):
      (WebCore::ScrollbarThemeChromiumMac::updateEnabledState):
      (WebCore::ScrollbarThemeChromiumMac::paint):
      
      LayoutTests:
      
      Removing the chromium-cg-mac version of the expectation file since it now matches the mac one.
      
      * platform/chromium-cg-mac/fast/events/scrollbar-double-click-expected.txt: Removed.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93356 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7420c701
    • tony@chromium.org's avatar
      add embedded png checksums to WebKitTestRunner · 78ae5ce4
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66494
      
      Looks like WebKitTestRunner has never supported embedded checksums.  This copies
      some code from DRT and adds it to the WebKitTestRunner.
      
      Reviewed by Darin Adler.
      
      * WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
      * WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
      * WebKitTestRunner/GNUmakefile.am: Add new files
      * WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
      * WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
      * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
      * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
      (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
      (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
      * WebKitTestRunner/cg/TestInvocationCG.cpp:
      (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
      (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
      * WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93355 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      78ae5ce4