GitLab

OLD:
It looks like you've moved.  Would you like to use http://www.google.de/?  [Yes] [No]

NEW:
Would you like to search with google.de instead of google.fr? [Switch to google.de] [Keep using google.fr] _Learn more_

BUG=85671
TEST=none
Review URL: http://codereview.chromium.org/7578015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95885 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91896
TEST=trybots

Review URL: http://codereview.chromium.org/7584033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95884 0039d316-1c4b-4281-b951-d872f2087c98

Landing this change for rogerm@chromium.org, original review at http://codereview.chromium.org/7541080/.

BUG=None
TEST=Incremental linking works again.
Review URL: http://codereview.chromium.org/7106002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95878 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95876 0039d316-1c4b-4281-b951-d872f2087c98

We were not waiting for the file manager extension to initialize its
Web Worker process before starting the test, which lead to occasional
crashes if the test completed before the init was done.

BUG=chromium:89733
TEST=browser_tests --gtest_filter=FileManagerDialogTest.* --gtest_repeat=10 --gtest_shuffle

Review URL: http://codereview.chromium.org/7528003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95875 0039d316-1c4b-4281-b951-d872f2087c98

Whitespace change: http://codereview.chromium.org/7600002

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/7600001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95874 0039d316-1c4b-4281-b951-d872f2087c98

This brings us closer to the most-recent UX request that
I've seen:

- muting displays the previous volume level in a disabled
  state rather than displaying 0%
- volume down while muted drops the level to 0%
- volume up while muted unmutes and raises the level to 25%
  if it was 0% or restores the previous level otherwise

The requested behavior is actually to swell to the louder
volume over three seconds in the volume-up-while-muted case
instead of doing it instantly, but the mixer code doesn't
support that at present, so I'm punting on it for now.

BUG=chromium-os:8473,chromium-os:13618
TEST=manual

Review URL: http://codereview.chromium.org/7566018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95873 0039d316-1c4b-4281-b951-d872f2087c98

This avoids having a nested class Observer in PersonalDataManager.

BUG=None
TEST=None

R=jhawkins@chromium.org

Review URL: http://codereview.chromium.org/7541065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95871 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95870 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
Review URL: http://codereview.chromium.org/7558005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95869 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7599006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95866 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91873
TEST=none

Review URL: http://codereview.chromium.org/7585020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95865 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95863 0039d316-1c4b-4281-b951-d872f2087c98

The sync integration tests currently use a class hierarchy where the test classes for each datatype are subclasses of LiveSyncTest. While this design worked in the past, it allows tests to work with only one datatype at a time, and therefore doesn't allow us to test the interplay between datatypes.

This patch is another in the series of patches that will move away from an inheritance model to one where test cases can operate on more than one datatype. It updates the Typed Urls datatype to the new model, and contains the following changes:

- LiveTypedUrlsSyncTest is no longer a class that inherits from LiveSyncTest, but is now a namespace called typed_urls_helper, and contains a bunch of methods that perform various operations related to Typed Urls.
- SingleClientLiveTypedUrlsSyncTest is renamed to SingleClientTypedUrlsSyncTest, and is a subclass of LiveSyncTest. It uses the methods in namespace typed_urls_helper by including its header file and attaching itself to the helper.

In addition, bookmarks, preferences and autofill helpers and the SyncDatatypeHelper were originally implemented as static classes. Based on the code review feedback in this patch, they have been modified to the "functions-in-a-namespace" model similar to typed urls. This patch consists of those changes too.

BUG=88510
TEST=sync_integration_tests, sync_performance_tests

Review URL: http://codereview.chromium.org/7461109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95862 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=andreip
Review URL: http://codereview.chromium.org/7526004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95861 0039d316-1c4b-4281-b951-d872f2087c98

This is so that long running tests don't flakily bump into the
timeout every now and then.

BUG=none
TEST=none
TBR=phajdan.jr

Review URL: http://codereview.chromium.org/7595008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95860 0039d316-1c4b-4281-b951-d872f2087c98

This fixes some bugs where we forgot to issue completion callbacks in some
error cases in the proxy, and cleans up the cases that were already doing this
properly.

This removes the PPB_AudioTrusted_API and folds those functions into the
regular Audio API. I'm trying to merge more things to have a smaller explosion
of APIs and the boilerplate associated with them.
Original review URL: http://codereview.chromium.org/7551032
Review URL: http://codereview.chromium.org/7585025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95859 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91760
TEST=Manual

Review URL: http://codereview.chromium.org/7566051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95858 0039d316-1c4b-4281-b951-d872f2087c98

ovda: fix the build break

Fixing the build break.

BUG=NONE
TEST=omx_video_decode_accelerator_unittest

Review URL: http://codereview.chromium.org/7583033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95857 0039d316-1c4b-4281-b951-d872f2087c98

You can now:
- drag a most visited tile onto an apps page to get an app for it
- drag a most visited tile onto the trash (cool animations)
- blacklisting a most visited tile with the [x] looks better
- you don't see the trash icon show up for things that can't be trashed (as opposed to being able to drag onto trash but having it do nothing)

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/7592001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95856 0039d316-1c4b-4281-b951-d872f2087c98

This declaration exists in the header, but it has no definition
nor callers.

Review URL: http://codereview.chromium.org/7583039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95855 0039d316-1c4b-4281-b951-d872f2087c98

As far as I can tell this code is unreferenced in the Chrome tree,
and dates back to the initial commit.

Review URL: http://codereview.chromium.org/7491100

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95854 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23581

Review URL: http://codereview.chromium.org/7583038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95852 0039d316-1c4b-4281-b951-d872f2087c98

download_manager_ can non-null if SavePackage is created and destroyed without Init() being called.
This CHECK was originally introduced when SavePackage was an observer of the DownloadManager.

BUG=91884
TEST=NONE
Review URL: http://codereview.chromium.org/7599001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95851 0039d316-1c4b-4281-b951-d872f2087c98

Since print-preview uses an object tag, relax the object-src restriction in
the content_security_policy.html file.  Also fix typo in print_preview.html
where the object tag has a src="", not a data="" attribute.
Review URL: http://codereview.chromium.org/7566049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95850 0039d316-1c4b-4281-b951-d872f2087c98

Types" section.

BUG=91658
TEST=manual


Review URL: http://codereview.chromium.org/7583023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95848 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none.
TEST=none.


Review URL: http://codereview.chromium.org/7491090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95847 0039d316-1c4b-4281-b951-d872f2087c98

TBR=fischman@chromium.org
Review URL: http://codereview.chromium.org/7601002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95846 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=89279
Review URL: http://codereview.chromium.org/7576027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95845 0039d316-1c4b-4281-b951-d872f2087c98

- Start/Finish page was missing.
- transform was off as well.
- This CL is on top of http://codereview.chromium.org/7585012/

BUG=91727
TEST=View saved PDF form print preview, content and margins should be correct.


Review URL: http://codereview.chromium.org/7584019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95844 0039d316-1c4b-4281-b951-d872f2087c98

Delete the query after notifying the consumer. Also clean up a style issue.

BUG=91950
TEST=none

R=groby@chromium.org

Review URL: http://codereview.chromium.org/7541062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95842 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7572040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95841 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90905
Review URL: http://codereview.chromium.org/7491098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95840 0039d316-1c4b-4281-b951-d872f2087c98

Also add OVERRIDE to the GTK+ and OSX implementations.

BUG=23581


Review URL: http://codereview.chromium.org/7550050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95839 0039d316-1c4b-4281-b951-d872f2087c98

In views-desktop world, the omnibox popup should be parented to the widget the
location-bar belongs to. This fixes pointer events on the popup in touchui.

BUG=none
TEST=manually

Review URL: http://codereview.chromium.org/7584024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95838 0039d316-1c4b-4281-b951-d872f2087c98

For contexts not sharing resources this means the 3 to 30 calls
to get link status and attrib/uniform locations will go from
3-30 sync calls to 1 sync call.

TEST=unit tests and ran OpenGL ES 2.0 conformance tests
BUG=85966


Review URL: http://codereview.chromium.org/7358006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95836 0039d316-1c4b-4281-b951-d872f2087c98

are called on trusted and untrusted implementations.

BUG=91758
TEST=n/a
Review URL: http://codereview.chromium.org/7576026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95835 0039d316-1c4b-4281-b951-d872f2087c98

BUG=5110667
TEST=None

Review URL: http://codereview.chromium.org/7597001
Patch from Ian Vollick <vollick@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95834 0039d316-1c4b-4281-b951-d872f2087c98

While I'm at it, simplify some code.

Review URL: http://codereview.chromium.org/7550051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95832 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=WidgetObserverTest.ActivationChange

Review URL: http://codereview.chromium.org/7585028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95828 0039d316-1c4b-4281-b951-d872f2087c98