GitLab

BUG=None

Review-Url: https://codereview.chromium.org/2543933002
Cr-Commit-Position: refs/heads/master@{#435585}

Setting the testing build time ensures that the test passes even if the
system clock is incorrect when running the test.

BUG=666821,668539

Review-Url: https://codereview.chromium.org/2546433002
Cr-Commit-Position: refs/heads/master@{#435584}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e08f5483..c43132b7

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2546693002
Cr-Commit-Position: refs/heads/master@{#435583}

tools/grit used to add it, but it should move to chrome_grit_defines
instead to avoid a ui dependency there. It's currently breaking WebRTC.

It's currently used by chrome/app/theme/theme_resources.grd.

(ui_resources.grd might need it later, but it doesn't right now).

BUG=657244
TBR=scottmg@chromium.org, sky@chromium.org

Review-Url: https://codereview.chromium.org/2535753007
Cr-Commit-Position: refs/heads/master@{#435582}

This CL has no behavior changes.

NOTRY=true

Review-Url: https://codereview.chromium.org/2546473004
Cr-Commit-Position: refs/heads/master@{#435581}

Cr-Commit-Position: refs/heads/master@{#435580}

BUG=604119
TEST=none

Review-Url: https://codereview.chromium.org/2530453002
Cr-Commit-Position: refs/heads/master@{#435579}

BUG= 591606

Review-Url: https://codereview.chromium.org/2540143002
Cr-Commit-Position: refs/heads/master@{#435578}

Test mojo-loading feature with http/tests layout tests.

BUG=669357

Review-Url: https://codereview.chromium.org/2505933002
Cr-Commit-Position: refs/heads/master@{#435577}

Grouped mode is currently in active development for MD History, but it
is necessary to execute Javascript in Devtools to enable it. This adds
an obscure keyboard shortcut to the page which enables grouped mode,
simplifying debugging of this feature.

BUG=589357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2543593003
Cr-Commit-Position: refs/heads/master@{#435576}

The "Harmony" control style diverges sufficiently from AppKit controls
such that we should no longer distinguish between "WebUI" and "AppKit"
themes for native dialogs when selecting whether to use the
toolkit-views or Cocoa version of a dialog.

Also the toolkit-views theme currently breaks on Mac when not used in
conjunction with --secondary-ui-md.

--secondary-ui-md describes the outcome nicely, so collapse the
"MacViewsNativeDialogs" and "MacViewsWebUIDialogs" feature flags into
--secondary-ui-md.

BUG=658105

Review-Url: https://codereview.chromium.org/2524213002
Cr-Commit-Position: refs/heads/master@{#435575}

Remove useless class and struct forward declarations, and add
missing ones in remoting header files.

BUG=662195

Review-Url: https://codereview.chromium.org/2538183002
Cr-Commit-Position: refs/heads/master@{#435574}

This fixes an issue where a resource loader belonging to one
ResourceFetcher was accidentally added as a blocking loader to another
ResourceFetcher, by checking the loader is part of the already
non-blocking loaders belonging to current ResourceFetcher.

This also adds DCHECKs on a couple of methods removing loaders from
hashmaps, to make sure we're not trying to remove a nullptr.

BUG=666563

Review-Url: https://codereview.chromium.org/2537303003
Cr-Commit-Position: refs/heads/master@{#435573}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/582ccd4ab71b..852f85163d54

$ git log 582ccd4ab..852f85163 --date=short --no-merges --format='%ad %ae %s'
2016-11-30 eakuefner Revert of [Telemetry] Ensure that story display names are unique (patchset #4 id:60001 of https://codereview.chromium.org/2153513002/ )
2016-11-30 eakuefner [Telemetry] Ensure that story display names are unique

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2541303002
Cr-Commit-Position: refs/heads/master@{#435572}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/22c94457..e08f5483

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2540233004
Cr-Commit-Position: refs/heads/master@{#435571}

This CL has no behavior changes.

NOTRY=true

Review-Url: https://codereview.chromium.org/2538333003
Cr-Commit-Position: refs/heads/master@{#435570}

This will allow easier testing of each property as we add support in
CSS Typed OM, as we will not have to hand-write exhaustive tests for each
property, and we will easily be able to add a new test that applies to
every element easily if we need to later.

The standard set of tests is:

*single-valued properties*
- Setting with a sequence of valid values throws
- Calling append with a valid value throws

*list-valued properties*
- Setting with a sequence of valid values works
- Setting with a sequence containing valid and invalid values throws
- Append succeeds with a valid value
- Appending a sequence of valid values succeeds
- Append throws when given an invalid value
- Append throws when given a sequence containing valid and invalid values
- GetAll when the property is set to a list returns all the properties

*common*
- Can be set to each valid keyword (automatically adds initial, inherit
    and unset)
- Can be set to each given valid instance of StyleValue
- Setting to an invalid type throws (automatically adds null, undefined,
    true, false, 1, 'hello', {}, and a fake keyword)
- Get returns the right KeywordValue when the property is set to each
    valid keyword
- Get returns the right StyleValue when the property is set to .cssText
    of each given valid StyleValue
- GetAll works when the property is set to a valid StyleValue instance
- Delete removes the style from the element
- GetProperties includes the name of the property when it is set
    to something

I've added example tests for "bottom" and "animation-direction", as
semi-random, convenient single-valued and list-valued properties.

Note that since getting CSSKeyword from a StylePropertyMap is not yet fully
supported, the new tests fail.

BUG=545318

Review-Url: https://codereview.chromium.org/2529043002
Cr-Commit-Position: refs/heads/master@{#435569}

A RuntimeException can be thrown when we call
ActivityManager.getMemoryInfo() when the system is going to restart.
To avoid immediate crash, handle these exceptions gracefully.

BUG=668966

Review-Url: https://codereview.chromium.org/2545673002
Cr-Commit-Position: refs/heads/master@{#435568}

The new metrics record the action the user took after the disclosure was
shown (ignored, clicked settings, or dismissed), as well as the time
that the infobar was shown for.

BUG=661011

Review-Url: https://codereview.chromium.org/2534363002
Cr-Commit-Position: refs/heads/master@{#435567}

Linux refuses to accept buffers that have sizes ualigned to
CPU cache line, which can be 128 bytes on certain devices.
This test inputs a frame that has unaligned size of U and V
planes to catch such errors.

BUG=664039
TEST=Run VEA unittest on Kevin.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/62f3a0edf9c5e19da3e59a6b2f5c402895b1805a
Review-Url: https://codereview.chromium.org/2525563005
Cr-Original-Commit-Position: refs/heads/master@{#435179}
Cr-Commit-Position: refs/heads/master@{#435566}

Revert of binding: Removes Document::wrap that must be equivalent to Node::wrap. (patchset #5 id:100001 of https://codereview.chromium.org/2525313004/ )

Reason for revert:
CHECK(!frame->document()->containsWrapper()); in WindowProxy::updateDocumentProperty() is causing crashes at several places.

Original issue's description:
> binding: Removes Document::wrap that must be equivalent to Node::wrap.
>
> Removes unnecessary Document::wrap and associateWithWrapper.
> The special code in these functions were made in order to keep
> WindowProxy::m_document updated and consistent with toV8(document).
> But we no longer rely on the hack, and we can remove the dead code.
>
> BUG=
>
> Committed: https://crrev.com/87dc599743f71d33466ac56a8db5a53c5f6ce46c
> Cr-Commit-Position: refs/heads/master@{#435226}

TBR=haraken@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=669968

Review-Url: https://codereview.chromium.org/2538403002
Cr-Commit-Position: refs/heads/master@{#435565}

BUG=542537

Review-Url: https://codereview.chromium.org/2541783002
Cr-Commit-Position: refs/heads/master@{#435564}

Replace entire passage taken from a particular news article with
more neutral dummy text (used http://www.cipsum.com to generate
random buzzword text).

BUG=542537

Review-Url: https://codereview.chromium.org/2541773002
Cr-Commit-Position: refs/heads/master@{#435563}

https://skia.googlesource.com/skia.git/+log/f447deea6289..71b762f2aca1

$ git log f447deea6..71b762f2a --date=short --no-merges --format='%ad %ae %s'
2016-11-30 borenet [nobuildbot] CT bots

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@google.com

Review-Url: https://codereview.chromium.org/2540423002
Cr-Commit-Position: refs/heads/master@{#435562}

BUG=

Review-Url: https://codereview.chromium.org/2539333002
Cr-Commit-Position: refs/heads/master@{#435561}

BUG=542537

Review-Url: https://codereview.chromium.org/2540013003
Cr-Commit-Position: refs/heads/master@{#435560}

Made CSS white-space property use IndependentInherit, which is part
of the process of making property inheritance faster. This change
adds 1 bit to the size of ComputedStyle but significantly reduces the
time for a recalc for independent-only changes involving whitespace.

Tested using:
third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html

BUG=622138

Review-Url: https://codereview.chromium.org/2538983002
Cr-Commit-Position: refs/heads/master@{#435559}

BUG=None

Review-Url: https://codereview.chromium.org/2542063002
Cr-Commit-Position: refs/heads/master@{#435558}

This can prevent the number of threads from growing when an app creates
and destroys webviews.

BUG=668692

Review-Url: https://codereview.chromium.org/2543893002
Cr-Commit-Position: refs/heads/master@{#435557}

Contextual search on Android spins up a WebContents which talks to
Google search. If Google search chooses to request a permission inside
this WebContents, the modal prompt crashes due to a lack of a containing
tab. This is not an issue with the standard infobar permission prompts
as they do not have a dependency on a tab for display.

This CL changes a DCHECK for a TabAndroid to an explicit conditional,
which acts as though the permission request was dismissed if there is no
active Tab for the requesting WebContents.

BUG=668640

Review-Url: https://codereview.chromium.org/2538253002
Cr-Commit-Position: refs/heads/master@{#435556}

This is an initial implementation of Select-to-speak. Given mouse events
that are "captured" - currently by holding down Search - it draws a box
around the area the user selects, and then speaks everything within that
box based on its accessible name.

This is not meant to be a final, complete implementation, just a good
starting point to begin experimenting.

Depends on: https://codereview.chromium.org/2493923002/

BUG=593887
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2509883002
Cr-Commit-Position: refs/heads/master@{#435555}

AppListButton tracks per-display [target] visibility.
(sets a new flag on Shown/Dismissed callbacks)

Check widget/button state, not global shell state.
Ignore dismissed app-list windows that are animating closed.

Fix a ShelfLayoutManager test to actually catch this.

BUG=654661
TEST=Shelf stays visible when the app-list is hidden.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2534953006
Cr-Commit-Position: refs/heads/master@{#435554}

Display configuration takes some time on real devices. Add in a 200ms
delay from when Configure() is called to when the callback is triggered
so off device timing is similar to on device timing.

BUG=none

Review-Url: https://codereview.chromium.org/2527263002
Cr-Commit-Position: refs/heads/master@{#435553}

This disables the 'focus and keyboard nav' test and re-enables
the rest of HistoryListTest.

BUG=669227

Review-Url: https://codereview.chromium.org/2545603003
Cr-Commit-Position: refs/heads/master@{#435552}

In download_to_file mode of resource loading, the resource handler needs
to call ResourceDispatcherHostImpl::RegisterDownloadedTempFile when the
file is created, and needs to call UnregisterDownloadedTempFile after the
client handles the file. Otherwise, the file is deleted before the client
uses it.
However, MojoAsyncResourceHandler doesn't call them, and that causes
layout test failure around XHR with responseType = 'blob'. This CL fixes
that by adding the RDTF and UDTF pair, and refactors similar code in
AsyncResourceHandler to share the same lifetime management of the
downloaded file in ResourceDispatcherHostImpl.

BUG=603396, 659917

Review-Url: https://codereview.chromium.org/2503813002
Cr-Commit-Position: refs/heads/master@{#435551}

In this cl, we are trying to add the logcat of each instrumentation
test into the corresponding test result object, so that when we are
checking the result of each test case, we would be able to see the
corresponding logcat for that test case at the same time.

The reason of reland is to fix the issue where environmental variables are not set.

BUG=631213

Review-Url: https://codereview.chromium.org/2545653002
Cr-Commit-Position: refs/heads/master@{#435550}

Added initial_keyword flag to CSSProperties.in, which specifies the
initial value for keyword-only properties generated in ComputedStyle.

BUG=628043

Review-Url: https://codereview.chromium.org/2538493005
Cr-Commit-Position: refs/heads/master@{#435549}

Cr-Commit-Position: refs/heads/master@{#435548}

This CL hooks up the toolbar forward and backward buttons in grouped mode to
change the search timeframe for week and month queries.

BUG=589357
TBR=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2481693002
Cr-Commit-Position: refs/heads/master@{#435547}

This patch switches to a create-or-update pattern for paint property
updates of the local border box. This is a 6% improvement on
large-table-collapsed-border-change-with-text [1].

[1] tools/perf/run_benchmark blink_perf.paint --browser=content-shell-release --pageset-repeat=5 --extra-browser-args=--enable-slimming-paint-v2

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2538273002
Cr-Commit-Position: refs/heads/master@{#435546}