GitLab

This fixes an issue where extraneous flags were being set on some
devices and causing the flag check to fail.

BUG=719013

Review-Url: https://codereview.chromium.org/2881403003
Cr-Commit-Position: refs/heads/master@{#472257}

Revert of Temporarily remove unit tests which use real git and real filesystem. (patchset #1 id:1 of https://codereview.chromium.org/2892463002/ )

Reason for revert:
Should be OK to run these tests again (https://bugs.chromium.org/p/chromium/issues/detail?id=722975#c10)

Original issue's description:
> Temporarily remove unit tests which use real git and real filesystem.
>
> BUG=722975
> TBR=dpranke
> NOTRY=true
>
> Review-Url: https://codereview.chromium.org/2892463002
> Cr-Commit-Position: refs/heads/master@{#472223}
> Committed: https://chromium.googlesource.com/chromium/src/+/02e0ec9c924364de9287e06255649674a75493d1

TBR=dmazzoni@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=722975

Review-Url: https://codereview.chromium.org/2891443003
Cr-Commit-Position: refs/heads/master@{#472256}

Added some utility functions for cached offline pages:
Get sizes of all cached offline pages;
Delete all cached offline pages.
Also added the usage of cached offline pages to the number shown at:
Chrome Settings -> Privacy -> Clear Browsing Data -> Cache

BUG=716142

Review-Url: https://codereview.chromium.org/2860573004
Cr-Commit-Position: refs/heads/master@{#472255}

NOTRY=true

Review-Url: https://codereview.chromium.org/2885183002
Cr-Commit-Position: refs/heads/master@{#472254}

Reflects current team structure.

BUG=None
TBR=blundell

Review-Url: https://codereview.chromium.org/2888573002
Cr-Commit-Position: refs/heads/master@{#472253}

We track if the transform is 2d axis aligned since the last render target
during property tree building but it is not updated when we create an
effect node but not a render surface. This CL fixes that.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2885953002
Cr-Commit-Position: refs/heads/master@{#472252}

This CL is separate from the others because I want to have a discussion
about possible performance regressions before committing.

BUG=596760

Review-Url: https://codereview.chromium.org/2887883002
Cr-Commit-Position: refs/heads/master@{#472251}

There was an incorrect assumption about how ThreadChecker worked which lead
to several classes not having the d'tor guarantees they expected.  The
assumption was that a ThreadChecker would DCHECK if it was not destroyed on
the same thread it was bound to.  This is not correct so I am adding DCHECKs
to the d'tors of the remoting classes which were missed.

BUG=715633

Review-Url: https://codereview.chromium.org/2888733002
Cr-Commit-Position: refs/heads/master@{#472250}

BUG=723086
NOTRY=true
TBR=horo@chromium.org

Review-Url: https://codereview.chromium.org/2885173003
Cr-Commit-Position: refs/heads/master@{#472249}

Now that we've addressed all of the known causes of crashes, it's time to
reenable.

BUG=708570

Review-Url: https://codereview.chromium.org/2887773003
Cr-Commit-Position: refs/heads/master@{#472248}

Since most "isAttribDirty()" methods were already const, require it
in the docs and via casting in the generated code to ensure that the
check is idempotent. Mostly for consistency, but this prevents us
from triggering unexpected side effects in future optimizations.

Update the one place (navigator.languages) where a non-const method
was being used.

Review-Url: https://codereview.chromium.org/2884493002
Cr-Commit-Position: refs/heads/master@{#472247}

Before this CL, ModuleTreeLinker::Instantiate assumed that it is only called for
modulator with a valid context. However, asynchronous module graph node load
completion may be triggered after the context was destroyed.

This CL fixes the issue by making ModuleTreeLinker::Instantiate fail without crashing
if the context is invalid.

BUG=594639,716935

Review-Url: https://codereview.chromium.org/2886593002
Cr-Commit-Position: refs/heads/master@{#472246}

Just a first pass, more to come later.

BUG=722551
TEST=No Chrome OS shelf changes.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2888623005
Cr-Commit-Position: refs/heads/master@{#472245}

They should no longer be needed after https://codereview.chromium.org/2851523002
and https://chromium-review.googlesource.com/497271

BUG=716117

Review-Url: https://codereview.chromium.org/2884303002
Cr-Commit-Position: refs/heads/master@{#472244}

This removes the last UsbService*::Create() method taking a
SequencedTaskRunner, allowing us to start cleaning up DeviceClient as
well.

BUG=None

Review-Url: https://codereview.chromium.org/2885143002
Cr-Commit-Position: refs/heads/master@{#472243}

Revert of Enable DCHECKs by default in non-official builds. (patchset #3 id:40001 of https://codereview.chromium.org/2886803002/ )

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 472195 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzg3NWEyZmE0M2NhYWIwZWU4MmVmZTY4ZmI1YWRiMzU3MzkyNDM0YWQM

Original issue's description:
> Enable DCHECKs by default in non-official builds.
>
> BUG=722827
> TBR=sdefresne@chromium.org for ios/
>
> Review-Url: https://codereview.chromium.org/2886803002
> Cr-Commit-Position: refs/heads/master@{#472195}
> Committed: https://chromium.googlesource.com/chromium/src/+/875a2fa43caab0ee82efe68fb5adb357392434ad

TBR=brettw@chromium.org,thakis@chromium.org,sdefresne@chromium.org,gab@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=722827,723090,723049

Review-Url: https://codereview.chromium.org/2892473002
Cr-Commit-Position: refs/heads/master@{#472242}

The method was removed in https://codereview.chromium.org/193663003 but
not the declaration. Also make P2PSocketClient's constructor protected
like the destructor as there is no way to create it without subclassing
anyway.

BUG=none

Review-Url: https://codereview.chromium.org/2865303003
Cr-Commit-Position: refs/heads/master@{#472241}

https://codereview.chromium.org/2882383002 introduced this virtual
test suite, breaking expectations for a couple of tests that need to be
excluded for --site-per-process.

BUG=477150
NOTRY=true

Review-Url: https://codereview.chromium.org/2888733003
Cr-Commit-Position: refs/heads/master@{#472240}

Came up in https://codereview.chromium.org/2878133002/
(calling the wrong function ate up 1hr+ debugging)
(this cl also depends on that one)

BUG=NONE
TEST=NONE
R=sky@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2889443002
Cr-Commit-Position: refs/heads/master@{#472239}

To allow changes to where fields are stored, ComputedStyle code should
not refer directly to a group, as that code will break when we change
groups. This patch removes references to box_data_ in ComputedStyle,
replacing with generated or handwritten getters. This patch does not
remove references within diffing functions as those will soon be
generated.

BUG=710938

Review-Url: https://codereview.chromium.org/2888513002
Cr-Commit-Position: refs/heads/master@{#472238}

This CL implements MusContextFactory::SharedMainThreadContextProvider()
which is needed by exo for uploading resources to GPU.

BUG=720600

Review-Url: https://codereview.chromium.org/2890453002
Cr-Commit-Position: refs/heads/master@{#472237}

R=dpapad@chromium.org
BUG=585553
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2881523002
Cr-Commit-Position: refs/heads/master@{#472236}

Replace uses of the individual Top, Left, Width, and Height accessors in
NGPhysicalFragment with Offset and Size respectively to reduce API size,
improve compiler enforcement of logical & physical, and reduce code size.

R=ikilpatrick@chromium.org

Review-Url: https://codereview.chromium.org/2885053003
Cr-Commit-Position: refs/heads/master@{#472235}

This patch changes StyleRareInheritedData to make it easier to generate:
- Remove unused destructor
- Replace explicit copy constructor with RefCountedCopyable
- Replace forward declarations with #includes.

This is in preparation for generating StyleRareInheritedData. While this
patch may increase compile times, we would have to pay this cost anyway
when we generate StyleRareInheritedData in ComputedStyleBase.

BUG=628043

Review-Url: https://codereview.chromium.org/2881003002
Cr-Commit-Position: refs/heads/master@{#472234}

* Adds new Offliner::RequestStatus::BROWSER_KILLED.
* Reports UMA for requests updated in reconcile task with the status
  above.

BUG=705115
R=petewil@chromium.org

Review-Url: https://codereview.chromium.org/2883413002
Cr-Commit-Position: refs/heads/master@{#472233}

Test expectation is that there is no signed in account at the beginning, and by
the end of setUp test expects mAccount to appear signed in from
AndroidSyncSettings perspective. It is done by calling updateAccount(mAccount)
from setUp(). The issue happens when there is another signed in account
according to ChromeSigninController.getSignedInAccountName, potentially left
from some other test execution.

The fix is to reset signed in account with
ChromeSigninController.setSignedInAccountName before AndroidSyncSettings
initialization.

R=skym@chromium.org
BUG=717960

Review-Url: https://codereview.chromium.org/2884953004
Cr-Commit-Position: refs/heads/master@{#472232}

Review-Url: https://codereview.chromium.org/2888683002
Cr-Commit-Position: refs/heads/master@{#472231}

It turns out that:

1) We can get resource loads for frames that don't belong to the page
and
2) We can get notice of frame commits for frames that don't belong to the page.

We hope this is rare (and record histograms to verify) and relax the constraints.

BUG=708570

Review-Url: https://codereview.chromium.org/2884753002
Cr-Commit-Position: refs/heads/master@{#472230}

design doc:
https://docs.google.com/document/d/1O-fB83mrE0B_V8gzXNqHgmRLCvstTB4MMi3RnVLr8bE/edit#
https://docs.google.com/document/d/1obEb8K4mJpG9Y_x4_ZhvnbFHojZoLLzMCFsalkl8voc/edit#

This CL calls ImageResourceObserver::ImageNotifyFinished()
after SVG image loading is completed, not necessarily the same time as
ResourceLoader completion (e.g. DidFinishLoading()).
This makes SVG's <img> load event to be fired after SVG image loading
is completed even when the SVG has subresources loaded asynchronously.

1. Image::SetData() can return SizeAvailableAndLoadingAsynchronously
   when SVG image loading is not completed synchronously (due to
   subresources), and notifies the completion asynchronously via
   ImageObserver:LoadCompleted().
   LocalFrameClient::DispatchDidHandleOnloadEvents() is used as a
   notification of SVG image loading completion in SVGImage.

2. ImageResourceContent delays calling ImageNotifyFinished() and
   setting |content_status_| to kCached until SVG image loading is
   completed.

3. ImageLoader additionally delays the Document load event
   - from the first ImageChanged() during image loading
   - until (potentially delayed) ImageNotifyFinished().

In image loading not by ImageLoader, the Document load event is not
delayed from ResourceLoader completion until ImageNotifyFinished(),
but this is not a regression.

In image loading by ImageLoader, the Document load event is delayed
until ImageNotifyFinished() by the combination of
ResourceFetcher::loaders_ and ImageLoader.
ImageLoader starts delaying the Document load event
- Not from |image_| is set, because we shouldn't delay the Document
  load event when image loading is deferred.
- Not from ImageResourceContent::NotifyStartLoad(), to avoid additional
  ImageResourceObserver callbacks.

BUG=382170, 690480, 667641

Review-Url: https://codereview.chromium.org/2613853002
Cr-Commit-Position: refs/heads/master@{#472229}

We need to make the cell's height unusable for calculating perecent/calc height
against before computing its preferred width, otherwise replaced children may use it
to scale up their intrinsic width.

BUG=666730

Review-Url: https://codereview.chromium.org/2851513004
Cr-Commit-Position: refs/heads/master@{#472228}

This is speculative as I can't easily compile with use_cras=true
without updating a full chrome os checkout first

BUG=722827
TBR=justinlin
NOTRY=true

Review-Url: https://codereview.chromium.org/2886993002
Cr-Commit-Position: refs/heads/master@{#472227}

* add support for detecting URLs on the amp cache domain using the new
  host prefixing scheme

* add support for amp documents loaded in the google news viewer

* factor existing google url detection logic into a common helper, and use
  it in both amp observer and from search observer

* add metrics broken out by type of amp load (amp cache, google search viewer, etc)
  since performance may vary depending on view type (especially for bare amp cache
  urls)

BUG=722690

Review-Url: https://codereview.chromium.org/2880323003
Cr-Commit-Position: refs/heads/master@{#472226}

By AudioManager API, Shutdown() must be called before destruction. This
isn't caught by tests because media_service_unittests is only run on
release builds.

Review-Url: https://codereview.chromium.org/2886683003
Cr-Commit-Position: refs/heads/master@{#472225}

This is a mechanical change.

BUG=687231

Review-Url: https://codereview.chromium.org/2883383002
Cr-Commit-Position: refs/heads/master@{#472224}

BUG=722975
TBR=dpranke
NOTRY=true

Review-Url: https://codereview.chromium.org/2892463002
Cr-Commit-Position: refs/heads/master@{#472223}

are currently in c/b/android/offline_pages but are not Android-dependent.
This is to avoid mixing of Android-specific code with cross-platform and to
facilitate offline_pages on other platforms (like ChromeOS) in the future.

Also, move the first file there. Tighter DEPS will come in the next CL.

BUG=722467

Review-Url: https://codereview.chromium.org/2881223002
Cr-Commit-Position: refs/heads/master@{#472222}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/649a1343..fefd00d2

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2886783002
Cr-Commit-Position: refs/heads/master@{#472221}

BUG=719535

Review-Url: https://codereview.chromium.org/2890553002
Cr-Commit-Position: refs/heads/master@{#472220}

BUG=681694

Review-Url: https://codereview.chromium.org/2888693002
Cr-Commit-Position: refs/heads/master@{#472219}

Previously, given a device_id "plug:foo" alsa_util.cc would try to open
the control named ":foo". It will now open "foo".

This is safe because at this point we know we have already found a ':'
at pos1.

BUG=internal 35197382
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2883313004
Cr-Commit-Position: refs/heads/master@{#472218}