GitLab

These are:
1. Change RemoveInvalidHandle to SignalHandleError to mirror SignalHandleReady.
2. Use SignalHandleError wherever handler->OnHandleError is called.

Review URL: https://codereview.chromium.org/1573383002

Cr-Commit-Position: refs/heads/master@{#369389}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4b380419..05c6728a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1582843004

Cr-Commit-Position: refs/heads/master@{#369388}

Before this patch, there is no way to gracefully cancel the start sequence when
the worker is requested to stop. Therefore, both start and stop sequences can
be interleaved. To be more specific, process allocation information can be left
in ServiceWorkerProcessManager even after the start sequence is canceled, and
the process manager sometimes behaves strangely when attempting to restart the
worker. This patch provides a way to cancel the start sequence.

<Details of this patch>

Roughly speaking, the start sequence consists of two phases: (1) process
allocation involving thread hops, and (2) IPC messaging between the browser
process and a worker process. We need to make it cancelable in either phase.

To achieve that, this patch introduces...

 * StartTask that is a cancelable task to allocate a worker process and to send
   a start worker message.
 * WorkerProcessHandle that is a handle for a worker process managed by
   ServiceWorkerProcessManager. Its dtor makes sure to release a process.
   The handle is created by StartTask when a process is allocated, and then
   passed to EmbeddedWorkerInstance.

When the start sequence is aborted during the phase (1), StartTask releases a
process on its dtor. When the start sequence is aborted during the phase (2),
EmbeddedWorkerInstance releases the process by destroying the process handle.

BUG=568915,568465

Review URL: https://codereview.chromium.org/1569773002

Cr-Commit-Position: refs/heads/master@{#369387}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/701b2443d668..1200798cc253

$ git log 701b2443d..1200798cc --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1582263002

Cr-Commit-Position: refs/heads/master@{#369386}

To handle incoming transactions:
  Add CommandStream::IncomingCommandHandler::OnTransaction.
  Add CommandBroker::OnTransaction.

To implement test:
  Add CommandBroker::EnterLooper, ExitLooper, PollCommands.
  Add Thread.
  Add TestService.
  Add BinderEndToEndTest.

BUG=563282

Review URL: https://codereview.chromium.org/1575313002

Cr-Commit-Position: refs/heads/master@{#369385}

If we're showing offline-available indications, then "file://" links should be treated as available

BUG=565219

Review URL: https://codereview.chromium.org/1579153002

Cr-Commit-Position: refs/heads/master@{#369384}

This is a mechanical refactor of RenderWidgetCompositor and
RenderWidget. At this point it removes references for
routing ID, and RenderWidget from RenderWidgetCompositor's
implementation. This is likely not the final refactor as I
am still in the process of detangling WebWidgetClient's
implementation from RenderWidget. Once that happens, I
might have some simplifications.

BUG=577321

Review URL: https://codereview.chromium.org/1587743002

Cr-Commit-Position: refs/heads/master@{#369383}

Revert of NaCl: Update revision in DEPS, 26c7e6a -> c4c237c (patchset #1 id:1 of https://codereview.chromium.org/1580293003/ )

Reason for revert:
Broke nacl_integration on Mac10.6 Tests.

https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/10932

dyld: Library not loaded: /usr/lib/libc++.1.dylib
  Referenced from: /Volumes/data/b/build/slave/Mac10_6_Tests/build/src/native_client/toolchain/mac_x86/pnacl_newlib/bin/x86_64-nacl-clang
  Reason: image not found
/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/native_client/toolchain/mac_x86/pnacl_newlib/bin/x86_64-nacl-clang -m64 -std=gnu99 -O2 -g -fomit-frame-pointer -fasynchronous-unwind-tables -Wall -Wundef -fdiagnostics-show-option -Werror -Wno-variadic-macros -Wno-language-extension-token -integrated-as -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1 -D_GNU_SOURCE=1 -D_POSIX_C_SOURCE=199506 -D_XOPEN_SOURCE=600 -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DDYNAMIC_ANNOTATIONS_PREFIX=NACL_ -DNACL_BUILD_ARCH=x86 -DNACL_BUILD_SUBARCH=64 -Iscons-out/nacl-x86-64/include -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/ppapi/native_client/scons-out/nacl-x86-64/include -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/ppapi -c -o scons-out/nacl-x86-64/obj/src/untrusted/nacl/stubs/socket.o src/untrusted/nacl/stubs/socket.c
scons: *** [scons-out/nacl-x86-64/obj/src/untrusted/nacl/sigprocmask.o] Error -5
...
scons-out/nacl-x86-64/obj/src/untrusted/nacl/sigprocmask.o failed: Error -5

And many similar messages

Original issue's description:
> NaCl: Update revision in DEPS, 26c7e6a -> c4c237c
>
> This pulls in the following Native Client changes:
>
> 95163bf: (stichnot@chromium.org) Update revision for PNaCl
> abee7c9: (petarj@mips.com) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS
> b44e8dc: (petarj@mips.com) [MIPS] Make $t8 point to the address of TLS pointers
> 11ff949: (thakis@chromium.org) clang/win: Fix -Wsign-compare warning in platform_impl.cc
> f39aa44: (mseaborn@chromium.org) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS: add ConvertToPSO
> aebc3c4: (mcgrathr@chromium.org) Update chrome_rev
> c4c237c: (erikchen@chromium.org) Back dynamic text regions with a Mach memory region.
>
> Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/26c7e6ae1327a43c948f4666fef9e84fe351ab7c..c4c237c0567cbe1c7de664a4d81673c3403cf55b
>
> BUG=none
> TEST=browser_tests and nacl_integration
> CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
>
> Committed: https://crrev.com/97c9eecf2e7a5857d6dc6ddb22eb27251f9eefc4
> Cr-Commit-Position: refs/heads/master@{#369294}

TBR=mcgrathr@chromium.org,mseaborn@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1586683003

Cr-Commit-Position: refs/heads/master@{#369382}

When the local player thinks it's currently seeking, it skips some
tasks, including updating the progress bar. See the linked bug.
This change forces notifying the local player that seek is completed
when starting cast.

BUG=568161

Review URL: https://codereview.chromium.org/1580733002

Cr-Commit-Position: refs/heads/master@{#369381}

BUG=415074

Review URL: https://codereview.chromium.org/1586623002

Cr-Commit-Position: refs/heads/master@{#369380}

Connecting to the same frame does not make sense because onMessage
should not be triggered for the same frame.

BUG=479425,575234

Review URL: https://codereview.chromium.org/1588533002

Cr-Commit-Position: refs/heads/master@{#369379}

BUG=525873
R=jbudorick@chromium.org,maruel@chromium.org,miguelg@chromium.org
TBR=miguelg@chromium.org

Review URL: https://codereview.chromium.org/1585573002

Cr-Commit-Position: refs/heads/master@{#369378}

BUG=483615

Review URL: https://codereview.chromium.org/1585643002

Cr-Commit-Position: refs/heads/master@{#369377}

This also remove WebView::deviceScaleFactor() and moved to RenderView because it's no longer necessary in Blink.

BUG=485650

Review URL: https://codereview.chromium.org/1572703002

Cr-Commit-Position: refs/heads/master@{#369376}

BUG=577478,576797,577028
R=haraken@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1583173002

Cr-Commit-Position: refs/heads/master@{#369375}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/cb9210d4..4b380419

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1587003002

Cr-Commit-Position: refs/heads/master@{#369374}

BUG=419656
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/1578363004

Cr-Commit-Position: refs/heads/master@{#369373}

The test crashes on ozone GBM, because GBM doesn't support software rendering
mode. This CL makes the test gracefully done, instead of crash.

[ RUN      ] SoftwareOutputDeviceOzoneTest.CheckCorrectResizeBehavior
[9442:9442:0111/131957:8760142320:FATAL:gbm_surface_factory.cc(88)] Software rendering mode is not supported with GBM platform

TEST=content_unittests --gtest_filter=SoftwareOutputDeviceOzoneTest* --ozone-platform=gbm --ozone-use-surfaceless --single-process-tests

Review URL: https://codereview.chromium.org/1575943002

Cr-Commit-Position: refs/heads/master@{#369372}

BUG=540493

Review URL: https://codereview.chromium.org/1571633002

Cr-Commit-Position: refs/heads/master@{#369371}

properties.

Without this patch, when an ancestor modifies custom property values
then children that make use of just the non-inherited part of the
matched properties cache won't apply any custom property value
overrides, as they aren't flagged as inherited.

BUG=570164

Review URL: https://codereview.chromium.org/1581223003

Cr-Commit-Position: refs/heads/master@{#369370}

BUG=568486
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/1586663004

Cr-Commit-Position: refs/heads/master@{#369369}

- Re-styled buttons on dialogs to MD's ones.
- Adjusted shadow, background, and layout of dialog container.
- Removed white shield which was shown behind the dialog.

BUG=575150
TEST=manually confirm the style of dialogs which are shown as follows.
- Delete a file (delete confirm dialog)
- Rename a file to ".foo" (alert dialog)
- Try to open unsupported file in Downloads. (alert dialog with a title)
- Open change-default dialog by selecting a file which has multiple support app and clicking "Change default..." from OPEN dropdown menu. (default task dialog)

Review URL: https://codereview.chromium.org/1584113002

Cr-Commit-Position: refs/heads/master@{#369368}

Cr-Commit-Position: refs/heads/master@{#369367}

This is a tad earlier than what we used to do; we used to do it for all sets in
one go at the end of layout of the multicol container. We now do it
individually for each column set (children of the multicol container) as we lay
them out.

This way we have an up-to-date column height when positioning column sets
during multicol container child layout (children being either spanner
placeholders or column sets).

For the bug in question, this is particularly important in the first layout
pass, where column heights are completely bogus. When we're in a nested
fragmentation context, inner column heights are typically set to the remaining
height of an outer column, which may be more space than the contents actually
need. This could in turn trick the machinery into believing that we need to
insert another fragmentainer group for a spanner following a column set, even
if column heights were completely unconstrained.

BUG=552615
R=leviw@chromium.org

Review URL: https://codereview.chromium.org/1558963003

Cr-Commit-Position: refs/heads/master@{#369366}

The patch starts treating css comments as CSS properties if the parsed
property name resembles a valid property name.

BUG=568017
R=pfeldman

Review URL: https://codereview.chromium.org/1534323003

Cr-Commit-Position: refs/heads/master@{#369365}

The current site engagement tests are a) based on
BrowserWithTestWindowTest (which doesn't run on Android); or b) not
compiled as part of unit_tests on Android. This CL refactors the tests
so that they compile, run, and pass on Android.

BUG=575509

Review URL: https://codereview.chromium.org/1578133002

Cr-Commit-Position: refs/heads/master@{#369364}

Before this patch, |VisibleSelection::setWithoutValidation()| assumes it is
always called |m_affinity| == |TextAffinity::Downstream|, however as attached
test case, "/set-without-validation-with-upstream-caret.html", this assumption
is false. |setWithoutValidation()| can be called with
|m_affinity| == |TextAffinity::Upstream|.

This patch makes |VisibleSelection::setWithoutValidation()| to handle in case
of |VisibleSelection::m_affinity| == |TextAffinity::Upstream| case by keeping
invariant only caret selection having |TextAffinity::Upstream|.

BUG=575568
TEST=editing/caret/set-without-validation-with-upstream-caret.html

Review URL: https://codereview.chromium.org/1581333002

Cr-Commit-Position: refs/heads/master@{#369363}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ebce338fa58c..701b2443d668

$ git log ebce338fa..701b2443d --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1589743002

Cr-Commit-Position: refs/heads/master@{#369362}

BUG=558054

Review URL: https://codereview.chromium.org/1588853002

Cr-Commit-Position: refs/heads/master@{#369361}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/302c89a0..cb9210d4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1585673004

Cr-Commit-Position: refs/heads/master@{#369360}

BUG=568486

Review URL: https://codereview.chromium.org/1582893002

Cr-Commit-Position: refs/heads/master@{#369359}

BUG=chrome-os-partner:48623
TEST=Set the "keyboard_layout" value as "ime:ko:hangul" in VPD; Goes to
OOBE screen, set the locale as Korean; Goes to Guest mode, verify the
Korean input method is the default (and the only one) input method.

Review URL: https://codereview.chromium.org/1578133003

Cr-Commit-Position: refs/heads/master@{#369358}

BUG=570588
TEST=manually

Review URL: https://codereview.chromium.org/1581933004

Cr-Commit-Position: refs/heads/master@{#369357}

Adds connection migration capability to QUIC. This CL causes QUIC connections to migrate to a new network when an old network is disconnected or about to be disconnected. These notifications are available for Android >= L, so QUIC connection migration will only work for Android >= L.

BUG=576998

Review URL: https://codereview.chromium.org/1327923002

Cr-Commit-Position: refs/heads/master@{#369356}

Previously BufferedSocketWriter was ignoring Write() calls before
Init(). Fixed it to buffer all data in that scenario. Also renamed
Init() to Start().

Review URL: https://codereview.chromium.org/1582583003

Cr-Commit-Position: refs/heads/master@{#369355}

- UseCounter::MenuItemElement
  Counts menuitem element usage.
  if chrome://flags/#enable-experimental-web-platform-features is enabled,
  HTMLMenuItemElement is used.  Otherwise, HTMLUnknownElement is used.

- UseCounter::MenuItemCloseTag
  Counts </menuitem>.  <menuitem> is a void element according to the current
  specification.  This counts wrong usages like crbug.com/412945.

BUG=412945

Review URL: https://codereview.chromium.org/1587673005

Cr-Commit-Position: refs/heads/master@{#369354}

This change adds SVGLengthListInterpolationType to enable additive
and neutral Web Animation keyframes for SVG attributes: x, y, dx, dy

This is a continuation of: https://codereview.chromium.org/1535523002

LayoutTests have been updated to test lengths, length lists and numbers
separately on these attributes.

BUG=530436

Review URL: https://codereview.chromium.org/1587533002

Cr-Commit-Position: refs/heads/master@{#369353}

BUG=576750

Review URL: https://codereview.chromium.org/1582843003

Cr-Commit-Position: refs/heads/master@{#369352}

Re-landing after first attempt was reverted:

https://codereview.chromium.org/1548523002/

TBR-ing, the only change is adding the missing visitor->trace().

BUG=570538
TBR=ojan@chromium.org,kinuko@chromium.org

Review URL: https://codereview.chromium.org/1582993002

Cr-Commit-Position: refs/heads/master@{#369351}

BUG=561867

Review URL: https://codereview.chromium.org/1563763002

Cr-Commit-Position: refs/heads/master@{#369350}