- 01 Feb, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/50b187ca8371..39b0b8e32a4e git log 50b187ca8371..39b0b8e32a4e --date=short --no-merges --format='%ad %ae %s' 2019-01-31 vadimsh@chromium.org Add presubmit check that runs 'lucicfg validate <script>'. Created with: gclient setdep -r src/third_party/depot_tools@39b0b8e32a4e The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:925532 TBR=agable@chromium.org Change-Id: Iddc65d57ba840b7be37319502e363b90e3d3e226 Reviewed-on: https://chromium-review.googlesource.com/c/1448563Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628196}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/67957c299322..2e5e7db63cd9 git log 67957c299322..2e5e7db63cd9 --date=short --no-merges --format='%ad %ae %s' 2019-01-31 cjmcdonald@chromium.org chromeos_config: Added documentation for goma-full builder Created with: gclient setdep -r src/third_party/chromite@2e5e7db63cd9 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I48ffd12957138bf370abd7bd76d24aa7faa4a90e Reviewed-on: https://chromium-review.googlesource.com/c/1448679Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628195}
-
Bret Sepulveda authored
This patch deletes ChromeLayoutProvider::UseExtraDialogPadding, which always returns false, and any code guarded by it. This patch also adds a margin between the title and content to the collected cookies dialog, which is currently guarded by the above method, but upon reviewing designer comments was probably intended to be replaced by the proper Harmony constant instead. Bug: 867557, 610428 Change-Id: I6d30e93e213cd235e66156b097d01a4cf6a40a1f Reviewed-on: https://chromium-review.googlesource.com/c/1449156Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#628194}
-
Joel Einbinder authored
There was 1px of margin on items in the elements tree outline. If that area was clicked, selecting a new element would fail. Change-Id: I62c3aeb814759349c05582ac6b23309901e6d98e Reviewed-on: https://chromium-review.googlesource.com/c/1387453Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#628193}
-
Becca Hughes authored
This is a follow up from https://crrev.com/c/1334661 which splits out spec metadata between Blink/Content with its own SpecMediaMetadata. BUG=892771 Change-Id: I48825f4c97e526888d5a9840cdcc129e2eed11e9 Reviewed-on: https://chromium-review.googlesource.com/c/1423400 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#628192}
-
Johannes Henkel authored
- Python3 changes - Maybe_h fix for UBSan warning - more encoding changes Change-Id: I8045bfb1f47b95171e3e395c85b6de05f6973e42 Reviewed-on: https://chromium-review.googlesource.com/c/1448995Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#628191}
-
Devlin Cronin authored
Opening a window to a blank URL and then navigating it previously did not properly instantiate extension bindings, since the created script context was evaluated to be "unknown" (and then reused in the navigated page). This was fixed by https://crrev.com/305d2102dc, which landed in M72. Though this has already been fixed, add a regression test specifically for extension bindings to expand our coverage. Bug: 925118 Change-Id: Id5d7748a09f6eb8b60d25935ab4efcbde3d0d5c6 Reviewed-on: https://chromium-review.googlesource.com/c/1446570 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#628190}
-
rbpotter authored
PDFAnnotationsTest.AnnotationsFeatureEnabled was failing when run with --enable-features=WebUIPolymer2. Fixing: - Test uses /deep/, which is deprecated in Shadow DOM v1. - Production code relies on the lookup_ function not being called when |strings| is undefined, which is an invalid assumption in Polymer 2. - Production code sets |disabled| for elements in a dom-repeat that are not actually available in attached(). Also add the PDFAnnotationsTests to the filter file, to help prevent future regressions. Bug: 860069, 923625 Change-Id: I48b353ecd06fdff5b773b1959b4625662a2ca5c0 Reviewed-on: https://chromium-review.googlesource.com/c/1446509Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#628189}
-
git config --global authored
Check Info.plist to get Failed/Passed status and ignore Error messages and return code of "xcodebuild test..." command. Bug: 924818 Change-Id: Ibcc91f253747667a7b673f3c9cb5863afd7da965 Reviewed-on: https://chromium-review.googlesource.com/c/1432156 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#628188}
-
Moe Ahmadi authored
Use UIView's alpha property instead of hidden to hide the button and show the spinner on translate infobar's language tab. As opposed to hidden, alpha is an animatable UIView property: https://developer.apple.com/library/archive/documentation/WindowsViews/Conceptual/ViewPG_iPhoneOS/AnimatingViews/AnimatingViews.html Bug: 910994 Change-Id: I35a853f52f4f7291412a51cacbd61a13e3c00087 Reviewed-on: https://chromium-review.googlesource.com/c/1448773 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#628187}
-
Joshua Peraza authored
Set the native library search path to first search a directory named for the current ABI, adjacent to the chrome package nativeLibraryDir, which will be the 32-bit ABI directory. The package's nativeLibraryDir is moved to the end of the path list because if a wrong bitness library is found first, the loader won't continue the search. Bug: crashpad:276 Change-Id: I5f0c13112b7423576f9e353cb3afef4e919e586c Reviewed-on: https://chromium-review.googlesource.com/c/1449005Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#628186}
-
Hui(Andy) Wu authored
Add a flag for the upcoming assisted actions feature. It will only be activated when the flag is enabled, which is defaulted to disabled. Change-Id: I715d933bb13952c63f54968cb628c1fccb549998 Bug: crbug/925947 Reviewed-on: https://chromium-review.googlesource.com/c/1446555Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Hui Wu <wuandy@chromium.org> Cr-Commit-Position: refs/heads/master@{#628185}
-
John Z Wu authored
It says "Search or type URL" like in //ios/chrome. Change-Id: I3d58b0487f76e174e9779f361c28869833fe943e Reviewed-on: https://chromium-review.googlesource.com/c/1448118 Auto-Submit: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#628184}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/258398020826..48d040e8c524 git log 258398020826..48d040e8c524 --date=short --no-merges --format='%ad %ae %s' 2019-01-31 geofflang@chromium.org D3D11: Fix reads and writes to EGL image textures with mip offsets. Created with: gclient setdep -r src/third_party/angle@48d040e8c524 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ife51223f5d11aaaa50a8080ab839a8ca59b6c8c6 Reviewed-on: https://chromium-review.googlesource.com/c/1448678Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628183}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8926f0f331d8..db987e614ff8 git log 8926f0f331d8..db987e614ff8 --date=short --no-merges --format='%ad %ae %s' 2019-01-31 thestig@chromium.org Make CPDF_Annot::IsAnnotationHidden() non-static. 2019-01-31 tsepez@chromium.org IJS_Runtime::Create() can not return null. 2019-01-31 tsepez@chromium.org Break core/fpdfapi/{edit,parser} circular dependence 2019-01-31 thestig@chromium.org Add constants for PDF 1.7 spec, table 8.15. 2019-01-31 thestig@chromium.org Add EmbedderTest::OpenSavedDocumentWithPassword(). 2019-01-31 thestig@chromium.org Use RenderLoadedPageWithFlags() instead of RenderPageWithFlags(). 2019-01-31 thestig@chromium.org Add EmbedderTest::RenderPage(). Created with: gclient setdep -r src/third_party/pdfium@db987e614ff8 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1e405c3486457bd8c66596a3a4f5ddee32346f76 Reviewed-on: https://chromium-review.googlesource.com/c/1448562Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628182}
-
Dan Beam authored
Screenshots: https://imgur.com/a/uqczMTg, https://imgur.com/a/OnNFo4u BUG=926935 R=aee@chromium.org Change-Id: Ib613901512e557695a66859b22abcbc5e84f63a7 Reviewed-on: https://chromium-review.googlesource.com/c/1446799 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#628181}
-
Andres Calderon Jaramillo authored
This CL modifies the ImageDecodeAcceleratorStub unit tests to test that service-side transfer cache entries are created correctly for completed image decodes. Additionally, a "return true;" is added to GpuChannelMessageFilter::OnMessageReceived() to make sure that image decode accelerator requests early out. Test: all the ImageDecodeAcceleratorStub unit tests pass. Bug: 868400 Change-Id: I95db80df9ef1f7651807177ffcc3d653b96e1374 Reviewed-on: https://chromium-review.googlesource.com/c/1368600Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#628180}
-
Adithya Srinivasan authored
We don't currently send a message because the RenderFrameProxy created has no parent (so it looks like a main frame). This ensures that same-origin frames within the portal are also detached. The test added would fail with --enable-leak-detection without this change (the iframe inside the portal would leak). Bug: 923898 Change-Id: I2b56b8e303b40d275976da5ed8a0fdde7726b51c Reviewed-on: https://chromium-review.googlesource.com/c/1430586Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#628179}
-
Jacob DeWitt authored
This is required due to WebXR breaking API changes made in M73. The associated test now checks that the WebXRDeviceM73 token works and that the WebXRDeviceM69 token no longer works. Bug: 925983 Change-Id: Ibca4bf9476a3f5958a34ed8a162a75748ce313a0 Reviewed-on: https://chromium-review.googlesource.com/c/1448976Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#628178}
-
Dale Curtis authored
Mostly just structural changes to return early instead of having a large set of nested conditionals. The only real change is when color accuracy is turned off, we won't blindly set SRGB mode anymore. This won't fix the default path, but may resolve issues where color accuracy has been turned off. BUG=854438, 902550, 825578, 851216 TEST=none R=liberato, sunnyps Change-Id: I5f5e12d1520e15e92167a1fc2e03f6606467c95d Reviewed-on: https://chromium-review.googlesource.com/c/1448741 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#628177}
-
Robbie McElrath authored
We're not supporting in-process network service on ChromeOS for now. Bug: 927435 Change-Id: I88f4e62ac1534c88cf77635fa6b8c4ac5464397e Reviewed-on: https://chromium-review.googlesource.com/c/1449109 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#628176}
-
David Jacobo authored
Smart text selection already has a metric for usage, more specifically this is recorded everytime an apps request is done to the ARC container. Currently the feature can be accessed via touch gestures or the context menu. This CL adds tracking to the access via touch gesture, since context menu was already covered. Bug: None Test: Build. Change-Id: Id394796f140605041efa0a37e298fd0764571292 Reviewed-on: https://chromium-review.googlesource.com/c/1449002 Auto-Submit: David Jacobo <djacobo@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#628175}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1345366c21ea..88bfed46ab6e git log 1345366c21ea..88bfed46ab6e --date=short --no-merges --format='%ad %ae %s' 2019-01-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 794364ebd51c..258398020826 (1 commits) 2019-01-31 egdaniel@google.com Fix type in Andoird string. 2019-01-31 reed@google.com fix tiler to handle large float rects Created with: gclient setdep -r src/third_party/skia@88bfed46ab6e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:927075 TBR=borenet@chromium.org Change-Id: I226b13831d3b8170118b9e102ff1701e612a1708 Reviewed-on: https://chromium-review.googlesource.com/c/1448117Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628174}
-
danakj authored
Since the data comes from the |delegate_| of the RenderWidgetHostImpl, it does not depend on a |view_| being non-null. This reduces the number of early outs for the browser controls code. TBR=ajwong@chromium.org Change-Id: I17b4ac724708091a65cf8936ecb56ba5080da581 Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1443530 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#628173}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2061050c4d27..b2818db71e6e git log 2061050c4d27..b2818db71e6e --date=short --no-merges --format='%ad %ae %s' 2019-01-31 chiniforooshan@chromium.org Telemetry: Use config to get UMA histograms Created with: gclient setdep -r src/third_party/catapult@b2818db71e6e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:927067 TBR=sullivan@chromium.org Change-Id: Ia50436c7d95a6f2eee7782aaffd5f580d75bf994 Reviewed-on: https://chromium-review.googlesource.com/c/1448710Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628172}
-
liberato@chromium.org authored
We'll often want to add features to our LabelledExamples that are difficult or impossible to get at the site where we're building the example. For example, "number of concurrent media players" or "current in-use network bandwidth" might not be available from everywhere we might want it (e.g., "media/" or "renderer process"). Further, many features are generic; we don't want every LearningTask to have to invent them. We'd like to provide some basic features to any task that wants to include them. This CL introduces FeatureProvider, which lets us collect features where it's convenient (e.g., the browser), and append it before sending the examples to the learning algorithm. If the LearningTask has a feature description that matches a pre-defined feature, then it will be filled in before being included in the training data. LearningTaskControllerImpl optionally taks a FeatureProvider, which it applies to all examples as they're added. Since the learning code makes no threading assumptions (e.g., it can be run on a background thread), the FeatureProviders are all wrapped up as SequenceBound<>, so that they can hop to whatever thread the FeatureProvider needs, such as the main thread. Change-Id: If3948f139fe2ae977cd1d814b9248b455e7b6907 Reviewed-on: https://chromium-review.googlesource.com/c/1446540 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#628171}
-
Sandra Sun authored
Since the swipe navigation shouldn't occur without the renderer calling OnOverscrolled(), this patch renames rendererDisabledOverscroll_ to overscrollTriggeredByRenderer_ and set the value to false for each gesture sequence. So unless OnOverscrolled() is called with overscroll-behavior:auto, swipe-navigation should not happen. Prior to this change, a webpage whose root scroller has overscroll-behavior:auto, but has another inner scroller with overscroll-behavior:none, overscrolling the inner scroller does not scroll the outer scroller(because the scroll chain is cut), and does not trigger OnOverscrolled(), leaving |rendererDisabledOverscroll_| with its default value of false. However, the unhandled scroll delta would still be directed to the browser side and triggers the navigation. Bug: 906765. Change-Id: I163c67b0f6201754133012ec98cc74bab9e78f0d Reviewed-on: https://chromium-review.googlesource.com/c/1403921Reviewed-by:
Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#628170}
-
bsheedy authored
Re-introduces the gtest-histogram conversion in process_perf_results.py, but restricts its usage to a whitelist. This is to help prevent the conversion from introducing widespread issues, instead isolating any potential issues to tests that are okay with being broken for a bit. Bug: 923564 Change-Id: Ic54312bfbe5f3dcde6f7d3cc915b18dfa00e2c5a Reviewed-on: https://chromium-review.googlesource.com/c/1449096 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#628169}
-
khachatryan authored
Due to dependences between the Window tests they are failing on Mac platform. Disabling those tests for Mac. Bug: chromedriver:2663 Change-Id: I5dddd1dc32e361f96b5de126abbb492f066e2bbf Reviewed-on: https://chromium-review.googlesource.com/c/1448688Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#628168}
-
Dan Beam authored
R=dpapad@chromium.org BUG=925209 Change-Id: I9704386f3856f601aa0c0c781f27ce28fe8e6b37 Reviewed-on: https://chromium-review.googlesource.com/c/1445313 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#628167}
-
Alexei Filippov authored
This is a reland of ccd67a4b Original change's description: > [heap profiler] Introduce the in-process samples storage mode. > > In the new mode the client heap_profiling::SamplingProfilerWrapper > collects and stores all the live allocation samples without sending > them to the profiling service. > > Profiling service can request the current profile from the client using > the RetrieveHeapProfile method of the ProfilingClient interface. > > TBR=dtrainor@chromium.org > BUG=923459 > > Change-Id: I0a787f1b8850b3dc3d48d27cabf71ee2baf5bd82 > Reviewed-on: https://chromium-review.googlesource.com/c/1432376 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#627138} TBR=erikchen@chromium.org,boliu@chromium.org,dtrainor@chromium.org,tsepez@chromium.org Bug: 923459 Change-Id: Ifc286d7010a2419521fa3bd1a9e9b473df0f3502 Reviewed-on: https://chromium-review.googlesource.com/c/1448973Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#628166}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/464111eaef80..846d12afedbf git log 464111eaef80..846d12afedbf --date=short --no-merges --format='%ad %ae %s' 2019-01-31 zoddicus@users.noreply.github.com Add whitelist for decorations in WebGPU (#2346) 2019-01-31 33432579+alan-baker@users.noreply.github.com Remove unused lambda capture (#2350) 2019-01-31 afdx@google.com Fixes #2338. Added functionality to remove OpPhi instructions (replacing their uses) when merging blocks (#2339) 2019-01-30 zoddicus@users.noreply.github.com Add WebGPU specific validation for WorkgroupSize BuiltIn decoration (#2334) 2019-01-30 zoddicus@users.noreply.github.com Add WebGPU specific validation for multiple BuiltIn decorations (#2333) 2019-01-30 zoddicus@users.noreply.github.com Add whitelist of allowed BuiltIn decorations for WebGPU (#2337) 2019-01-30 zoddicus@users.noreply.github.com Add WebGPU validation for LocalInvocationIndex BuiltIn decoration (#2335) 2019-01-30 zoddicus@users.noreply.github.com Add WebGPU specific validation for FragDepth BuiltIn decoration (#2332) 2019-01-30 zoddicus@users.noreply.github.com Add WebGPU specific validation for FragCoord BuiltIn decoration (#2331) 2019-01-30 zoddicus@users.noreply.github.com Add WebGPU specific validation for FrontFacing BuiltIn decoration (#2330) 2019-01-30 zoddicus@users.noreply.github.com Add WebGPU specific validation for InstanceIndex BuiltIn decoration (#2329) 2019-01-30 zoddicus@users.noreply.github.com Add WebGPU specific validation for VertexIndex BuiltIn decoration (#2328) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@846d12afedbf The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I6e318f5d574255576297a25bd2077dc44ea8e0e4 Reviewed-on: https://chromium-review.googlesource.com/c/1449012Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628165}
-
Fumitoshi Ukai authored
add category and short_name for builders in chromium.fyi.goma https://ci.chromium.org/p/chromium/g/chromium.fyi.goma/console and goma.latest https://ci.chromium.org/p/chromium/g/goma.latest/console Change-Id: I298a8038e416f8fca5ad5d3ad08cc02b1eab603b Reviewed-on: https://chromium-review.googlesource.com/c/1447355Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Auto-Submit: Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#628164}
-
Dan Beam authored
Update all the loading shims to account for this (and simplify code). Because prod code is bundled, we can just use --md-* vars from md_colors.css directly, rather than continue duplicating them (yay!). Drop toolbar bottom-border everywhere but in dev mode on extensions. In dev mode, extensions should have bottom-border below both toolbar and dev bar (and the loading shim should look accordingly as well). Additionally, fix some wrong icon colors inside toolbar (i.e. search, vertical more dots) and fix toolbar selection overlay bottom-border color. All of the changes in this CL are directly from Namrata. Screenshots (light & dark): https://imgur.com/a/yB0Xl19 R=dpapad@chromium.org BUG=883049,926937 Change-Id: I5b1ebc9d6130d2e899093602bf198cb407b46fdf Reviewed-on: https://chromium-review.googlesource.com/c/1445238 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#628163}
-
John Abd-El-Malek authored
Once this is rolled internally, CastNetworkContexts::OnLocaleUpdate needs to be called from SaveLocaleAndNotify. The functionality from CastHttpUserAgentSettings would then be fully ported to work with the network service. Bug: b/123321526 Change-Id: Ibb1b725a496bbb0803fe04260edaf2f5d7476b76 Reviewed-on: https://chromium-review.googlesource.com/c/1448238Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#628162}
-
Julian Pastarmov authored
It wasn't specific enough about not covering cert related interstitials. BUG=923867 TEST=none Change-Id: I7685706c666e6818e27f171e4ec9ac9f073c2a67 Reviewed-on: https://chromium-review.googlesource.com/c/1442792 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#628161}
-
Julie Jeongeun Kim authored
This CL removes dead files, merge_session_observer_bridge.mm/h. Bug: 926889 Change-Id: Ib66ed739e254bdac1be7b3019b270999c0e77fc4 Reviewed-on: https://chromium-review.googlesource.com/c/1447403Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#628160}
-
Wez authored
FDIO will implement BSD socket APIs using the new SocketProvider service rather than the old LegacySocketProvider, so add the new service to our sandbox policies. LegacySocketProvider will be removed after the Fuchsia SDK is rolled to pick up the new FDIO implementation. Bug: 927469 Change-Id: Ib662e052272a60dc1ee7d3d50553df89efa266df Reviewed-on: https://chromium-review.googlesource.com/c/1448985Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#628159}
-
Brian Salomon authored
Bug: skia:8736 Change-Id: If4d8eb548b8b8ec55ea93f8db82a72b3330e71aa Reviewed-on: https://chromium-review.googlesource.com/c/1448749 Commit-Queue: Brian Salomon <bsalomon@google.com> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#628158}
-
Xiaocheng Hu authored
Explainer: http://bit.ly/2QVAwGq#heading=h.i9ha0k20utmo This patch: 1. Adds line information into NGCaretNavigator. Each line is represented as a [start_offset, end_offset) range on |text_|. Also marks the role of each character in the line using newly introduced |CharacterFlag|. 2. Make visual caret left and right movements aware of the lines, so that it correctly moves across line boundaries even when bidi is involved. Bug: 894651 Change-Id: Ic0354feb6abf5de859dacb785e48493d355e3bfc Reviewed-on: https://chromium-review.googlesource.com/c/1407182 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#628157}
-