GitLab

Without check_output() the Popen() will always return None as returncode, this
prevents error handling during the build process.

With check_output() it will raise an exception in case of non-zero return code.

BUG=None

Review-Url: https://codereview.chromium.org/2947393002
Cr-Commit-Position: refs/heads/master@{#481948}

TriggerManager will now decide whether data collection can begin, and
whether a report can be sent, based on user preferences and incognito
state.

This also required moving the kSafeBrowsingExtendedReportingOptInAllowed
pref into component safe_browsing_prefs.

Bug: 730646
Change-Id: I9d84a550d389cc54eb1dfc2630066ca9fd6c5b20
Reviewed-on: https://chromium-review.googlesource.com/537392Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481947}

Adds grouping by section for resource_sizes diffs to make to diff
output easier to read. Removes summary from output diff file.

resource_sizes diff output:

MonochromePublic.apk_Breakdown (+17,441 bytes)
    +2,769 bytes Non-compiled Android resources size
    +8,712 bytes PNG drawables size
    +1,485 bytes Package metadata size
    +1,995 bytes Java code size
    +2,480 bytes Compiled Android resources size
MonochromePublic.apk_Specifics
   +25,038 bytes normalized apk size
       +20 zip entries file count
    +5,580 bytes main dex size

BUG=733307

Review-Url: https://codereview.chromium.org/2954043002
Cr-Commit-Position: refs/heads/master@{#481946}

Revert of Reland: Refactor DeviceMotionEventPump to use //device/generic_sensor instead of //device/sensors (patchset #14 id:260001 of https://codereview.chromium.org/2896583005/ )

Reason for revert:
Need to figure out some issues related to this CL on Windows.

To reland, need to add tests on Android and Mac, and fix the issue on Windows.

Original issue's description:
> Refactor DeviceMotionEventPump to use //device/generic_sensor instead of //device/sensors
>
> //device/generic_sensors already has all the sensors that can be used
> to implement the DeviceOrientation event:
> https://w3c.github.io/deviceorientation/spec-source-orientation.html
>
> Currently, //content/renderer/device_sensors uses sensors from
> //device/sensors as its backend, and this is one of the CLs that refactor
> //content/renderer/device_sensors to use sensors from
> //device/generic_sensor as the backend and removes //device/sensors.
>
> This CL refactors DeviceMotionEvent to use sensors from //device/generic_sensor.
>
> The issue page contains the design doc link for this change.
>
> BUG=721427
>
> Review-Url: https://codereview.chromium.org/2896583005
> Cr-Original-Commit-Position: refs/heads/master@{#480934}
> Committed: https://chromium.googlesource.com/chromium/src/+/687e6a76c9d634404eb93643ab900596a77958fd
> Review-Url: https://codereview.chromium.org/2896583005
> Cr-Commit-Position: refs/heads/master@{#481791}
> Committed: https://chromium.googlesource.com/chromium/src/+/33f72bfe8b9364e82990f92befa041a08d465d3c

TBR=reillyg@chromium.org,timvolodine@chromium.org,jam@chromium.org,scheib@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=721427

Review-Url: https://codereview.chromium.org/2953263002
Cr-Commit-Position: refs/heads/master@{#481945}

Previous attempt: https://codereview.chromium.org/2939373002

It was reverted because it caused large thinlto-cache directories
to be created on the perf bots, which were also being unnecessarily
included in package archives. This has been addressed in two ways:

1) the bots have been taught to exclude thinlto-cache from
   package archives (see https://chromium-review.googlesource.com/c/544530/).
2) this change limits the size of the cache to 10% of
   available disk space.

BUG=660216,735651
R=dpranke@chromium.org,thakis@chromium.org
TBR=thomasanderson@chromium.org

Review-Url: https://codereview.chromium.org/2957533002
Cr-Commit-Position: refs/heads/master@{#481944}

Implement the last minute font and string changes request.\

Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=735253#c4

BUG=735253
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2951213004
Cr-Commit-Position: refs/heads/master@{#481943}

The change explicitly initializes a COM MTA on the device polling
thread. Previously, an COM implicitly initialized an MTA on the first
CoCreateInstance call.

BUG=734706

Change-Id: I64e70f06b2e82520419ce74e3bc2db396896af4c
Reviewed-on: https://chromium-review.googlesource.com/544685Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481942}

This new method is only used in Android platform autofill which
requires to report actual text field change.

BUG=734702

Change-Id: I0487132d998bfc2f7244c534712b7ab24a3206d1
Reviewed-on: https://chromium-review.googlesource.com/540099
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481941}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e810453155c3..8d57d4e4986b

$ git log e81045315..8d57d4e49 --date=short --no-merges --format='%ad %ae %s'
2017-06-23 flackr Add pause option which pauses for interaction during tests.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ic515cca3cd83a73dd1b0485b44fd7da3028f5fcc
Reviewed-on: https://chromium-review.googlesource.com/545857
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481940}

Fixes some old trace events and adds a new one around condition matching.

Bug: 721512
Change-Id: I1f2dfb0708ea122b998c24a7fe21ca595c900160
Reviewed-on: https://chromium-review.googlesource.com/544195Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481939}

Change-Id: I59d60e77a96f389410d97847166182986ca662c8
Reviewed-on: https://chromium-review.googlesource.com/544904Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481938}

Chromecast has some tests that need this.

BUG=

Review-Url: https://codereview.chromium.org/2949403002
Cr-Commit-Position: refs/heads/master@{#481937}

These are string literals used as property keys, so we will internalize them
anyway, so using V8AtomicString will be faster and in most cases not need to
allocate a new string.

Change-Id: Iee92eb672dfc308a79688e9055c144bf95b35fb4
Reviewed-on: https://chromium-review.googlesource.com/545776Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481936}

BUG=730589

Review-Url: https://codereview.chromium.org/2944383006
Cr-Commit-Position: refs/heads/master@{#481935}

We now bundle lld on linux for linux builds.  Add this symlink to make it
easier to use it for cross builds too.

BUG=495204

Review-Url: https://codereview.chromium.org/2948413002
Cr-Commit-Position: refs/heads/master@{#481934}

https://skia.googlesource.com/skia.git/+log/8c86588d1bcc..a46969229d6b

$ git log 8c86588d1..a46969229 --date=short --no-merges --format='%ad %ae %s'
2017-06-16 halcanary SkPDF: implement SkPDFArray::reserve.

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=halcanary@chromium.org

Change-Id: I6b99cb172f2b11a394d62bca37ea09958f563cfb
Reviewed-on: https://chromium-review.googlesource.com/545976Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481933}

Use array elements instead of pointer values in comparisons involving
pointers to member functions.
One of these comparisons failed on Windows Debug and others are suspect
of failing on WinClang DLL builds.

BUG=736309

Review-Url: https://codereview.chromium.org/2958543002
Cr-Commit-Position: refs/heads/master@{#481932}

Native interface ContentViewCore is going away. This CL replaces
it usage in embedders with WebContents/ViewAndroid in preparation
of the deletion. This CL make changes to media-related part.

BUG=626764

Change-Id: I4afee7e603d8ea9d801f09e7f2a5ef27faf2dd68
Reviewed-on: https://chromium-review.googlesource.com/543081Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481931}

This reverts commit 44820576.

Reason for revert: This seems to break WebRtcApprtcBrowserTest.MANUAL_WorksOnApprtc test. The failure is consistent on Win bots and very likely on Mac bots:
https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/35214
https://build.chromium.org/p/chromium.webrtc/waterfall?builder=Mac%20Tester

Original change's description:
> [Mojo Video Capture] Enable service in default testing config
> 
> This CL is part of the Mojo Video Capture work.
> Design doc for dev work [1].
> Design doc for launch [2].
> 
> BUG:584797,721812
> 
> [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing
> [2] https://docs.google.com/document/d/1RLlgEdvqRA_NQfSPMJLn5KR-ygVzZ2MRgIy9yd6CdFA/edit?usp=sharing
> 
> Change-Id: I38b83efdf1e8619e3edba95df70a6b5fdae30a3f
> Reviewed-on: https://chromium-review.googlesource.com/524298
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Commit-Queue: Christian Fremerey <chfremer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#481767}

TBR=jwd@chromium.org,chfremer@chromium.org

Change-Id: Ife2bf7fc75a09528de04e08b5f8e4d4e7f94660c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/546276Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481930}

This avoids a blocker on removing HASH_VALUE_SHA1 and was unnecessary.
The |key_hash| field can just as easily be a der::Input and BoringSSL
already has abstractions for computing a digest. It also allows us to
fill in missing hash functions.

Bug: 564281
Change-Id: Ib044df61bb7bdfc4c5b021861c8f0561635dc6a8
Reviewed-on: https://chromium-review.googlesource.com/545017Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481929}

To help debug the Scheduling.Browser.MainAndImplFrameTimeDelta2 metric, this
adds a trace of the times used to compute the impl and main frame delta. We
should be able to use this to identify which frames were identified as slipping
and when those times were recorded.

BUG=719667

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6ab1d6ca72f0c3ec186740d33014e8d39cfe8404
Reviewed-on: https://chromium-review.googlesource.com/535658Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Brian Anderson <brianderson@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481928}

NOTRY=true
TBR=kinuko@chromium.org
BUG=736362

Review-Url: https://codereview.chromium.org/2954143002
Cr-Commit-Position: refs/heads/master@{#481927}

BUG=706832
TEST=Remove -Wno-shift-negative-values from Chrome OS build.
TEST=Build Chrome for Chrome OS, no warnings/errors.
TEST=Build Chrome with chromeos=1, no warnings/errors.

Change-Id: I71936ec6d3a41c787febe1b83f865fed2cd322fa
Reviewed-on: https://chromium-review.googlesource.com/546035Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481926}

This is a mechanical change.

At high level:
* Not posting to the FILE thread.
* Posting to a task runner obtained by calling GetTaskRunnerForThread.

Bug: 735695
Change-Id: I273289deeb1af44868970d561717fa03615a932c
Reviewed-on: https://chromium-review.googlesource.com/544444Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481925}

This CL adds a feature flag for image capture to ease debugging of
issues in the wild (e.g. https://crbug.com/722038 and
https://crbug.com/709819).  The flag is enabled by default:
  chrome://flags/#enable-image-capture-api

Bug: 735661
Change-Id: Iab06dbc9e6d4a5ecbbf85f70ad7221770915b464
Reviewed-on: https://chromium-review.googlesource.com/544185Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481924}

ProfileDownloaderDelegate implementation may delete ProfileDownloader inside
OnProfileDownloadSuccess or OnProfileDownloadFailure, so profile_image_fetcher_
has to be reset before calling these methods.

Bug: 736358
Change-Id: I5f16bd1c3b54f7f317957cf916ef1b9d93b30494
Reviewed-on: https://chromium-review.googlesource.com/546055Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481923}

https://chromium-review.googlesource.com/c/542962/ was reverted due to
a bug, however, part of the changes are still useful, so restore them
in this CL. And specifically, this CL refactors CRWWebController and
web view creation utils to use UserAgentType.

Bug: 
Change-Id: Iafaca12bd30d1b84b315295ee090e7ee68161bfe
Reviewed-on: https://chromium-review.googlesource.com/545112
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481922}

* Add workarounds for YCM build failures
* Fix recommended vscode settings to match recommended YCM path

Bug: none
Change-Id: I906ce3ede9d58ff2974de1c0d094eefd00b9f589
Reviewed-on: https://chromium-review.googlesource.com/546155Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481921}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/753d46ee..5844b475

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2954133003
Cr-Commit-Position: refs/heads/master@{#481920}

We send a fake mousemove event to check if there is any change of the
element underneath the mouse cursor, but we should not send the mousemove
event to the DOM, because the mouse does not move.

Bug: 333623
Change-Id: I037ce8f56605afc4b21031095425bdeee8b0aa0c
Reviewed-on: https://chromium-review.googlesource.com/537514Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481919}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2886043003
Cr-Commit-Position: refs/heads/master@{#481918}

The function name follows the WTF Vector convention.

Needed in LayoutNG.

BUG=636993

Review-Url: https://codereview.chromium.org/2956603002
Cr-Commit-Position: refs/heads/master@{#481917}

The problem only happens when an external monitor is connected to a MBP
and works together with the built-in screen. If the desktop capture is
started from the external monitor, e.g. window picker locates on the
external monitor, there is no notification bar on any screen. There is
no such problem when desktop capture is started from built-in screen.

The problem is because chrome aligns the notificaiton bar to the
cooridnates of the external monitor, but still draw it to the built-in
screen.

The fix is to draw the notification bar to the screen from which the
desktop capture is started, by adding the offset of x coordinat of the
curren |mainScreen|.

Bug: 671427
Change-Id: Ida11c91cc0525dc14110f42662c9f3269bf09234
Reviewed-on: https://chromium-review.googlesource.com/545115Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481916}

This removes the call to start() at the end of init(), and instead
waits until data is fed in. At that time, it writes as much data as
the AudioTrack instance takes, then calls start(), then feeds in any
additional data not taken on the first call.

Bug: internal b/62923451
Test: run on IMX7, observe logs for playback of TTS and Media
      streams, notice no underruns reported

Change-Id: I89b272655176d22e0cb17e896fe6b9c1daa3e717
Reviewed-on: https://chromium-review.googlesource.com/545262Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Chris Kuiper <ckuiper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481915}

The end-point now supports passing memory dump configs. Add tests.

BUG=chromium:735124

Review-Url: https://codereview.chromium.org/2954603002
Cr-Commit-Position: refs/heads/master@{#481914}

This tweaks/removes/reduces/throttles logging during audio playback
in CMA backend for Android. In addition, it added a couple of missing
initializers in AudioSinkAudioTrackImpl.

Bug: None
Test: run on IMX7, observe fewer/better logs...
Change-Id: I3ca294abe50a3e2a62c95c6b0feaff5bde485cdb
Reviewed-on: https://chromium-review.googlesource.com/545261Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Chris Kuiper <ckuiper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481913}

- Creates TransitionController objects so Coordinators don't have to conform to the
UIViewControllerTransitioningDelegate protocol. This will make it easy to switch out
to different transitions or make AB experiments.

- Moves the presentationFrame calculation into the MenuPresentationController,
which also reduces code duplication. In order to make this possible the
MenuPresentationDelegate has changed.

BUG=682880

Review-Url: https://codereview.chromium.org/2952213003
Cr-Commit-Position: refs/heads/master@{#481912}

When CSSParserContext is created, it determines whether the context
is in quirks mode or not, by looking at master document's quirks mode
flag instead of context object's document. This worked for stylesheets
in <style> element in an import, because the style rules defined
there actually applies to the master document.

This caused problem for querySelector/querySelectorAll because
the query mode mismatches when the master document is in quirks mode.
HTML Imports are always in no quirks mode without DOCTYPE declaration[1][2].

As we optimize ID match for quirks mode by lowercasing IDs in HTML
and ID selectors in CSS, but when the master document is in quirks
mode, querySelector in import ran in quirks mode (thus selector was
lowercased) while IDs in import are preserving case, and never matched.

The fix for this is to check if it is in querySelector (i.e. not
using dynamic profile), use the document's mode, rather than its
master document's mode.

[1] http://w3c.github.io/webcomponents/spec/imports/#additions-to-tree-construction-algorithm
[2] https://www.w3.org/Bugs/Public/show_bug.cgi?id=24349

Bug: 621172
Change-Id: I110bd62df962009ee015239fbc0e5fe24a1e6893
Reviewed-on: https://chromium-review.googlesource.com/544732
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Rune Lillesveen <rune@opera.com>
Cr-Commit-Position: refs/heads/master@{#481911}

Bug: 732846
Change-Id: I12291bfc4484a11cd068a50fd3603525d6577c18
Reviewed-on: https://chromium-review.googlesource.com/533217
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481910}

BUG=727173

Change-Id: Idb20e6d81192865d125c802e40ef58ab1960ffbd
Reviewed-on: https://chromium-review.googlesource.com/545136
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481909}