- 29 Aug, 2019 21 commits
-
-
Charlene Yan authored
Bug: 985382 Change-Id: I9bcc3f7429b0c2a2e697f6e2cfae5888448249c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775102 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#691409}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/83785d063c61..378c18813b5a git log 83785d063c61..378c18813b5a --date=short --no-merges --format='%ad %ae %s' 2019-08-28 lujc@google.com Use ProgramPipelineID in place of GLuint handle 2019-08-28 syoussefi@chromium.org Vulkan: Expose EXT_instanced_arrays 2019-08-28 lujc@google.com Use PathID in place of GLuint handle Created with: gclient setdep -r src/third_party/angle@378c18813b5a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: None Change-Id: I3e4b4d16cc291937fd9140d158f2086d7a70c338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775362Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691408}
-
Darren Shen authored
This reverts commit 524aa9d4. Reason for revert: Possible cause of crbug.com/998978 Original change's description: > Do not perform font scanning when cache directory not configured > > Fixes flakiness in unit testing due to DWriteFontLookupTableBuilder > spuriously trying to index fonts when it should not. > > In order to test DWriteFontLookupTableBuilder a cache directory is > configured for persisting the built table. The same happens when a full > browser runs with a profile - in which case a subdirectory of the > USER_DATA directory is used. Do not scan fonts if a directory is not > configured. > > This situation happens in unit tests in tests other than the > DWriteFontLookupTableBuilder unit tests, as ContentClient and > BrowserClient do not return a path for GetFontLookupTableCacheDir() in > testing. It is sufficient to test DWriteFontLookupTableBuilder in its > own unittests. If local unique font matching on Windows 7 is required in > a unit test, a cache directory can be configured using > DWriteFontLookupTableBuilder::GetInstance()-> > SetCacheDirectoryForTesting(...) > > Thanks to etienneb@ for spotting this problem and initial fix proposals. > > Bug: 996167 > Change-Id: Iccac27225d7be7fc464a645e7e7689eba3680efa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769437 > Reviewed-by: Etienne Bergeron <etienneb@chromium.org> > Commit-Queue: Dominik Röttsches <drott@chromium.org> > Auto-Submit: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691074} TBR=drott@chromium.org,etienneb@chromium.org Change-Id: Id60995dd4584df96b354a38779d76056dfd946eb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 996167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775638Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#691407}
-
Min Qin authored
The function has no ReferrerURL and the TODO has no ldap associated. The LOG was added by accident. Change-Id: Id90e4c3011ae9d06eca21fed51a5ca74e622dd00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775367Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#691406}
-
Sophie Chang authored
This will be populated by the first call to CanApplyOptimization and used in subsequent calls to the same method. Since a hint may have a lot of page hints, this is an optimization to short circuit that loop and only perform matching if necessary. Bug: 969558 Change-Id: I07ce231c862a6d1fb63260655480c243292a47d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775320Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#691405}
-
Oksana Zhuravlova authored
This change modifies BrowserInterfaceBrokerProxy::SetBinderForTesting() to remove the override if the passed callback is null, which is now done in MojoInterfaceInterceptor::stop(). Bug: 985118 Change-Id: I67ad6a6d8fcd3414d51f27f0b7b3cfa41f289e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773577 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#691404}
-
Dominic Battre authored
Bug: 984214 Change-Id: I0b90216bd601b0c8db7f56bf4c669e569e61e574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771396 Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#691403}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/650859b42008..ca0eac314b80 git log 650859b42008..ca0eac314b80 --date=short --no-merges --format='%ad %ae %s' 2019-08-28 enga@chromium.org Add Dawn perf test harness Created with: gclient setdep -r src/third_party/dawn@ca0eac314b80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I7a675e9066cf1e990cbfde2d68b06018e553dc6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775414Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691402}
-
minch authored
Bug: 995598 Change-Id: I0c66ec9635d681a3ae416546c1dc0e2e7db08c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772284Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#691401}
-
Daniel Rubery authored
When the appropriate policies are set, report all files that were too large to scan. Bug: 980777 Change-Id: I3e45acb89d40c31e284cf437e4df4b3f9c70eafa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774884 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#691400}
-
Henrique Ferreiro authored
Finish the migration of blink.mojom.OomInterventionHost and blink.mojom.OomIntervention started in https://crrev.com/c/1755798. Also, this CL overloads content::BindInterface to accept a Remote<T>. Bug: 955171, 978694 Change-Id: Id2775c8d5ce7281ccfc71ab20f4a061102047b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768520 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#691399}
-
Pratish Kumar authored
This CL introduces a logic to break the text runs whenever a link is found while generating the text runs in PDFiumPage::GetTextRunInfo(). A new method PDFiumPage::CalculatePageObjectTextRunBreaks() is introduced which pre-populates a set of text breakpoints according to the start and end char indices of links in the page. PDFiumPage::GetTextRunInfo() uses that pre-populated set to determine the text run boundary. This CL includes a unit test to verify the text runs in a pdf page which has a link in between a text block. Bug: 981448 Change-Id: Ib2787c92688b819f6e63da60aaf0c4e4c4c82cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765094 Commit-Queue: Pratish Kumar <prkum@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#691398}
-
Bill Budge authored
- Adds a constructor to BigBuffer, taking a single size_t parameter. - Extracts logic from BigBufferView into a helper function that can be used by both classes. Bug: chromium:992991 Change-Id: If271c770643ea3810d64a8ca224837a2d0771dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773843Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#691397}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7a7555ea7c86..25af6422926b git log 7a7555ea7c86..25af6422926b --date=short --no-merges --format='%ad %ae %s' 2019-08-28 andrewlamb@chromium.org Turn off hardware tests for betty. 2019-08-28 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@25af6422926b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I78482006b317db631eebbe8ca4b3d22c1da77b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775183Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691396}
-
Jamie Walch authored
We have received feedback that the string displayed when consent is needed from the user for Chrome Remote Desktop to control their computer is too complicated. This replaces it with the suggestion from UXW. Bug: 902041 Change-Id: I683e92e3a38d9cfd4d2d5bb00fd40a08f23bfb84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775353Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Auto-Submit: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#691395}
-
dpapad authored
Also add a new "Dynamic import" entry, in the "To Be Discussed" section, to ensure that we don't accidentally allow dynamic imports before examining any complications (for example ESLint breakage) further. Bug: 915053 Change-Id: I0f166cabcedfd4cc8cc445ad177e5344d7ac8b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733576Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#691394}
-
Erik Chen authored
The build-flag `strip_absolute_paths_from_debug_symbols = 1` produces deterministic outputs and has better goma caching, but breaks lldb. This CL adds machinery to help users get functional symbols in lldb while still using that compile flag. Bug: 330262 Change-Id: I42f1e6c9c76296d451730ea481d7e1c3c0a69476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775227Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#691393}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/88d42e9dea21..8624d125dc22 Created with: gclient setdep -r src-internal@8624d125dc22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I49d8f8fd2388050091ffd775e4aa89306961ab9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775184Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691392}
-
Jimmy Gong authored
- The header for saved printers will be hidden when the saved printers list is empty. - Adds a browsertest to reflect this change. Bug: 993819 Test: browser tests, end to end manual Change-Id: I4bbae8f389161a7c3252df09d39380c896413fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767488 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#691391}
-
Paul Dyson authored
Bug: 991433 Change-Id: I00980c065ed913f463c01a9c2c33b8f98d27a846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772942 Commit-Queue: Paul Dyson <pdyson@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#691390}
-
Kai Ninomiya authored
This was always supposed to be supported, but it seems we accidentally enabled it only on WebGL 2.0 contexts. This also adds this extension to the WebglExtension_* tests, though it wouldn't have caught this bug because those tests are always run with --enable-webgl-draft-extensions. Change-Id: I749790f242ac96cfff44e0db07598b9d5c6473bc Bug: 998878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775077 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#691389}
-
- 28 Aug, 2019 19 commits
-
-
Fabrice de Gans-Riberi authored
* This will allow Cast applications to be debuggable remotely via the DevTools protocol on port 9222. Bug: 997895 Change-Id: Iec595c5955f289b08c00795c3c7b07e91dbf603e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774200 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#691388}
-
Yusuke Sato authored
BUG=998847 TEST=sign in, enable two or more CrOS keyboards, enable ARC, then navigate to chrome://restart. Make sure CrOS login screen is not shown. Change-Id: I01dd27f0cd3203c664cefb73e25210b6f3db9c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774906Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#691387}
-
Min Qin authored
This CL allows us to track how download home was opened by user. For prefetch, they are categorized into UNKNOWN for now. BUG=988562 Change-Id: I463d63769c6e367a5bda8bba67b0147cf009290b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764885Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#691386}
-
Tom Anderson authored
R=mostynb@vewd.com BUG=978360 Change-Id: I82c59faa054cb5a0d1fd3d315971cd09b9e48205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775503 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:
Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#691385}
-
Andrey Kosyakov authored
Bug: 998421 Change-Id: Idbc111bd68e65acfd977f9d55ed077f0a1989059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772314 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Auto-Submit: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#691384}
-
Joel Hockey authored
The Terminal System App overrides the default app menu to show its own set of commands. When commands are selected, the terminal app is navigated to a new URL with a fragment associated with each command. Screenshot at: https://bugs.chromium.org/p/chromium/issues/detail?id=846546#c23 Bug: 846546 Bug: 998900 Change-Id: Id5601ea7ed8fd2ba40fe116434d1b2951773c761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753373Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#691383}
-
Paul Dyson authored
Bug: 991433 Change-Id: I781824a30f8d7e4103eac956acad7dd2a82627d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771231Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#691382}
-
Jeffrey Kardatzke authored
This is already being anonymized by stripping the serial from the EDID on input to edid-decode, but that means the checksum validity portion of edid-decode is always wrong. This CL strips the serial number that is output from edid-decode. Then we can stop stripping the serial number from the input to edid-decode, since this will anonymize it instead. Then at that point the checksum line in edid-decode will be correct. Bug: 961857 Test: Unit tests pass, serial is redacted in a feedback report Change-Id: If5a7413c140f0068f171c9035f3622175d5845ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773704 Commit-Queue: J Kardatzke <jkardatzke@chromium.org> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#691381}
-
Etienne Bergeron authored
This CL is activating the PlatformFontSkia on windows in the unittests. The migration is completed and there is a plan to activate the feature on Dev/Stable in the next release. R=robliao@chromium.org, asvitkine@chromium.org Bug: 944227 Change-Id: I8e5d13e04ad228a3f1aa33c6e1cd0a6ec84d0716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771180Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#691380}
-
Theresa Wellington authored
This reverts commit 0ac4f8fb and adds back a null removed in the original CL. This CL also hides the "Show in folder" object behind a separate flag that is default enabled so that the feature can be turned off independently off the reorder bookmarks feature. BUG=994293 Change-Id: Iaf753ba073ef724af78fd5d532d74aa71d81277b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772311Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#691379}
-
Robert Ogden authored
The cached data is an optimization and non-trivial to sort out per- origin, so just remove it all. Note that this is safe to do even when an active prober has a copy of the dictionary being cleared because the dictionary is read before being written to. Change-Id: Id1980ef20c3e08a1b0e556a616266e3b156080da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772240Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#691378}
-
Lukasz Anforowicz authored
Instead of crashing the NetworkService, we should treat this just as any other bad IPC message. Bug: 920634 Change-Id: I0184ea87f8b5fe81af40bb20965310045034cf3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764551 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#691377}
-
edchin authored
This reverts commit 34445e49. Reason for revert: ios-simulator-cronet compile fails Original change's description: > [ios] Use posix TimeExploded > > With 32 bits build gone, iOS can use the posix implementation of > TimeExploded, which is faster. > > Bug: 985061 > Change-Id: Ic1d42ebddfa2d0bb0d37bb7b2086683914aa87a5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763679 > Commit-Queue: David Jean <djean@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691094} TBR=miu@chromium.org,marq@chromium.org,kylechar@chromium.org,jbudorick@chromium.org,djean@chromium.org Change-Id: I09bc777ac81d89d85e2f7b0804b1c2ebfb541520 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 985061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775383Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#691376}
-
Nicolas Arciniega authored
There is a gap in testing for this policy. Group policy tests already ensure that this affects the kQuickCheckEnabled preference. In network context code, NetworkContextTest.PacQuickCheck tests the feature itself. There is no test that ensures that setting the kQuickCheckEnabled preference sets the right value in the network context mojo parameters. This test fills in that remaining gap. Bug: 981598 Change-Id: I739d4a0a937c5552d18e24fba0406d88713f304e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775259 Commit-Queue: Nicolas Arciniega <niarci@microsoft.com> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#691375}
-
Anand K. Mistry authored
The test uses EXPECT_DEATH in a multi-threaded environment, which is known to be unsafe by default. Changing the death test style to "threadsafe" makes it safer. BUG=None Change-Id: I0cbd046f294a6c4237da102739ee231f28e3eebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772955Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#691374}
-
Richard Townsend authored
Clang fails to compile code using the __prefetch macro in a DirectX header. This patch will temporarily work around the issue. Bug: 998160 Change-Id: Ie4828a3a3de4e6bb0573cbdf2e41484d917ef19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774283Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#691373}
-
Darren Shen authored
This reverts commit c7ea6754. Reason for revert: Possible cause of crbug.com/998948 Original change's description: > Add tick duration argument to testdriver Action > > We want to allow the users to define the duration for every tick, so we > add an argument to Action class which will be a duration for all > ticks. If there is a tick which need a different duration, we can call > addTick or pause to pass a different value. > > Bug: 606367 > Change-Id: I7e5d88557f5f4a4c63dbf85985c30881aee9f739 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762836 > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691186} TBR=lanwei@chromium.org,nzolghadr@chromium.org Change-Id: I52a0c14b77c9c6139b2f01b6a449d604fbe137d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 606367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774427Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#691372}
-
Daniel Rubery authored
For each triggered rule in the DLP response, we report the download as violating that rule. This also implements the UnsafeReportingEnabled enterprise policy, which controls whether or not we do any reporting. Bug: 980777 Change-Id: I48100cfb4dd5aa92ed80da1f34e64a6e393be2fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772381 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#691371}
-
Wenjie Shi authored
The Windows.Devices.Sensors WinRT path is currently streaming sensor data. This means a JS event will be raised every 200 ms whenever a client is subscribed to it. This makes it much more expensive to use than the existing ISensor API path. In order to help parity the performance cost, software thresholding will be implemented in the Chromium back end for Windows.Devices.Sensors. Chromium will filter out samples that don't meet a certain threshold and avoids a raising a JS event, which is the most costly operation. Threshold values were taken from the suggested defaults from: https://docs.microsoft.com/en-us/windows-hardware/drivers/sensors/sensor-thresholds-v2. Assuming the OEM/IHV used the default value, there should be threshold value parity with the ISensor path. In the future, once the current Windows SDK comes out of preview state, Windows.Devices.Sensors will support built-in hardware thresholding. Once that occurs, the software thresholding should be switched to that. This bug has been opened to track it: crbug.com/995594 Bug: 958266 Change-Id: Ib6f139f4532b064f802662283a413c0989b8817b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761473Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Wenjie Shi <wensh@microsoft.com> Cr-Commit-Position: refs/heads/master@{#691370}
-