- 03 Sep, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/77743492418e..e9d9a3278fdf git log 77743492418e..e9d9a3278fdf --date=short --no-merges --format='%ad %ae %s' 2019-09-03 brianosman@google.com Remove GrGLProgram cache stats, remove spurious declarations/includes 2019-09-03 halcanary@google.com gn: move all skia_* declare_args to skia.gni 2019-09-03 egdaniel@google.com Track all sampled textures in GrOpsTask and pass them to GrOpsRenderPass. 2019-09-03 bungeman@google.com [pdf] Only compute needed advances. 2019-09-03 kjlubick@google.com [canvaskit] Add rrect support 2019-09-03 reed@google.com update test to allow dumping images Created with: gclient setdep -r src/third_party/skia@e9d9a3278fdf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@google.com Bug: chromium:996185 Change-Id: If16273cf83c08501ef8d164287269e7f429c87f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783078Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692834}
-
Misha Efimov authored
- Keep NSURLRequest.HTTPBodyStream in HttpProtocolHandlerCore::http_body_stream_ to work around system behavior of returning new NSStream object for each call if NSURLRequest.HTTPBody is set. - Initialize |http_body_stream_delegate_| to nullptr if request doesn't have a body. - Rename HttpProtocolHandlerCore::http_body_stream_[delegate_] member variables for consistency. TBR=dschinazi@chromium.org Bug: 979324 Change-Id: Ibc0b5d4226c3e517f314e66fa305a995b54cc008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778407 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#692833}
-
Sidney San Martín authored
The toolbar buttons were easy to hit by accident. Bug: 999545 Change-Id: I7922fc6a942190e1f53bc37b49fe9bda09c516ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783197Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#692832}
-
Steven Bennetts authored
internet-detail-dialog is a top level element that may be loaded before InternetDetailDialogUI::BindCrosNetworkConfig() is called, causing 'chromeos.networkConfig.mojom' to be undefined when the HTML is loaded. Because of this, defining 'const mojom = chromeos.networkConfig.mojom' at the top level triggers an error. To address this, avoid using the alias outside of individual JS methods. This also fixes an error where cr_network_listener_behavior.html was not being included. Bug: 1000207 Change-Id: Id1c87c08a1c019d4c4dafbbc668dcce63c1c9c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783064 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#692831}
-
Mitsuru Oshima authored
Original CL: crrev.com/c/1767716 Bug: 989052 Change-Id: Id2e5e00c922e7e707afd0ad3312ad4b3d0aa9fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781541Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#692830}
-
Mikel Astiz authored
This experimental mode will allow plumbing the sync encryption keys by means other than the keystore keys in the sync protocol. Bug: 1000146 Change-Id: Ic78acb87036b4d1ba5158b260e4f383b08d550bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714585 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#692829}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d9cbe7ad6916..1db68ea0ba17 git log d9cbe7ad6916..1db68ea0ba17 --date=short --no-merges --format='%ad %ae %s' 2019-09-03 jmadill@chromium.org Add ANGLE issue tracker to my_activity.py. Created with: gclient setdep -r src/third_party/depot_tools@1db68ea0ba17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:None Change-Id: I9e0e88876a967729b617d6934222879d0eb51ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783244Reviewed-by:
-
Sidney San Martín authored
Also unlist Cocoa owners; they don't need to be bugged about this flag. Change-Id: Id90a93c424c7b5b65f5863b4d9bccd712d76db37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782941 Auto-Submit: Sidney San Martín <sdy@chromium.org> Reviewed-by:
-
Alexander Hendrich authored
This CL implements focusing behavior when tabbing through elements in the login screen extension UI's window. When reaching the last element of the window, the next tab will focus the first element of the login tray. When reaching the last element in the login tray, the next tab will focus the first element in the window. The same procedure also works with backwards tabbing (shift+TAB). Bug: 957573 Change-Id: I0e08c8b2a58e9b7efe4497927044f25277afb56b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774448 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#692826}
-
Nikita Podguzov authored
After UX decide to remove placeholders from printing strings we should also remove it from the code. Current behavior causes crash of DCHECK() here: https://cs.chromium.org/chromium/src/ui/base/l10n/l10n_util.cc?l=742 Bug: 985020 Change-Id: Ib929037beb6b3cc5ad70c86f36d52480145daa47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778489Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#692825}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/437660031093..050b124d7838 git log 437660031093..050b124d7838 --date=short --no-merges --format='%ad %ae %s' 2019-09-03 syoussefi@chromium.org Reland "Vulkan: Debug overlay" 2019-09-03 mihu@microsoft.com ANGLE test fixture leaking. Created with: gclient setdep -r src/third_party/angle@050b124d7838 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: None Change-Id: Id65c1b414268947a5ddacafdd7612229cab6087e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782746Reviewed-by:
-
Dominic Battre authored
One challenge of fixing local heuristics is to understand why a certain field has been classified by the local heuristic. This CL introduces corresponding logging in chrome://autofill-internals. Bug: 928595 Change-Id: Ia6b31ced07c58e7b6c8ee330243e3ae577505847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781462 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#692823}
-
Yannic Bonenberger authored
*** Note: There is no behavior change from this patch. *** This CL replaces calls to base::{Bind,BindRepeating} with calls to base::BindOnce, and removes calls to base::AdaptCallbackForRepeating when the returned base::RepeatingCallback is immediately converted to a base::OnceCallback. This CL was uploaded by git cl split. R=nharper@chromium.org Bug: 714018 Change-Id: I097288f597b7287b3e6c0f512fe7d69ab374a315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778610 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:Nick Harper <nharper@chromium.org> Auto-Submit: Yannic Bonenberger <contact@yannic-bonenberger.com> Cr-Commit-Position: refs/heads/master@{#692822}
-
David Bokan authored
This fixes the use counter for tracking cases where URL fragments have a superfluous hash character. Previously we would count ##targetText in the URL if the targetText feature was disabled. However, that invalidates the metric since we expect an uptick in these kinds of urls even if the feature is disabled. We're trying to find out how often we see a '#' in a URL fragment to determine the compatibility impact (since this is an invalid URL today). This CL prevents counting any URL with "#targetText=" in the fragment. Bug: 987027 Change-Id: Ic0297d9eab307c87c47c2106c1ed2c9022b53bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782132Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#692821}
-
François Doray authored
This reverts commit 15047f92. Reason for revert: Test MediaDialogViewBrowserTest.ShowsMetadataAndControlsMedia introduced by this CL is flaky since it landed. Original change's description: > GMC: Add interactive UI tests > > This CL adds some basic interactive UI tests for the global media > controls. This ensures we have better coverage than just unit tests. > > Bug: 993879 > Change-Id: I05b5c99959794bacb49813edcaeabf9fb3ed1382 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753690 > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691215} TBR=sky@chromium.org,beccahughes@chromium.org,steimel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 993879, 999297 Change-Id: I7ab6b3ff0d47e0e06d858377fb2c57bb7c093d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782939Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#692820}
-
Anatoliy Potapchuk authored
When a kiosk app is set to be auto-launched and the user cancels its launch, we should disable auto-launch on next boot. This was achieved by setting "KioskAppLaunch" variable into the local state, and subsequently resetting it every time. This variable was reused by both plain kiosk and arc kiosk modes. The variable was reset in only one of the code paths, leading to a race condition when second one tries to read from already reset variable. There are many possible solutions for this, one of the simplest ones is to persist the error state during the whole boot. Bug: 984740 Change-Id: I161daae80a4fedb51d47ebff93b84e34bfc475b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781431Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#692819}
-
Samuel Huang authored
This CL is the last piece for minimally viable DevUI DFM: Detect whether the host of a chrome:// URL request belongs in the DevUI DFM. If so, and if the DevUI DFM has not been installed and loaded, then rewrite the URL to chrome://dev-ui-loader, which is the interstitial to install / load the DFM, and on success, redirect to the original chrome:// page. Details: * URL rewrite uses existing BrowserURLHandler framework, which also has the advantage showing the original URL in the Omnibox. * Currently the only DevUI DFM host is chrome://bluetooth-internals. More will be added in the upcoming weeks, but these require case-by- case refactoring and BUILD file changes. * Add dev_ui_url_handler.* to implement detection logic and rendering of chrome://dev-ui-loader URL. * Currently redirection only keeps original URL's host, but not /path?query#fragment. This will be fixed in a follow-up. * The current chrome:// restrictions should suffice in preventing abuse of chrome://dev-ui-loader's ability to redirect. Meanwhile, the DevUI DFM feature is still behind the |dfmify_dev_ui| build flag. Bug: 927131 Change-Id: I2d108e648a9e8ac8f67a2b697ea615b01a1cf826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782016Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#692818}
-
Ayu Ishii authored
This changes does the bare minimum to remove the concept of timeouts from the SMS Receiver API. There will be following changes that will remove timeouts from the interface of the API and from the renderer process. Change-Id: If453d8b550090f6cfe0c22823fc7dcc9b1f587b5 Bug: 1000376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783219Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#692817}
-
Vadym Doroshenko authored
Bug: 984296, 995515, 997857 Change-Id: Ifb60a731b6bff185ea967d1fa107dfe84136d7c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782165 Auto-Submit: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#692816}
-
Andrew Grieve authored
This reverts commit 1595330c. Reason for reland: Tweaked rules & ensured all targets compile locally. Bug: 987226, 986693 Change-Id: I6987ca442089db80b7f4b8f44d51e1fda923bb3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726230 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#692815}
-
Daniel Libby authored
The original change to enable scrollbar latency for the composited scrollbars incorrectly used an existing member to try and determine whether a GestureScrollUpdate was the first one in an injected sequence or not. is_first_gesture_scroll_update_ was incorrect because it is only updated when input is actually dispatched to InputHandlerProxy, and the flag is cleared for all GSUs before the location where it was being read. This bug was missed because of incorrect tests. The VerifyRecordedSamplesForHistogram method doesn't actually assert or expect anything - the return value must be inspected. As part of fixing up the tests, I made a few other changes to get them passing consistently across all platforms: - turn on main thread scrollbar injection feature (in case it's ever turned off we don't want the tests to start failing) - enable mock scrollbars - disable smooth scrolling - don't run scrollbar tests on Android The composited scrollbar button test is disabled due to a bug in how the mock theme reports its button sizes, which throws off the region detection in ScrollbarLayerImplBase::IdentifyScrollbarPart (filed crbug.com/974063 for this issue). This previously landed as crrev.com/c/1652741 but was reverted for flakiness on ChromeOS. I'm unable to repro (ran 100s of times both locally and on swarming bots) the flakiness at this point, but have expanded out the histogram names to not use variables in order to better determine where the flakiness might be coming from. (Also crrev.com/c/1725224 added a RunUntilInputProcessed that could have fixed this flakiness). Bug: 954007 Change-Id: Ic102aebbcbd627ecb5edd0a0633ac2e8b1d17db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774911 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#692814}
-
Dave Tapuska authored
Rename variables to be more unique used so that they don't shadow variables possibly on the stack. BUG=794619 TBR=davidben@chromium.org Change-Id: Ic0818da5f6a6ab5fa60c4122a172ada7428251a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782969 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c7910d19fe50..086835f3ffbf git log c7910d19fe50..086835f3ffbf --date=short --no-merges --format='%ad %ae %s' 2019-09-03 natlee@microsoft.com Vulkan: Use dynamic uploader for temp buffer when clearing textures. Created with: gclient setdep -r src/third_party/dawn@086835f3ffbf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I03f94bf13ab9a074d1a78e615a0006549d2659ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782980Reviewed-by:
-
Vasiliy Telezhnikov authored
This CL fixes race condition in TrackedCallback. We must pass the same lock to conditional variable that we use to guard code when we signal it. Otherwise there is chance that we signal it before we start waiting and will wait forever. In previous code we call lock_.release() and then Wait() on conditional variable. In between the SignalBlockingCallback could be called and signal before wait will happen. Bug: 997329 Change-Id: Ifc16f1f8337846a1c253d91f59558ee1731256f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771383Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#692811}
-
Patrick Monette authored
Bug: 973497 Change-Id: I2c9df65478d9d140b3239215d5029768b558b02c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775460Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#692810}
-
Jérôme Lebel authored
When creating a tapable link with LabelLinkController, an accessibility identifier is needed to be able to test the UI. Adding -[LabelLinkController addLinkWithRange:url:accessibilityID:]. Patch needed for crrev.com/c/1782804 Bug: 1000357 Change-Id: I90cdeef60e94b8cd527f9d457209823002be68d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782801Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#692809}
-
Matt Wolenetz authored
Subtest: "Media tracks must be removed when the HTMLMediaElement.src is changed": Changing an HTMLMediaElement's src attribute to be "" will result in asynchronous error due to the value being empty. That error could race an otherwise-successful completion of that avtracks' subtest. This change fixes that race by making the subtest change the src attribute to a valid, newly created, MediaSource objectURL. This path (per spec) should still detach the previously attached MediaSource, and in the process of doing that, drop all of its tracks. Subtest: "Media tracks must be removed when the HTMLMediaElement.load() is called": A similar race is removed from another avtracks subtest by dropping that subtest altogether. The dropped "...load() is called..." subtest issues a load() on an HTMLMediaElement that was previously attached to a MediaSource via an already-revoked MediaSource objectURL. The load() call would find no object associated with that URL, so would eventually hit a similarly racing error path in attempting to fetch the resource via that now-revoked objectURL. While the previously attached MediaSource is detached correctly per spec, including dropping the avtracks, this test cannot be fixed by simply not revoking the previous MediaSource objectURL before doing the load() because Chrome will soon have auto-revoking MediaSource objectURLs (see https://crbug.com/920044). Therefore, this specific subtest is dropped from the test suite. BUG=994175,920044 TEST=http/tests/media/media-source/mediasource-avtracks.html Change-Id: I663d56e59a5055d9cf64c041c8661dcd2d1f0566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783224Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#692808}
-
Allen Bauer authored
Bug: 940771 Change-Id: I0eb0e5d6b23f371244bbeff1da5c654885defe3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783225 Auto-Submit: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#692807}
-
Xinghui Lu authored
Currently, password protection is not enabled on Android. In this change, the main goal is to build password protection service into Android apk and enable on-focus ping. The size of apk is going to increase by around 20kb, which is expected, since password protection service is built into it in this change. There are two types of pings sent by password protection: on focus ping and password reuse ping. In order to provide more granularity on which ping is enabled on different platform, a new key ON_FOCUS_PING_ENABLED is introduced to work alongside with SYNC_PASSWORD_REUSE_DETECTION_ENABLED. some TODOs will be addressed in other CLs: 1 Enable verdict cache manager 2 Enable CSD whitelist Bug: 995926 Binary-Size: Increase is due to password protection service built in, it is crucial for security. Change-Id: Ibf982f2f8e5d58d2cbea3aa78d5d25bb11bf7b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758740 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#692806}
-
Aga Wronska authored
Parent access view has different layout and size in tablet mode (virtual PIN keyboard is shown). The widget should resize together with the view. Bug: 991387 Test: ParentAccessWidgetTest Change-Id: I8f0232e2618198950b4e23acf7a7ada82400e570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779663 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#692805}
-
Roman Sorokin authored
Instead of the board name. Bug: 938738 Cq-Depend: chromium:1725615 Change-Id: Ie62ade68ec431cd11a3704f38246ddcb5775922f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725636 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#692804}
-
Ben Pastene authored
Disabling while we work on auth issue. Bug: 1000351 Change-Id: I7bd5af645ce2c40fa91de766bdeada44420d2039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780340Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#692803}
-
François Doray authored
This reverts commit 67d9a27b. Reason for revert: Speculative revert for crbug.com/1000427 Original change's description: > Remove ExternalBeginFrameControllerClient interface > > > ... and replace it with a callback to IssueExternalBeginFrame. > > Also, deprecate Headless.needsBeginFrameChanged in the protocol -- > the client is supposed to always attempt to drive frames. > > Bug: 997946 > Change-Id: Idd0f773b80e027241960451b638427366b4b07c1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768880 > Reviewed-by: ccameron <ccameron@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Michael Spang <spang@chromium.org> > Reviewed-by: Johannes Henkel <johannes@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692688} TBR=sky@chromium.org,dcheng@chromium.org,spang@chromium.org,ccameron@chromium.org,caseq@chromium.org,sunnyps@chromium.org,johannes@chromium.org,sagallea@google.com Change-Id: I6c410127479a4677b62df50a58770f14d3cf9f14 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 997946, 1000427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782515Reviewed-by:
-
minch authored
See https://docs.google.com/document/d/1DFKZsXCU4GySB9Ry8Bhd8k8sB7pO5wOz0GBcFmAq5B4/edit?pli=1#heading=h.8xp39kibavgr for details. Bug: 982950 Change-Id: I2025ad188db3f72dae55a649d69fd97eaab8c59a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779448 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#692801}
-
François Doray authored
This reverts commit f8ab5df9. Reason for revert: crbug.com/1000419 Original change's description: > Move definition of kWebRtcH264WithOpenH264FFmpeg to Blink > > This is a precursor CL to Onion soup'ing > content::RtcVideoEncoderFactory (phase 2.3 in the design document [1]). > > [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ > > Basically, it merged the definition and declaration of > content/public/common/feature_h264_with_openh264_ffmpeg.cc|h > into Blink's features.h. More specifically, to > third_party/blink/public/common/features.h (declaration) and > third_party/blink/common/features.cc (definition). > > This allows rtc_video_encoder_factory.cc|h to move to Blink in a > follow up step. > > BUG=787254 > R=guidou@chromium.org, haraken@chromium.org, jam@chromium.org > > Change-Id: I4ba7c59da0f799e1d30053923fb1e692202223b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778671 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692757} TBR=kinuko@chromium.org,jam@chromium.org,haraken@chromium.org,guidou@chromium.org,tonikitoo@igalia.com Change-Id: Ifb9829e762ec86bfca81f1d17b2ce76fd692ffaa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787254, 1000419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782511Reviewed-by:
-
Dominic Mazzoni authored
Manually tested with ChromeVox and verified that forward-translation and text editing work as expected. Automated tests all pass. Bug: 985499 Change-Id: I2e86424d402b81ec3a25db558bab3370a62b6b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782673Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#692799}
-
François Doray authored
This reverts commit 880ea642. Reason for revert: crbug.com/1000419 Original change's description: > Move moar content::kWebRtcHWH* definitions to Blink > > Particularly, this CL moves the features definitions needed by > content/renderer/media/webrtc/rtc_video_encoder_factory.cc, > so that it can be moved to Blink in a later step. > > This CL is a precursor CL for phase 2.3 on the design document [1]. > > [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ > > BUG=787254 > R=guidou@chromium.org, haraken@chromium.org, thestig@chromium.org > > Change-Id: If68e934449c0b34235b82d2b605c62cd13d84b3d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778672 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692760} TBR=thestig@chromium.org,jam@chromium.org,haraken@chromium.org,guidou@chromium.org,tonikitoo@igalia.com Change-Id: Id04ca4db1c7aa7c9fe86f255f8d2a68effdb0a60 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787254, 1000419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782510Reviewed-by:
-
François Doray authored
This reverts commit 19c2d0e4. Reason for revert: crbug.com/1000419 Original change's description: > Onion soup content/renderer/media/webrtc/rtc_video_encoder_factory.cc|h > > This is phase 2.3 on the design document [1]. > > [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ > > BUG=787254 > R=guidou@chromium.org, haraken@chromium.org > > Change-Id: I32628d84aaba9eba9bde7c9484f8984517b9abf4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778673 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692762} TBR=haraken@chromium.org,guidou@chromium.org,tonikitoo@igalia.com Change-Id: Iec91bfa7b37f4b5c5b5ea2869cd9f1839dfc7b22 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787254, 1000419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782509Reviewed-by:
-
François Doray authored
This reverts commit c96f561e. Reason for revert: <INSERT REASONING HERE> Original change's description: > Remove web_rtc_video_encoder_factory.h from the Blink API > > ... now that its solely client has been Onion soup'ed [1]. > > [1] https://crrev.com/c/1778673/ > > BUG=787254 > R=guidou@chromium.org, haraken@chromium.org > > Change-Id: Iec6d37197e2899f3381029b0e9b628c8d927722b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778674 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692769} TBR=haraken@chromium.org,guidou@chromium.org,tonikitoo@igalia.com Change-Id: Ia36cbfec8168a1c4e9a61e36313c25cead691f13 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782508Reviewed-by:
-
minch authored
See https://docs.google.com/document/d/1DFKZsXCU4GySB9Ry8Bhd8k8sB7pO5wOz0GBcFmAq5B4/edit?pli=1#heading=h.vzu2voccv5dk for details. Bug: 982950 Change-Id: I325be649349aa1b4c20a6285e097d82da3737e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776596 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
-
