GitLab

Avoid a race condition in reordering of notification bubbles when canceling them.

BUG=89078
TEST=none

Review URL: http://codereview.chromium.org/8774027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112835 0039d316-1c4b-4281-b951-d872f2087c98

Shaving parallel authenticator yak to remove unnecessary dependency on this class from OAuth specific code. Moved system salt and supplemental key related methods to cryptohome and cert libraries instead.

BUG=chromium-os:23301
TEST=none

Review URL: http://codereview.chromium.org/8761016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112834 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=overflow test

Review URL: http://codereview.chromium.org/8776035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112833 0039d316-1c4b-4281-b951-d872f2087c98

Tested by comparing output of ./scons -n extra_sdk_update_header both before and after.

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8785002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112832 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manual


Review URL: http://codereview.chromium.org/8733014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112831 0039d316-1c4b-4281-b951-d872f2087c98

I recently landed a patch that defers the SelectFileDialog::Listener callback until the file picker window is closed.  The test needed to be updated to simulate closing the window so that the Listener would delete itself.

BUG=none
TEST=unit_tests, memory waterfall

Review URL: http://codereview.chromium.org/8787007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112830 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=103443
TEST=Try to print tiles in a build with the PDF plugin / print preview on.


Review URL: http://codereview.chromium.org/8772053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112829 0039d316-1c4b-4281-b951-d872f2087c98

Fixes a race on startup. See issue for details.

BUG=chromium-os:20865
TEST=Ensure logging, including VLOG, works.
TBR=willchen@chromium.org

Review URL: http://codereview.chromium.org/8757002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112828 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin
Review URL: http://codereview.chromium.org/8789006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112827 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin
Review URL: http://codereview.chromium.org/8784004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112826 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin
Review URL: http://codereview.chromium.org/8788003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112825 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin
Review URL: http://codereview.chromium.org/8787003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112824 0039d316-1c4b-4281-b951-d872f2087c98

They used to be children of the root.  This change makes
shadows track their windows' transforms and simplifies the
code (as we no longer need to track stacking or parenting
changes).  I am still slightly worried that shadows will
look strange if we scale windows up or down, but we can
figure out how to deal with that when we need to.

BUG=101977
TEST=added; also hacked up StackingController to rotate and scale windows and checked that shadows were drawn as expected

Review URL: http://codereview.chromium.org/8785005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112823 0039d316-1c4b-4281-b951-d872f2087c98

Use ppapi_sources.gypi for nacl trusted build.scons like the untrusted nacl.scons does (mirroring nacl.scons changes in http://codereview.chromium.org/8727029/)

R=noelallen@chromium.org,bradnelson@chromium.org
BUG= none
TEST= ppNaClPlugin builds in nacl via scons.

Review URL: http://codereview.chromium.org/8769052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112822 0039d316-1c4b-4281-b951-d872f2087c98

Whitelists the following permissions:
 - contentSettings
 - pageCapture
 - webNavigation
 - webRequest
 - webRequestBlocking

BUG=105630
TEST=existing


Review URL: http://codereview.chromium.org/8770051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112821 0039d316-1c4b-4281-b951-d872f2087c98

 - didReceiveMessageError() handling
 - didStartClosingHandshake() handling
 - didReceive* state_ checking
 - MayForceCallback handling

BUG=87310
TEST=ui_tests --gtest_filter='PPAPITest.WebSocket*'

Review URL: http://codereview.chromium.org/8772001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112820 0039d316-1c4b-4281-b951-d872f2087c98

initiated by the client itself.

BUG=106208

Review URL: http://codereview.chromium.org/8772065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112819 0039d316-1c4b-4281-b951-d872f2087c98

base::SharedMemory now takes a flag for whether executability is required.
Plumb that through the Linux-only proxy for this interface.

BUG= http://code.google.com/p/chromium/issues/detail?id=103377
TEST= nacl still works

R=mseaborn@chromium.org,jam@chromium.org

Review URL: http://codereview.chromium.org/8776053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112818 0039d316-1c4b-4281-b951-d872f2087c98

or select text.

BUG=104468,104469
TEST=none
Review URL: http://codereview.chromium.org/8776030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112817 0039d316-1c4b-4281-b951-d872f2087c98

The fixed window size was too small for a tabbed browser window,
causing the window to grow after being restored.

BUG=105356
TEST=ExtensionApiTest.UpdateWindowShowState

Review URL: http://codereview.chromium.org/8762006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112816 0039d316-1c4b-4281-b951-d872f2087c98

Add abstract GetGroupsToChange() method to ModelChangingSyncerCommand.
Use that to figure out which worker threads to post work on (instead of
posting on all of them).

Implement GetGroupsToChange() for each ModelChangingSyncerCommand.

Add GetEnabledGroups() and GetEnabledGroupsWithConflicts() functions to SyncSession.

Key unapplied updates index by type for ApplyUpdatesCommand.

Make the abstract methods of ModelChangingSyncerCommand protected.

This patch includes a speculative fix for the perf regression introduced by the last time this was landed (112178).

BUG=97832
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112178

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112743

Review URL: http://codereview.chromium.org/8637006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112815 0039d316-1c4b-4281-b951-d872f2087c98

add attributes for the min and max scroll position, as the
first step towards implementing accessible scrolling APIs.

BUG=104468
TEST=none
Review URL: http://codereview.chromium.org/8776026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112814 0039d316-1c4b-4281-b951-d872f2087c98

This is so we can use the webstore app for dogfood experiments.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8771045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112813 0039d316-1c4b-4281-b951-d872f2087c98

Adds XInput redist DLL which is a new dependency of recently added gamepad code,
and is required on Win XP. laforge has OK'd the size addition to the final
package (~100K).

BUG=79050

Review URL: http://codereview.chromium.org/8774023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112812 0039d316-1c4b-4281-b951-d872f2087c98

is enabled, and for a pseudonymous ID to attach to logged events.

BUG=106208

Review URL: http://codereview.chromium.org/8775066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112811 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105997
TEST=Open NTP, verify that no warnings appear in console.
Review URL: http://codereview.chromium.org/8776054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112810 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105941
TEST=Verify NTP4 still works, tree green.
Review URL: http://codereview.chromium.org/8776015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112809 0039d316-1c4b-4281-b951-d872f2087c98

This breaks some ChromeOS tests. Among the log output:
"Feature 'chrome_url_overrides' is not allowed in this type of manifest."

Original review: http://codereview.chromium.org/8654001

BUG=101992, 104103, chromium-os:23709
TEST=no

Review URL: http://codereview.chromium.org/8786004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112808 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112807 0039d316-1c4b-4281-b951-d872f2087c98

It is possible to try and close the window now before the TemplateURLService is loaded. In this case we will not have a fallback search engine to select by default. So we will just reject attempts to close the window in this circumstance until it is loaded and a fallback choice has been set. It should be an edge case.

http://crbug.com/106078
TEST=unit test
Review URL: http://codereview.chromium.org/8771018

TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8790001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112804 0039d316-1c4b-4281-b951-d872f2087c98

It's typically extensions/apps team members making changes to the manifest file
here.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8789001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112803 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112802 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8785001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112801 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r7301: (pdox) Update BINUTILS_REV to pull in merge with git binutils repo up to
r7302: (ncbray) NaCl Mac 10.5 buildbots use Python 2.7 instead of 2.5.
r7303: (jasonwkim) Disable x86* translator on CrOS due to missing shim
r7304: (jvoung) Do a barrel^H^H^H^H^H^H toolchain DEPS roll!
r7306: (robertm) Add support for a bigger jail whih can  build large parts of chrome.
r7307: (dschuff) Fix unrecognized option bug in pnacl-translate, make run.py quiet mode swallow sel_ldr stderr output
r7308: (dschuff) Update torture test scripts to use clang, update known failures for clang
r7309: (sehr) Make llc and ld command lines use argz, and add new command line interfaces
r7310: (mseaborn) x86-64 Windows: Fix check in stack unwinding test to be suitably strict
r7311: (robertm) Exclude /usr/lib LIBPATH when using arm cross toolchain.
r7312: (mcgrathr) Move over tweaks to munge-phdr script from chromium repo
r7313: (mseaborn) Re-enable the multiple-sandboxes test on x86-32 Linux
r7314: (sehr) Update toolchain to get http://codereview.chromium.org/8771010/.
r7315: (robertm) update arm trusted TC to lastest version (manually built, labelled "rev 7000")
r7316: (mseaborn) Remove redundant "exit_status=0" arguments
r7318: (noelallen) Revert of ARM break.
r7320: (krasin) Update glibc rev to 9e33f4. This brings in: Define __WORDSIZE 32 for strt* routines.
r7321: (jvoung) Bump chrome deps / binary rev.
r7323: (sehr) Add needed Pnacl support to sel_universal.  This allows testing the argz-based
r7324: (jvoung) DEPS-in third_party/ply from chromium to allow running the IDL generator
r7326: (mseaborn) Enable tests/windows_crash_in_syscall to build with PNaCl
r7327: (mseaborn) sync_tgz.py: Fix unchecked subprocess.call() call
r7328: (ncbray) Browser tests are retried when known flake occurs.

BUG=none
TEST=nacl_integration

Review URL: http://codereview.chromium.org/8775037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112800 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=checklicenses.py should work on third_party/libphonenumber
Review URL: http://codereview.chromium.org/8769025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112799 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105046
TEST=manually


Review URL: http://codereview.chromium.org/8651001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112798 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105797
TEST=Manual


Review URL: http://codereview.chromium.org/8676049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112795 0039d316-1c4b-4281-b951-d872f2087c98

R=jhawkins@chromium.org
BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8733013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112793 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8774016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112792 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105763


Review URL: http://codereview.chromium.org/8735004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112790 0039d316-1c4b-4281-b951-d872f2087c98