- 27 Mar, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If9d344b84e58ecd730c26be997a7bacf8990dc39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125011Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754144}
-
Varun Khaneja authored
R=xinghuilu Change-Id: Ib12238898aae23f4c60ee5d26701026e15d3cfd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119755 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#754143}
-
Mario Sanchez Prada authored
Migrate this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Also, rename its filename to something more descriptive and less Chromium-specific (it currently references crbug.com/527039). Bug: 1063749 Change-Id: I55e9eb8b1943f1c9f71861b53437cd0e1908889b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124257 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#754142}
-
Lei Zhang authored
Move some message sending code into SendDocumentMetadata() and SendLoadingProgress(). Change-Id: Ic9881444f1af57531dc49ee2527ded092d7ffec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122924 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#754141}
-
Adam Langley authored
With M82 canceled, the original plan to leave this on M82 beta for a while is sunk. With M83 picking up two releases worth of changes, it's a poor choice for a potentially disruptive feature like this. It can still be enabled via chrome://flags for testing, but this change disables it by default for M83 to branch off. BUG=1028602 Change-Id: I746a3c7d89199b0521a68c6231a1dbef82027dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124599 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#754140}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a0519c673493..395a627b8ad8 git log a0519c673493..395a627b8ad8 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 rmhasan@google.com [Typ] Add getters for raw tags and raw results to Expectation Created with: gclient setdep -r src/third_party/catapult@395a627b8ad8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1050754 Tbr: wenbinzhang@google.com Change-Id: Iaa8f1206b7599b8924d45ebe7c279e49de043a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124670Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754139}
-
Evan Stade authored
This relands commit ce01fae5 but instead of including dialog_strings.grdp from two different grd targets, it uses the WebLayer components string whitelist. A small amount of extra work had to be done to package the strings tagged formatter_data="android_java" in components_strings.grd into a java string target. TBR=tedchoc@chromium.org Bug: 1058495 Change-Id: I94aae6e9f75f5252123fb83b6ade28cbf5c1f3ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124699Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#754138}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I7f8640cc02c10a929fe536ae31073b4a72849019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124873Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#754137}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/276eb74c..761afa07 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0ff7a17671a6fcadc4d7b14b5f075e70b8bc0382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124735Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754136}
-
Xiaohan Wang authored
Historically media_service_unittests needs a different test runner and involves a standalone binary with it's main() function and mojo manifest file. So we had put the tests in its own test target. After several redesign and refactoring, now these tests are just normal unit tests. There's no reason to treat them separately anymore. This CL folds media_service_unittests into media_unittests to simplify our test code. Bug: 1062194 Change-Id: I62ae08706b755622fd348189ecc87192e5e4b797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118582Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#754135}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fd3480d22624..7e0699a25089 git log fd3480d22624..7e0699a25089 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 timvp@google.com Create the ProgramExecutable Class Created with: gclient setdep -r src/third_party/angle@7e0699a25089 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: Ic026deeb835b8a18d51023cab71b85e37180de58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124808Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754134}
-
Tibor Goldschwendt authored
An interactive doodle can request to be resized via a postMessage. Resize doodle as requested when such a message is received. Bug: 1039910 Change-Id: Icd4563cabf1edc28eb22268c5e7969194cada2a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117299 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#754133}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4243010e6c8d..4502a6360996 git log 4243010e6c8d..4502a6360996 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 treehugger-gerrit@google.com Merge "Use random session name in HeapprofdJavaCtsTest." Created with: gclient setdep -r src/third_party/perfetto@4502a6360996 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id49f5627d4ca1d481befcf4f3f2879bf04b94988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124820Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754132}
-
Justin Donnelly authored
I couldn't check out the branch during my branch sheriff shift yesterday until I figured out that I needed to run git fetch. This CL basically copies the similar note from: https://www.chromium.org/developers/how-tos/get-the-code/working-with-release-branches Change-Id: I00a09a995ccedf49ea535f6ab3ed56d8c32eed13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124306Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#754131}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/60f529d224f9..a35ca2b5e91d git log 60f529d224f9..a35ca2b5e91d --date=short --first-parent --format='%ad %ae %s' 2020-03-27 jacktfranklin@chromium.org E2E test for element breadcrumbs 2020-03-27 tvanderlippe@chromium.org Remove unused global references from sdk-legacy.js Created with: gclient setdep -r src/third_party/devtools-frontend/src@a35ca2b5e91d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032561,chromium:1064958 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie4fef47e92ca38c9aad0e9b566c336e40f4d93a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124812Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754130}
-
rbpotter authored
Bug: 1026426 Change-Id: I3f20bae0e8fe0c22d401efb633ffaec80d93a12b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123769Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#754129}
-
David Bokan authored
This is a small cleanup. The code here was added way back in https://crrev.com/ba35627328434 as part of https://bugs.webkit.org/show_bug.cgi?id=11985. Today, scrollbar enabled state is computed explicitly in UpdateScrollbarEnabledState. I believe this is no longer needed, to see why: - This will only make a difference if the scrollbars were disabled prior to reaching this method. - If the scrollbars were disabled and were overflow:scroll, this means they didn't have overflow - If overflow was added at the same time as the style changed, we'll do a layout and update enabled state in UpdateAfterLayout or UpdateAfterOverflowRecalc - Otherwise, the scrollbars will be removed as there's no overflow and we're in overflow:auto|visible|hidden. Bug: None Change-Id: Iabc37c6933f43726529fb7fb19436393c53a5014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123635Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#754128}
-
Tommy Martino authored
TBR=pkasting@chromium.org Change-Id: I304210aac096854f666cafa2103ee9aed9f0df96 Bug: 1065474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125007Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#754127}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b7aacaca. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" a1caf42e "[css-flexbox] Move flex-item-contains-strict.html test to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: panicker@chromium.org, tdresser@chromium.org: external/wpt/paint-timing NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I63a5abde01fbfe26cf3884495fb590a651135b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124730Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754126}
-
Ovidio Henriquez authored
This change revives the PositionCache metrics to help us investigate the behavior of it and to help us investigate the geolocation API request traffic. Bug: 944320 Change-Id: Ic9b5d3b4ce266943804287dda8ac9777829a0f9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122467 Auto-Submit: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#754125}
-
Katie D authored
This reverts commit aba65951. The reland conflicted with another change I submitted 12 hours earlier. This fixes the conflict. Original change's description: > Improves distilled page metrics code health. > > Refactors a test DistillabilityObserver for use in multiple > browsertests. > > Adds DCHECK and adjusts tests to use an observer so as not > to hit the DCHECK. TBR=ellyjones@chromium.org Bug: 1061928, 1063961 Change-Id: I6d1140f118b164be98b16c8a0a6c5ef940955c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118211 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#754124}
-
Piotr Bialecki authored
Changes: - make anchor and plane pose nullable in blink - rename plane's pose matrix to align with existing convention - stop passing `const MojoPtr&`s around - this is equivalent to passing a smart ptr via const-reference There *should* be no functional change introduced by this CL. Change-Id: I6786053d07154ebeb8dade478a31596fdc302d8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123332Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#754123}
-
Lei Zhang authored
Stop collecting this data since the reported numbers have been steady over time. Bug: 1053099 Change-Id: I0326fbefa0758db0ab256215748ff36d697340b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122863 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#754122}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/22e477b2ce1d..774019051243 Created with: gclient setdep -r src-internal@774019051243 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1060280 Tbr: jbudorick@google.com Change-Id: Ia6d573613d17b4dc4d45ba789f4b3516906b9b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124811Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754121}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/fa17e1bc3e84..41820cd74f31 git log fa17e1bc3e84..41820cd74f31 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 dschuff@chromium.org Build arm trusted code in the Chrome sysroot Created with: gclient setdep -r src/native_client@41820cd74f31 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: mseaborn@chromium.org Change-Id: I3ab5c6ccb7cf3671a0bf50889406f7076ae55ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124818Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754120}
-
Jonathan Ross authored
As a part of the existing Gpu Peak Memory Traces, we wish to also report the size of the differences. To make analysis easier. This updates GpuChannelManager::SequenceTracker to also track the initial state, and to use this when recording the traces. An example trace has been added to the tracking issue. TEST=GpuChannelManagerTest.GpuPeakMemoryOnlyReportedForValidSequence Bug: 1054256 Change-Id: I62855d76c897ff33bed2840d144727afba8aaabe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115796 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#754119}
-
Jorge Lucangeli Obes authored
BUG=None TEST=CQ Change-Id: Id8ade84f94a4efac3860b3c540010bc4feff7248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125027 Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#754118}
-
Leonard Grey authored
The code this comment refers to was removed (though it would be nice for us to do this in Views browser at some point after fullscreen works better). Bug: 1063417 Change-Id: I2fe3b964842f1d64e82de592d0742f906dab8a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124727Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#754117}
-
Dave Tapuska authored
- Remove passing tests - Move some MSAN test failures into MSANExpectations BUG=983788,984438,984467,663585,1050559 Change-Id: I78a83ce61b9fa95a804649568733d793f84b6ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122910 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#754116}
-
Sreeja Kamishetty authored
This reverts commit d2cce3a4. Reason for revert: To avoid large code changes/fixes according to the guidelines and postponing landing this CL after M83 branches out. Original change's description: > [content] Introduce RenderDocumentHostUserData > > This CL introduces RenderDocumentHostUserData(RDHUD) API through which > we can associate data with the underlying document. > > This patch converts UsbTabHelper to use RenderDocumentHostUserData and > replaces existing manual tracking of frame lifetime in a map. > Currently a map from render_frame_host to the FrameUsbServices is > maintained to get the associated FrameUsbServices > object instead we use RDHUD to do the same set of operations. > > This document https://docs.google.com/document/d/138_67WkBaU35W_wlLUS7ux-ICM_5tosdyLOBiqvlWs8/edit?usp=sharing > explains in more detail on how RenderDocumentHostUserData can be > used and extended to different classes. > > BUG=1057611 > > Change-Id: I37894f2897f4f7b2c5bbd10d422a39daba9bd0c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055105 > Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Jun Cai <juncai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754070} TBR=nasko@chromium.org,rockot@google.com,fdoray@chromium.org,reillyg@chromium.org,clamy@chromium.org,alexmos@chromium.org,juncai@chromium.org,altimin@chromium.org,arthursonzogni@chromium.org,sreejakshetty@chromium.org Change-Id: If3a7449dd9155c542bf374cd2bcbf8aec267ffdd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1057611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124671Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#754115}
-
Dominique Fauteux-Chapleau authored
This handler validates the policy source is clud and it inherits from SchemaValidatingPolicyHandler since all of the connectors are configured by json. Bug: 1062338 Change-Id: I7e2c8a2b9f8618438af9fd8d151e1324482ed968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116010 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#754114}
-
behdad authored
This is a reland of 20dddaa6 The cause of revert was: crbug.com/1064605 Original change's description: > Added MissedDeadlineFrame category to Compositor Latency > > When a frame is started being tracked in controller the deadline is > recorded in compositor_frame_reporter and after presentation of the frame > it's compared to the presentation timestamp, and if it missed the > deadline is reported under CompositorLatency.MissedDeadlineFrame as well as > the super-set of CompositorLatency. > > Bug: chromium:1058909 > Change-Id: I39a624b3b0e11d764af26f92b5d849605a94ec0a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096791 > Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752939} TBR=schenney@chromium.org Bug: chromium:1058909 Change-Id: Id368127bcf57e2d9d882228a21fa0ed36f204310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122227 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#754113}
-
John Budorick authored
Bug: 1063671 Change-Id: I44e8c579c3d789539d07005ad883906d38e6c480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121033Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#754112}
-
Sophie Chang authored
This adds a feature parameter within the LoadingPredictorUseOptimizationGuide feature to dictate whether to actually use the predictions for preconnect or anything else later. I tested via browser tests by removing the DISABLED_ locally. I'm not remove the DISABLED_ in real code since I still haven't been able to repro the flake locally and don't know the root cause of the flake on bots. Bug: 1064121 Change-Id: I6a47645662b04760520c8eff4dd52ec7f55ca064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119372Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#754111}
-
Adam Langley authored
The native code cannot vary between Clank builds, but the Java code can. This change enables the caBLE v2 native Clank code unconditionally which will allow a future change to enable the Java code in default and canary builds. BUG=1002262 Change-Id: I60e34a8751f566bd41373a261a13c578100cf327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124303Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#754110}
-
Adam Langley authored
The C++ classes that reflect the CTAP2 protocol produce a lot of cruft. This change removes their use on Android in favour of some more hair-raising code. BUG=1002262 Change-Id: I6b039651ea291b14cbd53cb7e153e9a5833d9328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116942 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#754109}
-
Mehran Mahmoudi authored
This test seems to flaky. Disabling for now. Bug: 1065441 TBR: ckitagawa@chromium.org Change-Id: Iab0cac8fdbe605f299a607dc3540e3167adaaba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124705Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#754108}
-
Yaron Friedman authored
There's a flaky failure on the KK bot and screenshot shows the dialog still up. Let's try this first. BUG=1062568, 727310, 999361 Change-Id: I68f98c9d5a3174ccea09467473257d49462bd75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124302Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#754107}
-
Andrew Grieve authored
Noticed a bot failed because of this missing dep: https://ci.chromium.org/p/chromium/builders/try/android-binary-size/473198 Bug: 1056299 Change-Id: I76267f48ff1b7071af6c082c4b64ab18a807da07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124693 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Henry Jian <hzjian@chromium.org> Reviewed-by:
Henry Jian <hzjian@chromium.org> Cr-Commit-Position: refs/heads/master@{#754106}
-
Thomas Lukaszewicz authored
Removed the need for GetInstanceForNativeUi() in SharingDialogView, cleaned up unnecessary code and wrapped several uses of icons with ImageViews that keep colors up to date on theme changes. Bug: 1056916 Change-Id: Id1a3a132803b1ec563903e19d9f80f102eb3157b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122239Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#754105}
-