GitLab

There was a potential for a subtle race built into these tests:
if the timing of determining the language shifted, the observer
may end up waiting forever. This is what's happening in
https://codereview.chromium.org/1398823004, and the race
becomes visible.

Instead, let's reogranize observation of
chrome::NOTIFICATION_TAB_LANGUAGE_DETERMINED to be managed
at the test harness level and ensure that observation begins
outside of the message loop pump.

Also, let's move a very similar test from browser_browsertest
and convert it to use the same machinery.

Finally, refactor that test to remove another subtle race:
it actually opens two tabs and receives two notifications,
but that is only vaguely implied by the test logic.

R=jam,jochen,toyoshim@chromium.org
BUG=521166

Review URL: https://codereview.chromium.org/1420093004

Cr-Commit-Position: refs/heads/master@{#357176}

This more or less reverts commit 735b8fd7.

BUG=549161

Review URL: https://codereview.chromium.org/1422773003

Cr-Commit-Position: refs/heads/master@{#357175}

BUG=528839
R=behdad,eae

Review URL: https://codereview.chromium.org/1422503010

Cr-Commit-Position: refs/heads/master@{#357174}

BUG=546840

Review URL: https://codereview.chromium.org/1418073008

Cr-Commit-Position: refs/heads/master@{#357173}

This changes the method to only do the unscaling. Callers use a
ScopedCanvas instead. Then they don't need to call Restore()
themselves.

R=pkasting, sky

Review URL: https://codereview.chromium.org/1425163002

Cr-Commit-Position: refs/heads/master@{#357172}

give them the smaller upload progress job for now.

BUG=548819

Review URL: https://codereview.chromium.org/1416003008

Cr-Commit-Position: refs/heads/master@{#357171}

This CL converts references to LayoutSVGInlineText* objects and some general
LayoutObject* to the equivalent objects in the new line layout API
(LineLayoutSVGInlineText and LineLayoutItem). No functional changes.

BUG=499321

Review URL: https://codereview.chromium.org/1411123014

Cr-Commit-Position: refs/heads/master@{#357170}

See the screenshot of all the notifications types I'm trying to align here: https://drive.google.com/a/google.com/file/d/0B44CKnXso82GQUstazR0b3ZxZVZHbkRXczdVX19Udlgtbnlv/view?usp=sharing

Align the one and two button case with the existing video flinging notification (see remote_notification_bar.xml). Reduce the gap between the two buttons.

BUG=541629
TBR=mlamouri@chromium.org

Review URL: https://codereview.chromium.org/1427023003

Cr-Commit-Position: refs/heads/master@{#357169}

We are pretty sure problem was fixed by https://codereview.chromium.org/1414603003/

BUG=542521

Review URL: https://codereview.chromium.org/1407203003

Cr-Commit-Position: refs/heads/master@{#357168}

BUG=482083

Review URL: https://codereview.chromium.org/1423313006

Cr-Commit-Position: refs/heads/master@{#357167}

R=jwd@chromium.org
BUG=471815

Review URL: https://codereview.chromium.org/1411153006

Cr-Commit-Position: refs/heads/master@{#357166}

This patch copies the SyncSetupHandler used in Options to the MD-Settings directory as well.

It's basically a straight-copy with the options-specific code removed.

BUG=537405

Review URL: https://codereview.chromium.org/1421893005

Cr-Commit-Position: refs/heads/master@{#357165}

https://chromium.googlesource.com/chromium/src/+/fc23940c

BUG=549594
TBR=bungeman@chromium.org

Review URL: https://codereview.chromium.org/1411463006 .

Cr-Commit-Position: refs/heads/master@{#357164}

https://chromium.googlesource.com/webm/libvpx.git/+log/dc9d36c0a6c7..9645cd4826de

$ git log dc9d36c0a..9645cd482 --date=short --no-merges --format='%ad %ae %s'
2015-10-28 aconverse Revert "Replace the zero handling in extend_to_full_distribution."
2015-10-26 hkuang Add more resize test videos that with larger resolution change intervals.
2015-10-22 hkuang Add several new test vectors with small resolution.
2015-10-27 marpan Update to vp9-denoising.
2015-10-27 johannkoenig Only set sysroot when alt_libc finds a directory
2015-10-27 marpan VP9-SVC: Allow frame dropping due to overshoot for spatial layers.
2015-10-26 marpan Adjustments to vp9-denoising.
2015-10-27 yaowu Reorder code to be consistent accross branches
2015-10-26 aconverse Fix VS build.
2015-10-26 johannkoenig Skip AS detection when using --enable-external-build
2015-10-08 aconverse Replace the zero handling in extend_to_full_distribution.

R=tomfinegan@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1424373002

Cr-Commit-Position: refs/heads/master@{#357163}

Implementing default handlers from SpawnedTestServer to allow us to
migrate more tests to EmbeddedTestServer.

BUG=492672
R=bnc@chromium.org,mmenke@chromium.org

Review URL: https://codereview.chromium.org/1406313002

Cr-Commit-Position: refs/heads/master@{#357162}

BUG=482207

Review URL: https://codereview.chromium.org/1405993005

Cr-Commit-Position: refs/heads/master@{#357161}

R=simonhatch
BUG=548756

Review URL: https://codereview.chromium.org/1408243009

Cr-Commit-Position: refs/heads/master@{#357160}

bug fixes only.

from NEWS:
- 10/15/15: version 0.4.4
  This is a binary compatible release.
  * rescaling out-of-bounds read fix (issue #254)
  * various build fixes and improvements (issues #253, #259, #262, #267, #268)
  * container documentation update
  * gif2webp transparency fix (issue #245)

Review URL: https://codereview.chromium.org/1422493004

Cr-Commit-Position: refs/heads/master@{#357159}

BUG=381251

Review URL: https://codereview.chromium.org/1411773002

Cr-Commit-Position: refs/heads/master@{#357158}

When guessing the tranistion type for a URL change:
- When possible, use specific information from the last main frame load
  request.
- Fall back to guessing based on whether there has been a touch since
  the last URL change, rather than the last document change. This
  prevents changes that happen after, e.g., a replaceState from being
  assumed to be user-initiated.

BUG=548636
TEST=On an iPhone with WKWebView enabled, follow a link on
yahoo.com, then go back via the browser back button. It should return
to the main page.

Review URL: https://codereview.chromium.org/1409033004

Cr-Commit-Position: refs/heads/master@{#357157}

For the frames using GPU memory buffer, the REFERENCE_TIME is lost, and
then WebMediaPlayerMS will not be able to apply rendering algorithm to
enhance the rendering smoothness.

In this CL, we make those frames to carry over the REFERENCE_TIME from
original frame.

BUG=545165

Review URL: https://codereview.chromium.org/1418923006

Cr-Commit-Position: refs/heads/master@{#357156}

The actual physical memory usage of tcmalloc cannot be obtained by
GetNumericProperty. This accounts for the current_allocated_bytes,
fragmentation and malloc metadata, and excludes the unmapped memory
regions. This helps the user to understand how much memory is actually
being used for the allocations that were made.

This change is done only in chromium tree since the
metadata_unmapped_bytes is added only in the chromium's tcmalloc in CL:
www.crrev.com/10499004.

This is to be used by malloc dump provider for tracing.

BUG=546491

Review URL: https://codereview.chromium.org/1410353005

Cr-Commit-Position: refs/heads/master@{#357155}

Every now and then a bug report would include WebRtc
logs with an error string: this is generated in
VideoCaptureDevice::Client::OnError() and has no
origin information. This CL adds that in a way that
clients add the classical FROM_HERE, so that the error
log includes the originating file and line.

Review URL: https://codereview.chromium.org/1418263006

Cr-Commit-Position: refs/heads/master@{#357154}

Cause any change in network state in HTMLMediaElement to repaint the media
controls, since they rely on it silently during painting.

BUG=545704

Review URL: https://codereview.chromium.org/1417683004

Cr-Commit-Position: refs/heads/master@{#357153}

document.scrollingElement was added in M44, but apparently the ref build
is currently older than that.  Provide a temporary fallback without
loosing the benefit of https://codereview.chromium.org/1428733002.

CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

BUG=549644

Review URL: https://codereview.chromium.org/1425723003

Cr-Commit-Position: refs/heads/master@{#357152}

FILE_FLAG_SEQUENTIAL_SCAN is a hint to the system that a file will be
read sequentially from beginning to end.

It is required to pre-read modules efficiently.

BUG=547794

Review URL: https://codereview.chromium.org/1424943006

Cr-Commit-Position: refs/heads/master@{#357151}

BUG=

Review URL: https://codereview.chromium.org/1427133002

Cr-Commit-Position: refs/heads/master@{#357150}

As far as I can tell, these have unused for at least the last 3 years.

Review URL: https://codereview.chromium.org/1430763002

Cr-Commit-Position: refs/heads/master@{#357149}

We used it to pass GraphicsContext from PageOverlay to
PageOverlay::Delegete implementors. Pass GraphicsContext directly.

Skip cache in InspectorOverlay because view painted for the overlay
may conflict with the view's real painting.

BUG=536999
R=chrishtr@chromium.org
TBR=dpranke@chromium.org (remove an extra include from src/components/test_runner.cc)

Review URL: https://codereview.chromium.org/1412593003

Cr-Commit-Position: refs/heads/master@{#357148}

Fails consistently on my Linux workstation and also seems to have
trouble on a variety of bots that actually have camera hardware,
so disable everywhere.

The primary cause seems to be that this will flake other tests when
run in parallel.

BUG=417824
TEST=all media_unittests pass when a camera is attached.

Review URL: https://codereview.chromium.org/1428853003

Cr-Commit-Position: refs/heads/master@{#357147}

I missed this null check in setScaleAndLocation. There's some edge cases, likely
during loading, where we might get here without a frame. Also, until we figure
out what to do with VisualViewport for OOPIF we could also have a null
mainFrame.

BUG=543945

Review URL: https://codereview.chromium.org/1431433005

Cr-Commit-Position: refs/heads/master@{#357146}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b8500e4d..e35721ee

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1414703005

Cr-Commit-Position: refs/heads/master@{#357145}

I confirmed with simonhatch@ that this made sense given the way that
the Chromium TracingController works. The agent will be communicating
over a serial connection, which probably shouldn't be done
synchronously.

BUG=542837

Review URL: https://codereview.chromium.org/1407033008

Cr-Commit-Position: refs/heads/master@{#357144}

This CL adds tests for regressions that have been fixed
recently, some of them involving ContentViewCore.

In order to be able to properly instrument the ContentViewCore,
changes in the testing framework have been made. There are now
a couple of wrapper classes: OverlayPanelContentWrapper and
ContentViewCoreWrapper, which allow us to test for example
if the onShow() method was ever called, or if URLs have been
properly removed from local history when not seen.

This CL also introduces a few more helpers to simulate searches
caused by gestures (long press and tap) in a way that it
encapsulates the simulation logic and prevent flakiness. We
were manually doing a search term resolution by calling a
fakeResponse() method. Sometimes we are calling this when
not necessary (on long press) and tests don't call it in the
same order. We are also assuming it completed when the Bar
peeks (which works but under the wrong assumption). There are
now simulateLongPressSearch(id) and simulateTapSearch(id)
methods that simulate the search and handle the resolution
automatically when the system requests one.

There are several helper methods in ContextualSearchManagerTest
that are similar but do slightly different things, and some
assumptions are not quite correct which can and may be causing
falkiness in some tests. A couple of examples are: tests rely
on the change of state of the Panel in order to determine that
animations/actions are done. The closed state was being changed
before destroying the Contents. This is now fixed.

Another example is the tapBasePageToClosePanel() helper method
that wasn't properly working when the Panel was peeking while
a long press selection is present. I believe this is the cause
of the flakiness of 3 of our tests.

The new search simulation method should help making our tests
more robust and a followup CL is required to change existing
tests to use the new methods, once it has been confirmed that
the new methods work properly on existing test bots.

BUG=543319

Review URL: https://codereview.chromium.org/1426683005

Cr-Commit-Position: refs/heads/master@{#357143}

Follow up r355010 and arrange for persisted plugin widget disposal
when the plugin is completely detached and removed from the tree.

r355010 restricted disposal to not happen for persisted widgets
when re-attaching, but also ended up not disposing for the
fully-detached persistent plugin widget case.

Lacking those, widgets would end up being finalized without their
required dispose() having been called first.

R=haraken
BUG=544175

Review URL: https://codereview.chromium.org/1422503009

Cr-Commit-Position: refs/heads/master@{#357142}

BUG=548694
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1425693004

Cr-Commit-Position: refs/heads/master@{#357141}

BUG=none

Review URL: https://codereview.chromium.org/1406973006

Cr-Commit-Position: refs/heads/master@{#357140}

BUG=510485

Review URL: https://codereview.chromium.org/1412013008

Cr-Commit-Position: refs/heads/master@{#357139}

Based on Fredrik Söderquist <fs@opera.com>'s idea.

For <use>-instanced SVGPathElements, reuse the referenced Path object (now
cached in SVGPath).  This ensures that all <path> instances paint using the
same SkPath, which in turn reduces the pressure on internal Skia path caches.

BUG=skia:4527,549242
R=fs@opera.com

Review URL: https://codereview.chromium.org/1425913004

Cr-Commit-Position: refs/heads/master@{#357138}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c2e2977..f93982a

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Commits in this roll:
f93982a bsalomon@google.com Don't run nvpr on TSAN bot
21adcb9 halcanary@google.com DEPS: roll zlib: 20 new commits

Review URL: https://codereview.chromium.org/1423423002

Cr-Commit-Position: refs/heads/master@{#357137}