GitLab

This patch converts "editing/deleting/delete-tab-[1234].html" to use w3c
test harness and consolidates into "delete_tab.html" to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2172943002
Cr-Commit-Position: refs/heads/master@{#407085}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/71da59b9..5bc62d66

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2176443003
Cr-Commit-Position: refs/heads/master@{#407084}

BUG=

Review-Url: https://codereview.chromium.org/2137863002
Cr-Commit-Position: refs/heads/master@{#407083}

Specification:
https://www.w3.org/TR/payment-request/#updatewith

BUG=629462

Review-Url: https://codereview.chromium.org/2170783002
Cr-Commit-Position: refs/heads/master@{#407082}

This patch converts "editing/deleting/delete-and-undo.html" to use w3c test
harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2164243002
Cr-Commit-Position: refs/heads/master@{#407081}

This patch converts "editing/deleting/delete-3928305-fix.html" to use w3c test
harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2170753003
Cr-Commit-Position: refs/heads/master@{#407080}

BUG=624038,497094

Review-Url: https://codereview.chromium.org/2169213002
Cr-Commit-Position: refs/heads/master@{#407079}

Before, only 4 were shown, even though there was space for more.
It could confuse users, that there are no other apps matching the
criteria.

This CL increases this limit to 8, which fill the available space.

TEST=Tested manually on Samus.
BUG=629411

Review-Url: https://codereview.chromium.org/2165483002
Cr-Commit-Position: refs/heads/master@{#407078}

Per the spec[1] we can treat an object as a callback interface
if an effective overload set contains the callback interface.

[1] http://heycam.github.io/webidl/#es-overloads

BUG=629068

Review-Url: https://codereview.chromium.org/2175463002
Cr-Commit-Position: refs/heads/master@{#407077}

The Cotnrol-Click functionality navigates users from Styles Sidebar Pane
into the Source code.

This patch moves this functionality into the
StylePropertiesSection from StylesSidebarPane, which
simplifies it a lot.

BUG=none
R=pfeldman

Review-Url: https://codereview.chromium.org/2153263002
Cr-Commit-Position: refs/heads/master@{#407076}

BUG=624590

Review-Url: https://codereview.chromium.org/2166093002
Cr-Commit-Position: refs/heads/master@{#407075}

Currently ThreadableLoader's destructor implicitly cancels loading.
This CL requires a user to cancel the loader explicitly before
destructing a ThreadableLoader, as a preparation for moving it to
Oilpan heap.

BUG=587663

Review-Url: https://codereview.chromium.org/2146403004
Cr-Commit-Position: refs/heads/master@{#407074}

|EditAction| is used to describe editing operations in
Blink internal only, however with the introduction of
|InputEvent| we got a new type |InputType| which does the
same thing and SPECed.

Since having both is redundant, this CL removes
|EditAction| and finalized the list of possible
|InputType|.

This CL shouldn't have too much web-exposed effect (except
some trivial command mapping).

BUG=627740
Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/InputEvent/blink-dev/RrnitB0OElc/rirueVekCwAJ

Review-Url: https://codereview.chromium.org/2151353002
Cr-Commit-Position: refs/heads/master@{#407073}

The 32-bit metric is recorded as a sparse histogram. Each
sample contains information on transport RTT, HTTP RTT,
bandwidth, and time taken to download the resource. Each
metric occupies 7 bits with first 4 bits left unset.

BUG=624597

Review-Url: https://codereview.chromium.org/2107243003
Cr-Commit-Position: refs/heads/master@{#407072}

BUG=630056

Review-Url: https://codereview.chromium.org/2165023004
Cr-Commit-Position: refs/heads/master@{#407071}

Now the feature is moved to wayland, we can remove it.

BUG=b/29728385
TEST=Build and run ARC, with client side WindowManagerInstance removal.

Review-Url: https://codereview.chromium.org/2168533002
Cr-Commit-Position: refs/heads/master@{#407070}

We already have similar mechanism in cc. Blink-side DebugRedFill also
brings complexities about display item list and paint property tree.

Review-Url: https://codereview.chromium.org/2163113002
Cr-Commit-Position: refs/heads/master@{#407069}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/cc88d565..71da59b9

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2175573002
Cr-Commit-Position: refs/heads/master@{#407068}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ab911d94c16a..20358d6bf8c9

$ git log ab911d94c..20358d6bf --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2170183003
Cr-Commit-Position: refs/heads/master@{#407067}

Review-Url: https://codereview.chromium.org/2169243002
Cr-Commit-Position: refs/heads/master@{#407066}

BUG=chromedriver:1384

Review-Url: https://codereview.chromium.org/2170163002
Cr-Commit-Position: refs/heads/master@{#407065}

Cr-Commit-Position: refs/heads/master@{#407064}

Revert of Reland: H264 HW encode using MediaFoundation (patchset #2 id:20001 of https://codereview.chromium.org/2167333002/ )

Reason for revert:
Build errors on this bot: https://build.chromium.org/p/chromium/builders/Win%20x64/builds/2630/steps/compile/logs/stdio

Original issue's description:
> Reland: H264 HW encode using MediaFoundation
>
> Got reverted due to breaking MSVC build:
> https://bugs.chromium.org/p/chromium/issues/detail?id=630335#c2
>
> This CL moves GTEST_FAIL() lines so that they fail at the end of the
> function.
>
> Original description ----------------------------------------------
>
> H264 HW encode using MediaFoundation
>
> This CL adds MediaFoundationVideoEncodeAccelerator which enables H264 encode support
> using MediaFoundation on Windows 8.1+. Also, it includes a refactor of common
> MediaFoundation classes under mf_helpers.*.
>
> Note that, this is the first CL and H264 codec is still behind a flag.
>
> Design Doc(with perf measurements): http://goo.gl/UCnwyA
>
> BUG=590060
> TEST= Tested AppRTC loopback with Chrome flag "--enable-webrtc-hw-h264-encoding" and
> "--enable-mf-h264-encoding" on https://apprtc.appspot.com/?debug=loopback&vsc=h264
> Also, added WIN specific sections at vea_unittests.
>
> TBR=ananta@chromium.org,avi@chromium.org,grt@chromium.org,sandersd@chromium.org,wuchengli@chromium.org
> The incremented change is trivial.
>
> Committed: https://crrev.com/aa60bafce8cb29062030362aaa7c321350b67f84
> Cr-Commit-Position: refs/heads/master@{#407049}

TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=590060

Review-Url: https://codereview.chromium.org/2170133003
Cr-Commit-Position: refs/heads/master@{#407063}

Previously, the ViewportControl never stuck to the bottom after a scroll event.
The event.isTrusted check was always true, so it was not correctly
distinguishing user-generated scroll events from script-generated ones.  This
CL removes isUserGesture accordingly.

BUG=613879

Review-Url: https://codereview.chromium.org/2154893002
Cr-Commit-Position: refs/heads/master@{#407062}

TreeElement.expand() should not need to check that the element has children and
TreeOutline.insertChild() should not automatically expand a child when it is
inserted. ObjectPropertiesSection.js depended on this logic to automatically
expand the Entries property. This CL updates it so that the Entries property is
added before expanded.

BUG=

Review-Url: https://codereview.chromium.org/2147343002
Cr-Commit-Position: refs/heads/master@{#407061}

Currently hold-and-press dragging in direct input mode doesn't quite follow
the user's finger. The problem is that when the viewport moves (since
dragging around), the cursor position will be set to the center of the
screen, while the user's finger may be on somewhere else, causing an offset
between the user's finger and the cursor position. This CL fixes this problem
by always moving the cursor to the finger's position when it's in direct
input mode and the user is dragging around.

BUG=628031

Review-Url: https://codereview.chromium.org/2166423003
Cr-Commit-Position: refs/heads/master@{#407060}

Desired behavior when long press happens on an empty text field is to
activate touch selection and show the quick menu if there is anything
available to show in the quick menu. Otherwise, the regular context menu
should be shown. This was regressed due to changes in context menu
source type that added LONG_PRESS and LONG_TAP types. In addition to
fixing this regression, this CL fixes the regression on the new tab page
that shows an incorrectly placed quick menu instead of the context menu.

BUG=594101

Review-Url: https://codereview.chromium.org/2124913002
Cr-Commit-Position: refs/heads/master@{#407059}

As preparation for moving ThreadableLoader to Oilpan heap, this CL moves
ThreadableLoaderClientWrapper to Oilpan heap.

This CL also removes ThreadableLoaderClientWrapper::ResourceTimingClient and makes
ThreadableLoaderClient::didReceiveResourceTiming() to be called also for
ThreadableLoaderClient associated with WorkerThreadableLoader.

BUG=587663

Review-Url: https://codereview.chromium.org/2146333002
Cr-Commit-Position: refs/heads/master@{#407058}

BUG=626456

Review-Url: https://codereview.chromium.org/2169203002
Cr-Commit-Position: refs/heads/master@{#407057}

The way OriginTrialContext and the WebTrialTokenValidator API was
designed made a lot of sense when the bindings were still done in such
a way that only when a feature is first used we validate if there are
tokens for that feature. But now that we check every feature in every
context the current design is both not very efficient, and also
needlessly complex.

This simplifies things a lot by validating tokens as soon as AddToken
is called (as all tokens will be validated anyway). This way we only
have to validate each token once rather than once for each feature.

Also gets rid of the old histograms as they weren't very meaningful
anymore: The FeatureEnabled was logged regardless of if a feature was
actually being used on a page, making the data hard to reason about. And
the MessageGenerated histogram was 100% NotRequested after the bindings
changes, making it not useful at all.

BUG=627942

Review-Url: https://codereview.chromium.org/2123323004
Cr-Commit-Position: refs/heads/master@{#407056}

Eliminate one SpdyHeaderBlock copy in SpdyStream::ProduceSynStreamFrame() (soon
to be renamed ProduceHeaderFrame).  This is achived by saving the GURL as soon
as request_headers_ are set.

Note that |url_| is not necessarily the same as url_from_header_block_, see, for
example, SpdyHttpStreamTest.SpdyURLTest.

Also remove test-only SpdyStream::HasUrlFromHeaders().

BUG=621905

Review-Url: https://codereview.chromium.org/2169583002
Cr-Commit-Position: refs/heads/master@{#407055}

All changes to the color text from the spectrum should count as one change
for undo/redo. Pressing Ctrl-Z should also move the cursor to the change.

R=lushnikov

Review-Url: https://codereview.chromium.org/2168713004
Cr-Commit-Position: refs/heads/master@{#407054}

As the test is not slow on recent runs, remove the entry from SlowTests.

BUG=601726
NOTRY=true

Review-Url: https://codereview.chromium.org/2172543002
Cr-Commit-Position: refs/heads/master@{#407053}

This is hoping to achieve better build performance.

BUG=627637

Review-Url: https://codereview.chromium.org/2165183003
Cr-Commit-Position: refs/heads/master@{#407052}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c66d67b05d04..ab911d94c16a

$ git log c66d67b05..ab911d94c --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2174593002
Cr-Commit-Position: refs/heads/master@{#407051}

Changes the associated bindings implementation for ChannelMojo
such that remote interfaces can be acquired immediately upon
ChannelMojo construction rather than having to wait for connection
on the IO thread.

Simplifies the Channel bootstrapping process, removing a round-trip
Init message (and in fact the entire IPC::mojom::Boostrap interface)
since there's no need to actually exchange associated interface handles
over the pipe. Instead both sides can assume the other will use a fixed,
reserved endpoint ID for their IPC::mojom::Channel interface.

This also removes the restriction that associated interfaces must be
added to a Channel after Init. Instead the same constraints apply as
with AddFilter: an associated interface, like a filter, may be added
at any time as long as either Init hasn't been called OR the remote
process hasn't been launched.

The result of this CL is that any place it's safe to AddFilter,
it's also safe to AddAssociatedInterface; and any place it's safe to
Send, it's also safe to GetRemoteAssociatedInterface and begin using
any such remote interface immediately.

Remote interface requests as well as all messages to remote interfaces
retain FIFO with respect to any Send calls on the same thread. Local
interface request dispatch as well as all messages on locally bound
associated interfaces retain FIFO with respect to any OnMessageReceived
calls on the same thread.

BUG=612500,619202

Committed: https://crrev.com/e1037f997da9e1d44ca3b09d4ff32f0465673091
Review-Url: https://codereview.chromium.org/2163633003
Cr-Original-Commit-Position: refs/heads/master@{#406720}
Cr-Commit-Position: refs/heads/master@{#407050}

Got reverted due to breaking MSVC build:
https://bugs.chromium.org/p/chromium/issues/detail?id=630335#c2

This CL moves GTEST_FAIL() lines so that they fail at the end of the
function.

Original description ----------------------------------------------

H264 HW encode using MediaFoundation

This CL adds MediaFoundationVideoEncodeAccelerator which enables H264 encode support
using MediaFoundation on Windows 8.1+. Also, it includes a refactor of common
MediaFoundation classes under mf_helpers.*.

Note that, this is the first CL and H264 codec is still behind a flag.

Design Doc(with perf measurements): http://goo.gl/UCnwyA

BUG=590060
TEST= Tested AppRTC loopback with Chrome flag "--enable-webrtc-hw-h264-encoding" and
"--enable-mf-h264-encoding" on https://apprtc.appspot.com/?debug=loopback&vsc=h264
Also, added WIN specific sections at vea_unittests.

TBR=ananta@chromium.org,avi@chromium.org,grt@chromium.org,sandersd@chromium.org,wuchengli@chromium.org
The incremented change is trivial.

Review-Url: https://codereview.chromium.org/2167333002
Cr-Commit-Position: refs/heads/master@{#407049}

Even though SerializedScriptValue normally serializes values to a WTF::String,
the string isn't actually a valid unicode string. Because of that it can't
be safely passed over mojo as a string (invalid strings get silently converted
to null). This changes the mojo interface to use array<uint8> instead, thereby
making sure arbitrary values get passed across correctly.

BUG=630203

Review-Url: https://codereview.chromium.org/2171843002
Cr-Commit-Position: refs/heads/master@{#407048}

Revert of Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS (patchset #17 id:310001 of https://codereview.chromium.org/2124633002/ )

Reason for revert:
Seems to break the Android and Linux GPU fyi bots:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%205X%29/builds/1098
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28ATI%29/builds/48671
https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%206P%29/builds/1004
<couple others>

GpuProcess.no_transparent_visuals_gpu_process
Failure: disable_transparent_visuals is missing in Browser process workarounds: [u'broken_egl_image_ref_counting', u'clear_uniforms_before_first_program_use', u'disable_blend_equation_advanced', u'disable_chromium_framebuffer_multisample', u'disable_depth_texture', u'disable_discard_framebuffer', u'disable_framebuffer_cmaa', u'disable_program_cache', u'force_cube_map_positive_x_allocation', u'max_copy_texture_chromium_size_1048576', u'max_texture_size_limit_4096', u'scalarize_vec_and_mat_constructor_args', u'unbind_attachments_on_bound_render_fbo_delete', u'unbind_egl_context_to_flush_driver_caches', u'use_virtualized_gl_contexts', u'wake_up_gpu_before_drawing']

[  FAILED  ] GpuProcess.no_transparent_visuals_gpu_process (5860 ms)

Original issue's description:
> Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS
>
> This is for better polish in the UI but it fixes a drag
> image issue on Linux crbug.com/593256 .
>
> Also add a kGpuDriverBugListJson entry to automatically
> disable transparent visuals on all drivers (especially
> the proprietary NVIDIA driver) except for opensource
> drivers (i.e. Mesa based drivers).
>
> BUG=369209
>
> R=kbr@chromium.org, sadrul@chromium.org, tapted@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/71b2517dd4cd620a56ca6f13571129c6aee30b42
> Cr-Commit-Position: refs/heads/master@{#406505}

TBR=kbr@chromium.org,sadrul@chromium.org,tapted@chromium.org,piman@chromium.org,j.isorce@samsung.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=369209

Review-Url: https://codereview.chromium.org/2171023002
Cr-Commit-Position: refs/heads/master@{#407047}

Previously WebrtcDataStreamAdapter was implementing MessageChannelFactory,
which means that it was always creating channels asynchronously and in OPEN
state. Refactored it to create channels in CONNECTING state. Significantly
simplifies channel setup code as it's always synchronous. It's also possible
to reject incoming channels before they are connected and handle channels
rejected by the peer before being fully connected.

Review-Url: https://codereview.chromium.org/2164163002
Cr-Commit-Position: refs/heads/master@{#407046}