- 07 Feb, 2019 40 commits
-
-
Ted Choc authored
Requiring user gesture on form submission broke OAuth providers, so this allows incoming intents bypass this restriction. BUG=927509,839751 Change-Id: I4a46cf0b3bb3fad0f18211b2194dd823d0bdc897 Reviewed-on: https://chromium-review.googlesource.com/c/1456211Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#629993}
-
danakj authored
Remove TODOs lamenting this obsolete behaviour, and branches on frozen in the shown/hidden RenderWidget code. Instead DCHECK the RenderWidget is not frozen when being shown/hidden. Note that when becoming frozen they will stay in whatever shown/hidden state they were before being frozen until after they are thawed. R=dcheng@chromium.org Bug: 419087 Change-Id: I49bc0c4a622485cc0ab5550a11c9f6c07507c7b3 Reviewed-on: https://chromium-review.googlesource.com/c/1455496 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#629992}
-
Jonathan Backer authored
The primary motivation for this CL is to remove the callbacks from GLRendererCopier. When used by GLRenderer, GLRendererCopier executes on the same display compositor thread as GLRenderer and the callbacks are fine. When used by SkiaRenderer, SkiaRenderer will run on display compositor thread and GLRendererCopier will run on GPU main thread. By plumbing the data down, we can avoid synchronization issues. This CL also centralizes the calculations and eliminates a bit of code duplication. Bug: 927335 Change-Id: Ib45fc3d3a515a9e21aaa4638cc5e0b462c498bdd Reviewed-on: https://chromium-review.googlesource.com/c/1456948 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#629991}
-
Henrique Ferreiro authored
Remove the usage of the IdentityManager Mojo API in favor of the C++ API for consistency with other //chrome/browser code. Bug: 928187 Change-Id: Id6431d3ec57c0b7dc872ed5e23d863dd3c96e922 Reviewed-on: https://chromium-review.googlesource.com/c/1454527 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#629990}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0041fe53dcfe..710f3d3e4483 git log 0041fe53dcfe..710f3d3e4483 --date=short --no-merges --format='%ad %ae %s' 2019-02-07 danilchap@webrtc.org Use task queue factory factory as parameter for TaskQueueTest Created with: gclient setdep -r src/third_party/webrtc@710f3d3e4483 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1e764f80fd5681e9160f44c8fad2339f9f4fdfbe Reviewed-on: https://chromium-review.googlesource.com/c/1458420Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629989}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/603ad164a6fc..088e521769f9 git log 603ad164a6fc..088e521769f9 --date=short --no-merges --format='%ad %ae %s' 2019-02-07 syoussefi@chromium.org Vulkan: Suppress flaky test on Nexus5X Created with: gclient setdep -r src/third_party/angle@088e521769f9 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Id17f80392b1330e5df702066c996bef7f7562d60 Reviewed-on: https://chromium-review.googlesource.com/c/1458421Reviewed-by:
-
Boris Sazonov authored
This CL replaces layout_height="36dp" for buttons in the sign-in screen with layout_height="wrap_content". These buttons use TextButton and FilledButton.Flat text styles, so they already have min height set to 36dp. Setting layout_height to wrap_content allows these buttons to grow if font height is larger than 36dp. Bug: 927425 Change-Id: I616c1a952b3a4aa9ab52c46a7c7aff47bc05c301 Reviewed-on: https://chromium-review.googlesource.com/c/1458209 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#629987}
-
Markus Heintz authored
Bug: None Change-Id: I6c923ffd2c5631e21b6964774dd9588573236811 Reviewed-on: https://chromium-review.googlesource.com/c/1458204Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#629986}
-
Raul Tambre authored
The former non-overloaded variants are deprecated. This is a mechanical change; there is no intended behavior change. Change-Id: I326c68bf2910fbbf75db379e08202d5aac4f2ef2 Reviewed-on: https://chromium-review.googlesource.com/c/1456015 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#629985}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/36651e4e3873..be531eda4378 Created with: gclient setdep -r src-internal@be531eda4378 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibcab6633552856707b155cef818dbad963b10934 Reviewed-on: https://chromium-review.googlesource.com/c/1458419Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629984}
-
Clemens Arbesser authored
Since most existing LOGs were only used for reporting fatal errors, most DVLOGs currently use verbosity 1. Bug: 806868 Change-Id: Ie5819d88975daf8e2a9e8169843b6d39d7fa365b Reviewed-on: https://chromium-review.googlesource.com/c/1449680 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#629983}
-
Ehsan Karamad authored
The test is running in a virtual suite and is flaky most likely due to outstanding work the needs to be done for FeaturePolicyForSandbox. TBR=dpranke@chromium.org, iclelland@chromium.org Bug: 929678 Change-Id: Iedc0bdefc6c376031d48b46fdee68a475d16e319 Reviewed-on: https://chromium-review.googlesource.com/c/1458363 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#629982}
-
kylechar authored
CompositorResizeLock was deleted in https://crrev.com/c/1053588. UI.CompositorResizeLock.* hasn't been recorded since then so mark as obsolete. Bug: 928497 Change-Id: Idcb1473864f9342d797942f1b749ae587c1b2213 Reviewed-on: https://chromium-review.googlesource.com/c/1454222Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#629981}
-
Elly Fong-Jones authored
This program generates a list of all the currently unowned flags. Bug: 897809 Change-Id: Ifc5462557fe16784b792dc4d3811fc447bf566db Reviewed-on: https://chromium-review.googlesource.com/c/1458598 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#629980}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/01a3e9b6383f..3b71e65658cd git log 01a3e9b6383f..3b71e65658cd --date=short --no-merges --format='%ad %ae %s' 2019-02-07 cwallez@chromium.org Make CopyTests_T2B.Texture2DArrayMip suppression more precise Created with: gclient setdep -r src/third_party/dawn@3b71e65658cd The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ie243a8a8388b8f9a10c7bb79f62dc26757ea5a94 Reviewed-on: https://chromium-review.googlesource.com/c/1458418Reviewed-by:
-
jdoerrie authored
This change modifies CommandLine::ParseFromString() to take its param as base::StringPiece16 instead of a const-ref to string16. This allows for a more flexible interface as well as a more efficient implementation. Bug: NONE Change-Id: Ie099afa9be90d2030c72057ce040f6bc16e1df32 Reviewed-on: https://chromium-review.googlesource.com/c/1451941 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c19d81acc096..c877ea265759 git log c19d81acc096..c877ea265759 --date=short --no-merges --format='%ad %ae %s' 2019-02-07 reed@google.com Hide setDrawLooper -- deprecate loopers Created with: gclient setdep -r src/third_party/skia@c877ea265759 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I960dcf6ef282cd84f165a6221aa185b4e24c8ea8 Reviewed-on: https://chromium-review.googlesource.com/c/1458417Reviewed-by:
-
Mohamed Amir Yosef authored
Before posting a client to server message, the sync cycle is informed about an upcoming ProtocolEvent. ProtocolEvent's are only consumed in SyncInternalsMessageHandler::OnProtocolEvent() using the ToValue() method. It's basically used to log the data to the sync-internal pages. All other occurrences of ProtoclEvent in the code are just to forward that protocol event across different layers of sync. One issue is the request object used to create the ProtoclEvent is incomplete and some fields that as store_birthday are actually set when posting the message to the server. This CL is splitting the functionality in PostClientToServerMessage() by creating another method to fill in the required fields. Such that, those fields get filled before reporting the ProtocolEvent. Bug: 925839 Change-Id: If6e09dd65acea99619f5ebe82a18492ef3c322ee Reviewed-on: https://chromium-review.googlesource.com/c/1456076 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Mattias Nissler authored
BUG=None TEST=Compiles Change-Id: I2d87af0d1f4164d9d28621fdefa547ee94896402 Reviewed-on: https://chromium-review.googlesource.com/c/1458198Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#629975}
-
Pavol Marko authored
This is a follow-up to CL:1446226 . Bug: none Test: unit tests Change-Id: Ia3e323a8b5ab9f18d69af944a9b85c479625b055 Reviewed-on: https://chromium-review.googlesource.com/c/1452187 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#629974}
-
vasilii authored
Autofill uses __gCrWeb.fill.setInputElementValue that triggers additional events which React or Angular can use. Now the password manager reuses the function for password forms. Bug: 813175 Change-Id: I8c57bc33b27eba050e8d74d63e8caeee283adb1f Reviewed-on: https://chromium-review.googlesource.com/c/1453439Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#629973}
-
Finnur Thorarinsson authored
Bug: 921425, 656015 Change-Id: Ia5f324ea9c6d3c66c52214af083f597ea55df8b2 Reviewed-on: https://chromium-review.googlesource.com/c/1455950 Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
Daniel Bratell authored
Jumbo, as implemented as a gn template, will naturally hide the original files behind new files target_jumbo_1.cc, target_jumbo_2.cc, .... This breaks the gn analyze step which is used by cq to figure out if it needs to test compile or not. To give gn analyze a chance to see what is going on, put the original sources in the merge action's |input| list. The action won't use the files and it will serialize actions that don't need serializing but it might be a small price to pay. There might be unexpected and unwanted side effects from this. The cleanest solution would be to give gn native jumbo support which would also allow other changes like better IDE support and better error messages, but this is what we got. Bug: 893071 Change-Id: I36aa498795871a63cfcd4e2d27c29e2f59d5ccbb Reviewed-on: https://chromium-review.googlesource.com/c/1455943 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#629971}
-
Marc Treib authored
Callers can instead trigger a reconfigure by grabbing and immediately releasing a SyncSetupInProgressHandle instead. This resolves one of the last reasons for using ProfileSyncService rather than SyncService. Bug: 924508 Change-Id: I2ba2839356e32954d3c655356a60c6398d41adae Reviewed-on: https://chromium-review.googlesource.com/c/1456658Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#629970}
-
Etienne Pierre-doray authored
This CL removes redundant members in base::internal::Task: - delay: Redundant with PendingTask::delayed_run_time - sequenced_time: Redundant with PendingTask::queue_time (unused when sequenced_time is used). This clean up makes Task easier to read, and slightly more lightweight. Change-Id: I7ed16bd3458d61f98d717f2f3dd83124f9f0121f Reviewed-on: https://chromium-review.googlesource.com/c/1448977Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#629969}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: I5fc899717a00db03daf0a4c5a94e267daa305c0d Reviewed-on: https://chromium-review.googlesource.com/c/1458601Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#629968}
-
Marc Treib authored
These were previously only exposed in *Profile*SyncService. Moving them up into the interface removes one of the last reasons to use ProfileSyncService directly. Bug: 924508 Change-Id: Ie7f44f4dc8adba814812b9fae9bf3e753c7890c5 Reviewed-on: https://chromium-review.googlesource.com/c/1458038Reviewed-by:
-
David Benjamin authored
Make it slightly easier to find the actual uses. Bug: 755368 Change-Id: I3b9929aba2440ad876e1500c279ea9fd9d63d29a Reviewed-on: https://chromium-review.googlesource.com/c/1456936Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
-
Benoît Lizé authored
Cleans up feature flags for string parking, making foreground and background compression mutually exclusive. Compression on memory pressure is kept in both cases. This does not remove background compression, as the foreground one is still experimental, whereas the background one has been validated by deb/beta/stable experiments. Bug: 877044, 924164 Change-Id: I79b65e6d0073b18a704055e0cfeb54ba451e20c2 Reviewed-on: https://chromium-review.googlesource.com/c/1458200Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#629965}
-
Friedrich Horschig authored
This change tries to use more of the Chrome stack for our integration tests. This might catch errors in the bridge that previously let compile failures slip. This *might* increase robustness because the calls of the native bridge are now correct and don't have to be replaced anymore. This caused some weird cases where the bridge would say: display nothing and the test quickly called *DO* display something. The overhead shouldn't increase much, since we don't actually load the test data from the render but instead fill the cache of the native part of the component. This allows the native side to behave naturally and even fill tapped suggestions as it normally would. A small clean-up that supported this change: the EmbeddedTestServer allows loading html pages which provides an IP as origin instead of a data url. Bug: 913888, 894428, 922131, 920901 Change-Id: Ib2c09ed386354965ccdaf2f44ca1aafd218fd018 Reviewed-on: https://chromium-review.googlesource.com/c/1448233 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#629964}
-
Caitlin Fischer authored
Bug: 850597 Change-Id: Ie295693b36e077086f3beb379a80dc87211e2323 Reviewed-on: https://chromium-review.googlesource.com/c/1455055 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
Igor authored
This is a device policy that specifies whether and in which case the device must reboot on user sign out. By default the policy value is NEVER. Two other options are available, with possibility to add more in the future. The implementation of the effects of the policy, the reboot itself, will be done in a separate CL. Bug: b:77799573 Test: unit_tests --gtest_filter=DeviceSettingsProviderTest.DeviceRebootAfterUserSignout Change-Id: I2f8e847620f5b28d36d20d3e6912b99ec6e00497 Reviewed-on: https://chromium-review.googlesource.com/c/1455961 Commit-Queue: Igor <igorcov@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Cr-Commit-Position: refs/heads/master@{#629962}
-
Christian Dullweber authored
Change-Id: I5e4b63cb0a7bf86b4978b4089ab5fe9086d48a90 Reviewed-on: https://chromium-review.googlesource.com/c/1446351Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#629961}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3043fbd9fc27..af5e7a520e64 git log 3043fbd9fc27..af5e7a520e64 --date=short --no-merges --format='%ad %ae %s' 2019-02-07 lalitm@google.com Merge "trace_processor: improve test framework and add kernel LMK tests" 2019-02-07 lalitm@google.com Merge "trace_processor: fix crash with instants table when adding args" 2019-02-07 hjd@google.com perfetto-ui: Add process_scheduling track 2019-02-07 lalitm@google.com Merge "trace_processor: remove duration column on counters table" 2019-02-07 hjd@google.com Merge "Remove GOOGLE_CHECK" Created with: gclient setdep -r src/third_party/perfetto@af5e7a520e64 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I8efe052759702ac4ca8b2fa6e761c9a55bf8f52b Reviewed-on: https://chromium-review.googlesource.com/c/1458416Reviewed-by:
-
Thomas Tangl authored
When files in chrome/browser/resources are changed, the tryjob linux_chromium_dbg_ng is added to the commit queue. This is done to catch browser tests that fail because of missing dependencies/includes. These failures are often not caught by rel builds. Change-Id: I4a17e1e09e7a4ed450f5cc9efc2ce8831a9be525 Reviewed-on: https://chromium-review.googlesource.com/c/1437286 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#629959}
-
Koji Ishii authored
Following bot results are included. 14771 14772 14779 14790 14798 14801 14812 14817 2 lines were removed and 0 lines were deflaked by consecutive results since 14754. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I38d1d2800e92dcc6833a4206cb6d7f119c929800 Reviewed-on: https://chromium-review.googlesource.com/c/1456416Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#629958}
-
Sergio Villar Senin authored
ChildAccountService was observing changes the list of gaia accounts in the cookie jar in order to notify its observers. We can achieve the same behaviour by observing IdentityManager instead. Apart from that the call to GaiaCookieManagerService::ListAccounts() was successfully replaced by IdentityManager::GetAccountsInCookieJar(). This allows us to completely remove the dependency on GaiaCookieManagerService. Bug: 921007 Change-Id: I7acc064c65ae2d61eb9d807e08183f2ee30e5183 Reviewed-on: https://chromium-review.googlesource.com/c/1409010 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
-
Dominic Farolino authored
This reverts commit 66236c64. Reason for revert: Bad and unexpected performance regressions were introduced with this change. It is possible to incur an infinite loop of loading a <link> and firing the load event, if the onload function tampers with the `rel` attribute, as is sometimes done with preload links. This may prevent a window's load event from ever being fired. Mitigating problems like this needs to more looking into before this change can land apparently. Performance regression bugs: https://crbug.com/927427, https://crbug.com/928796, https://crbug.com/929153, https://crbug.com/929265. The original bug (https://crbug.com/922618) has been re-opened to track future work for this. Original change's description: > Link element events should be able to fire more than once > > As per spec https://html.spec.whatwg.org/multipage/links.html#link-type-stylesheet, > the <link> element can have its load and error events fire multiple times, > per resource it loads. > > Bug: 922618 > Change-Id: Ifc9ade076e119d5cf9f4eaf656c6ea7c1deb0ba9 > Reviewed-on: https://chromium-review.googlesource.com/c/1423601 > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Dominic Farolino <domfarolino@gmail.com> > Cr-Commit-Position: refs/heads/master@{#628010} TBR=yhirano@chromium.org,kouhei@chromium.org,domfarolino@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 922618 Change-Id: I0affe5a242bf472743d11a4905a630da7895cfca Reviewed-on: https://chromium-review.googlesource.com/c/1457745Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Dominic Farolino <domfarolino@gmail.com> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#629956}
-
kylechar authored
Remove usage of deprecated base::Bind, base::Callback, base::Closure, base::CancelableCallback and base::CancelableClosure types from content/gpu/*, content/browser/gpu* and chrome/gpu/*. Where possible convert to the corresponding once type. Otherwise replace with the repeating type which is equivalent to the deprecated type. Bug: 714018 Change-Id: I8da148c51d9eb8b5d85a4a8f76b41f8a13ff295f Reviewed-on: https://chromium-review.googlesource.com/c/1456941Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#629955}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7ca375c8ca54..0041fe53dcfe git log 7ca375c8ca54..0041fe53dcfe --date=short --no-merges --format='%ad %ae %s' 2019-02-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1a597bc4..ee5dfb22 (629788:629907) 2019-02-07 oprypin@webrtc.org Roll chromium_revision c27b32b2..1a597bc4 (629510:629788) 2019-02-07 oprypin@webrtc.org Pause rolling buildtools 2019-02-06 steveanton@webrtc.org Reland: Remove dead code from stream_params.h 2019-02-06 solenberg@webrtc.org Remove HAVE_WEBRTC_VOICE. 2019-02-06 nisse@webrtc.org Move RtpSenderVideo tests to separate file. 2019-02-06 nisse@webrtc.org Delete MediaTransport method SetNetworkChangeCallback 2019-02-06 nisse@webrtc.org Allow more than one registered network change callback in MediaTransport 2019-02-06 oprypin@webrtc.org Roll chromium_revision 9d5d0c66..c27b32b2 (629245:629510) Created with: gclient setdep -r src/third_party/webrtc@0041fe53dcfe The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:927867,chromium:None,chromium:none,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7a024246384477be0b56fa2bed7316f6983db105 Reviewed-on: https://chromium-review.googlesource.com/c/1457535Reviewed-by:
-
