GitLab

When StopRecognition is invoked and no data was recorded, there is a possibility that the delegate
might release the recognizer within the DidCompleteRecognition callback. So we now perform cleanup
tasks such as freeing the encoder_ object before invoking the delegate. Without this change there
would be an assert in the SpeechRecognizer dtor about encoder_ remaining valid.

BUG=none
TEST=Manual, double-click on the speech button quickly a few times and verify no assert pops up in the dtor.

Review URL: http://codereview.chromium.org/6381004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71994 0039d316-1c4b-4281-b951-d872f2087c98

  "sidebar": {
    "default_url": "",
    "default_title": "",
    "default_icon": ""
  }

Allow extension to access experimental.sidebar API only in presence of this section.

BUG=51084
TEST=unit_tests, ExtensionManifestTest.Sidebar

Review URL: http://codereview.chromium.org/6321006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71993 0039d316-1c4b-4281-b951-d872f2087c98

BUG=61745
TEST=in progress

Review URL: http://codereview.chromium.org/6247013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71992 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:9256
TEST=Verify web widgets (aka form controls) look close to the mock in chromium-os:9256.

Review URL: http://codereview.chromium.org/6247012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71991 0039d316-1c4b-4281-b951-d872f2087c98

Changing the behaviour of DOMStorageMessageFilter so that receiving invalid messages does not terminate the renderer.

For background, see remarks in the associated bug.

BUG=69729
TEST=None

Review URL: http://codereview.chromium.org/6342011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71990 0039d316-1c4b-4281-b951-d872f2087c98

broken in r71858.

BUG=70244
TEST=manual (in and out of --kiosk)

Review URL: http://codereview.chromium.org/6343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71988 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=thakis


TBR=senorblanco@chromium.org
Review URL: http://codereview.chromium.org/6287006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71987 0039d316-1c4b-4281-b951-d872f2087c98

Add gpu/ files from the public skia project into the chrome build. This is in
preparation for experimenting with them to gpu-accelerate various aspects of
chrome's drawing. In this initial patch, the files will be built, but not
called.

BUG=none
TEST=be sure that page rendering, and <canvas> rendering, look the same as before

Review URL:  http://codereview.chromium.org/6357006


TBR=senorblanco@chromium.org
Review URL: http://codereview.chromium.org/6329014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71986 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Pepper Flash, PPAPITests

Review URL: http://codereview.chromium.org/6261017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71985 0039d316-1c4b-4281-b951-d872f2087c98

The |WebViewClient::didAcceptAutocompleteSuggestion| method is no longer dispatched from the WebKit side, and had been replaced by |WebViewClient::didAcceptAutoFillSuggestion|.  The PasswordAutocompleteManager had not been updated to account for this.  Those updates are made in this patch.  Follow up is to remove the |WebViewClient::didAcceptAutocompleteSuggestion| method from WebKit.  Also, the |PasswordAutocompleteManager::FrameClosing| method was not getting properly dispatched to perform cleanup tasks.  This is fixed now.

BUG=68681
TEST=PasswordAutocompleteManagerTest.SuggestionSelect

Review URL: http://codereview.chromium.org/6262008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71984 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=thakis


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71983 0039d316-1c4b-4281-b951-d872f2087c98

Add gpu/ files from the public skia project into the chrome build. This is in
preparation for experimenting with them to gpu-accelerate various aspects of
chrome's drawing. In this initial patch, the files will be built, but not
called.

BUG=none
TEST=be sure that page rendering, and <canvas> rendering, look the same as before

Review URL:  http://codereview.chromium.org/6357006


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71982 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6340001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71976 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6265012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71975 0039d316-1c4b-4281-b951-d872f2087c98

This allows Chrome to recreate its status tray icons on Windows in the case
that explorer.exe is restarted, or isn't running yet at the time that chrome
starts up.

BUG=69972
TEST=Run chrome without explorer.exe running, then start explorer.exe

Review URL: http://codereview.chromium.org/6289010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71974 0039d316-1c4b-4281-b951-d872f2087c98

to notify the control that the checked state has changed.

BUG=69613
TEST=none

Review URL: http://codereview.chromium.org/6285003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71973 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65911
TEST=manually run tests.
Review URL: http://codereview.chromium.org/6231004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71972 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71971 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=brettw

Review URL: http://codereview.chromium.org/6257006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71970 0039d316-1c4b-4281-b951-d872f2087c98

- Move linux web widgets painting code from webkit;
- Move dependent resources from webkit_resources into gfx_resources and
  follow the pattern in net package to add resource loading support to
  gfx package;
- Update ChromeOS theme engine to follow mocks in chromium-os:9256.

BUG=chromium-os:9256
TEST=Verify default web widgets has desired look on ChromeOS.

Review URL: http://codereview.chromium.org/6254004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71969 0039d316-1c4b-4281-b951-d872f2087c98

TEST=manually, trybots
BUG=none

Review URL: http://codereview.chromium.org/6380005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71968 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=BUILD

Review URL: http://codereview.chromium.org/6255006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71967 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=pkasting@chromium.org

Review URL: http://codereview.chromium.org/6249011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71966 0039d316-1c4b-4281-b951-d872f2087c98

This skips r33 (which is unrelated) for the moment because NaCl needs changes in order to compile with r33.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6307009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71965 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben

Review URL: http://codereview.chromium.org/6306005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71964 0039d316-1c4b-4281-b951-d872f2087c98

BUG=58975
TEST=none

Review URL: http://codereview.chromium.org/6268005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71963 0039d316-1c4b-4281-b951-d872f2087c98

Ignore touch-move events that don't actually change the touch location.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6323010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71962 0039d316-1c4b-4281-b951-d872f2087c98

I wasn't thinking and realized I need to get rid of the dependency on Browser IOThread, because the service process doesn't have one.
This means I can move this back to chrome/common, but I won't do that until you have finished your implementations.

BUG=NONE
TEST=BUILD

Review URL: http://codereview.chromium.org/6312007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71961 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=printing works after code change.

Review URL: http://codereview.chromium.org/6374004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71960 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=thakis
Review URL: http://codereview.chromium.org/6294008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71958 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69719

Review URL: http://codereview.chromium.org/6295010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71957 0039d316-1c4b-4281-b951-d872f2087c98

I have not added a new test for this because the existing test is flaky and
didn't seem right to add another flaky test like that. Instead I've added a TODO
to add a browser test for this case once the flaky test has been fixed.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/6358007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71956 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/6271012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71955 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Run browser_tests --gtest_filter=ExistingUserControllerTest.*

Review URL: http://codereview.chromium.org/6360006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71953 0039d316-1c4b-4281-b951-d872f2087c98

In Chromium OS there is no 'extensions' directory, so this case should
be handled correctly.

BUG=chromium-os:11107,70197
TEST=login to CrOS, no crashing

Review URL: http://codereview.chromium.org/6265014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71952 0039d316-1c4b-4281-b951-d872f2087c98

Speculative fix for a bug that happens during Chrome Frame teardown while there are pending IPC messages to be handled. Keep the ChromeFrameAutomationProxyImpl instance alive until all messages have been handled.

BUG=68869
TEST=No more crashes during handling of OnChannelError during teardown.

Review URL: http://codereview.chromium.org/6250015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71951 0039d316-1c4b-4281-b951-d872f2087c98

TEST=browser_tests --gtest_filter=IndexedDBBrowserTest.TransactionGetTest
BUG=67323

Review URL: http://codereview.chromium.org/6248011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71950 0039d316-1c4b-4281-b951-d872f2087c98

This is the chromium side of the webkit patch https://bugs.webkit.org/show_bug.cgi?id=52718.

Suggested reviewer split:
wtc@ - the 2 url_fetcher.* files
hans@ - rest of the files

I needed to add a URLFetcher::set_referrer() method to send the origin url in the Referer header.

Also I had to create a new IPC params struct for startRecognition since the
number of parameters exceed what is provided by the macros. And in the process I also moved
the speech input IPC messages to their own source files.

BUG=none
TEST=No change in functionality except additional debug info sent to server.

Review URL: http://codereview.chromium.org/6308009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71949 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71948 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/6268007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71947 0039d316-1c4b-4281-b951-d872f2087c98