GitLab

Currently m_webMediaPlayer is cleared in resetMediaPlayerAndMediaSource
and clearMediaPlayerAndAudioSourceProviderClientWithoutLocking. So
reusing clearMediaPlayerAndAudioSourceProviderClientWithoutLocking
in resetMediaPlayerAndMediaSource.

Review URL: https://codereview.chromium.org/1287063006

git-svn-id: svn://svn.chromium.org/blink/trunk@200720 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=515763

Review URL: https://codereview.chromium.org/1288623004

git-svn-id: svn://svn.chromium.org/blink/trunk@200719 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When support for 4-value syntax for background-position was added,
only the non-repeating case was actually tested and render support for
the non-top-left anchor points were missing.

This patch adds render support and a simple test for the three anchor
positions that wasn't supported before for repeated/tiled
backgrounds.

BUG=488707,521481

Review URL: https://codereview.chromium.org/1287293002

git-svn-id: svn://svn.chromium.org/blink/trunk@200718 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With  https://codereview.chromium.org/1287263004/ all spellcheck
work in blink moved to a separate subdirectory. Cleaning up
WATCHLISTS accordingly.

BUG=none

Review URL: https://codereview.chromium.org/1294283002

git-svn-id: svn://svn.chromium.org/blink/trunk@200717 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1296233002

git-svn-id: svn://svn.chromium.org/blink/trunk@200716 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521481

Review URL: https://codereview.chromium.org/1297913003

git-svn-id: svn://svn.chromium.org/blink/trunk@200715 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We have quirk code that |checked| returns new value even before the default
action of a click event is executed.  It adds some code complexity and produced
multiple bugs.

BUG=

Review URL: https://codereview.chromium.org/1295173004

git-svn-id: svn://svn.chromium.org/blink/trunk@200714 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves spell checker related files into "core/editing/commands/"
directory to reduce number of files immediately under "core/editing/" for ease
of working these files as same as issue 448772, which moves iterator related
files into "core/editing/iterators/".

Moved files:
 - *Command.{cpp,h}
 - EditAction.h
 - SmartReplace.h
 - SmartReplaceCF.h
 - SmartReplaceICU.h
 - UndoStack.{cpp,h}
 - UndoStep.{cpp,h}

This patch also arrange order of editing files in "core.gypi" to match with
C++ files.

BUG=509527
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1294543005

git-svn-id: svn://svn.chromium.org/blink/trunk@200713 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=513066

Review URL: https://codereview.chromium.org/1257793005

git-svn-id: svn://svn.chromium.org/blink/trunk@200712 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Fix the mechanism by which Blink determines OSX version number. (patchset #4 id:60001 of https://codereview.chromium.org/1301693002/ )

Reason for revert:
VersionUtilMac.AppKitVersions fails on OSX 10.6 and 10.7.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_platform_unittests&showExpectations=true&tests=VersionUtilMac.AppKitVersions


Original issue's description:
> Fix the mechanism by which Blink determines OSX version number.
> 
> Previously, Blink was checking NSAppKitVersionNumber against a compile time
> constant. This mechanism doesn't work (see the bug for more details). This CL
> converts the logic to use the same mechanism that Chromium uses.
> 
> BUG=521034
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200708

TBR=thakis@chromium.org,erikchen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=521034

Review URL: https://codereview.chromium.org/1286233004

git-svn-id: svn://svn.chromium.org/blink/trunk@200711 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=501297

Review URL: https://codereview.chromium.org/1297563003

git-svn-id: svn://svn.chromium.org/blink/trunk@200710 bbb929c8-8fbe-4397-9dbb-9b2b20218538

doApply assumes |endingSelection()| has rootEditableElement as L114 checks.
However, reseting |endingSelection()| through |endOfSelection| at L171 can 
invalidate the assumption.
This CL let it return early if it does.
We should fix the reseting |endingSelection| algorithm in long term but let me fix 
the stable blocker crash.

BUG=515490
TEST=LayoutTests/editing/execCommand/insert-ordered-list-crash2.html

Review URL: https://codereview.chromium.org/1298633002

git-svn-id: svn://svn.chromium.org/blink/trunk@200709 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously, Blink was checking NSAppKitVersionNumber against a compile time
constant. This mechanism doesn't work (see the bug for more details). This CL
converts the logic to use the same mechanism that Chromium uses.

BUG=521034

Review URL: https://codereview.chromium.org/1301693002

git-svn-id: svn://svn.chromium.org/blink/trunk@200708 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The current BitmapPatternBase/BitmapPattern/StaticBitmapPattern class hierarchy exists to support
SkBitmap vs. SkImage-backed patterns.  But with the recent SkImage conversion effort, all Images
are now backed by SkImage and BitmapPattern has to go through an unnecessary conversion phase to
get its SkBitmap.

IOW, this dichotomy is now obsolete.  The CL removes BitmapPatternBase, BitmapPattern,
StaticBitmapPattern, and replaces them with ImagePattern (which is always/naturally backed by
SkImage).

Also, since we're in this area, convert the current non-repeating tile mode workaround to a
SkPicture-based implementation: instead of allocating/drawing into an expanded bitmap, allocate
an expanded SkPictureImageGenerator-backed SkImage and defer the actual tile drawing until
rasterization time.

BUG=449197
R=junov@chromium.org,senorblanco@chromium.org,reed@google.com

Review URL: https://codereview.chromium.org/1290983003

git-svn-id: svn://svn.chromium.org/blink/trunk@200707 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For now, this CL doesn't change any behavior since there is no opportunity
where precise GCs and idle GCs are scheduled at the same time.
(If ENABLE(IDLE_GC) is on, precise GCs are disabled. Otherwise, idle GCs are disabled.)

However, we're planning to mix precise GCs and idle GCs in the near future.
At that point, a precise GC needs to be more prioritized than an idle GC.
Specifically, this CL makes a change so that a precise GC is scheduled
when an idle GC is scheduled.

BUG=474470

Review URL: https://codereview.chromium.org/1295713003

git-svn-id: svn://svn.chromium.org/blink/trunk@200706 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For some reason, the initial auto-rebaseline
(http://crrev.com/1294993002) did not land XP expectations.

BUG=521801
TBR=yurys@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1299833002

git-svn-id: svn://svn.chromium.org/blink/trunk@200705 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=463547

Review URL: https://codereview.chromium.org/1298543002

git-svn-id: svn://svn.chromium.org/blink/trunk@200704 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=520763

Review URL: https://codereview.chromium.org/1293093002

git-svn-id: svn://svn.chromium.org/blink/trunk@200703 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Blink r199183 changed the encoder to no longer reserve WTF::Vector capacity.
An alternative is to no longer use a WTF::Vector, and allocate the buffer in
an OwnPtr<T[]> instead.

BUG=504690

Review URL: https://codereview.chromium.org/1285533002

git-svn-id: svn://svn.chromium.org/blink/trunk@200702 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In order to handle fetch() Request data more correctly, this CL introduces
FetchFormDataConsumerHandle which is made from FormData (including String
and ArrayBuffer) and provides a means to drain the data as a FormData.

This CL also modifies drainAsBlobDataHandle contract and implementation.

BUG=457484

Review URL: https://codereview.chromium.org/1265413002

git-svn-id: svn://svn.chromium.org/blink/trunk@200701 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change sorts the generated palette by hue and expands the palette to
24 colors. This change reduces the preview palette size to fix a line
wrapping issue on Mac.

BUG=521228,521139,461320

Review URL: https://codereview.chromium.org/1300513003

git-svn-id: svn://svn.chromium.org/blink/trunk@200700 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=515763

Review URL: https://codereview.chromium.org/1295083003

git-svn-id: svn://svn.chromium.org/blink/trunk@200699 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix z-index of tooltips to appear on top of glass panes such as the new main menu. This also adds a tooltip for toggle dock side tooltip.

BUG=520272,521206

Review URL: https://codereview.chromium.org/1294033002

git-svn-id: svn://svn.chromium.org/blink/trunk@200698 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL is split out from [1] where we support multiple author origins in
terms of shadow dom scopes. The vector of MatchedProperties contains
matched declarations from all origins in the order in which they should
be applied. For !important declarations, they are applied in the same
order within the same origin, but the order of the origins are different
as the cascading order is:

  - UA important
  - Author important
  - Author
  - UA

We used to have two ranges, one for UA and one for author to accomplish
this. However, with the normal/!important cascading order for
declarations from different shadow doms, we need multiple author ranges:

  - UA important
  - Author important scope n
  ...
  - Author important scope 1
  - Author scope 1
  ...
  - Author scope n
  - UA

We introduce an ImportantAuthorRangeIterator to iterate through the
author ranges and add iterator-style iteration for each range through the
MatchedPropertiesRange class.

As the applyMatchedProperties code is hot, I've run the blink_perf.css
tests locally. Some improved by 2-4%, some became worse by similar
percentages.

[1] https://codereview.chromium.org/1224673002/

BUG=487125
TEST=fast/css

Review URL: https://codereview.chromium.org/1282243002

git-svn-id: svn://svn.chromium.org/blink/trunk@200697 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch is to address a reverted patch (https://codereview.chromium.org/1264913002/).  At line 253 in WorkerThread.cpp, the original check was script()->scriptState()->contextIsValid() which can crash if the scriptState is null.  This patch was reverted and is now changed to script()->isContextInitialized().  isContextInitialized was also changed from a private to a public function.

BUG=501569

Review URL: https://codereview.chromium.org/1287103002

git-svn-id: svn://svn.chromium.org/blink/trunk@200696 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Length::intrinsic() doesn't return true for min-intrinsic. isLegacyIntrinsic()
does. But use isIntrinsicOrAuto() to catch both intrinsic, legacy-intrinsic and
auto values, since that seems to be a rather popular way of doing things.
Nobody seems to call isLegacyIntrinsic() directly. Regarding auto values here,
it doesn't really matter whether we call valueForLength() or not, since they'll
resolve to 0 anyway.

BUG=521526
R=leviw@chromium.org,robhogan@gmail.com

Review URL: https://codereview.chromium.org/1292163005

git-svn-id: svn://svn.chromium.org/blink/trunk@200695 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When an iframe's custom scrollbar changes its thickness, it is the LayoutView
within the iframe that should be marked for relayout, not the LayoutIFrame.

BUG=512914

Review URL: https://codereview.chromium.org/1296033002

git-svn-id: svn://svn.chromium.org/blink/trunk@200694 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Document about replacing:
https://docs.google.com/document/d/1e4OvVMFuPxtoLGr6VkAu7qTaHWS02qBv5ndQoW8v1Wg/edit

blink-dev thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/1YrpiUJ0etg

BUG=

Review URL: https://codereview.chromium.org/1278983003

git-svn-id: svn://svn.chromium.org/blink/trunk@200693 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This use counter tracks whenever a page starts multiple CSS animations
on an element where the tail animations include neutral keyframes.
This is to gauge the occurrence of this in the wild to determine the
viability of altering the behaviour in a subset of these cases.

Review URL: https://codereview.chromium.org/1248483005

git-svn-id: svn://svn.chromium.org/blink/trunk@200692 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Biquad filters have a tail where zero input can produce non-zero
output due memory from previous inputs.  However, we were
disconnecting biquad filter nodes when the input is disconnected such
as when a source node is finished.  This causes the biquad to suddenly
produce zero output.

Add a case to handle biquad filters like convolver nodes and delay
nodes which don't disconnect their outputs even if the inputs are
disconnected.

This is a temporary solution until full tail-time supported is implemented.
That will fix this issue, and also allow biquad's to be collected when
no longer needed.  With this change, biquad's will be active for a
very long time even with no inputs.

BUG=521155
TEST=biquad-tail.html

Review URL: https://codereview.chromium.org/1285073005

git-svn-id: svn://svn.chromium.org/blink/trunk@200691 bbb929c8-8fbe-4397-9dbb-9b2b20218538

nextChild may be removed from the DOM tree during the
|parserRemoveChild(*newChild)| call which triggers unload events of newChild's 
descendant iframes. In order to maintain the integrity of the DOM tree, the
insertion of newChild must be aborted in this case.

This patch adds a return statement that rectifies the behavior in this
edge case.

BUG=519558

Review URL: https://codereview.chromium.org/1283263002

git-svn-id: svn://svn.chromium.org/blink/trunk@200690 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=501896
NOTRY=true

Review URL: https://codereview.chromium.org/1296013002

git-svn-id: svn://svn.chromium.org/blink/trunk@200689 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=439376
TBR=yurys@chromium.org, oilpan-reviews@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1298843002

git-svn-id: svn://svn.chromium.org/blink/trunk@200688 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes files in "core/editing/" to match Blink coding style and
formatting comments, near style changes, to fit 80 characters to ease of working
these files in the future for improving code health.

Note: Naming related style violation will be addressed in other patches to
reduce size of patches.

This patch is also a preparation of moving execCommand related files,
http://crrev.com/1294543005

BUG=509257
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1292303005

git-svn-id: svn://svn.chromium.org/blink/trunk@200687 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=519918

Review URL: https://codereview.chromium.org/1287423005

git-svn-id: svn://svn.chromium.org/blink/trunk@200686 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=200677

BUG=509025
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/1287903005 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200684 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is output of webkit-patch print-flaky-tests.

TBR=leviw@chromium.org
BUG=521862, 521861, 521860, 521859, 521858, 521857, 521856, 521855, 521854, 521853, 521852, 521852, 521852, 521852

Review URL: https://codereview.chromium.org/1300733003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200682 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=515518
R=pfeldman@chromium.org, pfeldman

Review URL: https://codereview.chromium.org/1282593003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200681 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Re-rebaseline xp results after r200605 (patchset #1 id:1 of https://codereview.chromium.org/1296753004/ )

Reason for revert:
webkit_lint errors due to duplicate TestExpectation entries

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6/builds/43492/steps/webkit_lint/logs/stdio

The test is already marked as failing by https://codereview.chromium.org/1286343003 Auto-rebase didn't help first time that's why I preferred skipping it on XP and let the author to take care of it.

Original issue's description:
> Re-rebaseline xp results after r200605
> 
> The rest of the bots updated and were happy. XP kept failing...
> 
> BUG=449197
> TBR=fmalita@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200676

TBR=fmalita@chromium.org,leviw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=449197

Review URL: https://codereview.chromium.org/1299473004

git-svn-id: svn://svn.chromium.org/blink/trunk@200680 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521704,496259

Review URL: https://codereview.chromium.org/1286373004

git-svn-id: svn://svn.chromium.org/blink/trunk@200679 bbb929c8-8fbe-4397-9dbb-9b2b20218538