- 06 Oct, 2020 40 commits
-
-
Maksim Sisov authored
This is a follow up CL that implements OzoneUIControlsTestHelper in Ozone/X11. It basically reuses the X11UIControlsTestHelper that was extracted to ui/base/x in https://crrev.com/c/2445109 Test: all interactive_ui_tests with Ozone/X11 pass Bug: 1134495 Change-Id: Ic9c123c74a5f425b78b5a51f8f4fd452029c0971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443850 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#814244}
-
Josiah K authored
Just noticed test was missing this.newCallback(), so added it, to make sure test runs and waits for callback before finishing. AX-Relnotes: n/a Change-Id: I72baf27159706853672d18af00410c07cfef91b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450794 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#814243}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e6a8f4ed40bb..972e0ab44119 2020-10-06 saklein@chromium.org package_info: Refactor usages of SplitPV to parse. 2020-10-06 gbiv@google.com cros_setup_toolchains: package rust 2020-10-05 michaelirani@chromium.org Fix typing issue in cros_analyze_image.py 2020-10-05 skau@chromium.org licensing: Allow net-print/brother_mlaser for Google-TOS 2020-10-05 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-05 engeg@google.com cbuildbot: fix spelling of 'finished' If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I2fd18a23b570c8f571d202857678b1c266812882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452829Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814242}
-
Matt Menke authored
We're getting crashes that imply it can be null here (though it can't be null in NavigatorUAData::getHighEntropyValues(), apparently). Bug: 1134994 Change-Id: Ie361625dc6df4d25592bfe167a82119a7b00167d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450289Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#814241}
-
Mitsuru Oshima authored
Bug: 1134279 Test: covered by unittests Change-Id: Ic8a411f57e8401321454f187dbcace2bd3c3c85d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451709Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#814240}
-
Sophey Dong authored
Bug: 1135311 Change-Id: Ibc63b2a0ee9591edf988937378b1abd0201ace90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451314Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#814239}
-
Steven Bennetts authored
It is preferred to embed base::Value and use is_none() over unique_ptr. This simplifies some existing code and will further simplify some code for tracking captive portal state in NetworkState. Bug: 1133376 Change-Id: I7bce0e322bb5f34a280e6be8db168c78d096afb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450489 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#814238}
-
Yash Khandelwal authored
This change removes the RequestRefreshFrame logic from WebRTC sink and moves it up to MediaStreamVideoTrack so other sinks (like MediaStreamVideoRendererSink) can also use it. Bug: 931033, 1100746, 1099280 Change-Id: I6479e9f77a8fdf03325b7ed980091273726cc57a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427563 Commit-Queue: Yash Khandelwal <yakhande@microsoft.com> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#814237}
-
Mohamed Amir Yosef authored
This CL introduces the skeletons for the SaveAddressProfileView and SaveAddressProfileBubbleController. Bug: 1135178 Change-Id: I66e1f931c7e87c03710602b8dd452ac56e5449e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449982 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#814236}
-
Titouan Rigoudy authored
These tests are defined in chrome/, as opposed to content/, because the UseCounter integration with UMA histograms relies on chrome/ code. Bug: chromium:1124358 Change-Id: I9faa667e2ced9e92f0c8bd10652ccc2f225c3b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442013 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#814235}
-
kylechar authored
SkiaOutputDeviceBufferQueueTest was crashing on Linux with passthrough command decoder when SwANGLE is enabled. We end up testing SkiaOutputDeviceBufferQueue with shared images it's not intended to work with since it's the default implementation for the platform. Add TestSharedImageBackingFactory that always creates a TestSharedImageBacking to avoid this. We don't need a real shared image in order to test SkiaOutputDeviceBufferQueue logic. Bug: 1131521 Change-Id: I668a4a158c45ad36cabd53376e764a1c5343c013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450724 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#814234}
-
Andrei-Laurențiu Olteanu authored
Change SystemEventsProxy events property to const events. Bug: b:167523716 Change-Id: I93d8068eee97aad9c9681140bd28d998b2089f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450318 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#814233}
-
Milica Selakovic authored
Bug: 1086109 Change-Id: I8b5d54afb531993436b14be1c5715d0869f58c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452769 Commit-Queue: Milica Selakovic <selakovic@google.com> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#814232}
-
Michael Ershov authored
Bug: 1082459 Test: *TpmChallenge* Change-Id: I4c53ecca6ca4403e266bea9ba745e1bd1e337f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449991 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#814231}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: OSSettingsInternetPage* Change-Id: Ic7c493399e0865e9bd8ad1273f67a4d29b313cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451811Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#814230}
-
Andrei-Laurențiu Olteanu authored
Create and make available mojo interface for chrome://. Add implementation in chrome://. Add implementation in chrome-untrusted://. Add implementation for cros_healthd fake event emitters. Add browser test for power event listener. Bug: b:167523716 Change-Id: Id13d13feecc8360a1408387a5f44b46a9812f6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418313 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#814229}
-
Robert Sesek authored
Change-Id: Ib204efb0b0bdebf3188da7e8afd153ace9efbcf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452569 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#814228}
-
Xiaocheng Hu authored
The spec (*) intentionally leaves the behavior of `font-display: auto` as user-agent-defined, allowing different browsers to use different strategies. Therefore, the behavior will not be interoperable and should not be tested in WPT. This patch removes the related tests from css/css-fonts/font-display/font-display.html (*) https://drafts.csswg.org/css-fonts-4/#valdef-font-face-font-display-auto Bug: 1132458 Change-Id: Ia48d4e36f3bf619d384b262b2978040865eca694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450748Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#814227}
-
Anqing Zhao authored
This histogram is still helpful to MGS team because there are many new users and feature requests recently. The statistical data about extension permissions can save debug efforts and discover potential issues when necessary. Bug: 1088743 Change-Id: Id85b2f86caa49d7a4a7604675ce33053408308db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452631Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#814226}
-
Koji Ishii authored
Following r813630 crrev.com/c/2448269 that added the early return to |NGBoxFragmentPainter::NodeAtPoint|, this patch: * Extracts more correct early return logic from |LayoutBox:: HitTestAllPhases|. It looks like |LayoutNGBlockFlowMixin| copied from it in 2017 (r508056 crrev.com/c/710498), but the logic in |LayoutBox::HitTestAllPhases| evolved. * Changes |IsScrollContainer| to |ShouldClipOverflowAlongBothAxis| because it misses other clipping situations. * Changes to unite |PhysicalBorderBoxRect| and the overflow. * Changes |LayoutNGBlockFlowMixin| to apply the early return logic not only when |NGPaintFragment|. The early return in |LayoutNGBlockFlowMixin| improves the perf test by ~65%, to almost equivalent to M85. Note the previous patch (r813630) should match this, I will do it in a following patch. Bug: 1134574 Change-Id: If8e2fc5f52254168cd994c7fdf1d54aa5653da0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448709 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#814225}
-
Peter Kotwicz authored
BUG=1064277 Change-Id: I1cebb0c67269978d32fee2fb57750926dd8ba144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444442 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#814224}
-
Tim Volodine authored
The parameterized ExpandablePaymentHandlerTest#testSecureConnectionShowUi* tests appear to be flaky on Android Tablet bots (in particular on Marshmallow Tablet Tester). BUG=1135547 TBR=rouslan@chromium.org Change-Id: I8e660266edb7af99f2b9ea03bf48151ee900cfbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452809Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#814223}
-
Rushan Suleymanov authored
Some fields of updates during bookmarks initial merge are used after being moved to check if the update has been processed. This CL fixes it and prevents using moved updates. Change-Id: Idaf3a912525ab8edb5e6568d65f3d7740e0d8f22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449331 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#814222}
-
Austin Eng authored
The new API allows passing/getting the old/new image layouts to do proper image layout transitions. ExportSignalSemaphoreOpaqueFD is deprecated. Bug: dawn:200, 976495 Change-Id: Icbdd354bf5d8231c16b1bbc64317bcd158e0c135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451710Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#814221}
-
Mohamed Heikal authored
Add a new gn template that allows depending on a prebuilt native library in chrome's build rules. Bug: 1135175 Change-Id: I98b442862afe3bed6c48a7fa48ced5aa77522362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448666 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#814220}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f6e983b87ff4..3453f745f068 2020-10-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from b588cd4df419 to c7d7610581df (4 revisions) 2020-10-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b3c1e71eb1cb to afe6ca45b6da (4 revisions) 2020-10-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 7c07085ad1cc to 3610ce9fa2d8 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Id460d841dc5eba1a6f95b737dc979110b497f210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452592Reviewed-by:
-
Cammie Smith Barnes authored
Histograms recorded are the sum of the maximum concurrent values recorded for each frame in the ad frame tree. This change also adds some field trial configuration and in particular the MemoryPollMode FeatureParam. Tests: chrome/test:unit_tests --gtest_filter=*AdsMemoryMeasurement* chrome/test:browser_tests --gtest_filter=*AdsMemoryMeasurement* Bug: 1117176,1116087 Change-Id: I0049fba5a09c02c179d75e90c3d3db8272b8adf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242471Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#814218}
-
Brian Malcolm authored
For FlexOrgs only, instead of saying: "foo.com recommends that you update this device." will instead say "user@foo.com recommends that you update this device." BUG=chromium:1081272 Change-Id: I1a2b4c99f93618bd414f4f07860cfce7c8eb38d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451319Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/master@{#814217}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b910ce5dce08..e017318956fd 2020-10-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-10-06 tvanderlippe@chromium.org Typecheck sources/EditingLocationHistoryManager.js with TypeScript 2020-10-06 tvanderlippe@chromium.org Expose location symbol function for layout tests 2020-10-06 patrick.brosset@microsoft.com Rolling DevTools deps 2020-10-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-06 aerotwist@chromium.org TypeScriptify webaudio/graph_visualizer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1134064 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7b1f1d3710f38e683e66cc2e4f864718a3d31d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452611Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/edd7ee8a..b0ecf543 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I245ba4d621bbb7bf4c7a244a288dc38b1f7ce546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452551Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814215}
-
Andrei-Laurențiu Olteanu authored
Create and make available mojo interface for chrome://. Add implementation in chrome://. Add implementation in chrome-untrusted://. Add implementation for cros_healthd fake event emitters. Add browser test for bluetooth event listener. Bug: b:167523716 Change-Id: Iee440ec06446187943389d76158ece55d0c08dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416280 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
-
Stephen McGruer authored
To avoid unexpected breakages of the wptrunner MVP, we want to smoketest it on the WPT importer. This will hopefully catch both upstream test changes as well as infra changes that would break the MVP. There is some risk that the bots might be unstable and unnecessarily block imports. If this starts to happen, this commit should be reverted. Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Bug: None Change-Id: Ie0dfde425bbdf4d21b2bee2f818697c29b1aa03a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451504 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#814213}
-
Clark DuVall authored
This change adds a @IdentifierNameString annotation to use the -identifiernamestring R8 rule. There are a few limitations to this: - -identifiernamestring only obfuscates the string, it does not actually check that the class exists. - If a field has the annotation, it must be non-final, otherwise javac will inline the constant and R8 won't obfuscate it. - Any field/method must be assigned/called with a String literal, otherwise R8 won't obfuscate the string and there will be issues at runtime. Due to these limitations, I ended up adding a getIdentifierName() method to SplitCompatUtils which returns the obfuscated name of implementation classes for split compat. I also added a PRESUBMIT check to enforce that only string literals are passed to that method. There can be cases where R8 will not fail, but a string variable is silently ignored if it is not a String literal. Bug: 1126301 Change-Id: Ie5216e6a81cdbca71cc117460704ea4d9122fc78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451388 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by: -
Clemens Arbesser authored
This is a reland of c66038fc Original change's description: > [Autofill Assistant] Added missing unit tests for new service deps. > > Bug: b/158998456 > Change-Id: Ib580385e201a1b68967dcace71af8cd8f2ed58e2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450309 > Commit-Queue: Clemens Arbesser <arbesser@google.com> > Reviewed-by: Sandro Maggi <sandromaggi@google.com> > Cr-Commit-Position: refs/heads/master@{#814184} Bug: b/158998456 Change-Id: Ie318ecb1aba3af9f8ee64d9e727460889b8734c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452629 Commit-Queue: Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#814211}
-
Dominique Fauteux-Chapleau authored
TBR=skobes@chromium.org Bug: 1135527 Change-Id: Ibd640a81482959629c909ee0fc80abeef9edf0ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451217Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#814210}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/db2c2dd9b9a2..e85652b61d42 2020-10-06 tandrii@google.com infra: Remove no longer used refs.cfg. 2020-10-06 vadimsh@chromium.org infra: Stop statically enforcing Xcode version. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: Iacedbaf33815ba7f86fe51eb523af9d12d19c9b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452610Reviewed-by:
-
chrome://interventions-internals/Yuheng Huang authored
Bug: 1049960 Change-Id: I326731a647f8d048b902f1448f6da944946d1207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145159Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#814208}
-
Raphael Kubo da Costa authored
Based on https://github.com/web-platform-tests/wpt/pull/16323 by wanming.lin@intel.com. Change-Id: I9d0c8b29b81c9457d4268c4adae0250609157e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445409 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#814207}
-
Patrick Brosset authored
In order to land the new jump-to-var in bug 1124707 I had to disable 3 devtools web tests since they were testing some UI code that was getting changed in the devtools front end repo. Now that the code has landed, I can re-enable those tests, making sure to adapt the way they go about testing the UI. Bug: 1135145 Change-Id: Icd1407f571c7ef070e8646bdc025e36faa5f2933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451500Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Cr-Commit-Position: refs/heads/master@{#814206}
-
Ella Ge authored
Change-Id: Ic4eece52d8ef0edb6b88955bb477975481aabb9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440241Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#814205}
-
