- 29 Nov, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1c5463726c3e..f9cad2f75cd2 git log 1c5463726c3e..f9cad2f75cd2 --date=short --first-parent --format='%ad %ae %s' 2019-11-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 43fc40ae..c8e3617e (252 commits) 2019-11-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 fc3ec57ddf27..bc82fb14aab4 (9 commits) Created with: gclient setdep -r src/third_party/skia@f9cad2f75cd2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None,chromium:None Tbr: bungeman@google.com Change-Id: Ib5541158588622f43ef38de6ec1721c0d9bbbc51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944009Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720131}
-
Yutaka Hirano authored
Intent-to-Deprecate-and-Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Z1XdYf6SjDU Bug: 1013087 Change-Id: I34be2e59d6fa44834333e368dbd06a5e2cf1b876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942187Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#720130}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I75d2c3abf8b721d876dc921f1ecb97839eb6e936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943032Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#720129}
-
Takashi Sakamoto authored
Bug: 1029417 Change-Id: I678b4de72cdebdd3cfd43685085ed0c34a1f24fe Tbr: csharp Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943073Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#720128}
-
Yuki Shiino authored
In order to avoid circular #include, use forward decls for the implementation classes of IDL dictionaries. This patch adds a lot of #include "dict.h" due to the change. The main change is only in bindings/scripts/v8_types.py Change-Id: I4a3175a9532a46035eca63e856bcb1c2c3bb8bef Tbr: mkwst@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942887 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#720127}
-
Makoto Shimazu authored
This has already been implemented but the comment is left. TBR=falken@chromium.org Bug: 999049 Change-Id: I7359619e74b1d23f48fbc3e21f7f21c293a63457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942889Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#720126}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eb7cd5902b87..5e2a454edcf7 Created with: gclient setdep -r src-internal@5e2a454edcf7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Ic27f441f72ace4a8cae8b6a4d45c0844adbf202f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944007Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720125}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4f14c4f2bdf6..1c5463726c3e git log 4f14c4f2bdf6..1c5463726c3e --date=short --first-parent --format='%ad %ae %s' 2019-11-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d6e903bdc9ef..fb7ca1d5aca5 (13 commits) Created with: gclient setdep -r src/third_party/skia@1c5463726c3e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: bungeman@google.com Change-Id: I66602aa0b854eb19ec35cfd4b8e28f76c2b12a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943994Reviewed-by:
-
Alexey Baskakov authored
All async WebAppIconManager read icon methods must return void. A call site should check if an app has appropriate icon via corresponding Has*Icon methods. These changes are required for integration with AppService. This code is disabled by default behind kDesktopPWAsWithoutExtensions base feature. Bug: 1029221 Change-Id: Iad46ea383f062d0b3787e11d20b5f89a08eb61f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943650Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#720123}
-
Alexandre Courbot authored
V4L2Queue logs are useful, but they omitted one important piece of information: which queue triggered the log. Add a few macros to ease the process and make V4L2Queue use them. While at it, fix a small formatting mistake when using VPLOGF in this class. Bug: None Test: Build Chromium for Kukui. Change-Id: I3ec6b7e00c1912ddeaae2a66571052957772d884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939998 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#720122}
-
Alex Danilo authored
Dragging files using mouse positions the drag image origin at the location of the mouse, i.e. the image extends to the right and down. In the case whem the drag is initiated from touch, the drag image is obscured. Check for touch initiated drag and position the image above the touch position. Bug: 755703 Change-Id: I313f245bacb4c0e649cae5597653bcdad4fd1130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943071Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#720121}
-
Noel Gordon authored
Our tree.css comes from the cr.ui.tree source and modified to the taste of files app. Add mode tastiness in form of files-ng. Again, rules like .tree-row > .file-row > blah ... are specific to files-ng (there is an echo in this room). Bug: 992819 Change-Id: I5da539e81005cbb412004461dc5f6ef00a4f5251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942589Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#720120}
-
Austin Tankiang authored
Use <cr-dialog>'s default for buttons, flex-end. This is done to be consistent with other dialogs. Tbr: fukino-san Bug: 1026127 Change-Id: I872d535f51d1d2caa1225399dfdf6c9eaed837b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943709 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has goal to use To<SVGPatternElement> and DynamicTo<SVGPatternElement> as new downcast helper Bug: 891908 Change-Id: Ibcc937ce3e849c5132d7e412246eb32268e16f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936614Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<SVGSVGElement> and DynamicTo<SVGSVGElement> as new downcast helper 2. Use IsA<SVGSVGElement>(element) in place of IsSVGSVGElement(element) Bug: 891908 Change-Id: I2f47d7b1e92f77a7f1584b98ceabae942cfb8552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936619Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has goal to use IsA<SVGPolylineElement>(element) in place of IsSVGPolylineElement(element) Bug: 891908 Change-Id: Icf9966502255b06ee97ea085374054d3498d4b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936616Reviewed-by:
-
Anqing Zhao authored
Considering the logic of generating request list has been extracted to report_request_queue_generator, we needn't keep two sets of test cases with same converage. The ones in report_generator_unittest.cc should be removed. Bug: 1010213 Change-Id: I183b39de1152a5090e56e34811fb370757306565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940113Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#720115}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I4693b2577e57b3e4f56c3ce0146e9dc8e920e03a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943749Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720114}
-
Jay Harris authored
This is in preparation for the origin trial, where we will need to be able to disable and re-enable file handlers as the validity of the origin trial token changes. Bug: 1028448 Change-Id: Ifd78328ce8dd2ddb71113e84f001ac809135903b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936440 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#720113}
-
Wanming Lin authored
This CL adds a test for testing multiple scan() from the same NDEFReader object with new options should replace existing filters. Test fails at present as which has not been implemented yet. This CL also rename NDEFReader_options.https.html as NDEFReader_scan_filter.https.html because NDEFReader has no construct options any more, and this test file is mainly for scan filter testing. BUG=520391 Change-Id: I4d19659c990c0ddc8dc19a5984c55be1ece48e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939327 Commit-Queue: Wanming Lin <wanming.lin@intel.com> Reviewed-by:
Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#720112}
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL moves matching registrations and relevant functions from ServiceWorkerProviderHost to ServiceWorkerContainerHost. Also, this makes ServiceWorkerContainerHost inherit ServiceWorkerRegistration::Listener instead of ServiceWorkerProviderHost. This CL adds a guard in ServiceWorkerContainerHost::UpdateUrls() against service worker execution contexts. Before ServiceWorkerProviderHost separation, UpdateUrls() was called only for service worker clients. After the separation, this is now also called for service worker execution contexts to update |url_| etc from the outside of ServiceWorkerContainerHost. Running the remaining parts of UpdateUrls() for service worker execution contexts was not harmful, but this CL puts SyncMatchingRegistrations() call that may change the behavior. The guard prevents the behavior change. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: Icc4a54cf7e26e21b69a45d4b971e2acb979eb707 Tbr: falken@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941466 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#720111}
-
Kent Tamura authored
- As for input.valueAsDate, add separated counters for the getter and the setter. - file.lastModifiedDate already has a counter. Bug: 988353 Change-Id: Ia5fa197705698c0e3465c079b77f8d8d426c6cdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943068Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#720110}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/26500402..310ba9ca Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie31cd10b2a90f95e1cde2ad6d2b99cdcbaf0efaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942997Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720109}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5a493efee284..eb7cd5902b87 Created with: gclient setdep -r src-internal@eb7cd5902b87 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Ie508ec865b5eaa7921c7b8592d7a90225587aa8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943548Reviewed-by:
-
Takashi Sakamoto authored
- external/wpt/secure-contexts/idlharness.any.html - external/wpt/compression/compression-stream.tentative.any.serviceworker.html Bug: 856601 Change-Id: If0e6187dc43163c3361bdd8a70ad2ee681af0e89 Tbr: csharp Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942888Reviewed-by:
-
Fumitoshi Ukai authored
Change-Id: I981e2e523efa04cd1b787485f24ade79e5b31302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942668Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Auto-Submit: Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#720106}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I73e7fd863ce149d4f024a21fdc55914c378e1c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943328Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720105}
-
Patrick Monette authored
This simplifies the code a bit by having all calls to AddClient() in the same function. Also merged DidCreateScriptLoader() and StartWorker() to centralize the worker starting logic. Bug: 1026740 Change-Id: I0b3070cf0c5d3b4c8765725c4223dca7fd66cc4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937968Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#720104}
-
Yuta Kasai authored
This CL doesn't change any behaviors. This just fixes typo in headers. Change-Id: I646bd2bd09370489c26b7e2529327647fa42fa5b Bug: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943488 Commit-Queue: Yuta Kasai <yutakasai@google.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#720103}
-
Dominic Farolino authored
This is the last of a series of CLs that remove manual notifications BrowserAccessibilityManager, now that it implements WebContentsObserver. This CL removes manual BAM::Navigation{Succeeded,Failed} notifications in favor of WCO::DidFinishNavigation, and BAM::UserIsNavigatingAway in favor of WCO::DidStartLoading. Bug: 981271 Change-Id: Ieca6ce0b97f2a0267fd7f2582ab1e333deb11b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938489Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#720102}
-
Ce Chen authored
run all model operations. Tested on iOS simulator & Pixel 2 XL. Bug: 925072 Change-Id: I56c2873c132bef83d6c8636aa290eeeeb2a771b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927471 Commit-Queue: Ce Chen <cch@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#720101}
-
Luciano Pacheco authored
The item was flickering when pressing Tab key, because of different background color for :focus. This list doesn't need a special color for focused because it only has 1 element in the dialog. Remove orange outline because the selection is indicated by the background color. Bug: 1029398,916099 Change-Id: I583d3cc92462920a4bd65716d9ed55b31c860da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943767 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2792515dab7c..4f14c4f2bdf6 git log 2792515dab7c..4f14c4f2bdf6 --date=short --first-parent --format='%ad %ae %s' 2019-11-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@4f14c4f2bdf6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I919e5f241b245fe4ef51a6098f8982aca717aca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943598Reviewed-by:
-
Tsuyoshi Horo authored
We need to isolate Web Bundles subresources in Memory cache to avoid cache pollution attack. Bug: 1027050 Change-Id: I33994bdb3430cbd539dd3335d50aa6d104a7cba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933841Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#720098}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ff24962cacae..7c62ed63ace5 git log ff24962cacae..7c62ed63ace5 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 samuel.r.attard@gmail.com properly detect msys_nt as windows in the ninja script Created with: gclient setdep -r src/third_party/depot_tools@7c62ed63ace5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: If14769238aafb941e4afb417d0c835606a09e5e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943593Reviewed-by:
-
Alex Danilo authored
Selecting a file, followed by opening the search box and attempting to click 'delete' or 'open' buttons to the left of the search box failed due to a mousedown listener that removed the search box and in turn, moved the position of the 'delete' or 'open' buttons mid-click causing the user action to fail. Adds a new class to the search box 'hide-pending' that defers the shrinking of the search box until a 'click' event is received on any part of the action bar. Noted during debugging that aria-disabled wasn't being set correctly, so replace the use of 'hidden' for the <cr-input> element with 'disabled' to control show/hide of the input text area, that updates aria-hidden true || false correctly in the <cr-input>. Change the Ctrl-F/Escape open and close of the search box to set the 'disabled' property instead of 'hidden'. Bug: 668427 Tests: browser_tests --gtest_filter="*HidingTextEntryField" Change-Id: Iac5f1cc0bec31f024f397797dd9c0397a6d703e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940325 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Chris Lu authored
This change checks the current state of Translate and returns early if the TranslateInfobarViewDelegate action methods are attempting to execute either a translate or revert when Translate is already in that state. Bug: 1014959, 1029120 Change-Id: Ifdbfe587f215876eb09d46a4dea41e6590b0f160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940171 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#720095}
-
Maggie Cai authored
Currently when app detail view open with an invalid app id, the redirect to main view of app management doesn't work. This is due to two issues. First, the rendering of the main view is called inside the rendering of the app detail view, which causes the app detail view rendering overwrite the main view rendering. Second, the apps initialisation might not be finished when the redirect need to happen so we cannot check if the app ID exists. This CL fixes both of the two issues. BUG=1010398 Change-Id: Id7ffd16abd33af0233cfba3aed128ef7343ba46b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939824 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#720094}
-
Anand K. Mistry authored
TBR=yamaguchi@chromium.org # for file_system_provider Bug: 1007832 Change-Id: I713339420b703843475c97e07e5dfbd1c67f8b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930241 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#720093}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e8c96d8e6116..2792515dab7c git log e8c96d8e6116..2792515dab7c --date=short --first-parent --format='%ad %ae %s' 2019-11-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@2792515dab7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I94b83676d07155440b7055a305e1aadd1b2493d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943589Reviewed-by:
-
