- 13 Aug, 2018 40 commits
-
-
Tarun Bansal authored
Add wildcard string matcher to previews. This would be used for matching URL (aka page) patterns provided by the hints optimization server. Also, fix some existing errors in gn files. Change-Id: Id24365b8f475b5740b0d897d9514dd1d6d3281d4 Bug: 870039 Reviewed-on: https://chromium-review.googlesource.com/1172159 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#582683}
-
Reza.Zakerinasab authored
This change removes the requirement of ExtendedImageBitmapOptions runtime enabled feature for CreateImageBitmap resize options to work. Bug: 762559 Change-Id: I6bd1e098e695116a66ef2387c07087da3cc91445 Reviewed-on: https://chromium-review.googlesource.com/1155164Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#582682}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/87a737292804..b35c655378ee git log 87a737292804..b35c655378ee --date=short --no-merges --format='%ad %ae %s' 2018-08-13 jvanverth@google.com Fix viewer assert in onResize Created with: gclient setdep -r src/third_party/skia@b35c655378ee The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I3bc607564014f12361e2d0792bee9c63dcde0a2a Reviewed-on: https://chromium-review.googlesource.com/1172703Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582681}
-
Jordy Greenblatt authored
This CL adds the forget device line in the subpage that has no functionality yet. Bug: 870069, 824568 Change-Id: Id85730eccd456d3a80516cc5c7d156fd86174d09 Reviewed-on: https://chromium-review.googlesource.com/1166334Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#582680}
-
enne authored
This reverts commit 0e3bef3e. https://chromium-review.googlesource.com/c/chromium/src/+/1171377 increased the timeout value for these tests, so I am reverting this commit. Two tryjobs both passed with no flakes. The tests in question now run at 7s long and no longer hit the shorter timeout. Investigation of decreasing the size of the output did not reduce the runtime significantly, and so there's some suspicion that most of the time is in shader compilation. These tests would need to be batched/rewritten into many different tests to decrease the time spent on an individual test basis. Change-Id: I80769b84f5adf9fddcd913b6d944923e77d5201a Reviewed-on: https://chromium-review.googlesource.com/1171425Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#582679}
-
Vladimir Levin authored
Maybe this is more complicated, but after the macro definition it seems cleaner and clearer which properties are added and it reduces the need to copy-paste things if new nodes are added. R=pdr@chromium.org, chrishtr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I60d4d47cffc34d6da7820e5ce4bf1e01db0b94a3 Reviewed-on: https://chromium-review.googlesource.com/1168102 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#582678}
-
Xiaoqian Dai authored
The 'drop-down-search-box' was extracted to 'cr-searchable-drop-down' element in https://chromium-review.googlesource.com/c/chromium/src/+/1145774. But 'drop-down-search-box' was not replaced in the edit printer dialog. Bug: 872031 Change-Id: Ia78cec9d26664a3e8d66e65c30ea6b4b0cf9117c Reviewed-on: https://chromium-review.googlesource.com/1167722 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#582677}
-
Adrienne Walker authored
Bug: 757605 Change-Id: I371ecafedd86627065ca698bfb33d6db54b6c1c6 Reviewed-on: https://chromium-review.googlesource.com/1169958 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Reilly Grant authored
He is no longer a member of the Chrome signin team. Change-Id: Id7580adfcb150951fbe8bcf59f61a8be21b025e3 Reviewed-on: https://chromium-review.googlesource.com/1172708Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#582675}
-
Yuwei Huang authored
RendererProxy is used mainly on the UI thread, but it is deleted on the display thread because GlDisplayRenderer binds its WeakPtrFactory to the display thread when initializing it. This forces QueuedTaskPoster to be deleted on the wrong thread, which may be a source of crash. You can see more details in the bug. This CL resolves this by making GlDisplayRenderer::Core initialize RendererProxy on the UI thread. Bug: 872944 Change-Id: I37dbd20aad80dd05e4eb0ad410c339fdfa5053c5 Reviewed-on: https://chromium-review.googlesource.com/1170133 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#582674}
-
Adithya Srinivasan authored
This is a reland of 104d9bf8 Original change's description: > Mojofy FileSystem > > - Mojofies and removes all messages in file_system_messages.h. > - Replaces FileAPIMessageFilter with FileSystemDispatcherHost. > - Adds mojom types for FileSystemInfo and FileSystemType and adds > type converters to convert these types to storage::FileSystemInfo > and storage FileSystemInfo respectively. The storage types will be > replaced with the mojom types in follow up CLs. > > Change-Id: I82aaf9dcb04149880e68238540766f21771d2b21 > Bug: 787281 > Reviewed-on: https://chromium-review.googlesource.com/1125316 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Reviewed-by: Joshua Bell <jsbell@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580346} Bug: 787281 Change-Id: I59369069558b57f4cf5001d072bb8a631e5e9d9a Reviewed-on: https://chromium-review.googlesource.com/1162204 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#582673}
-
Tarun Bansal authored
This is behind an experiment. Change-Id: Ib1657c2c333140da4471f72dec54d4b25c7adcd6 Reviewed-on: https://chromium-review.googlesource.com/1164247Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
Mike Dougherty authored
Bug: 851636 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1654ba4ee1576fc33bd9d59cd1c50b2bc86fbfae Reviewed-on: https://chromium-review.googlesource.com/1164649 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#582671}
-
Wez authored
Early termination of QEMU, e.g. due to missing KVM permissions, was neither logged nor handled by the runner script, requiring an explicit --system-log-file=<file> to be specified in order to determine the cause of the failure. Also add support for --system-log-file=- to have system log output logged to the console, if desired. Bug: 872920 Change-Id: Ib2db7213231791e404eb94caa5f8788149c01bca Reviewed-on: https://chromium-review.googlesource.com/1170086Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#582670}
-
Wei-Yin Chen (陳威尹) authored
- Amend bug ID handling: one space after colon (:). - Use GoB/gerrit URLs for diff and CL list. Bug: 749769 Change-Id: I7ea67512da418c54405fd7ffb81d3bc24f70b9db Reviewed-on: https://chromium-review.googlesource.com/1171846Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582669}
-
Eugene But authored
Slim Navigation Manager is implemented with assumption that session restoration URL is not corrupted for the large sessions. This test verifies that URL ref contains full session for 5k navigation items. This test will be modified later to verify that the number of entries is trimmed to 100 (which is max number of pushState calls allowed by WKWebView in 30 seconds timeframe). Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I47e09cf90b5b9726c87d391a5cbba2e3f7b78f60 Reviewed-on: https://chromium-review.googlesource.com/1170039 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#582668}
-
bsheedy authored
Adds versions of tests that interact with web contents (scrolling, clicking, etc.) where the interaction tested is in a cross-origin iframe. In order to achieve this, also adds the ability to request the focused iframe and execute JavaScript in it from Java. Bug: 862153 Change-Id: Ic0a1e5bee38c4f962626bb576040dd56bfc69bbf Reviewed-on: https://chromium-review.googlesource.com/1163831 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582667}
-
Jun Choi authored
Relying parties can enforce restriction on which transport type should be used to call GetAssertion API using PublicKeyCredentialDescriptor.transports[1]. As so, add transport field to PublicKeyCredentialDescriptor object. Furthermore, fix the blink layer type conversion for PublicKeyCredentialDescriptor. AuthenticatorTransport field is optional. When AuthenticatorTransport field is not set, we should allow all transport types. Currently, transport list in credential descriptor is set to empty array. Change this so that transport list is set to array of all transport types instead. [1]: https://w3c.github.io/webauthn/#enumdef-authenticatortransport Bug: 866601 Change-Id: I9cf2a17977a1078db772908be23745f06a680af8 Reviewed-on: https://chromium-review.googlesource.com/1166469 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582666}
-
Scott Violet authored
BUG=none TEST=none Change-Id: If445889772710cdb17df1780c52a4cd23a21feda Reviewed-on: https://chromium-review.googlesource.com/1172949Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#582665}
-
Tommy Steimel authored
This CL changes NavigationEntryImpl::GetTitleForDisplay for content URIs to use the file's display name if determinable. This affects HTML, audio, and video files opened with Chrome on Android. This does not affect image files since ImageDocument already has a built-in title. Bug: 800880 Change-Id: I0ad03d2dc13d4895f6789a6a7a6ea1199e19745b Reviewed-on: https://chromium-review.googlesource.com/1165790Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#582664}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/af1759587922..db7ea8c45f39 git log af1759587922..db7ea8c45f39 --date=short --no-merges --format='%ad %ae %s' 2018-08-13 mbonadei@webrtc.org Re-enable gtest absl pretty printers. Created with: gclient setdep -r src/third_party/webrtc@db7ea8c45f39 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4da3a747c9ce3cd8dd1432ead6395df6c9aab701 Reviewed-on: https://chromium-review.googlesource.com/1172702Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582663}
-
Muyuan Li authored
Bug: b/111900449 Test: 1. Connect external display and set to primary 2. Long-press app list button on internal display 3. assistant should show on the internal display Change-Id: I3acd11ba208864525bd144fe077fdd6209379cc4 Reviewed-on: https://chromium-review.googlesource.com/1171823 Commit-Queue: Muyuan Li <muyuanli@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582662}
-
Saman Sami authored
Stop observing the ui::WindowAndroid when its compositor has detached. This should prevent us from calling into it once it's destroyed. Bug: 869775,868849,865118 Change-Id: I75b4351f76f029a33c5ce6c9fc10b39f050fc750 Reviewed-on: https://chromium-review.googlesource.com/1170857Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#582661}
-
Weilun Shi authored
Writing a test for the new feature remembering the last selected directory for user. This unit test is for CL: 1162712:[NTP] Upload file from the most recent directory Bug: 871703 Change-Id: I18769a34ae360ff9b51241178c0e9ffdfd6f8c29 Reviewed-on: https://chromium-review.googlesource.com/1171880Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#582660}
-
Bruce Dawson authored
nt_registry.h was implicitly assuming that vector would include string. This change adds an explicit include of string to allow <vector> to stop including <string> in the VS header files. Change-Id: Id03d249b90320bc5506b20fd7481eecab58eecbc Reviewed-on: https://chromium-review.googlesource.com/1173065Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#582659}
-
Leonard Mosescu authored
The local (unofficial) builds use --build-id=uuid, which unlike sha1 build IDs does not slow down the build. Bug: 870919 Change-Id: Ib55cbc86e11e8208fa8560d98b3288bbc6a149de Reviewed-on: https://chromium-review.googlesource.com/1169903Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Leonard Mosescu <mosescu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582658}
-
spqchan authored
Bug: 867518 Change-Id: I350cee1c4b4c819ec902b7b43d6efb25b40acf76 Reviewed-on: https://chromium-review.googlesource.com/1172991Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582657}
-
lanwei authored
In HWNDMessageHandler::HandlePointerEventTypeTouch, the ReleaseNumber is after the touch events are dispatched, which will cause a crash when calling id_generator_, because the current |HWNDMessageHandler| is already destroyed so is |id_generator_|, when the current window is closed and new window pops out. We should move it before we dispatch the events. Bug: 853681 Change-Id: I0f2a6319a746aa0b38111693fa89ca639dad05fd Reviewed-on: https://chromium-review.googlesource.com/1166039Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#582656}
-
Alexis Hetu authored
Now that SwiftShader has been integrated into every platform on every test, we can remove OSMesa from the chromium codebase. BUG=chromium:873321 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_dbg_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie75c73c172aaffd17a3e041aa7f4cf37a96c3d4d Reviewed-on: https://chromium-review.googlesource.com/1128207Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Douglas Creager authored
Reporting specifies that the user agent should allow users to prohibit uploads on a per-origin basis. The Network Service's NetworkDelegate needs to actively disallow Reporting uploads until we're able to hook up the permissions manager across the service boundary. Bug: 845559 Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib63890e3b045c0067969a70628191530a96d482f Reviewed-on: https://chromium-review.googlesource.com/1171571Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Douglas Creager <dcreager@chromium.org> Cr-Commit-Position: refs/heads/master@{#582654}
-
Etienne Pierre-doray authored
IndirectReference brings complexity conceptually. The purpose of IndirectReference was to speed-up look-ups. Turns out that there is no significant impact on patching time when using direct references. Furthermore, this reduces coupling between TargetPool and ReferenceSet. Change-Id: Ic50dbf59e483a7fa1480c8eb37f4b1d01a53401a Reviewed-on: https://chromium-review.googlesource.com/1136578 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#582653}
-
Zhiqiang Zhang authored
CAF reconnection service is enabled by default. However the reconnection service is used for recovering sessions when the app crashes and relaunches. MediaRouter won't need this feature so it should be disabled. Bug: 711860 Change-Id: Ib7b3e13af56c4be4286be7d50dc2b0e7868a3722 Reviewed-on: https://chromium-review.googlesource.com/1171795 Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#582652}
-
Robert Liao authored
This is part 1 of 3 for aligning BubbleDialogDelegateView with its filename. BUG=873422 Change-Id: Ie57ac06eeda6afde915d3de6a1b60770a22e0da7 Reviewed-on: https://chromium-review.googlesource.com/1171907Reviewed-by:
-
David Black authored
Previously, answers were not scrollable. Now they are. To accomplish this, we've: - Created an abstract AssistantScrollView class to share logic between UiElementContainerView and SuggestionContainerView which both have the need to scroll. - Moved AssistantHeaderView out of UiElementContainerView because it should not participate in the scroll. Known issue: We still have not addressed the WebView event processing issue, so it is only possible to scroll UiElementContainerView via mouse/touch events that do not involve the WebView. This will be addressed in a follow up CL. Temporary workaround: initiate scroll events from the margins beside the cards, not over the cards themselves. Known issue: If the user scrolls the content and then issues another query, we fade out the current answer and show our thinking dots. But if the content has been scrolled, the thinking dots collide with other views. To address this, I force scroll the content back to the top and disallow events while waiting for the next answer to come in. Need UX guidance on what might be a better approach. See bug for demo. Bug: b:110039692 Change-Id: I20dbca681b92981857c4266ef1882642503eb0da Reviewed-on: https://chromium-review.googlesource.com/1172144 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#582650}
-
Leszek Swirski authored
The events in ChromeVoxEventWatcher are sorted to move LiveRegion entries to the end of the event list. However, Array.sort is not guaranteed to be stable, nor does it specify how the comparison function will be applied to the elements of the array. Instead, we can push events into two different arrays, and concatenate them after, preserving within-event order. Change-Id: Iec917f72295312760ba77080897eac86b8424b8f Reviewed-on: https://chromium-review.googlesource.com/1172775Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#582649}
-
Cole Winstanley authored
Implemented client-side replay from a ChromeDriver log file. Doesn't work for Android or remote browsers yet. Bug: chromedriver:2501 Change-Id: I40b634b5e7c5973a920b9ecd92cf7b039c867a4d Reviewed-on: https://chromium-review.googlesource.com/1137367 Commit-Queue: Cole Winstanley <cwinstanley@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582648}
-
Derek Cheng authored
Due to the way cast message delegates are layered, a cast message coming from a receiver first goes through KeepAliveDelegate, which inspects the message for keep-alive type and passes it through if it is not a ping/pong message. Instead of doing JSON parsing (which isn't safe in browser process), we will check for the heartbeat namespace and do a quick substring check for PING/PONG type. Also removed the now unused function and clean up tests to move usage of JSONReader to the test itself. Change-Id: I3c906b8215f7b7149b18c014278cdad3bdf6b3e7 Bug: 809249 Reviewed-on: https://chromium-review.googlesource.com/1170130 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#582647}
-
Elly Fong-Jones authored
Now that Button has a focus ring, use that instead of creating a second one. Bug: 872691 Change-Id: I078a223c491bd83121cf7a488595b26e3c56f81d Reviewed-on: https://chromium-review.googlesource.com/1172794Reviewed-by:
-
Lukasz Anforowicz authored
The bug has been in fixed r574623 - let's remove the test expectations (FWIW the tests are passing when run 20 times on my local machine). Bug: 601584 Change-Id: I5f99d8a066407d3b7be0d5fc1bdaf389de181b87 Reviewed-on: https://chromium-review.googlesource.com/1169956Reviewed-by:
-
John Abd-El-Malek authored
Mark external/wpt/service-workers/service-worker/mime-sniffing.https.html as fixed with network service. This was fixed in r580143 TBR=shimazu@chromium.org Bug: 771118 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I4766a79d1ddb3c017b35da0ced75f30e2a8113d6 Reviewed-on: https://chromium-review.googlesource.com/1172936 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#582644}
-
