GitLab

BUG=102591
TEST=type chrome://settings/syncSetup. You should see a sync dialog, not the personal options page.


Review URL: http://codereview.chromium.org/8571022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114147 0039d316-1c4b-4281-b951-d872f2087c98

Per discussion with thakis, cmp we should remove this dep from the tree and instead install it via install-build-deps.sh.

BUG=106105
TEST=Installed dep, ran tests.


Review URL: http://codereview.chromium.org/8919026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114146 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106772
TEST=NONE


Review URL: http://codereview.chromium.org/8918021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114144 0039d316-1c4b-4281-b951-d872f2087c98

This can potentially cut the mouse move, mouse wheel, and touch move
latency for platforms that send the UpdateRect_ACK message within the
UpdateRect IPC handler. Today, it seems that windows and mac will
sometimes send the UpdateRect_ACK synchronously, while linux never will.

Patch also includes some extra instrumentation to make this easier to
track that we may or may not want to land.

BUG=none


Review URL: http://codereview.chromium.org/8820001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114141 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
Review URL: http://codereview.chromium.org/8917030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114140 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107221
TEST=Change GAIA acct passphrase, wait for auth error, re-auth, make sure data is re-encrypted with the new passphrase.


Review URL: http://codereview.chromium.org/8921025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114139 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106060
TEST=none


Review URL: http://codereview.chromium.org/8917026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114138 0039d316-1c4b-4281-b951-d872f2087c98

BUG=93109
TEST=Launch Chromium, log in, open the NTP.


Review URL: http://codereview.chromium.org/8922011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114137 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=content_unittests --gtest_filter=URLFetcher*

Review URL: http://codereview.chromium.org/8885002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114136 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/8923011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114135 0039d316-1c4b-4281-b951-d872f2087c98

Hasn't fired since October 18, and it should be fixed.

BUG=86483


Review URL: http://codereview.chromium.org/8897016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114134 0039d316-1c4b-4281-b951-d872f2087c98

Revert 114059 - Fixed service side implementation of glTexStorage2DEXT to only initialize the number of
levels requirested. Also ClearLevel now uses glTexSubImage2D to clear the level if the
texture is immutable.  Finally, rearranged the code in doTexSubImage2D to correctly
bypass clearing a level if the bitmaps supplied matches the dimensions of the texture level.
BUG=106894
Review URL: http://codereview.chromium.org/8872061

Reverting as it may be causing a failure in the XP perf bots:
http://build.chromium.org/p/chromium.perf/builders/XP%20Perf%20%28dbg%29/builds/6854

TBR=vangelis@chromium.org
Review URL: http://codereview.chromium.org/8905027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114133 0039d316-1c4b-4281-b951-d872f2087c98

I suspect the Microsoft expand tool does not work reliably if invoked concurrently. Since a recent change to extract the xinput DLL using the same script, but for a different target than the D3D DLLs, it is possible that expand_from_cab.py can be invoked concurrently.

BUG=107291
Review URL: http://codereview.chromium.org/8921029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114132 0039d316-1c4b-4281-b951-d872f2087c98

Original CL (http://codereview.chromium.org/8821004/) was causing crash on some of browser_tests due to this.

BUG=104361
TEST=manual, and browser_tests now pass without crash


Review URL: http://codereview.chromium.org/8892025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114131 0039d316-1c4b-4281-b951-d872f2087c98

In addition to being unable to repro locally, the stack trace has been incorrect for a while and there are no reports from linux/mac valgrind bots.

BUG=76370
TBR=timurrr

Review URL: http://codereview.chromium.org/8923018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114130 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none


Review URL: http://codereview.chromium.org/8922016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114129 0039d316-1c4b-4281-b951-d872f2087c98

instead of a per-install ID.

BUG=106208
TEST=none

Review URL: http://codereview.chromium.org/8893015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114127 0039d316-1c4b-4281-b951-d872f2087c98

bug with ChromeOS where the Select File dialog's selected text color was
white on white.

BUG=chromium-os:23379
TEST=see bug for repro

Review URL: http://codereview.chromium.org/8894021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114126 0039d316-1c4b-4281-b951-d872f2087c98

Original commit text:

Add some suggested performance improvements to geturl.

Original Review URL: http://codereview.chromium.org/8603014

BUG=None
TEST=None
TBR=bradnelson@chromium.org

Review URL: http://codereview.chromium.org/8922018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114125 0039d316-1c4b-4281-b951-d872f2087c98

1) This is discouraged because it prevents callers from benefiting from automatic coersion from string/char* types.
2) A follow-up CL (http://codereview.chromium.org/8659047/) will make StringPiece a template, and thus awkward to forward declare. The very small number of places that were appropriately forward declaring it do not justify writing a 'string_piece_forward.h'.

BUG=87634
R=brettw@chromium.org


Review URL: http://codereview.chromium.org/8820016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114124 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=ajwong

Review URL: http://codereview.chromium.org/8919016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114122 0039d316-1c4b-4281-b951-d872f2087c98

The Active Window is now stored in a property on the RootWindow. Classes wishing to observe changes to this can implement WindowObserver and attach to the RootWindow to be notified of changes in this property.

We provide an ActivationClient interface in Aura for customers to use to set/get the active window, and deactivate a window. This is because setting the active window involves more than just changing the property, there is some additional book-keeping that must be done. The ActivationClient is stored in a property on the RootWindow.

We also provide an ActivationDelegate interface in Aura that window owners can use to be notified of changes in activation state, and to specify whether or not a window can be activated. The ActivationDelegate should be stored on the relevant window in a property.

I moved a lot of Activation-related functionality out of Aura, including all of the unit tests, now on ActivationController, and the associated WindowDelegate implementations which have now become a single TestActivationDelegate implementation.

BUG=none
TEST=unit tests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114095
Review URL: http://codereview.chromium.org/8894018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114121 0039d316-1c4b-4281-b951-d872f2087c98

Remove an outdated comment from nacl.scons
Left over from a previous CL - apparently commit queue ignores svn 'D' files.
Will submit this CL via gcl...
BUG=none
TEST=ppapi_geturl
Review URL: http://codereview.chromium.org/8922019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114119 0039d316-1c4b-4281-b951-d872f2087c98

Pulls out the core of gbillock's http://codereview.chromium.org/8283002/
- Move NOTREACHED and similar checks into the sql:: implementation code.
- Add malformed SQL checks to Connection::Execute.
- Add SQL-checking convenience methods to Connection.

The general idea is that the sql:: framework assumes valid statements,
rather than having client code contain scattered ad-hoc (and thus
inconsistent) checks.

This version puts back Statement operator overloading and loosy-goosy
Execute() calls to allow other code to be updated in small batches.

R=gbillock@chromium.org,jhawkins@chromium.org,dhollowa@chromium.org 
BUG=none
TEST=sql_unittests,unit_tests:*Table*.*


Review URL: http://codereview.chromium.org/8899012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114118 0039d316-1c4b-4281-b951-d872f2087c98

Tested using html5 drag demo and bookmark dragging to make sure that the patch didn't break dragging

BUG = 105886
Test = Manual


Review URL: http://codereview.chromium.org/8788002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114117 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106218,104368
TEST=Bookmark a host, then restart it. The bookmark should still work.

Review URL: http://codereview.chromium.org/8782001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114116 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/8888033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114115 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 84677847.

TEST=ran browser tests on OSX
BUG=103989
TBR=apatrick@chromiu.org

Review URL: http://codereview.chromium.org/8919014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114114 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107234
TEST=none
R=csilv

Review URL: http://codereview.chromium.org/8905020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114112 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107246
TEST=fixed


Review URL: http://codereview.chromium.org/8921016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114111 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r112107.

BUG=107269
TEST=as in bug

Review URL: http://codereview.chromium.org/8928001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114110 0039d316-1c4b-4281-b951-d872f2087c98

I'm doing this to pick up a naming change for a not-yet-used
D-Bus signal that'll be sent by the power manager
("PowerButtonEvent" becomes "ButtonEvent").

BUG=98328
TEST=ran "gclient sync"
TBR=satorux@chromium.org

Review URL: http://codereview.chromium.org/8919023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114108 0039d316-1c4b-4281-b951-d872f2087c98

R=jhawkins@chromium.org
TEST=Use an account with ASP, be able to easily navigate to the ASP input when
prompted on the sync setup overlay and full page promo.
BUG=98928


Review URL: http://codereview.chromium.org/8923008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114106 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101099
TEST=
  1. Enable Full Keyboard Access in System Preferences
  2. Create a folder on the bookmarks bar containing many (20+) bookmarks.
  3. Press the Tab key until this folder is selected in the bookmarks bar.
  4. Press the Space key to open the folder.

  After these steps, the folder should look identical to how it looks when you click on it directly.


Review URL: http://codereview.chromium.org/8789010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114104 0039d316-1c4b-4281-b951-d872f2087c98

The Active Window is now stored in a property on the RootWindow. Classes wishing to observe changes to this can implement WindowObserver and attach to the RootWindow to be notified of changes in this property.

We provide an ActivationClient interface in Aura for customers to use to set/get the active window, and deactivate a window. This is because setting the active window involves more than just changing the property, there is some additional book-keeping that must be done. The ActivationClient is stored in a property on the RootWindow.

We also provide an ActivationDelegate interface in Aura that window owners can use to be notified of changes in activation state, and to specify whether or not a window can be activated. The ActivationDelegate should be stored on the relevant window in a property.

I moved a lot of Activation-related functionality out of Aura, including all of the unit tests, now on ActivationController, and the associated WindowDelegate implementations which have now become a single TestActivationDelegate implementation.

BUG=none
TEST=unit tests
Review URL: http://codereview.chromium.org/8894018

TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8926004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114101 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107254,107255
TEST=as described in the bug

Review URL: http://codereview.chromium.org/8922014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114100 0039d316-1c4b-4281-b951-d872f2087c98

This change causes incognito requests to effectively have a different SSL
session cache from other requests. SSL session information will therefore not
leak into or out of incognito mode.

BUG=30877
TEST=net_unittests

Review URL: http://codereview.chromium.org/8857002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114098 0039d316-1c4b-4281-b951-d872f2087c98

The Active Window is now stored in a property on the RootWindow. Classes wishing to observe changes to this can implement WindowObserver and attach to the RootWindow to be notified of changes in this property.

We provide an ActivationClient interface in Aura for customers to use to set/get the active window, and deactivate a window. This is because setting the active window involves more than just changing the property, there is some additional book-keeping that must be done. The ActivationClient is stored in a property on the RootWindow.

We also provide an ActivationDelegate interface in Aura that window owners can use to be notified of changes in activation state, and to specify whether or not a window can be activated. The ActivationDelegate should be stored on the relevant window in a property.

I moved a lot of Activation-related functionality out of Aura, including all of the unit tests, now on ActivationController, and the associated WindowDelegate implementations which have now become a single TestActivationDelegate implementation.

BUG=none
TEST=unit tests
Review URL: http://codereview.chromium.org/8894018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114095 0039d316-1c4b-4281-b951-d872f2087c98

BUG=95845
TEST=Print preview a  webpage. Increment the number of copies to 2.
Observe the state of collate checkbox. It should be checked by default.


Review URL: http://codereview.chromium.org/8918013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114094 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106381
TEST=NONE
TBR=willchan,acolwell,grt
Review URL: http://codereview.chromium.org/8919018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114093 0039d316-1c4b-4281-b951-d872f2087c98