- 06 Jun, 2018 40 commits
-
-
Ryan Hansberry authored
BLE advertisement logic like generating an advertisement and inspecting it are factored into BleServiceDataHelper, allowing BleScanner and BleAdvertiser to be agnostic of whether the new DeviceSync Mojo API is being used. This CL completes Magic Tether's integration with the DeviceSync Mojo API; a user can enable use of the API by enabling the kMultiDeviceApi flag. This CL refactors BleAdvertisementGenerator and BackgroundEidGenerator to accept RemoteDeviceRef lists with BeaconSeeds inside them, instead of accepting a RemoteBeaconSeedFetcher. This removes the need for RemoteBeaconSeedFetcher; it will be removed in a subsequent CL. Bug: 824568, 752273 Change-Id: Ibfc8328ae979e176f438aa53b8258839133068b8 Reviewed-on: https://chromium-review.googlesource.com/1088311 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#565057}
-
Stephen Martinis authored
Bug: 782863 Change-Id: I6f4fb63fe1ed9c56a4f5238f1b0ca37c1c3a0715 Reviewed-on: https://chromium-review.googlesource.com/1087762Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#565056}
-
James Cook authored
It was previously defaulting to the primary display, which is wrong. Bug: none Change-Id: I827424b0e5a8dbb1725fe2741402c069afeb4fa3 Reviewed-on: https://chromium-review.googlesource.com/1089202 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#565055}
-
khmel@google.com authored
for Activity manager and Play Store is not closed after initial start. Test: Locally, confirmed that configuration changed is called only once Bug: b/67734479 Bug: b/76398711 Change-Id: I121243c03704587454516393467df08f9981f0c9 Reviewed-on: https://chromium-review.googlesource.com/1079457 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#565054}
-
Saman Sami authored
This should make it easier to have an Android implementation where ui::Compositor is not available. Bug: 848881 Change-Id: Ib7838f53b0935bf178954f1aa64bbf777cae3b6d Reviewed-on: https://chromium-review.googlesource.com/1087807Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#565053}
-
Weidong Guo authored
Changes: Make apps grid view in folder handles all scroll event if folder is opened to avoid closing app launcher via scrolling up in 1st page of folder. Bug: 847800 Change-Id: I5ec3744686202d519b421044d810857a3a5020d5 Reviewed-on: https://chromium-review.googlesource.com/1088148 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#565052}
-
Klaus Weidner authored
When ARCore loses tracking, continue providing camera images, but send null poses. This allows JS applications to handle tracking loss, i.e. by displaying a pose-independent info message. BUG: 837116 Change-Id: I92238f1bf158ca2714a4068ddba8ac5bbdb123fc Reviewed-on: https://chromium-review.googlesource.com/1043207Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#565051}
-
Xianzhu Wang authored
This reverts commit e2d97e7a. Reason for revert: Reland with the null pointer issue fixed. LayoutSVGEllipse and LayoutSVGRect override LayoutSVGShape methods not to create paths in case that optimized algorithm can be used. However, the original condition in their ShapeDependentStrokeContains() might call LayoutSVGShape::ShapeDependentStrokeContains() without use_path_fallback_ in some cases (e.g. when the shape is invalid). Now ensure ShapeDependentStrokeContains() is called only if use_path_fallback_ is set. Also ensure that use_path_fallback_ is set whenever we need it. Original change's description: > Revert "[PE] Ensure update of LayoutSVGShape::NoScalingStrokeTransform" > > This reverts commit 85b96ea9. > > Reason for revert: crbug.com/849968 > > Original change's description: > > [PE] Ensure update of LayoutSVGShape::NoScalingStrokeTransform > > > > In Pre-SPv175 we forced subtree paint invalidation on non-composited > > transform change. SPv175 no longer does that, causing > > NonScalingStrokeTransform not updated on ancestor transform change. > > > > We also had a non-obvious bug that LayoutSVGShape::StrokeBoundingBox > > didn't get updated on ancestor transform change. > > > > Now always explicitly update non-scaling-stroke data during layout. > > > > Bug: 849080 > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Change-Id: Ia61eb94f43e53a71a80e1102e4d605e4331f44b1 > > Reviewed-on: https://chromium-review.googlesource.com/1086715 > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: Fredrik Söderquist <fs@opera.com> > > Cr-Commit-Position: refs/heads/master@{#564584} > > Change-Id: Ifbdd23b74dc45b5c8bc66c3d64bff580d5306f78 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 849080, 849968 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Reviewed-on: https://chromium-review.googlesource.com/1087332 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564793} Bug: 849080, 849968 Change-Id: I15c2f80a2f80d11ccf356328ad41e8ab9d8de72f Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/1089090 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#565050}
-
Amy Qiu authored
Move tough_image_decode_cases into the rendering folder and refactor classes to inherit from RenderingStory Bug: 849392 Change-Id: I888b1226bc8663c28d79e5871215547af1052b4a Reviewed-on: https://chromium-review.googlesource.com/1089203 Commit-Queue: Amy Qiu <amyqiu@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#565049}
-
Justin Novosad authored
This is a step in unifying canvas and OffscreenCanvas code paths BUG=788439 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6f3a3f7bed8b36f502bc7ce138b4bf21920629f7 Reviewed-on: https://chromium-review.googlesource.com/1089582Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#565048}
-
Xi Cheng authored
Change-Id: I4121159c9326842a2e868a58e34a00359b1756c9 Reviewed-on: https://chromium-review.googlesource.com/1088312Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#565047}
-
Dan Beam authored
How I generated this: https://gist.github.com/danbeam/d5fe7b1bcfebc9a94d60c9975b842e97 R=dpapad@chromium.org BUG=none Change-Id: Ic8d85539990d9ccc4a2e0faa8a3928ee2c878adf Reviewed-on: https://chromium-review.googlesource.com/1089716 Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#565046}
-
edchin authored
This reverts commit cd9fa081. This CL fixes the reason that the DCHECK failed causing the original revert. Original change's description: > Revert "[ios] Hook up remote tabs in tab grid" > > This reverts commit 5316b1cb. > > Reason for revert: breaking ios_chrome_settings_egtests > > Original change's description: > > [ios] Hook up remote tabs in tab grid > > > > This CL hooks up the remote tabs in the tab grid. > > > > A user can sign in from the remote tabs page in the tab grid. The > > transition animation that displays the signin interaction controller > > looks bad (and we are investigating the cause). If the user is signed > > in but does not have sync enabled, the user can enable sync from here. > > > > Currently, tapping on a tab does nothing. This will be enabled in a > > future CL. > > > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > > Change-Id: Ifba06919e1fb496917254a0da7e5462a4b854d79 > > Reviewed-on: https://chromium-review.googlesource.com/1084080 > > Commit-Queue: edchin <edchin@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Reviewed-by: Sergio Collazos <sczs@chromium.org> > > Reviewed-by: edchin <edchin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#564684} > > TBR=rohitrao@chromium.org,eugenebut@chromium.org,edchin@chromium.org,sczs@chromium.org,javierrobles@chromium.org > > Change-Id: Idc0b0b2def356a173949298bc7f560ee4dad3744 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Reviewed-on: https://chromium-review.googlesource.com/1088566 > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > Commit-Queue: Olivier Robin <olivierrobin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564828} TBR=rohitrao@chromium.org,eugenebut@chromium.org,olivierrobin@chromium.org,edchin@chromium.org,sczs@chromium.org Change-Id: I34dca3dadbe0d356aff881559353876736722224 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1089251Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#565045}
-
Jordy Greenblatt authored
Change-Id: I81c5655e357b6211ccb32f1b82b829bb8d402f0b Reviewed-on: https://chromium-review.googlesource.com/1088230 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#565044}
-
Antonio Gomes authored
The closure in case is ContentHash::DidFetchVerifiedContents which takes a |const FetchParams&| parameter, but does not use it. This CL removes it. This is a driven by simplication as part of the preparation for making FetchParams non-copyable. Next, FetchParams will store a scoped_refptr<network::SharedURLLoaderFactory> rather than a raw network::mojom::URLLoaderFactory pointer. BUG=844926 Change-Id: I237c93be558f4cc7c65c5de2f73e8722a246863d Reviewed-on: https://chromium-review.googlesource.com/1089272Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#565043}
-
Kevin McNee authored
This reverts commit f58a0ada. Reason for revert: Suspecting this CL for the failures of CrSettingsSiteListTest.AddExceptionDialog and CrSettingsSiteListTest.EditExceptionDialog. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=CrSettingsSiteListTest.*ExceptionDialog Original change's description: > WebUI[MD-refresh]: switches remaining paper-input in Settings to cr-input. > > Bug: 832177 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: Iae1036e0a8975f65a37ff9ccc7b6084b4a6d45ef > Reviewed-on: https://chromium-review.googlesource.com/1081243 > Commit-Queue: Scott Chen <scottchen@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564968} TBR=dpapad@chromium.org,scottchen@chromium.org Change-Id: I4a0a973a5d54324389e2164e041bfb085dffd631 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 832177 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1089870Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#565042}
-
Mohamed Heikal authored
WebAPK shell currently sends us activity creation timestamp in the intent extras. This CL wires it through to the splashscreen UMA handler and records time to splashscreen shown/hidden from the launch of the WebAPK. Bug: 842023 Change-Id: Ie8c7289de4ce0f31cddec3bfec8e538a73469ae9 Reviewed-on: https://chromium-review.googlesource.com/1073875 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#565041}
-
Elly Fong-Jones authored
Two changes are required: 1) Explicitly upcast the result of dispatch_get_global_queue() to a dispatch_queue_t*, since it changed to return dispatch_queue_global_t*; 2) Add empty implementations of the new methods on ICCameraDeviceDelegate for ImageCaptureDevice TBR=maxmorin@chromium.org Bug: 849689 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9448d1b07f8d4116ecdb0c75a7796472e51c6dd8 Reviewed-on: https://chromium-review.googlesource.com/1087169Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#565040}
-
Bill Orr authored
As part of Mojoification of VRDevice, this change removes ExitPresent, and moves exclusive session management out of the VRDevice interface. BUG=795510 Change-Id: I60c7dca54b62eb518e1895d7a2d0df628fbd84d8 Reviewed-on: https://chromium-review.googlesource.com/1087718 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#565039}
-
Tommy Steimel authored
This CL adds CSS to use ellipsis when overflow menu text is too long. Bug: 839107 Change-Id: I367549c2e669d8e501f70157217544af96e74f0d Reviewed-on: https://chromium-review.googlesource.com/1089382Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#565038}
-
Aaron Leventhal authored
Separate out the different concepts: - Suggestions are available or not (call ViewAccessibility::OnInputSuggestionsAvailable or OnInputSuggestionsUnavailable). This is now a static so no view is required in case the menu for the suggestions has not yet been created. - Menu is open -- the AX code now just uses the menustart/end event to track this - Menu item is selected -- the AX code now just uses the selection event on a menuitem when menus are open By separating out these concepts, a11y can expose the fake menu item focus only when a menu item is actually selected, and indicate when a textfield has suggestions available even if the menu popup is not visible. Bug: 848427 Change-Id: I4a75c58402d1dd1e5da0368b59f6c9ba7fc8775c Reviewed-on: https://chromium-review.googlesource.com/1081022 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#565037}
-
Henrique Grandinetti authored
Before using the UsageTimeLimit on the TimeLimitProcessor we convert this to higher level structs, that allow the processor to work better. I was going to submit all together, but it was too big, so I split into two cls. These structs here didn't need to have their interfaces public, since its going to be used solely by the TimeLimitProcessor. However, I exposed its interface on the internal namespace in order to make it testable. Usually, we don't want to test private code, but these converters have a complex logic, and I thought it was better to have this explicitly tested. Bug: 823536 Change-Id: Ia90c5e83b5d0f149ae93024a1671b93850584f91 Reviewed-on: https://chromium-review.googlesource.com/1071687 Commit-Queue: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#565036}
-
Ella Ge authored
This CL adds LSQ predictor to input prediction. LSQ predictor uses a quadratic least square regression model: y = b0 + b1 * x + b2 * x ^ 2. The resampling is still behind flag: kResampleInputEvents. design doc: https://docs.google.com/document/d/1DLfibi2NkV85p7AfEtNkvy24d283VRBSd3hz1Qh24Jw/edit# Bug: 836352 Change-Id: Ie1959c6b95152a80076debfb762c49d88a758af3 Reviewed-on: https://chromium-review.googlesource.com/1003220 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#565035}
-
David Bertoni authored
Bug: 65337 Change-Id: I60eccbb32f782f98f147c95f8bbbebf7f92a7c34 Reviewed-on: https://chromium-review.googlesource.com/1082009 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#565034}
-
Sean DuBois authored
Matching the recents changes in libwebrtc[0] enable MediaTek just for H264 [0] https://chromium.googlesource.com/external/webrtc/+/5b6891afddcef18ea699efcd457dfab80c22ac70 BUG=848511 R=braveyao@chromium.org Change-Id: I0431b48730eb14149530a1265d173cca7e8944f3 Reviewed-on: https://chromium-review.googlesource.com/1086408Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#565033}
-
CJ DiMeglio authored
The comment refers to a field that does not exist. Bug: 746182 Change-Id: I76586b938980f95e93a01386ea7bde7844d59f4d Reviewed-on: https://chromium-review.googlesource.com/1087324Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#565032}
-
Fadi Meawad authored
Freezing can only work on hidden pages, currently there is no easy way in webdriver that allows us to hide the page. A new webdriver API is in the works to enable that, but meanwhile, for all testing API, we have to couple hiding with freezing. This CL does that and reenables the test with Network Service. Bug: 837709, 848604 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ib5c513aefb219cef38a563be81fe8abf4b354051 Reviewed-on: https://chromium-review.googlesource.com/1089354 Commit-Queue: Fadi Meawad <fmeawad@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#565031}
-
Stephen Martinis authored
The tests are passing on CI now, so make it block the CQ. NOTRY=true Bug: 831847 Change-Id: I9767bb792b99cf3a47975062f6820c1fc82f8f6a Reviewed-on: https://chromium-review.googlesource.com/1035794 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#565030}
-
B. Menegola authored
Leave the flag in place so we can revert the state in case we have any blockers. R=escordeiro@chromium.org, yusukes@chromium.org Bug: 828983 Change-Id: I9886bde062fc076acc34fe14cf42203784ef18f5 Reviewed-on: https://chromium-review.googlesource.com/1089150 Commit-Queue: B. Menegola <menegola@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#565029}
-
Xiaohan Wang authored
- Make test constant names more specific. - Use auto where applicable. - using Requirement = blink::WebMediaKeySystemConfiguration::Requirement; - Move ASSERT_TRUE into SelectConfig*() functions. - clang format Bug: 848532 Test: Test cleanup only Change-Id: I8c7613dad4c582adfcfb3d9d97c5456f86177257 Reviewed-on: https://chromium-review.googlesource.com/1089465Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#565028}
-
Martin Kreichgauer authored
This changes sign_app.sh to take a provisioning profile path as an argument, which it will copy into the app bundle Content/ directory. It then signs the app with --entitlements pointing at a newly created entitlements.plist file, in order to grant the keychain-access-group entitlement. The entitlement is needed to create and access cryptographic key material in the Secure Enclave Processor (SEP) on compatible macOS devices. Bug: 848052 Change-Id: Ib002fc73d250409e555f4caee8848a2c3e95e591 Reviewed-on: https://chromium-review.googlesource.com/1079833 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#565027}
-
Greg Thompson authored
It was reporting a preferred size inconsistent with its Layout(), causing potential clipping. To fix, anticipate the required alignment using constants. BUG=847904 R=bsep@chromium.org CC=tapted@chromium.org Change-Id: I775dbe8a346839914b6dda4965a9c0e97c852661 Reviewed-on: https://chromium-review.googlesource.com/1087965Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#565026}
-
Mathieu Perreault authored
Bug: 850078 Test: browser_tests Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I026e1098fedd85f6cf413d74fe596934794ae001 Reviewed-on: https://chromium-review.googlesource.com/1088873 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#565025}
-
Ted Choc authored
BUG=849294 Change-Id: I8bf82b86b517d3c269af2a8580df86aa546a88ed Reviewed-on: https://chromium-review.googlesource.com/1089351Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#565024}
-
Ryan Daum authored
Re-submission with fixes of cl 1081234 (reverted by 1087371.) * Move the cast AccessibilityManager into chromecast/browser/accessibility. * Only compile and create AccessibilityManager if extensions enabled. Bug: none Test: manual Change-Id: Id81fdb1711af84d8eecefd2061cca061826df39a Reviewed-on: https://chromium-review.googlesource.com/1087650Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#565023}
-
Kevin McNee authored
This reverts commit 1ff37758. Reason for revert: external/wpt/webusb/idlharness.https.any.* tests are failing Original change's description: > Multi-global WebUSB WPT for window and worker > > This change updates the existing web platform tests for WebUSB to use > multi-global tests to test the API in the supported contexts. The > change updates the following tests: > * idlharness > * usb > * usbConnectionEvent > > Bug: 841510 > Change-Id: I6b118aa4121109cd6a48054c2ebc69b831660afc > Reviewed-on: https://chromium-review.googlesource.com/1087209 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564981} TBR=reillyg@chromium.org,chongz@chromium.org,odejesush@chromium.org Change-Id: Ifde97a1736134477422b6fd81392b11bbd775a63 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 841510 Reviewed-on: https://chromium-review.googlesource.com/1089690Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#565022}
-
Vikas Soni authored
All the Aimages associated with AImageReader must be closed/deleted before we close/delete the AImageReader. Bug: 849218 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9b013a7da53f0da716b869c48fe2ee024bee21a3 Reviewed-on: https://chromium-review.googlesource.com/1087827 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#565021}
-
Jun Cai authored
Noticed this presubmit warning when working on another CL which modifies this file. This CL adds explicit for single-parameter constructors in this file. Bug: None Change-Id: I03dc030cc981751bf754f0b5f391afa747f019d9 Reviewed-on: https://chromium-review.googlesource.com/1089357Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#565020}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/01f608b..1b40071 git log 01f608b..1b40071 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 dtu@chromium.org [pinpoint] Plumb Swarming test exceptions to the job level. Created with: gclient setdep -r src/third_party/catapult@1b40071 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I7ac3c50b2389dbf02afbaf151d2a106ac1cf9ca9 Reviewed-on: https://chromium-review.googlesource.com/1089490Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565019}
-
Wei Li authored
Turn on using pdf compositor service for printing by default. Still keep the feature flag as a kill switch for now. BUG=824867 Change-Id: I5b7751c5ce453a7ffcda1bf38b5f141135f850f6 Reviewed-on: https://chromium-review.googlesource.com/1087872Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#565018}
-