GitLab

This CL makes URLFetcherFileWriter::Finish() skip closing file when there is an
error. If there is an error, Finish() will delete the file after any pending
operation completes.

TBR=hashimoto@chromium.org
TBR=mkwst@chromium.org
BUG=487732, 656692

Review-Url: https://chromiumcodereview.appspot.com/2425673006
Cr-Commit-Position: refs/heads/master@{#426540}

rather than reject them.

Roughly this means cookie expiration times prior to 1970 on (non-OSX)
POSIX, or after 2038 on 32-bit (non-OSX) POSIX, will now be interpreted
as either very small or very large base::Time values.

This is a reland of https://codereview.chromium.org/2424443002/, which
ran into issues due to base::Time::FromTimeT() returning Time::Max() when
passed the maximum time_t value. As a workaround, ParseCookieExpirationTime
now returns the min/max base::Time() values for times outside the supported
range, instad of the min/max base::Time() values supported by
Time::FromUTCExploded() on the current platform.

BUG=649416

Review-Url: https://chromiumcodereview.appspot.com/2438513003
Cr-Commit-Position: refs/heads/master@{#426539}

BUG=None
TEST=Manual

Review-Url: https://chromiumcodereview.appspot.com/2436833002
Cr-Commit-Position: refs/heads/master@{#426538}

BUG=

Review-Url: https://chromiumcodereview.appspot.com/2436703003
Cr-Commit-Position: refs/heads/master@{#426537}

This CL moves the 'Add site exception' button to an 'Add' button on the
header line of the site exceptions. The filter for the site data has
been moved into the list of sites. The remove all local cookie and
storage button has been removed from the list of cookies (it's still
available in the dialog).

Also, the misalignment of .secondary text in checkboxes and content
settings has been fixed.

BUG=654875, 655036
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://chromiumcodereview.appspot.com/2429973003
Cr-Commit-Position: refs/heads/master@{#426536}

- Combine the 4 notification action arrays sent through JNI
into a single array of ActionInfo java objects

- Pass action type as a java-exported enum/int

BUG=650302

Review-Url: https://chromiumcodereview.appspot.com/2440483002
Cr-Commit-Position: refs/heads/master@{#426535}

BUG=656911

Review-Url: https://chromiumcodereview.appspot.com/2439543002
Cr-Commit-Position: refs/heads/master@{#426534}

This test still assumes that the following command should throw an exception:
var array = new TypedArray(null, 0, 0);

The specs https://www.khronos.org/registry/typedarray/specs/latest/#TYPEDARRAYS
doesn't say it should throw an exception. So we update this test.

BUG=623120

Review-Url: https://chromiumcodereview.appspot.com/2433363003
Cr-Commit-Position: refs/heads/master@{#426533}

The policy blacklist parser used to first check for "file" schemes first as a
special case before checking for wildcard hosts like "http://*", and the file
special-case had it's own wildcard special casing.

I am working on making "*" an invalid host character, and with this future
patch, creating a GURL of "file://*" will fail. This change moves the wildcard
handling above the file scheme checking so it will work regardless of whether
"*" is a valid host character or not.

The particular structure of this code looks like a result of adding the
wildcard handling ( https://codereview.chromium.org/1692503002/ ) after the
file handling was already in place.

BUG=652808

Review-Url: https://chromiumcodereview.appspot.com/2426733002
Cr-Commit-Position: refs/heads/master@{#426532}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d2709daf..79132f63

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2440443004
Cr-Commit-Position: refs/heads/master@{#426531}

The revert was documented in here http://crbug.com/657240, it is likely
that ASAN builders messed up due to a dummy event used as input for the
intent picker, this only affects the unit tests.

The original CL can be found here:
https://codereview.chromium.org/2229943003/

BUG=620129, 638063
TEST=Manual test, also IntentPickerBubbleViewTest unit tests passing.

Review-Url: https://chromiumcodereview.appspot.com/2436543003
Cr-Commit-Position: refs/heads/master@{#426530}

The (formerly) IsValidDXTSize check is specific to the
WEBGL_compressed_texture_s3tc semantics, but doesn't
correspond to constraints in the native extension
(EXT_texture_compression_s3tc), so only apply this check to
WebGL contexts.

BUG=657678
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://chromiumcodereview.appspot.com/2439643003
Cr-Commit-Position: refs/heads/master@{#426529}

This is a temporary fix for chrome_public_test_apk hanging when the
enable_vr_shell flag is enabled on non-component builds. This will be reverted
once the .a is added to allow for non-component VR builds. .a status available
at https://buganizer.corp.google.com/issues/31479702
BUG=

Review-Url: https://chromiumcodereview.appspot.com/2425603006
Cr-Commit-Position: refs/heads/master@{#426528}

This changes the NetworkConnect::Delegate interface to
consistently use network_id instead of service_path which is
a Shill implementation detail that should not be exposed to
the UI.

BUG=5=657127

Review-Url: https://chromiumcodereview.appspot.com/2430003002
Cr-Commit-Position: refs/heads/master@{#426527}

The inspector now finds one additional script location in the test which was
already collected using object grouping.

BUG=chromium:468240
R=haraken@chromium.org,hlopko@chromium.org
NOTRY=true

Review-Url: https://chromiumcodereview.appspot.com/2432163005
Cr-Commit-Position: refs/heads/master@{#426526}

Since the http://crrev.com/b4d6bf98e, we started
sending two "documentUpdated" events for every
page reload.

It's not a bad thing by itself (but probably needs
addressing in a follow-up), but the element restoration
logic is unprepared for this.

This patch re-writes the element restoring logic in the
elements panel.

BUG=645645

Review-Url: https://chromiumcodereview.appspot.com/2428823002
Cr-Commit-Position: refs/heads/master@{#426525}

For Ash material design (--ash-md=experimental), restore
focus to the previously-focused system menu row
when transitioning away from a detailed view using
the keyboard (i.e., when the back button has focus and
the return key is pressed).

BUG=650776
TEST=TrayDetailsViewTest.TransitionToDefaultViewTest

Review-Url: https://chromiumcodereview.appspot.com/2434553003
Cr-Commit-Position: refs/heads/master@{#426524}

Also replace mentionings of the deprecated platformKeysPrivate by
platformKeys.  Comments only, no functional changes.

BUG=645078

Review-Url: https://chromiumcodereview.appspot.com/2424003003
Cr-Commit-Position: refs/heads/master@{#426523}

Revert of Expose RTT and throughput estimates from Cronet (patchset #7 id:240001 of https://codereview.chromium.org/2417643007/ )

Reason for revert:
Reverting this due to trybot failures:
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20ARM64%20Builder%20%28dbg%29/builds/40129

Original issue's description:
> Expose RTT and throughput estimates from Cronet
>
> The estimates are computed by the network quality estimator
> (NQE) and are pushed to CronetUrlRequestContext.
>
> Embedders can query for the estimates by calling
> appropriate methods on CronetEngine.
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_cronet
>
> BUG=654498

TBR=ryansturm@chromium.org,mgersh@chromium.org,xunjieli@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=654498

Review-Url: https://chromiumcodereview.appspot.com/2433923005
Cr-Commit-Position: refs/heads/master@{#426522}

The IoThreadClient has a map that's keyed by RenderFrame IDs. That doesn't work with plznavigate where navigation requests only have a frame tree node id. This requires another map.

Ideally it would be good to not have to use that map and remove IoThreadClient completely. However, that is not possible. But most of the code in IoThreadClient already posts directly to UI thread and not need to be plumbed from there.

This is first of the patches to move code that does not necessarily has to use IoThreadClientImpl out of it.

BUG=645983

Review-Url: https://chromiumcodereview.appspot.com/2425423004
Cr-Commit-Position: refs/heads/master@{#426521}

This sets up the plumbing to get data from the Task Scheduler to the
internals page. The first target are some selected histograms.

BUG=553459
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://chromiumcodereview.appspot.com/2420973002
Cr-Commit-Position: refs/heads/master@{#426520}

We used to request audio focus in AndioManagerAndroid and save/restore
the audio mode. Both are not necessary now.

The newly added MediaSessionDelegate will take care of audio focus.
And it's more resonable to switch back to NORMAL since we can't know
that the saved mode is still valid. This will be handled by Android
audio frame.

BUG=650533

Review-Url: https://chromiumcodereview.appspot.com/2437963002
Cr-Commit-Position: refs/heads/master@{#426519}

In preparation for the migration of many Chrome threads to
TaskScheduler, we want to get rid of MessageLoop destruction
observers.

This CL removes the code that deletes DeviceMonitorLinux from
a destruction observer and uses a LazyInstance::Leaky to manage
the lifetime of DeviceMonitorLinux.

This CL also helps reducing the amount of work done during
shutdown
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/AMB2Y7Sqj48/QltA07wUCQAJ

BUG=650318

Review-Url: https://chromiumcodereview.appspot.com/2433933004
Cr-Commit-Position: refs/heads/master@{#426518}

The estimates are computed by the network quality estimator
(NQE) and are pushed to CronetUrlRequestContext.

Embedders can query for the estimates by calling
appropriate methods on CronetEngine.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_cronet

BUG=654498

Review-Url: https://chromiumcodereview.appspot.com/2417643007
Cr-Commit-Position: refs/heads/master@{#426517}

Notifies RemotePlayback about the attribute being set that
rejects the pending prompt() promise and cancels all availability watch callbacks.

BUG=657566
TEST=RemotePlaybackTest

Review-Url: https://chromiumcodereview.appspot.com/2432173006
Cr-Commit-Position: refs/heads/master@{#426516}

This prevented LayoutBlockFlow::layoutBlockFlow from seeing that the height had
changed.  As a result, it failed to set relayoutChildren = true.

The bug affects fixed-pos objects in abs-pos containers, so it got worse with
http://crrev.com/1172153004 but existed before.

An equivalent patch for width was made in http://crrev.com/171463003.

Additionally, update the early return for the case where the abs-pos container
is the LayoutView.  (This is just an optimization.)

BUG=640639

Review-Url: https://chromiumcodereview.appspot.com/2429113002
Cr-Commit-Position: refs/heads/master@{#426515}

See bug for many failing tests.
Example: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/47887/steps/browser_tests%20on%20Ubuntu-12.04/logs/EditDictionaryWebUITest.testNoCloseOnSearchEnter

BUG=657514
TBR=aboxhall
NOTRY=true

Review-Url: https://chromiumcodereview.appspot.com/2436063002
Cr-Commit-Position: refs/heads/master@{#426514}

Specification: https://w3c.github.io/browser-payment-api/

There are some circumstances where a cross-origin iframe
wants to make a payment request. A cross-origin iframe
needs explicit permission from the embedding page to invoke
the payment request API.

BUG=652148

Review-Url: https://chromiumcodereview.appspot.com/2394473002
Cr-Commit-Position: refs/heads/master@{#426513}

This code no longer has any effect, since we now fragment and set the correct
row heights way BEFORE cell alignment and flexing. It was also buggy, in that
it didn't recalculate intrinsic padding after resizing the row.

BUG=534751

Review-Url: https://chromiumcodereview.appspot.com/2433413002
Cr-Commit-Position: refs/heads/master@{#426512}

The removed utility functions are no longer used.
The improved unit tests give better coverage to the
functions that remain.

Review-Url: https://chromiumcodereview.appspot.com/2364373002
Cr-Commit-Position: refs/heads/master@{#426511}

As suggested by Ryan Sleevi (https://codereview.chromium.org/2348393002/diff/80001/components/certificate_transparency/mock_log_dns_traffic.cc#newcode47), MockLogDnsTraffic will no longer CHECK-fail when given invalid test expectations. Instead, it will return false and the tests using it can ASSERT_TRUE.

BUG=624894

Review-Url: https://chromiumcodereview.appspot.com/2389993003
Cr-Commit-Position: refs/heads/master@{#426510}

This is a follow up to http://crrev.com/2360893002, which made it so that
lines in the generic test expectations file (LayoutTests/TestExpectations)
are updated when tests are removed or renamed in the upstream repo.

It turns out that this should be done for all test expectations files,
not just that one.

BUG=649010

Review-Url: https://chromiumcodereview.appspot.com/2432883003
Cr-Commit-Position: refs/heads/master@{#426509}

Since we don't know for sure what the outcome will be and need to perform
field trials, default to disabled.

BUG=655585

Review-Url: https://chromiumcodereview.appspot.com/2441633002
Cr-Commit-Position: refs/heads/master@{#426508}

This is to avoid costly analysis for a display item containing huge
number of operations, especially drawRect operations drawing small
rects.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://chromiumcodereview.appspot.com/2425323002
Cr-Commit-Position: refs/heads/master@{#426507}

When the credit card editor launches because of, for example, a missing
billing address, the card number should be formatted for easy grokking.

BUG=657585

Review-Url: https://chromiumcodereview.appspot.com/2433093003
Cr-Commit-Position: refs/heads/master@{#426506}

This CL is blocked on the master/slave configuration in https://codereview.chromium.org/2437923003/

BUG=chromium:633253

Review-Url: https://chromiumcodereview.appspot.com/2439733002
Cr-Commit-Position: refs/heads/master@{#426505}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/0ec7a44..9c4cafa

$ git log 0ec7a44..9c4cafaa --date=short --no-merges --format=%ad %ae %s
2016-10-20 danilchap@webrtc.org Append second nack list in same compound rtcp packet instead of replace
2016-10-20 aleloi@webrtc.org Made AudioReceiveStream a mixer participant.
2016-10-20 sakal@webrtc.org Fix org.mockito.Matchers deprecation warnings in DirectRTCClientTest.
2016-10-20 aleloi@webrtc.org Split audio mixer into interface and implementation.
2016-10-20 brandtr@webrtc.org Add FlexfecReceiveStream.
2016-10-20 kjellander@webrtc.org Remove all traces of Dr Memory.
2016-10-20 palmkvist@webrtc.org Make GN build screenshare_loopback
2016-10-20 magjed@webrtc.org iOS: Optimize video scaling and cropping
2016-10-20 minyue@webrtc.org Moving WebRtcVoiceMediaChannel::SendSetCodec to AudioSendStream.
2016-10-20 magjed@webrtc.org Android YuvConverter: Use OpenGL Framebuffer instead of EGL pixel buffer
2016-10-20 magjed@webrtc.org Android: Extend functionality of EglRenderer
2016-10-20 nisse@webrtc.org Revert of Delete unused file mediacommon.h. (patchset #1 id:1 of https://codereview.webrtc.org/2437703002/ )
2016-10-20 sakal@webrtc.org Remove check for numberOfCameras from AppRTC Mobile PeerConnectionClient.
2016-10-20 sakal@webrtc.org Suppress deprecation warning in CallFragment.
2016-10-20 aleloi@webrtc.org Added a level controller initialization value to MediaConstraints.
2016-10-20 denicija@webrtc.org Add loopback option and improve UX of AppRTCMobile for Mac.
2016-10-20 kthelgason@webrtc.org Prevent stripping of C interfaces in framework
2016-10-20 danilchap@webrtc.org Add to rtc::Optional equality/unequality comparisions with object
2016-10-20 nisse@webrtc.org Delete unused file mediacommon.h.
2016-10-20 kthelgason@webrtc.org QualityScaler reset bugfix
2016-10-20 perkj@webrtc.org Change RefCountedObject to use perfect forwarding. The main reason for doing this is to allow refcounted objects to accept rvalue references in ctor and be able to std::move ctor rvalue arguments. Also, refcounted.h is now generated using pump.py instead of manually creating each ctor version.
2016-10-19 zijiehe@chromium.org A variable in ScreenCapturerWinDirectx has a bad name
2016-10-19 kthelgason@webrtc.org Revert of Move bitstream parser to more appropriate directory. (patchset #4 id:60001 of https://codereview.webrtc.org/2370853005/ )
2016-10-19 kthelgason@webrtc.org Move current bitstream parser to more appropriate directory.

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://chromiumcodereview.appspot.com/2439673003
Cr-Commit-Position: refs/heads/master@{#426504}

The reference images generated for Accelerated2D and
Unaccelerated2D cases look correct.

TBR=zmo@chromium.org
BUG=655311
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://chromiumcodereview.appspot.com/2423413002
Cr-Commit-Position: refs/heads/master@{#426503}

BUG=623613
NOTRY=true

Review-Url: https://chromiumcodereview.appspot.com/2434933002
Cr-Commit-Position: refs/heads/master@{#426502}

BUG=621464

Review-Url: https://chromiumcodereview.appspot.com/2434893003
Cr-Commit-Position: refs/heads/master@{#426501}