GitLab

BUG=268812
TEST=Files.app runs without error. All tests pass.
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/22382002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215855 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces fileOperationUtil namespace and move/extracts some helper
methods from FileCopyManager to it.
This is preparation to move copyTo helper to it, so that moving the copyTo
from js-side to c++-side should be simpler task. The moving copyTo will be done
in following CLs.

BUG=246976
TEST=Ran browser_tests --gtest_filter="*FileSystemExtensionApiTest*:*FileManagerBrowserTest*" and tested manually.

Review URL: https://chromiumcodereview.appspot.com/22291004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215854 0039d316-1c4b-4281-b951-d872f2087c98

I've just checked and found it's unnecessary. Touching comes with click events?

BUG=none
TEST=manual
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/22384002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215853 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://chromiumcodereview.appspot.com/21205007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215852 0039d316-1c4b-4281-b951-d872f2087c98

The Drive file operations are on the blocking pool (not the FILE thread)
so the current fan-in is racy if multiple Drive files are selected.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/22336003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215851 0039d316-1c4b-4281-b951-d872f2087c98

Due to flakiness, disabling this test.

BUG=86562
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/22347002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215850 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/22325002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215849 0039d316-1c4b-4281-b951-d872f2087c98

Justification: the keyboard shortcuts are already allowed when
--ash-debug-shortcuts is specified.

BUG=None
R=derat@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22324002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215848 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/22306002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215847 0039d316-1c4b-4281-b951-d872f2087c98

This allows RWHVA::CopyFromCompositingSurfaceToVideoFrame to work when the CopyOutputResult contains a bitmap, which happens with the software renderer.

BUG=

Review URL: https://chromiumcodereview.appspot.com/22284006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215846 0039d316-1c4b-4281-b951-d872f2087c98

For consistency with other member functions ReorderChildren now takes
const BookmarkNode pointers.

BUG=126092

Review URL: https://chromiumcodereview.appspot.com/20521005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215845 0039d316-1c4b-4281-b951-d872f2087c98

Previously, there was a single synchronous IPC that would
check if PNaCl is installed, then install if not installed,
as well as open the individual files read-only.

That sync IPC would block the UI if it needed to install PNaCl.

Instead separate checking from the opening a file read-only.
Have a separate IPC that is async, so that the UI is
not blocked, and progress events could eventually be sent.
Some basic plumbing of progress events is set up, but not
yet wired up to JS.

Order of events is:

CheckInstalled
* if Installed, reply w/ success
* if not Installed {
    send progress event indicated install start
    try install
    (may send more progress events)
    send progress of install success or failure
  }


BUG=252760
TEST=unit_tests --gtest_filter=NaClFileHostTest*  (and manual)

Review URL: https://chromiumcodereview.appspot.com/19863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215844 0039d316-1c4b-4281-b951-d872f2087c98

Related review: https://codereview.chromium.org/19281007/

BUG=260644

Review URL: https://chromiumcodereview.appspot.com/19256012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215843 0039d316-1c4b-4281-b951-d872f2087c98

Some of existing IPCs and methods for Blob are renamed for readability.

Note
- raw data sending code in webblobregistry_impl.cc are duplicated intentionally
not to bother michaeln's refactoring

Bonus: Stopped over-optimization of sharing webkit_blob::BlobData::Item instances in webblobregistry_impl.cc

BUG=169957

Review URL: https://chromiumcodereview.appspot.com/15817013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215842 0039d316-1c4b-4281-b951-d872f2087c98

If thumbnail_db_ Init() fails, then reset() is called, so later calls
need to be checked.

BUG=242636
TEST=Chrome stops crashing in the field.

Review URL: https://chromiumcodereview.appspot.com/22305002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215837 0039d316-1c4b-4281-b951-d872f2087c98

navigation is started.

We don't replace browser-initiated pending entries in didStartProvisionalLoad
because either (1) they were just created for this navigation and are already
correct, (2) they're for a different SiteInstance and won't be used upon
commit, or (3) they're same-site (see below).

Note that pending entries for same-site browser-initiated navigations can be
incorrectly used for renderer-initiated navigations that interrupt them, but
that's a long standing bug that we can address separately.

BUG=266922
TEST=See bug for repro steps.

Review URL: https://chromiumcodereview.appspot.com/21913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215836 0039d316-1c4b-4281-b951-d872f2087c98

BUG=259492
TBR=isherman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/21854002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215835 0039d316-1c4b-4281-b951-d872f2087c98

The code was incorrectly using the title as the message for the MessageBox.

BUG=none
TEST=Navigate to about:inducebrowsercrashforrealz and make sure the message
box looks correct.

Review URL: https://chromiumcodereview.appspot.com/22288003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215834 0039d316-1c4b-4281-b951-d872f2087c98

Because variable which has type in the included file becomes pointer.
This change is rest of following:
https://src.chromium.org/viewvc/chrome?view=rev&revision=215590

Review URL: https://chromiumcodereview.appspot.com/22299004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215833 0039d316-1c4b-4281-b951-d872f2087c98

The goal is to delete third_party/gles2_book.
This patch deletes all known references.

BUG=98130
TBR=apatrick@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22299002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215832 0039d316-1c4b-4281-b951-d872f2087c98

Hitting enter in this field should be a no-op instead of closing
the overlay, as hitting enter is a natural thing to do when done
typing in a search.

BUG=266710

Review URL: https://chromiumcodereview.appspot.com/22298002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215831 0039d316-1c4b-4281-b951-d872f2087c98

BUG=268590

Review URL: https://chromiumcodereview.appspot.com/22296002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215830 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215829 0039d316-1c4b-4281-b951-d872f2087c98

Rename the class name as well.
"extensions" in the file name and the class name don't make much sense.

Along the way, add lots of comments and make some cosmetic changes,
but no semantic changes.

BUG=268248
TEST=none
R=hashimoto@chromium.org

Review URL: https://codereview.chromium.org/22259008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215828 0039d316-1c4b-4281-b951-d872f2087c98

BUG=170924
TEST=Manual test by creating progress notifications

Review URL: https://chromiumcodereview.appspot.com/22277003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215827 0039d316-1c4b-4281-b951-d872f2087c98

If the focus before opening an overlay was on a button, the overlay
will restore focus to that button when the overlay closes. If the
cause of the overlay closing was executing a default button via the
document handler, the newly focused button would then execute
immediately via the same event. This CL prevents that from
happening by calling preventDefualt() after executing the defualt
button.

BUG=268336

Review URL: https://chromiumcodereview.appspot.com/22268005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215826 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://chromiumcodereview.appspot.com/22290003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215825 0039d316-1c4b-4281-b951-d872f2087c98

Main difference from last release 2.1 are as below:
1. New DevTools Command for touch events.
2. Fixed bug that chromeDriver can't find Chrome on windows with non-en locale.
3. Fixed bug that right click doesn't trigger app context menu.
4. Fixed bug that sendKeys to a button failed with chrome 29+.
5. Support for Android WebView apps.
6. Change the key of cache because the original one conflicts with the one used in bot/inject.js included by inject_test.html

BUG=none

Review URL: https://chromiumcodereview.appspot.com/22283004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215824 0039d316-1c4b-4281-b951-d872f2087c98

The initialization of volume item has been done in VolumeList.renderRoot_(), but as I wrote in the TODO comment in volume_list.js, it should be done in the constructor of VolumeItem. This patch moves it as the comment.

This patch shouldn't change any functionality.

BUG=none
TEST=Volume list works correctly on mounting/unmounting volume. Folder shortcut can be created and removed.
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/22021003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215823 0039d316-1c4b-4281-b951-d872f2087c98

Forgot to do this in crrev.com/215775

BUG=268248
TEST=none
R=hashimoto@chromium.org

Review URL: https://codereview.chromium.org/22314007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215822 0039d316-1c4b-4281-b951-d872f2087c98

WindowTracker.

BUG=none
TEST=none
R=sadrul@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22254003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215821 0039d316-1c4b-4281-b951-d872f2087c98

Currently, copyFileEntry_ depends on FileCopyOperation.maybeCancel. This CL
removes it, instead copyFileEntry_ starts to return a callback to cancel the
on going operation.
Also, this CL adds some missing cancellation handling in copyFileEntry_().

BUG=246976
TEST=Ran browser_tests --gtest_filter="*FileSystemExtensionApiTest*:*FileManagerBrowserTest*" and tested manually.

Review URL: https://chromiumcodereview.appspot.com/22150006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215820 0039d316-1c4b-4281-b951-d872f2087c98

We always print to stderr if a system call is not handled by our sandbox.

It is more friendly to developers than crashing in debug mode, and in release
mode, this will allow to track issues when we can't have crash reports, which
is for instance the case with NaCl.

BUG=168812

Review URL: https://chromiumcodereview.appspot.com/22349002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215819 0039d316-1c4b-4281-b951-d872f2087c98

allocator.gyp removes libcmt/libcmtd from link via direct_dependent_settings
so having chrome_main_dll depend on it fixes the link.

(I think it probably doesn't work in non-multiple_dll Debug either, but
linking Debug-static_library with symbols doesn't work anyway so likely no
one noticed.)

R=jamesr@chromium.org
BUG=262396

Review URL: https://chromiumcodereview.appspot.com/22329002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215818 0039d316-1c4b-4281-b951-d872f2087c98

This property can be removed. This patch also fixes a small bug on changing the selection on the list.

BUG=none
TEST=manual
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/22167002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215817 0039d316-1c4b-4281-b951-d872f2087c98

These function are unused. OpenActionChoiceDialog() is also unused
but kept as we may need it in the near future.

BUG=268248
TEST=none
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/22301003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215816 0039d316-1c4b-4281-b951-d872f2087c98

f_bavail is more appropriate because it tells the amount
of disk space that is available to a non-privileged user.
(Writing to Downloads/ indeed stops working if f_bavail=0.)

BUG=268705
TEST=Checked the gear menu value matches with what chrome:drive-internals shows.
R=hidehiko@chromium.org

Review URL: https://codereview.chromium.org/22256004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215815 0039d316-1c4b-4281-b951-d872f2087c98

Adds a gyp variable to simplify WINSDK path strings,
and grabs the x64 files rather than x86.

BUG=268525,267893

Review URL: https://chromiumcodereview.appspot.com/22262003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215814 0039d316-1c4b-4281-b951-d872f2087c98

Feature is stable and this flag has been defaulted to enabled for several milestones.

Review URL: https://chromiumcodereview.appspot.com/22256002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215813 0039d316-1c4b-4281-b951-d872f2087c98

Add erg@ as an owner of x11 specific files in aura and views.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/22253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215812 0039d316-1c4b-4281-b951-d872f2087c98