- 17 Oct, 2019 40 commits
-
-
Andrey Kosyakov authored
This re-lands https://chromium-review.googlesource.com/c/chromium/src/+/1856929 while fixing unpausing of virtual time during same-document navigation. Change-Id: Ie51a92b2385ff055f0bf86b938349720489bde19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865619Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#706929}
-
John Budorick authored
This reverts commit f4bc92d6. Reason for revert: did not resolve flakes. Original change's description: > Revert "Resubmit: Lower priority of processes hosting exclusively ads." > > This reverts commit 4ba7eb3a. > > Reason for revert: spec revert for > crbug.com/1014952 > crbug.com/1015014 > crbug.com/1015013 > crbug.com/1014951 > > Original change's description: > > Resubmit: Lower priority of processes hosting exclusively ads. > > > > This change adds a variable to ChildProcessPriorityLauncher to > > indicate whether the associated process is only used to run tasks for > > ad frames (low priority frames). That variable is then used by the > > RenderProcessHost to background the frame in those cases. Notification > > happens in the RenderProcessHost via new UpdateFrameWithPriority. > > > > Note: Identification of ad frames is done as per the AdTagging project. > > Frames that have been marked as ads remain ads, and thus the > > RenderProcessHost will remain low priority if the frame is navigated > > to any other non-ad URL within the same process (same domain). > > > > Currently this is behind a feature which is off by default. > > We will be experimenting with this to determine its impact on > > both ads and in the browser as a whole. > > > > TBR=dcheng@chromium.org,gab@chromium.org,pbos@chromium.org,jkarlin@chromium.org > > > > Bug: 979234 > > Change-Id: I1acd1b8de7e66f8b2c47564df5e708f9b41f72a6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855680 > > Commit-Queue: Eric Robinson <ericrobinson@chromium.org> > > Reviewed-by: Alexander Timin <altimin@chromium.org> > > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#706049} > > TBR=alexmos@chromium.org,altimin@chromium.org,ericrobinson@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 979234,1014951,1014952,1015013,1015014 > Change-Id: Ib719e3f70371b7941d0b27f9bc171594149dd24e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864618 > Commit-Queue: John Budorick <jbudorick@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706625} TBR=alexmos@chromium.org,altimin@chromium.org,jbudorick@chromium.org,ericrobinson@chromium.org Bug: 979234, 1014951, 1014952, 1015013, 1015014 Change-Id: I6625c321b9f7a384ed3407b862d3c04b45dfb735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865562Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#706928}
-
Joe DeBlasio authored
This CL allows us to disable topsites-based lookalike matching in Safety Tips via a "disable_topsites" feature parameter. This feature param is inverted from the other feature params (it disables instead of enables) to ensure that the default no-param state is consistent before and after this change. Bug: 1015003 Change-Id: I2e7e94622dd20b8879e8157d588d39cf9383e790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865415Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#706927}
-
Henrique Nakashima authored
Move some methods from ColorUtils to it: - getTextBoxColorForToolbarBackground() - getToolbarSceneLayerBackground() - getTextBoxAlphaForToolbarBackground() - isUsingDefaultToolbarColor() - getThemedToolbarIconTintRes() - getThemedToolbarIconTint() This breaks the dependency from ColorUtils to Tab and NewTabPage. Bug: 995916 Change-Id: Ifa4dad973877f6bf764cc8fb3e5c5bdad048cdd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815281Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#706926}
-
Michael van Ouwerkerk authored
Bug: 1006264 Change-Id: I0b9d02f8bde14958b7ba3b54215ec330af09a9bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866630Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#706925}
-
John Budorick authored
Bug: 1014951 Change-Id: I0212752e770b5d995b81e1c98447f3ff4a9d116c Tbr: achuith@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866789Reviewed-by:
-
Vadym Doroshenko authored
This table contains field identifiers and autofill types that corresponds that were leaned from user actions. In the subsequent CLs this will be used for storing information whether particular form is username form for username first flow. Bug: 959776 Change-Id: If13482fa719638f6552f0e942a65c4731cccf3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865150 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#706923}
-
Jonathan Backer authored
With this CL, SkiaRenderer will receive a signal from GpuServiceImpl::LoseAllContexts and mark the shared context_state_ as lost. This will cause us to abandon all future draws and no-op the releases. Unfortunately, we cannot delete fulfilled promise images after GrContext::abandonContext is called. So an explicit leak in ImageContextImpl::OnContextLost was added. TBR=boliu@chromium.org Bug: 1011420 Change-Id: I5f5e178b6a51d770534c2260274f0b9c75c21831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864413 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#706922}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I5bca7f4f02d72bf7915dcc51ae6b377df869b9e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866405Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706921}
-
khmel@chromium.org authored
These apps exist on system image and available for all users. This also moves custom Play Store case handled separately before to system app. TEST=unit test BUG=1013730 Change-Id: Iaf63d52c38c376b6b07930bc8ec88e5b9de4bb58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865472Reviewed-by:
Josh Horwich <jhorwich@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#706920}
-
Min Qin authored
DownloadFilter is used by non-UI code and should be moved out. BackendProvider is not needed and can be removed. BUG=1013759 Change-Id: I88d346e9035171fff4d371c77df3812e93a857b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865537Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706919}
-
Owen Min authored
Similar to ExtensionManagement::IsInstallationExplicitlyAllowed, IsInstallationExplicitlyBlocked return true only if an extension's installation is blocked by its id but not wildcard. This function is going to be used by extension request feature. With it, user can send extension install request to admin. Only extensions that are not explicily blocked can be requested. Bug: 1006899 Change-Id: I6160fee3ab25f4da095b51bd727fe53fb3b8760c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863635 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706918}
-
Eric Stevenson authored
This is a reland of 987ed6b5. Fixed the package name in UkmUtilsForTest in the reland. Also moved the test file to be part of the same directory. Original change's description: > Android: Move UkmUtilsForTest.java. > > Moved to a subdirectory of the build target using it. The old location > was confusing because it's in the same directory as non test code. > > Bug: 1010218 > Change-Id: I1de7cd4ec72c7967506ebd8451fcf2b9378a9fe3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838522 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Auto-Submit: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702581} Bug: 1010218 Change-Id: I153ea9f421b1a714350e852060571a3c52814073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841651 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#706917}
-
Nico Weber authored
Instead, use -imsvc and the hermetic toolchain for the preprocessor, and don't look in system include dirs for resources. This means we can't include resources from the system include dirs, but we don't want to do that anyways. For now, keep using tool_wrapper to set the env so that we can find MS rc.exe on %PATH%. Bug: none Change-Id: I1065be2513659c6eb5b4de440299fa86cfb58736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863149Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#706916}
-
Julian Pastarmov authored
I would guess this policy was marked Chrome OS only because at the time Chrome OS was the only platfrom that had cloud management. It technically works on all platfroms as it maps to a pref existing on all platforms. The comment that when invalidation is available and operation the policy is reset is also true and visible on chrome://policy. BUG=1011855 TEST=Existing tests already cover all code paths. Change-Id: I3ebf105345ca71e0508a7170d6f829fae819354c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864797Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#706915}
-
Julian Pastarmov authored
BUG=NONE Change-Id: Ib137a3cc040e12fec5e6d629dbd79d11d64e63de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865223Reviewed-by:
-
Rayan Kanso authored
This reverts commit 513ca106. Reason for revert: Tests are failing on Lollipop Bug: 1015406 Original change's description: > Merge WebAPK/TWA status bar behaviour 1/3 > > This CL matches the status bar behaviour of WebAPKs to that of TWAs by: > - Changing the status bar colour used by WebAPKs when the Web Manifest > does not provide a "theme_color" to white. This requires increasing > MINIMUM_REQUIRED_CHROMIUM_VERSION_NEW_SPLASH > - Making the status bar use dark icons if the Web Manifest provides > a light colour. > > BUG=997793 > > Change-Id: Ia628810345af90cd45bb9762e0ce24f500ed4bba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857205 > Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706765} TBR=yfriedman@chromium.org,pkotwicz@chromium.org Change-Id: I84ef085dd2421f28dba39f77a982e2812a6462cd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 997793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866515Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#706913}
-
Koji Ishii authored
This patch adds NGFragmentItem painting code path for floating objects. There should be more then one tests that turn to pass. I'll update FlagExpectations once we've got the try-bot. Bug: 982194 Change-Id: I83e74338251bbe754e82ce0dcf69164293d494f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865924 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706912}
-
Alex Turner authored
ComputeTopFrameOrigin currently uses current_origin(), which has a prominent warning about possible incorrect behavior. The function's use is likely causing incorrect Network Isolation Keys to be used. We thus use the replacement suggested by the warning. Bug: 1014077 Change-Id: Iaecbb0ab028c626dce037462bb22053b5114bc52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860106Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#706911}
-
Friedrich Horschig authored
This CL adds a button that allows users to navigate to the password preferences after pulling up the touch to fill sheet fully. Screenshots in the linked bug. Bug: 1013257 Change-Id: Ib6616f93498b4061a0e3b2b97b9f45cfc0364138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859982 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#706910}
-
Brian White authored
Adds expires_after attribute for 19 histograms that do not already have one. The date will get pushed out automatically if significant use is detected. Change-Id: I4b9ad6c4ea7275de465122f35b420a5dce3aa13a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865372Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#706909}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a6d7b028242c..5f01bf6c8b78 git log a6d7b028242c..5f01bf6c8b78 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 sprang@webrtc.org Refactor handling of TransportSequenceNumber in PacketRouter Created with: gclient setdep -r src/third_party/webrtc@5f01bf6c8b78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I371c3682d4a0aa9de956518414f46dce2d8cb490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866613Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706908}
-
Roger Tawa authored
Bug: 1015065 Change-Id: I570988d8350f48aaaeca132ce3c0ec2ff80ff476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864879 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#706907}
-
Maksim Moskvitin authored
The newly introduced mechanism around PendingLocalNigoriCommit allows implementing NigoriSyncBridgeImpl::MergeSyncData(), responsible for keystore Nigori initialization (in case it receives a default NigoriSpecifics), in a way that: a) Success is only reported when the sync server acks the commit. b) Conflict-resolution becomes simple. c) Logic is factored out from NigoriSyncBridgeImpl. Bug: 922900 Change-Id: Ie6e2f2ecdb37bb6de21f57de472bfe6e6c28237a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865310 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#706906}
-
Shakti Sahu authored
Change-Id: I7d24d5b4cd1f45c1ae1c268b14c6f1c779caf2fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866012 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ae1b7786b89a..48aa52f7305a git log ae1b7786b89a..48aa52f7305a --date=short --no-merges --format='%ad %ae %s' 2019-10-17 jmadill@chromium.org Fix broken GN "all_dependent_configs". 2019-10-17 shaobo.yan@intel.com Add "DIFF_LINES_OF_CONTEXT: 1" to fix format issue 2019-10-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 9097eeb5359b..6652f0b64287 (11 commits) 2019-10-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 1ff0c181bb37..a959deb00750 (12 commits) 2019-10-17 jmadill@chromium.org Vulkan: Re-enable release ASSERTs. Created with: gclient setdep -r src/third_party/angle@48aa52f7305a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: chromium:None,chromium:None Change-Id: I5257425b362303da0af54151b87126b6276f1b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864528Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/572eb8c70fdc..e62dfe9064db git log 572eb8c70fdc..e62dfe9064db --date=short --no-merges --format='%ad %ae %s' 2019-10-17 phoglund@google.com Add support for WebRTC internal commit ranges. Created with: gclient setdep -r src/third_party/catapult@e62dfe9064db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:1015329 Change-Id: I22a3722e302408b043ce7b58f07a28a21d71a846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864526Reviewed-by:
-
Thomas Tangl authored
Additionally, the close icon is updated. Bug: 995720 Change-Id: I3d8c0969def4483867fe3e6d985fe5026a955b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866511 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#706902}
-
Thomas Tangl authored
Bug: 995720 Change-Id: I8a430194bd97efc6de3bdd0586aa591e46310611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863931 Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#706901}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/df1de01ceff3..7c836ccb431d git log df1de01ceff3..7c836ccb431d --date=short --no-merges --format='%ad %ae %s' 2019-10-17 seanabraham@chromium.org lkgm_manager: fix bug that's breaking legacy CQ Created with: gclient setdep -r src/third_party/chromite@7c836ccb431d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1fe59a85d30964ddcfd6cf14a4328cdd0a38c2d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866729Reviewed-by:
-
Mohamed Amir Yosef authored
This CL removes obsolete code. Change-Id: I451253435eab20f3a04b5f10ba79ef9b22c149d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863930 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#706899}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3787dee78156..0544d1e26010 git log 3787dee78156..0544d1e26010 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 treehugger-gerrit@google.com Merge "tools(tmux): add script argument" 2019-10-17 eseckler@google.com Merge "processor: Fix handling of legacy chrome async event IDs" 2019-10-17 lalitm@google.com Merge "trace_processor: add all bits iterator" 2019-10-17 hjd@google.com Merge "Refactor LoadingManager to remove dep" Created with: gclient setdep -r src/third_party/perfetto@0544d1e26010 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I77ff285e1ccff21456dcce9689c544d87ca43159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864527Reviewed-by:
-
Clemens Backes authored
This is a roll-back to V8 7.9.317. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. R=machenbach@chromium.org CC=hablich@chromium.org Change-Id: I18d9b5d0adf94660ea8590c2ac8c598b1814c938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866571Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706897}
-
Theresa Wellington authored
- Move OverviewModeObserver that dismisses menu when overview mode changes from appmenu/ to RootUiCoordinator. - Remove unneeded ToolbarManager import (only used in comments). - Create TranslateUtil with static utility for determining if translate is available for the current Tab. - Use ObservableSupplier to pass BookmarkBridge to AppMenuPropertiesDelegateImpl instead of using interface method. - Rename AppMenuTest to TabbedAppMenuTest since this is really an integration test shown for the app menu in ChromeTabbedActivity. - Update AppMenuTest to remove dependency on ChromeActivity and avoid exposing future internal classes. - Create javatests/res/values/ids.xml with test ids for use in modal dialog tests. BUG=966644 Change-Id: I0ae1b13e59f936100e942dd46281aaae2ddf2fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859881 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
Maksim Moskvitin authored
For decryption and encryption of |keystore_decryptor_token| we need a special version of cryptographer, which contains only keystore keys and uses last keystore key as the default encryption key. To avoid heavy creation of keystore cryptographer and simplify some future error handling (crypto errors, which don't allow to create keystore cryptographer), we now maintain its cached version inside NigoriState. It's implemented as KeystoreKeysCryptographer, which wraps CryptographerImpl and provides interface specific for encryption and decryption of |keystore_decryptor_token|. Keystore keys now stored inside KeystoreKeysCryptographer. Bug: 922900 Change-Id: I905bd351f99704c07419a815c59ae7efa7b119f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865309 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Kuo Jen Wei authored
Bug: 1014829 Test: Verify capture event metrics is collected correctly under both intent/non-intent mode. Change-Id: I84833c4b6b58ddfe848434dcfdee0d26051b8e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863060 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#706894}
-
kylechar authored
DevToolsFrameMetadata was just a copy of RenderFrameMetadata. Avoid creating a new class and just cache RenderFrameMetadata instead. Bug: 985009 Change-Id: Ie2451eb2bfc76e9a61253f93611dc777eeafd81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850368 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#706893}
-
Fredrik Söderquist authored
In the DidMoveToNewDocument() override in HTMLImageElement and SVGImageElement, initiate the load as the last thing rather than the first, since ImageLoader::ElementDidMoveToNewDocument() will clear out the image content, thus requiring a new load to take place later on (when the element gets the "inserted into document" callback). Bug: 1000273 Change-Id: I977d63bb8e14d7f8fbd1e7004b788d09b7b897fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789394Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#706892}
-
John Budorick authored
This reverts commit 2aa5da39. Reason for revert: reenabling given crrev.com/1864618 Original change's description: > Disable WelcomeScreenBrowserTest.WelcomeScreenNext. > > Bug: 1014952 > Change-Id: I1df1941c2a0a92d243cb4e4624ae920b150c7694 > Tbr: achuith@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865351 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706500} TBR=achuith@chromium.org,jbudorick@chromium.org Change-Id: I86cba6fe329f52b5bdcd7b07d04d1dfb40fa65cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1014952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866407Reviewed-by:
-
John Budorick authored
This reverts commit 005483fe. Reason for revert: breaks compilation: https://ci.chromium.org/p/chromium/builders/ci/linux-archive-rel/11718 Original change's description: > [Trusted Types] Remove TrustedURL. > > The current Trusted Types spec no longer supports TrustedURL. This CL adapts > to the spec. > > Bug: 1002555 > Change-Id: I35c6d8a257046558f155b9f38289457b14dcb1d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834142 > Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706886} TBR=vogelheim@chromium.org,mkwst@chromium.org Change-Id: I97a2e1e31947cf854ed52a5866166dbc894c61b8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1002555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866406Reviewed-by:
-
