GitLab

Revert of Chromecast: Play audio streams not supported by CMA via default renderer (patchset #5 id:70001 of https://codereview.chromium.org/973633002/)

Reason for revert:
Audio tests started failing consistently in the next build after this was checked in. See:
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/3762

Not sure if this CL is the culprit, but seems the most likely one, so attempting a revert to see if it fixes the problem.

Error:
[ RUN      ] AudioRecorderTest.BasicRecordAndStop
../../components/audio_modem/audio_recorder_unittest.cc:203: Failure
Value of: IsRecording()
Actual: false
Expected: true
../../components/audio_modem/audio_recorder_unittest.cc:208: Failure
Value of: IsRecording()
Actual: false
Expected: true
../../components/audio_modem/audio_recorder_unittest.cc:213: Failure
Value of: IsRecording()
Actual: false
Expected: true
[  FAILED  ] AudioRecorderTest.BasicRecordAndStop (1292 ms)

Original issue's description:
> Chromecast: Play audio streams not supported by CMA via default renderer
>
> For Chromecast we want to choose which media renderer to use based on
> the types of input content streams. We will use CMA media renderer for
> media types that are supported by our hardware (H264, AAC, etc) and
> will use the default media renderer for audio streams other than AAC
> or Vorbis. This will allow us support software decoding of FLAC and
> Opus via the default Chrome audio path.
>
> BUG=457959
>
> Committed: https://crrev.com/2e583073b996e66d62f709dd2ffde9e1ef58b276
> Cr-Commit-Position: refs/heads/master@{#318941}

TBR=gunsch@chromium.org,lcwu@chromium.org,dalecurtis@chromium.org,servolk@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=457959

Review URL: https://codereview.chromium.org/981473003

Cr-Commit-Position: refs/heads/master@{#319033}

Reason for revert:
Causes test to consistently time out.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/35869

[ RUN      ] ChromeWhispernetClientTest.EncodeAndDecode
[724:3320:0303/204246:WARNING:data_reduction_proxy_config.cc(240)] SPDY proxy OFF at startup
[3956:4296:0303/204248:ERROR:singleton_hwnd.cc(43)] Cannot create windows on non-UI thread!
[724:4156:0303/204249:INFO:CONSOLE(5)] "Not allowed to load local resource: chrome://resources/css/text_defaults.css", source: chrome-extension://bpfmnplchembfbdgieamdodgaencleal/background.html (5)
[724:4156:0303/204249:INFO:CONSOLE(83)] "init: Starting Nacl bridge.", source: chrome-extension://bpfmnplchembfbdgieamdodgaencleal/js/init.js (83)
[2012:2524:0303/204249:ERROR:singleton_hwnd.cc(43)] Cannot create windows on non-UI thread!
[2012:2832:0303/204249:ERROR:pnacl_translation_resource_host.cc(135)] Got invalid platformfilefortransit
[724:4156:0303/204253:INFO:CONSOLE(65)] "init: Nacl ready!", source: chrome-extension://bpfmnplchembfbdgieamdodgaencleal/js/init.js (65)
[724:4156:0303/204254:INFO:CONSOLE(26)] "Configuring encoder and decoder for client E77A9C58-00C9-4A99-AC57-1353FB0B918D", source: chrome-extension://bpfmnplchembfbdgieamdodgaencleal/js/init.js (26)
[223/223] ChromeWhispernetClientTest.EncodeAndDecode (TIMED OUT)

Original issue's description:
> 1. Token CRCs are not handled correctly. This adds the corrected Whispernet binary (from cl/87383487), and a test to confirm the correct behavior.
>
> 2. If we get tokens that require more than one padding character, the padding will not be completely removed when appropriate. This is a simple change in the js.
>
> BUG=463218
>
> Committed: https://crrev.com/6e37f17aa09f5244315d6eb84fa305154bc65062
> Cr-Commit-Position: refs/heads/master@{#319015}

TBR=rkc@chromium.org,ckehoe@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=463218

Review URL: https://codereview.chromium.org/979723002

Cr-Commit-Position: refs/heads/master@{#319032}

I believe the param (active_version_id) was a remnant of the ancient spec/impl.

BUG=n/a

Review URL: https://codereview.chromium.org/966393002

Cr-Commit-Position: refs/heads/master@{#319031}

R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/971323002

Cr-Commit-Position: refs/heads/master@{#319030}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5c82b52..467060f

TBR=enne@chromium.org,samli@chromium.org

Review URL: https://codereview.chromium.org/964523004

Cr-Commit-Position: refs/heads/master@{#319029}

Cr-Commit-Position: refs/heads/master@{#319028}

Revert of Revert of Update V8 to version 4.3.16. (patchset #1 id:1 of https://codereview.chromium.org/978433002/)

Reason for revert:
The roll wasn't the cause for issue 463436. Therefore relanding.

Original issue's description:
> Revert of Update V8 to version 4.3.16. (patchset #1 id:1 of https://codereview.chromium.org/974813002/)
>
> Reason for revert:
> Speculative revert for issue 463436.
>
> Original issue's description:
> > Update V8 to version 4.3.16.
> >
> > Summary of changes available at:
> > https://chromium.googlesource.com/v8/v8/+log/155278d6..ea02c333
> >
> > Please follow these instructions for assigning/CC'ing issues:
> > https://code.google.com/p/v8-wiki/wiki/TriagingIssues
> >
> > TBR=machenbach@chromium.org
> > NOTRY=true
> >
> > Committed: https://crrev.com/5d61006f40e3f14bbf8f2c60f698b051f8f84fd9
> > Cr-Commit-Position: refs/heads/master@{#318874}
>
> TBR=v8-autoroll@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/cb33633cc8920c3dc61b217285e4887f03d75613
> Cr-Commit-Position: refs/heads/master@{#318879}

TBR=v8-autoroll@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/976713005

Cr-Commit-Position: refs/heads/master@{#319027}

Review URL: https://codereview.chromium.org/977553003

Cr-Commit-Position: refs/heads/master@{#319026}

For onscreen, viewport should match window size initially. For offscreen,
viewport should match the default FBO size initially as-is.

Review URL: https://codereview.chromium.org/965223002

Cr-Commit-Position: refs/heads/master@{#319025}

After the inlined trace transition, the callee part of registerWeakMembers()
call can be of type CXXDependentScopeMemberExpr instead of UnresolvedMemberExpr.
The plugin should be aware of this case.

BUG=462511
R=kouhei@chromium.org
CC=zerny@chromium.org, oilpan-reviews@chromium.org

Review URL: https://codereview.chromium.org/975683003

Cr-Commit-Position: refs/heads/master@{#319024}

Revert of Revert of Update V8 to version 4.3.15. (patchset #1 id:1 of https://codereview.chromium.org/975713002/)

Reason for revert:
The roll wasn't the cause for issue 463436. Therefore relanding.

Original issue's description:
> Revert of Update V8 to version 4.3.15. (patchset #1 id:1 of https://codereview.chromium.org/969053002/)
>
> Reason for revert:
> Speculative revert for issue 463436.
>
> Original issue's description:
> > Update V8 to version 4.3.15.
> >
> > Summary of changes available at:
> > https://chromium.googlesource.com/v8/v8/+log/c791d841..155278d6
> >
> > Please follow these instructions for assigning/CC'ing issues:
> > https://code.google.com/p/v8-wiki/wiki/TriagingIssues
> >
> > TBR=machenbach@chromium.org
> >
> > Committed: https://crrev.com/32e6c72188d6b0b948d668afdc1cb209d44c2e70
> > Cr-Commit-Position: refs/heads/master@{#318755}
>
> TBR=v8-autoroll@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/0607e55050323137b334f8569a7e522d6f1844da
> Cr-Commit-Position: refs/heads/master@{#318880}

TBR=v8-autoroll@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/977583004

Cr-Commit-Position: refs/heads/master@{#319023}

BUG=461629
TEST=None

Review URL: https://codereview.chromium.org/975883003

Cr-Commit-Position: refs/heads/master@{#319022}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7d85a55..5c82b52

TBR=enne@chromium.org,samli@chromium.org

Review URL: https://codereview.chromium.org/978483003

Cr-Commit-Position: refs/heads/master@{#319021}

This skips a method call on devices where it would cause a crash.

BUG=463719

Review URL: https://codereview.chromium.org/969413003

Cr-Commit-Position: refs/heads/master@{#319020}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b2c2289..7d85a55

TBR=enne@chromium.org,samli@chromium.org

Review URL: https://codereview.chromium.org/981443002

Cr-Commit-Position: refs/heads/master@{#319019}

Setting cursor type to ui::kCursorNone is treated the same as setting
visibility to false.

However note that it is necessary to track the last requested cursor
visibility separately.

BUG=chrome-os-partner:30313
TEST=verify that large cursor disappears in Youtube full-screen mode

Review URL: https://codereview.chromium.org/980453002

Cr-Commit-Position: refs/heads/master@{#319018}

speculatively reverting this to solve browser CPM

BUG=463776

This reverts commit 5f1263bb.

Merge branch 'master' of https://chromium.googlesource.com/a/chromium/src

Revert "Handle unsucessful JsonPrefStore initialization in SupervisedUserSettingsService."

this may be casuing an increase in rendererexit code.

BUG=463646

This reverts commit 0197d5df.

Merge branch 'master' of https://chromium.googlesource.com/a/chromium/src

This is causing a huge amounts of renderer crashes because of RESULT_CODE_KILLED_BAD_MESSAGE.  Reverting this from master.

Revert "<webview>: Removed ResolveURL"

This reverts commit c2fc6144.

Cr-Commit-Position: refs/heads/master@{#319017}

BUG=463675
TEST=bots, WebGL2 demos
R=kbr@chromium.org,bajones@chromium.org

Review URL: https://codereview.chromium.org/978593003

Cr-Commit-Position: refs/heads/master@{#319016}

1. Token CRCs are not handled correctly. This adds the corrected Whispernet binary (from cl/87383487), and a test to confirm the correct behavior.

2. If we get tokens that require more than one padding character, the padding will not be completely removed when appropriate. This is a simple change in the js.

BUG=463218

Review URL: https://codereview.chromium.org/969843002

Cr-Commit-Position: refs/heads/master@{#319015}

BUG=462507

Review URL: https://codereview.chromium.org/972893003

Cr-Commit-Position: refs/heads/master@{#319014}

This ensures that re-creating a window with the same id shows that
window if it already exists. This was broken in:
https://codereview.chromium.org/417433002

BUG=461081

Review URL: https://codereview.chromium.org/958923004

Cr-Commit-Position: refs/heads/master@{#319013}

BUG=
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/975973002

Cr-Commit-Position: refs/heads/master@{#319012}

The "on"/"off" text and the switch were both too close to the edge of
the screen on pre-L devices. The bug arose because the LinearLayout had
conflicting padding attributes: it defined "padding" inline, and used a
style which defined "paddingStart" and "paddingEnd". The latter values
were overriding the inline "padding" value.

Review URL: https://codereview.chromium.org/970603003

Cr-Commit-Position: refs/heads/master@{#319011}

This is to fix regression of https://codereview.chromium.org/913033002.

BUG=455996

Review URL: https://codereview.chromium.org/972293003

Cr-Commit-Position: refs/heads/master@{#319010}

Cleaning the webapp as the Hangout Remote Desktop service has discontinued.

BUG=463322

Review URL: https://codereview.chromium.org/973333002

Cr-Commit-Position: refs/heads/master@{#319009}

Flaky on L.

TBR=klundberg@chromium.org,jaekyun@chromium.org
BUG=463740

Review URL: https://codereview.chromium.org/973393002

Cr-Commit-Position: refs/heads/master@{#319008}

Fix the TODO add by jhawkins.
Struct data members do not have the trailing underscores that data members in
class have.

BUG=

Review URL: https://codereview.chromium.org/968813002

Cr-Commit-Position: refs/heads/master@{#319007}

BUG=none

Review URL: https://codereview.chromium.org/975973003

Cr-Commit-Position: refs/heads/master@{#319006}

- Add a install_immediately flag to ExternalProviderImpl;
- Set install_immediately flag to true for kiosk app provider
  so that updated app install is not delayed;
- Set auto acknowledge since kiosk should not show external
  install alert;

BUG=461419

Review URL: https://codereview.chromium.org/974713002

Cr-Commit-Position: refs/heads/master@{#319005}

BUG=447778

Review URL: https://codereview.chromium.org/973983003

Cr-Commit-Position: refs/heads/master@{#319004}

This reverts commit 59e9a996.

it broke linux build
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/10478

BUG=none

Review URL: https://codereview.chromium.org/979663002

Cr-Commit-Position: refs/heads/master@{#319003}

This change contains of two parts. This is Part 1 (Chromium),
Part 2 (Clank) is https://chrome-internal-review.googlesource.com/#/c/204475/

This change reverts https://codereview.chromium.org/972973002/
and restores original https://codereview.chromium.org/896673003/
with an addition of a fix: it removes DCHECK
that verifies that an entry is always found and removed in a map.

An entry will not be in the map unless corresponding player
has been audible at least once.

BUG=414810,463445

Review URL: https://codereview.chromium.org/975943003

Cr-Commit-Position: refs/heads/master@{#319002}

PeerHandle() is not necessarily unique, so have a HostSharedBitmapManagerClient per renderer channel that's responsible for deleting bitmaps from renderers that die.

Review URL: https://codereview.chromium.org/955523005

Cr-Commit-Position: refs/heads/master@{#319001}

Power monitoring was added to the scheduler based on the incorrect
assumption that it would allow the system to use a lower timer
resolution on windows. This is not true because the timer resolution is
always high when on AC power while DelayBasedTimeSource is used for
vsync timing. On battery power the high resolution timer is disabled by
the power monitor irrespective of the presence of high resolution timer
tasks.

BUG=448939

Review URL: https://codereview.chromium.org/974083002

Cr-Commit-Position: refs/heads/master@{#319000}

BUG=

Review URL: https://codereview.chromium.org/975963002

Cr-Commit-Position: refs/heads/master@{#318999}

BUG=450428

Review URL: https://codereview.chromium.org/893313004

Cr-Commit-Position: refs/heads/master@{#318998}

This CL:
- Makes PointerDeviceObserver use ui::InputDeviceEventObserver on X11 (it is
  already used on Ozone)
- Makes X11HotplugEventObserver notify ui::DeviceDataManager when a mouse /
  touchpad is plugged in / unplugged
- Removes DeviceHierarchyObserver

BUG=440503
TEST=Manual

Review URL: https://codereview.chromium.org/946173002

Cr-Commit-Position: refs/heads/master@{#318997}

CL 906403006 introduced a linking error by referencing a symbol that is
not included in iOS builds of the cast sender library. This patch stubs
out the relevant code.

BUG=463713

Review URL: https://codereview.chromium.org/974133002

Cr-Commit-Position: refs/heads/master@{#318996}

In single process mode with impl-side-painting, browser and renderer
would both try to set number of raster worker threads, which causes
DCHECK. This CL makes sure there won't be duplicate call to set number
of worker threads in single process mode.

R=enne
BUG=314185

Review URL: https://codereview.chromium.org/971943002

Cr-Commit-Position: refs/heads/master@{#318995}

ChannelDelegate::GetWeakPtr() was called from the UI thread but
it was racy as the weak ptr is also used in the IO thread.
This CL turns ChannelDelegate a ThreadSafeRefCounted so that
we can pass ChannelDelegate itself to the task runner, instead
of using its weak ptr on the UI thread.

This change also turns some TaskRunner declarations to
SequencedTaskRunner to access its DeleteSoon() API from
ChannelDelegate.

TBR=creis@chromium.org
R=viettrungluu@chrormium.org, agl@chromium.org
BUG=460243

Review URL: https://codereview.chromium.org/955813002

Cr-Commit-Position: refs/heads/master@{#318994}