- 08 Nov, 2019 40 commits
-
-
evliu authored
Bug: 997813 Change-Id: I1cc6104341d131e3688c6167c430a14cb57f3337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903761 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#713988}
-
Dirk Pranke authored
This reverts commit 3b26aa05. Reason for revert: Reverting due to failures on Mac as per the comment. Original change's description: > Attempt to fix the parser caching in the IDL compiler. > > PLY has a feature where it'll load a generated lexer > table by importing it as a python module. It turns out > that we were being inconsistent in how we were generating > these modules and that could lead to incomplete builds depending > on when the various IDL compilation targets ran. > > This CL attempts to be more consistent about the generation > of the cached files to eliminate that problem, by requiring > the scripts to consistently pass in the location of the cached > files. We can't really fix this without doing more serious > surgery on PLY (or working around it) to be more deterministic > in how the cached file is imported. > > R=dcheng@chromium.org, haraken@chromium.org > BUG=1022647 > > Change-Id: I141059341634633f0df33848638eecc432aa764c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903938 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713872} TBR=dcheng@chromium.org,dpranke@chromium.org,haraken@chromium.org Change-Id: Ia84a8baa53bef4556f2239e564ac19a92fffda9a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1022647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906117Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#713987}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/039522eb577e..0e9afd2a56f2 git log 039522eb577e..0e9afd2a56f2 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 brucedawson@chromium.org Change "CPU time" to "elapsed time" Created with: gclient setdep -r src/third_party/depot_tools@0e9afd2a56f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I62e53a374ea5c34d719bc578b85b9ad7a55e7372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906721Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713986}
-
David Schinazi authored
Fix issue where receiving HTTP response status 408 on an HTTP/2 connection would cause us to retry infinitely. We now only retry for HTTP/1.1 (and 0.9 and 1.0) but not HTTP/2 and later. Bug: 695225 Change-Id: I6a3c2c9447e4dde536fa7925306b41de9d4afb28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907188 Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#713985}
-
Aran Gilman authored
Bug: 1016614 Change-Id: I9c16e9d8a31c1decb9269e6d5daf064132575d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906633Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#713984}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/636832d9a666..814821a14375 git log 636832d9a666..814821a14375 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 tsepez@chromium.org Remove unused CBC_QRCoder::GetNumECBytes(). 2019-11-08 tsepez@chromium.org Remove CBC_Writer::Set{Background,Barcode}Color(). 2019-11-08 tsepez@chromium.org Cover more branches in fx_crypt_sha.cpp. 2019-11-08 tsepez@chromium.org Simplify control flow in FPDF_RenderPage(). 2019-11-08 tsepez@chromium.org Remove duplicate FPDF_OBJECT_ definitions from fpdf_annot.h 2019-11-07 tsepez@chromium.org No need to check for null pages in RenderPageWithContext() Created with: gclient setdep -r src/third_party/pdfium@814821a14375 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Ic3a103b1f3483effe684a5eaaf730fdc4d69f372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907196Reviewed-by:
-
John Lee authored
Pressing a shortcut (ctrl+f1 on ChromeOS) will now allow the user to focus into an opened tab strip. Once the tab strip becomes focused, it will focus the first tab within it. If the tab strip is not opened, pressing the toggle to open it will automatically move the focus into the tab strip, but only if the user is already focusing the button, suggesting they were able to arrive at the button using other keyboard shortcuts. This CL also adds a title to the HTML doc to announce it when the user focuses into the tab strip, and adds the tab's title as context to the close button. The CL does not update focused styles. Demo screencast in bug. Bug: 1017472 Change-Id: I6af0114b24f1136c8a77faacadc89f4d3a6309b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896045 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#713982}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/f7e05c734266..f0bfbce62d42 git log f7e05c734266..f0bfbce62d42 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 rharrison@google.com Another major API rework (#871) Created with: gclient setdep -r src/third_party/shaderc/src@f0bfbce62d42 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I800c7b7729f175550466898fec078543767a638d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906712Reviewed-by:
-
Robert Sesek authored
Bug: 1017830 Change-Id: I1c0c69b130bc048ec75a70a65e22e7d73fad0158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906632 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#713980}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2a7f3180..fdd7f421 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I41dc224608e14b61ed087198c6ce53e0c4de6d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906510Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713979}
-
Ce Chen authored
The creation will happen on |task_runner_| when |model_update_listener| fires the new model available notification, instead of synchronously on receiving the user autocomplete input. This is to fix the omnibox.QueryTime2.1 regression (other QueryTime2.x is not affected by the existing design), e.g. http://screenshot/1U2Oq5vfnRm Tested on Pixel 2 XL for pre-existing model loading and new model download. Bug: 925072 Change-Id: Ieb26aa78c8bbd848ed1f0c9b722bab266b21aa59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902513 Commit-Queue: Ce Chen <cch@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#713978}
-
Quinten Yearsley authored
This would also rename BuildBot class to TestResultsFetcher, and rename the attribute buildbot to results_fetcher. These classes have nothing to do with Buildbot, which is no longer used. They do seem to be basically about fetching results of tests that were run on bots. Bug: 1002702 Change-Id: Ie877f4c16e8edde5023366a299dabb657a0ecd52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894618Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#713977}
-
Nick Diego Yamane authored
As of crrev.com/c/1789603, GdkEventKey::state is not being set correctly when translating ui::KeyEvent into GdkEvents. Such field should be equivalent to XKeyEvent::state, which contains, besides modifiers state bits, keyboard group information. This causes regressions such as crbug.com/1021732, oddly specifically when GTK_IM_MODULE env variable is set to 'xim'. This CL fixes it by including 'group' value into GdkEventKey::state composed value, as was already done in GtkEventLoopX11. Bug: 1021732 Change-Id: I2d166ab9f88fc46fd5150f0f2d224aa85a22f9a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902438Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#713976}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/60c88fd3ec68..e9709db85ca9 git log 60c88fd3ec68..e9709db85ca9 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 eseckler@google.com processor: Build all of TP on chrome desktop platforms 2019-11-08 fmayer@google.com Merge "Do not block on control socket." 2019-11-08 treehugger-gerrit@google.com Merge "compact sched_waking: cfg/trace protos" Created with: gclient setdep -r src/third_party/perfetto@e9709db85ca9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:1022386 Change-Id: Ibaa5a79c764fbdeb5474dc741a72c1509a135752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906943Reviewed-by:
-
Doug Arnett authored
Bug: 1022820 Change-Id: Icada0c443861e2c5a9b66a879abb3c976db2c2e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906311Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#713974}
-
Reilly Grant authored
These metrics for usage of the device motion and orientation sensor APIs are unused because these features are no longer available in insecure contexts. Bug: 1016906 Change-Id: I86f4d7f5979b307753b0ee6c5a96fb4b1d1af6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904749 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#713973}
-
Xiaohan Wang authored
Currently if there are encrypted streams in the demuxer and there's no CDM set, Renderer::Initialize() will wait for the CDM to be set to finish initialization. This logic has been implemented in RendererImpl and DecryptingRenderer. This CL moves this logic to PipelineImpl for two purposes: 1. We can create different Renderers based on the CDM type. 2. We can remove the waiting-for-CDM from Renderer implementations. Bug: 1018372 Test: Change-Id: I4d1b22bd0a3661a96934de1c78ccd5d9e179e2fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902647Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#713972}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I4c0a72b515a8ea51b7312347783b40cee2b9f529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907186Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f0ade8a687ee..a53e47fe9483 git log f0ade8a687ee..a53e47fe9483 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 mtklein@google.com native f32 min/max 2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-08 mtklein@google.com convert SkVMBlitter over to floats 2019-11-08 csmartdalton@google.com Always attach stencil buffers with exact sample count matches 2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@a53e47fe9483 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I6765528c0a685b89721ffc14aa4ae41abe754bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907187Reviewed-by:
-
Victor Vasiliev authored
This way, we can reuse the logic in non-HTTP QUIC servers. Change-Id: I9651e80c965ea0ea3890f776f380d402a563f8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904690 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
-
Alex Cooper authored
This updates the WebXr Samples from 76 (whose Origin Token just expired) to call out that these samples are deprecated and to redirect visitors to the official immersive web samples instead. Also modifies the gitignore file to allow staging of samples without "git status" or "git cl upload" thinking the repo is dirty. Fixed: 1022918 Change-Id: I802000baa7fee52b4b24c39feb5e95fda0521439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906641 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#713968}
-
Mikel Astiz authored
Deleting permanent folders is not handled well and violates an existing DCHECK in BookmarkModel::RemoveNodeFromIndexRecursive(), but no layer enforces this precondition for an API that is exposed to extensions (and possibly other callers). The patch now adds a DCHECK in BookmarkModel::Remove() to explicitly make it a precondition violation, and updates the extensions codepath to prevent such case. Specifically, one side effect is that prior to this patch observers were notified for OnWillRemoveBookmarks(), which could explain the sync-related CHECK failures in the linked bug. Bug: 1021829 Change-Id: Ia4f013258420c024c06e0d6ce54f5b1868cff62e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899374 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#713967}
-
Maksym Onufriienko authored
Fixed recipe failure for ios13-sdk-simulator "recipe infra failure: Uncaught Exception: AssertionError('Triggered same task twice: ios_chrome_integration_egtests (iPad Pro (12.9-inch) iOS 12.4) shard 0 (with patch)',)" https://ci.chromium.org/p/chromium/builders/ci/ios13-sdk-simulator?limit=200 Change-Id: I0e0a80b45aa6f186c90e246914655d1f7bc3651e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906928Reviewed-by:Rohit Rao <rohitrao@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#713966}
-
David Grogan authored
RTL items weren't positioning their children correctly. Bug: 845235 Change-Id: Ic0ff8e8417a638a4da88eea574877c7b469106e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906942Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713965}
-
Bailey Berro authored
This change uses selectedDisplay's width and height properties, which correctly reflects the orientation of the display, to set the logical resolution text so that it correctly reflects the orientation of the display. Fixed: 994970 Test: Ran unittests, verified manually on device Change-Id: I3aa0174edff55fb88a0599e1a2809bcb7001abfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894173Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#713964}
-
Roger McFarlane authored
Bug: 978849, 1006806 Change-Id: Id797a8c9955ece26668490664f07c83756d0f6a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906335Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#713963}
-
Dominique Fauteux-Chapleau authored
Migrates RetrieveDMToken call to use the new BrowserDMToken class. Bug: 1020296 Change-Id: I384a64e4587915930817ad7a803484a0f9cc9a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906626Reviewed-by:
Tien Mai <tienmai@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#713962}
-
Wei-Yin Chen (陳威尹) authored
Add one more RenderTest for native tab. Choose NTP in incognito mode for its consistency. Also fix the issue about thumbnails being not freed in http://crrev.com/c/1903402. Bug: 983170 Change-Id: I68d3f08184cb4b9504935a53f893bb7ea9473ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903620 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#713961}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7eee1a626bd1..80a89976c142 git log 7eee1a626bd1..80a89976c142 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 yangguo@chromium.org Simplify build Created with: gclient setdep -r src/third_party/devtools-frontend/src@80a89976c142 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=v8-waterfall-sheriff@grotations.appspotmail.com Bug: None Change-Id: I6082e6fa1d9fecd32a369126a4531121929c0e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906714Reviewed-by:
-
nancy authored
Chrome is a special extenision app, which doesn't launch a new tab, but reuses the current item in shelf, when click the icon in app_list. So work around the issue for Chrome. When AppService Instance feature is ready, AppService should check the shelf id or window for Chrome, and not re-launch a new tab. BUG=1022541 Change-Id: Iddac3f0749f8bad4fc5396f1152a73cef5c2ad54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905303Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#713959}
-
Chris Hamilton authored
Creates another VoteAggregator class that allows expressing "priority boosting" votes, which can be used to resolve priority inversions. BUG=971272 Change-Id: If84f0a7a22598de5f7a8897eb12066fbc5a00ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853867Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#713958}
-
Raymond Toy authored
Change base::Bind to base::BindOnce or base::BindRepeating as appropriate.. Bug: 1007798 Change-Id: I0bc1f2049624a4c4a1423139fd061ae84d6aa0ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902269Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#713957}
-
Henrique Nakashima authored
Chromium's only exists for historic reasons, currently serving documentation purposes only. AndroidX's version is supported by Android lint, though the check at build time is not currently working (crbug.com/1022939). This check is still useful for Android Studio. Bug: 889467 Change-Id: I491efe7472e03cddfdc20009341955ed92bc7e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907194Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#713956}
-
Doug Arnett authored
The code was actually removed a while ago but the histogram hadn't yet been marked obsolete. Bug: 1018793 Change-Id: Idade711cc8782aa6415058e4ce97e469493a3b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906259Reviewed-by:
-
Michael Wasserman authored
This reverts commit 2b5d8199. Reason for revert: Causing consistent base_unittests StackTraceTest.OutputToStream failures on: https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-google-rel/3709 Original change's description: > [base] Cleanup StackTraceTest.OutputToStream #ifdef soup. > > Bug: 999737, 706728 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780074 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Albert J. Wong <ajwong@chromium.org> > Auto-Submit: Wez <wez@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#712377} > Change-Id: I627b5250055233ea89718a9143de356c85633add > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905270 > Cr-Commit-Position: refs/heads/master@{#713876} TBR=ajwong@chromium.org,wez@chromium.org Change-Id: I2e09ac22e3c2fa66312d142664e7b03c1950989f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 999737, 706728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906545Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#713954}
-
kylechar authored
Three tests are timing out occasionally on Mac FYI Retina Release (NVIDIA). Mark as RetryOnFailure to suppress failures as Mac Nvidia drivers are unlikely to get fixed. Bug: 1022831 Change-Id: If241719809f135546d89ca13fb69e4107a06cb9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906879Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Auto-Submit: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#713953}
-
Wei-Yin Chen (陳威尹) authored
Move common test helpers to TabUiTestHelper for easier reuse. This is a rather mechanical moving without functional changes. Bug: 983170 Change-Id: I7aaace040a1a93f653761cc73661c46ec92dd591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903691Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#713952}
-
Max Li authored
Bug: 923594 Change-Id: I20025d7919c07d29b466a4d36d7a2c36b47d5cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896299 Commit-Queue: Max Li <themaxli@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#713951}
-
Kenneth Russell authored
Address review comments from jdarpinian. Bug: 681341 Change-Id: I68923295cbc6699c1a313e18af4dd8c0ea226354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907106Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#713950}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d5c0b56e84e0..039522eb577e git log d5c0b56e84e0..039522eb577e --date=short --no-merges --format='%ad %ae %s' 2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@039522eb577e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I935c94bd9772a227a33aa644625a0c62c18a68f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906710Reviewed-by:
-
