- 18 Oct, 2018 40 commits
-
-
Jun Mukai authored
I've got a report saying some SpokenFeedbackTest cases fail with some leaks when SingleProcessMash is enabled. It can be fixed by disabling AutomationManagerAura at shutdown since the leaked objects are allocated through some asynchronous events after shutting down (QuitBrowsers()). BUG=896728 TEST=interactive_ui_tests --enable-features=SingleProcessMash Change-Id: I215c3d5990cc78653c7fd44d378f7130a137a219 Reviewed-on: https://chromium-review.googlesource.com/c/1289295Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#600889}
-
Sergei Istomin authored
StreamMixer can be configured to use audio post processor. The test did not set any post processing pipeline for StreamMixer. When the test ran on a device test failed because a device additionaly processed audio and test got audio data changed. The test succeeded only when it is run on host (testx86). The test was fixed to use fake post processor. Bug: 117792326 Test: Unittests on device. Change-Id: Ife64df2690504bac249829f98ca659b19d763f23 Reviewed-on: https://chromium-review.googlesource.com/c/1285124 Commit-Queue: Sergei Istomin <sistomin@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#600888}
-
Maks Orlovich authored
Bug: 882585 Change-Id: Ic740f1ccd310ba5fc23f7bbb6f6bb40d6a3c59c2 Reviewed-on: https://chromium-review.googlesource.com/c/1287069Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#600887}
-
James Cook authored
Window close events are sent over mojo between browser and ash. The test needs to wait for in-flight messages to complete before making assertions about the state of ash. Also fix a problem where the window delete message wasn't being sent by WindowTreeClient. Bug: 877118 Test: DeviceLocalAccountTest.LastWindowClosedLogoutReminder Change-Id: I43145c8140462428a7db050489593038745c8f94 Reviewed-on: https://chromium-review.googlesource.com/c/1284059 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#600886}
-
Leonard Grey authored
Bug: 850098 Change-Id: Ia9559f323ba5d8d7b74578c91a4fee0618d3bd53 Reviewed-on: https://chromium-review.googlesource.com/c/1288854Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#600885}
-
Mikel Astiz authored
From the bridge's perspective, it's confusing to receive ApplyStopSyncChanges() with a non-null parameter, which reflects sync being disabled, without a prior MergeSyncData() call, which represents sync being enabled. Instead, make sure that a null parameter is passed to the bridge if the initial sync is not done. Prior to this patch, bridges would be overly conservative and clear sync metadata unnecessarily (because there couldn't be any). Other than that, no real user-facing issue exists. Credits for feuunk@ for surfacing and investigating the scenario. Bug: 890709 Change-Id: Ic39fb83596bd4e5e4c6f921b2df0812d0d94515c Reviewed-on: https://chromium-review.googlesource.com/c/1288578Reviewed-by:
Florian Uunk <feuunk@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#600884}
-
Daniel Rubery authored
Based on some example campaigns for which chrome sync history won't be useful, extend the maximum number of gestures in a referrer chain to 5 gestures. We can then evaluate how useful the extra data is, and possible extend the maximum gestures for all users. Bug: 864266 Change-Id: Idbcc2e07f7593a90f05ba07a2e1ef0c2a1be757b Reviewed-on: https://chromium-review.googlesource.com/c/1287041 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#600883}
-
Scott Violet authored
This increases msan multiplier from 6x to 7x and asan multipler from 2x to 3x. I'm doing this as a fair number of tests run very close to the limit, and often timeout. This leads to flake, which makes sheriffing tedious. BUG=896756 TEST=test only change Change-Id: Ib05875935fc2fdc5e042e7af0429794bf5f5b04f Reviewed-on: https://chromium-review.googlesource.com/c/1289083Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#600882}
-
Greg Kerr authored
The keychain was re-authorized to support Chrome's new signing certificate 18+ months ago. At this point, users who haven't re-launch Chrome in 18 months are unlikely to do so, or need the keychain. This removes the re-authorization code. Bug: 893729 CQ-Depend: CL:*698113 Change-Id: I9ba74e11861baafd36dd92b5cd2be2a2d46e6fa6 Reviewed-on: https://chromium-review.googlesource.com/c/1282028 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#600881}
-
Tarun Bansal authored
Enable the experiment that probes data saver proxies, and disables a proxy if the probe to it fails. Change-Id: I037d000f375d9a1eddf3515e4929948cafbd7d36 Bug: 760294 Reviewed-on: https://chromium-review.googlesource.com/c/1280142 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#600880}
-
Eric Karl authored
The passthrough command decoder counterpart to: https://chromium-review.googlesource.com/c/chromium/src/+/1279429 Adds support for DoCreateAndTexStorage2DSharedImageCHROMIUM to the passthrough command decoder. Causes the passthrough command decoder to store shared image representations for relevant client IDs. This isn't really used now, but will be used in a future begin/end access patch. Bug: 891059 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I14f9c0cdfeaf9e836361c2c811a06b69f36cdd66 Reviewed-on: https://chromium-review.googlesource.com/c/1287267 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#600879}
-
Theresa authored
Create a new omnibox/status/ component and move status icon (security and location icons) and verbose status text code from LocationBarLayout to a new StatusViewCoordinator. A future CL will refactor StatusViewCoordiantor. This CL specifically aims to move code with minimal changes. BUG=896096 Change-Id: I2464e1f32ceff17bfeb6c9c9b10c7f7e7fa22c9e Reviewed-on: https://chromium-review.googlesource.com/c/1287042Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#600878}
-
proberge authored
InlineInstallPrivate seems to have been an experimental API developed to allow apps to install other apps and extensions. It seems like it was never launched. Since regular inline installation is being removed, we should probably remove this API as well. Bug: 882045 Change-Id: Iefa97bd46cc38873d1a3d07292d45b2188c8f637 Reviewed-on: https://chromium-review.googlesource.com/c/1265558 Commit-Queue: proberge <proberge@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600877}
-
Nate Fischer authored
No change to the product, this only adds a python script for developers. This adds a script to remove the pre-installed system image WebView APKs. This is an adaptation of the guide at https://www.chromium.org/developers/how-tos/build-instructions-android-webview#TOC-Building R=jbudorick@chromium.org, torne@chromium.org Test: adb shell ls /system/app/webview /system/app/WebViewGoogle /system/app/WebViewStub Test: adb shell pm path com.android.webview Test: adb shell pm path com.google.android.webview Change-Id: Ib4a9c9706b15aa4c8ec826eb552a4b7552cff129 Reviewed-on: https://chromium-review.googlesource.com/c/1281964 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#600876}
-
Edward Lemur authored
The functionality was moved to cq.cfg in https://chromium-review.googlesource.com/c/chromium/src/+/1265735 Bug: 881860 Change-Id: I839784ec7babfa095272ab06c4c21c1e57475216 Reviewed-on: https://chromium-review.googlesource.com/c/1266055Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3d878160972c..1922eb00bbd9 git log 3d878160972c..1922eb00bbd9 --date=short --no-merges --format='%ad %ae %s' 2018-10-18 vmpstr@chromium.org Update trace categories to reflect new trace names. 2018-10-18 eyaich@google.com Updating user timing argument regex to not parse on subsequent ':' chars. 2018-10-18 benjhayden@chromium.org Add chopsui to third_party via bower. 2018-10-18 cbruni@chromium.org [results.html] Speed up <histogram-json> parsing 2018-10-18 perezju@chromium.org [pinpoint_cli] Add try job configs for v8 and scheduler teams Created with: gclient setdep -r src/third_party/catapult@1922eb00bbd9 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:892184,chromium:879526 TBR=sullivan@chromium.org Change-Id: I41ed30ce8eb8a704b4105398214b09008cff9566 Reviewed-on: https://chromium-review.googlesource.com/c/1289132Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600874}
-
Theresa authored
Disable this test on Android only. TBR=sahel@chromium.org,dtapuska@chromium.org BUG=894857 Change-Id: I3018030565a733de22b5c16a495a62211d8e1838 Reviewed-on: https://chromium-review.googlesource.com/c/1289081 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#600873}
-
Mirko Bonadei authored
Before this CL, the following GN args were causing an error [1] when building WebRTC. is_debug = false target_cpu = "arm64" target_os = "android" rtc_use_h264=true [1] - ERROR at //third_party/openh264/BUILD.gn:38:5: Undefined identifier. defines += [ "ANDROID_NDK" ] ^------ See //modules/video_coding/BUILD.gn:325:7: which caused the file to be included. "//third_party/openh264:encoder", Bug: None Change-Id: Ia27d995500364306edc555132dba3dbfdf632daa Reviewed-on: https://chromium-review.googlesource.com/c/1286409Reviewed-by:Henrik Boström <hbos@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#600872}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/2d98d49cf712ca7dc6f4b23b9c5f5542385d8dbe..dd412c428ad7c2a60ae4709dfbad6301e499dcb8 The following commits have Chromium bugs associated: 6650898e0 Remove -fsanitize-cfi-icall-generalize-pointers. b68b83223 Fix undefined function pointer casts in LHASH. Bug: 785442 Change-Id: I8a7cdc34cf9c6d9991452eaed6156361ee8c0bab Reviewed-on: https://chromium-review.googlesource.com/c/1289159 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#600871}
-
Jonathan Backer authored
This fixes instrumentation relied on by rendering.desktop telemetry tests. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ibfdb788359a873f7eba83a678a903d0aab8f9b19 Reviewed-on: https://chromium-review.googlesource.com/c/1288715Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#600870}
-
Edward Lemur authored
The PRESUBMIT_test is broken (see https://crrev.com/c/1289164). PRESUBMIT only filters out LayoutTests changes, but PRESUBMIT_test passes more files and expecting all of them to be filtered out. Bug: None Change-Id: I3a7e03c22c0c486fc438490c4b3ea00db5cdae0f Reviewed-on: https://chromium-review.googlesource.com/c/1289300Reviewed-by:
-
dpapad authored
Need to wrap <style is="custom-style"> with <custom-style> such that styling works both in Polymer 1 and Polymer 2. Bug: 739532,896507 Change-Id: I40e4a1fa6ac071cc31268c5e86fa13a023a59490 Reviewed-on: https://chromium-review.googlesource.com/c/1287258Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#600868}
-
Andrey Kosyakov authored
This reverts commit 5f74e543. Reason for revert: this broke run_web_tests.py, I'm getting: No handlers could be found for logger "blinkpy.web_tests.port.base" Original change's description: > Automatically pick a target directory which exists for run_web_tests.py script > > This also updates how we compute the default for 'configuration'. First, we try to look for the > configuration definition (args.gn) & use that value. If that doesn't succeed, we guess the > value of configuration using the target value. > > Reviewers: the main change is in third_party/blink/tools/blinkpy/web_tests/port/base.py, the rest are followed by. > > > Bug: 893618 > Change-Id: I578c977bcaccd6294596f8cf7079748809698db6 > Reviewed-on: https://chromium-review.googlesource.com/c/1281043 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Robert Ma <robertma@chromium.org> > Commit-Queue: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#600760} TBR=dpranke@chromium.org,nednguyen@google.com,robertma@chromium.org Change-Id: I99ddad12601e0d207ee7d9c276b9d64333488f67 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 893618 Reviewed-on: https://chromium-review.googlesource.com/c/1289431Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#600867}
-
Nicolas Ouellet-payeur authored
It returns true when there are any policies at the machine level, whether that's from a platform provider, or from cloud policies. Bug: 893626, 893628 Change-Id: I6e90ff54ee400a82df04c2f671d408d04b3e3bc5 Reviewed-on: https://chromium-review.googlesource.com/c/1269764 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#600866}
-
Robert Ogden authored
It was agreed that we should use "provided" instead of "delivered". Bug: 896774 Change-Id: I542a0ffc217aa5601d114e5cf1541c12b5b9f990 Reviewed-on: https://chromium-review.googlesource.com/c/1289293Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#600865}
-
Theresa authored
TBR=msramek@chromium.org BUG=894572 Change-Id: I0f9cea8f6434598f9a2c03e5b68d6c95e21f3ece Reviewed-on: https://chromium-review.googlesource.com/c/1289079Reviewed-by:
-
Andreas Butler authored
Change-Id: I88a0fe75383bb9712478580a7bd60a145e2d89ba Bug: 1228492 Reviewed-on: https://chromium-review.googlesource.com/c/1228492 Commit-Queue: Andreas Butler <andreasbutler@google.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#600863}
-
jdoerrie authored
This change enables the WebAuthN M70 Features "WebAuthenticationUI", "WebAuthenticationTouchId" and "WebAuthenticationCableWin" by default. Relevant Launch Bugs: - TouchId: https://crbug.com/837392 - UI and CableWin: https://crbug.com/873195 TBR=jochen@chromium.org Bug: NONE Change-Id: I3693fbd28c0b11978a045c7fa9f68c9e4995c1a0 Reviewed-on: https://chromium-review.googlesource.com/c/1288795 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#600862}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2d0fa5b17840..d876a0dad49c Created with: gclient setdep -r src-internal@d876a0dad49c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iffcc95d192c4a997669b555078592019909e17d4 Reviewed-on: https://chromium-review.googlesource.com/c/1288956Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600861}
-
Sammie Quon authored
Previously the fling in the wrong direction would do the same as a fling in the right direction. (ex. flinging down when dragging up from the shelf would show the home launcher as well) Test: ash_unittests HomeLauncherModeGestureHandlerTest.Fling* Bug: 896510 Change-Id: I0a366eaab679e5e041947a07e80bd82ab495a8af Reviewed-on: https://chromium-review.googlesource.com/c/1289073 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#600860}
-
Erik Luo authored
Typing 'h' in text inputs with 'maxLength' may produce key events without producing the 'input' event. This scenario leads DevTools to allow shortcut-defined actions that are normally suppressed. This CL replaces suppression logic with a simpler condition: "if a key might trigger input, and we are editing, do not run action" Bug: 833340 Change-Id: I75c5c0dd49c9f5b1624122345459438fc1d976f3 Reviewed-on: https://chromium-review.googlesource.com/c/1265837Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#600859}
-
Kim Paulhamus authored
Prevents create() calls where requireResidentKey = true. Also disables resident credentials in getAssertion calls entirely until they can be fully and properly supported. (Previously, if an empty list was passed to getAssertion() and resident credentials for that RP existed, then a random single credential would be passed back.) Bug: 896404 Change-Id: Ic6efcb99891825f929efba616ff5cf5788236a7d Reviewed-on: https://chromium-review.googlesource.com/c/1287089 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#600858}
-
Tatiana Buldina authored
This reverts commit 6a308947. Reason for revert: Caused https://crbug.com/chromedriver/2615 Original change's description: > [ChromeDriver] Do not return stale window handle > > Move ExecuteGetCurrentWindowHandle() from session_commands.cc > to window_commands.cc, to make use of automatic window state > validation done for window commands. > > Bug: chromedriver:1404 > Change-Id: Id5ac4c7cea5323f12612b2dfb4dff2b819ce22ff > Reviewed-on: https://chromium-review.googlesource.com/1257362 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Tatiana Buldina <buldina@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595938} TBR=johnchen@chromium.org,buldina@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromedriver:1404 chromedriver:2615 Change-Id: I7b8605d8f83536e0ebcdae4fe8f628fe1de80d1b Reviewed-on: https://chromium-review.googlesource.com/c/1289069Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#600857}
-
Nate Chapin authored
These tests are reliably passing: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fworkers%2Fbaseurl%2Falpha%2Fworker-in-worker.html%2Cexternal%2Fwpt%2Fworkers%2FWorker_ErrorEvent_error.htm Bug: 655458 Change-Id: I1b58a462249f9b7f19644958c717dc9e59d4eac7 Reviewed-on: https://chromium-review.googlesource.com/c/1289078Reviewed-by:
Ojan Vafai <ojan@chromium.org> Commit-Queue: Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#600856}
-
Vadym Doroshenko authored
Before this CL, during cloning the new metric recorder was created and then it was overwritten with the old one. That leads to many extra metric sending (each recorder sends metrics separately). This CL fixes this to adding metric recorder to the constructor, so it's possible to reuse existing metric recorder. It's very similar to PasswordFormManager implementation, but then it's done with a separate Init() function, but it's easier to add this in constructor in order to have the consistent object after constructor call, since anyway the recorder must be created. Bug: 831123 Change-Id: Id46dee6aee4ae30686f1190884db05e25f26113b Reviewed-on: https://chromium-review.googlesource.com/c/1288437 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#600855}
-
Josh Karlin authored
When checking if a resource request is an ad or not, also check if the frame requesting the resource is considered an ad frame. Note that this is redundant at the moment because the SubresourceFilter already does this on its inspection of the request but the plan is to remove the SubresourceFilter logic for that in a follow-up CL. Bug: 894505 Change-Id: Ib85fa44ed74a59e090e9ae893090d1c99d7c71e6 Reviewed-on: https://chromium-review.googlesource.com/c/1288850Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600854}
-
Evan Stade authored
Move the immersive reveal lock into OmniboxViewViews::SetFocus so more codepaths will use it. Bug: 337689 Change-Id: I16546969e99eae5493da60df5454ebac9a4d1292 Reviewed-on: https://chromium-review.googlesource.com/c/1287303Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#600853}
-
Aga Wronska authored
Allow user to change screen brightness defined by screen brightness policy. User defined brightness value will be preserved till the end of the user session, even if policy gets updated. The policy brightness values will not be sent to power manager in that situation. Bug: 890068, 310429 Test: chromeos_unittests and manually with local policy server Change-Id: Ia048b4e328d739347cff7b49a0128db7869165a3 Reviewed-on: https://chromium-review.googlesource.com/c/1285730 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#600852}
-
Robert Sesek authored
Also ensure Hide Others and Show All are in the PWA menus. Bug: 892480 Change-Id: I507771745c95203fda8344703c7b1b015a93699a Reviewed-on: https://chromium-review.googlesource.com/c/1288851Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#600851}
-
James Cook authored
They were fixed by crrev.com/600598 that moved window bounce animations to ash. Bug: 855767 Change-Id: I5a711a6a93966ef30ce410138f4b13b3f1da039f Reviewed-on: https://chromium-review.googlesource.com/c/1289290 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
-
