GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126754 0039d316-1c4b-4281-b951-d872f2087c98

Regression introduced in r119183 when "Null" and "Invalid" were disambiguated.

Tests will require refactoring; tracked as crbug.com/118033

BUG=117920

Review URL: http://codereview.chromium.org/9691021

TBR=jsbell@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9704039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126752 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nkostylev@chromium.org,bartfab@chromium.org
BUG=116996,117995

Review URL: https://chromiumcodereview.appspot.com/9702043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126751 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92439
TEST=try bot

Review URL: https://chromiumcodereview.appspot.com/9700001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126750 0039d316-1c4b-4281-b951-d872f2087c98

BUG=24672
TEST=none

Review URL: http://codereview.chromium.org/9691059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126749 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=apatrick


Review URL: http://codereview.chromium.org/9700031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126748 0039d316-1c4b-4281-b951-d872f2087c98

* Replace a pair of overlapping functions in the API with two distinct accessors for relevant pieces of information about prepopulated URLs. One key side effect here is that we no longer return TemplateURL*s from these, which will make the upcoming refactoring changes slightly cleaner. 
* Make the implementation of these a bit more robust w.r.t. determining if a provided URL corresponds to Google. This will also be important later as we'll want to be able to match a hand-coded "google.co.uk" entry against an auto-generated "google.de" entry (or similar). 
* Remove a bunch of string conversions, as well as a lot of passing of raw C-style string pointers. 
* Remove using statements. 
* Remove two obscure engines which have the same hostname as another, different engine. These cause problems when we ask for the name or type of an engine because the answer we get back is basically indeterminate. I don't think either of these is very important (they lived at slots 4 and 5 in their respective countries) so just gut them. 

BUG=none 
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9705021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126746 0039d316-1c4b-4281-b951-d872f2087c98

vista-release-dual-core: 0.7% dhtml time regression
http://build.chromium.org/f/chromium/perf/vista-release-dual-core/dhtml/report.html?history=270&rev=126694

mac-release-10.5: 0.5% dhtml time regression
http://build.chromium.org/f/chromium/perf/mac-release-10.5/dhtml/report.html?history=350&rev=126677

They both seem to start in 125608, "Roll WebKit r110147:110159"

BUG=118252
TBR=cmp
Review URL: https://chromiumcodereview.appspot.com/9702038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126745 0039d316-1c4b-4281-b951-d872f2087c98

* Move all TemplateURL creation into a single core CreateTestTemplateURL() function.  This will ease the later TemplateURL refactoring changes that will modify how TemplateURLs are created and modified.
* Make use of the TemplateURLService::TemplateURLVector typedef.
* Pass string16s to EditSearchEngine() since that's what it really wants.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9692072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126744 0039d316-1c4b-4281-b951-d872f2087c98

* Move SpansToString()/SpansFromString() and AddLastMatchIfNeeded() from static functions in shortcuts_provider_shortcut.cc to static members on AutocompleteMatch and rename them, to go along with the other existing classification-related functions there, since there's nothing particularly shortcut-related about them.
* Move the definitions of Shortcut and ShortcutMap to the ShortcutsBackend, mainly to "namespace" them -- having a global-scope type named "Shortcut" didn't seem like a good idea.  This made sense as a location anyway since the backend already depended heavily on these types.
* Eliminate using statements.
* Modify ShortcutsProviderTest::FillData() so it can be reused in an additional place.
* Shortcut had two different constructors whose function and use was confusing and error-prone -- they took some of the same fields but as different types, and didn't guarantee all the members were initialized.  Condense to one constructor which takes the most logical types and sets all members.
* Eliminate ShortcutsBackend::guid_map() (unused).
* Simplify/clarify code.
* Eliminate 2K clamp on shortcut data fields.  We don't clamp like this elsewhere, and if the clamp kicks in, it could lead to corrupted results -- e.g. trimming a "description" field but not updating the classifications for that field.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9689085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126743 0039d316-1c4b-4281-b951-d872f2087c98

CID=100255

TBR=rickcam@chromium.org

BUG=
TEST=


Review URL: http://codereview.chromium.org/9705024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126742 0039d316-1c4b-4281-b951-d872f2087c98

It was being initialized lazily on the IO thread when the first AsyncPresentAndAcknowledge came in.

Also, the AcceleratedSurface::presenter_ variable was mutable, initialized on the IO thread and used on the IO and UI thread with no lock. I think this allowed the UI thread to attempt to use a partially initialized AcceleratedPresenter. I made presenter_ immutable and ensured that the AcceleratedPresenter is instead always created on the UI thread and not visible in partially constructed form on the IO thread.

I had to change the timing of the Direct3D device initialization so that it is not created if it is not needed because that can crash windows bots.

BUG=117453

Review URL: http://codereview.chromium.org/9694015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126741 0039d316-1c4b-4281-b951-d872f2087c98

BUG= 117778
TEST= crx_id_unittest.py

Review URL: https://chromiumcodereview.appspot.com/9693014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126740 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=eroman

Review URL: http://codereview.chromium.org/9705026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126739 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110130, 109480
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9704029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126738 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126737 0039d316-1c4b-4281-b951-d872f2087c98

Instead of showing the demo user UI, show the screensaver directly. On going active, the user gets dropped into a demo user session directly (see bug for details). Additionally removed the Lock Screen and Shutdown options from the wrench menu model for ChromeOS.

tbarzic@ - main review
sky@ - owners review for chrome/browser/ui/toolbar/wrench_menu_model_chromeos.cc

R=tbarzic@chromium.org,sky@chromium.org
BUG=chromium-os:26041,chromium-os:27543
TEST=Ran unit tests, tested with kiosk-mode flags and tested with giving an invalid screensaver to test the fallback flow.

Review URL: https://chromiumcodereview.appspot.com/9695029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126736 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:27007
TEST=Manual test.


Review URL: http://codereview.chromium.org/9695049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126733 0039d316-1c4b-4281-b951-d872f2087c98

Uses an error injection technique to simulate hard-to-reproduce file system errors.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/9426029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126732 0039d316-1c4b-4281-b951-d872f2087c98

This is just a renaming, it still uses the same renderer visibility hooks to decide how to manage buffers.


BUG=116049
TEST=Manual


Review URL: http://codereview.chromium.org/9703024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126731 0039d316-1c4b-4281-b951-d872f2087c98

Move creation of content TabContentsViews to content so that we can hide these headers through DEPS and avoid any more includes until TabContentsViewsViews is removed. I also moved all the TCVXDelegate to be in one header, that way we can more conveniently ask the embedder for a delegate without a lot of ifdefs.

BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9700023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126730 0039d316-1c4b-4281-b951-d872f2087c98

snapping/minimizing. FrameMaximizeButton handles all the logic for
this. If you move the mouse the drag threshold we'll trigger to
snapping behavior. moving to the left snaps to the left half, moving
to the right the right half, and below minimizes. Uses
PhantomWindowController to render the snap position. Minimizing
highlights the launcher button. To support this I had to plumb through
getting the bounds of the launcher button.

BUG=116213
TEST=none
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9703026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126729 0039d316-1c4b-4281-b951-d872f2087c98

The major reason for us to enable a fix for HEAP_PROFILE_MMAP.
Please note that this change doesn't affect Chromium builds.

BUG=114302
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9316021

TBR=dmikurube@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9701040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126728 0039d316-1c4b-4281-b951-d872f2087c98

BUG=118070
TEST=none
R=csilv

Review URL: https://chromiumcodereview.appspot.com/9706031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126727 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110130, 109480
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9700036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126726 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116171
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9618033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126725 0039d316-1c4b-4281-b951-d872f2087c98

Some untracked files were created in a clean repo build on Windows.

NOTRY=true
BUG=
TEST=No untracked files left after building all.sln on Windows 7 (VS20120)


Review URL: http://codereview.chromium.org/9700026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126724 0039d316-1c4b-4281-b951-d872f2087c98

Crash occurs because the previous code would early-out when there were no services installed, which would prevent creating the LayoutManager. As a result, the layout manager was NULL.

BUG=117068
TEST=none
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9651024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126723 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=rsesek

Review URL: http://codereview.chromium.org/9706027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126722 0039d316-1c4b-4281-b951-d872f2087c98

Removed the SpeechRecognizerDelegate interface and replaced with SpeechRecognitionEventListener. By now it might seem just a rename of the former interface, however this interface will gradually incorporate, in the next CLs, the other delegates and become the reference interface used by all clients to interact with SpeechRecognition inside Chrome.

BUG=116954
TEST=none

Review URL: http://codereview.chromium.org/9688012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126721 0039d316-1c4b-4281-b951-d872f2087c98

ContentAPI change - Post DomStorage tasks via a SequencedTaskRunner instead of directly to WEBKIT_DEPRECATED.

BUG=106763
Review URL: https://chromiumcodereview.appspot.com/9700007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126720 0039d316-1c4b-4281-b951-d872f2087c98

Regression introduced in r119183 when "Null" and "Invalid" were disambiguated.

Tests will require refactoring; tracked as crbug.com/118033

BUG=117920

Review URL: http://codereview.chromium.org/9691021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126719 0039d316-1c4b-4281-b951-d872f2087c98

R=dominich@chromium.org
BUG=117620
TEST=PrerenderBrowserTest.PrerenderNaClPluginDisabled, PrerenderBrowserTestWithNaCl.PrerenderNaClPluginEnabled

Review URL: http://codereview.chromium.org/9677033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126718 0039d316-1c4b-4281-b951-d872f2087c98

OpenProcess returns NULL on error, see http://msdn.microsoft.com/en-us/library/windows/desktop/ms684320(v=vs.85).aspx

BUG= none
TEST= none

Review URL: http://codereview.chromium.org/9703019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126717 0039d316-1c4b-4281-b951-d872f2087c98

The major reason for us to enable a fix for HEAP_PROFILE_MMAP.
Please note that this change doesn't affect Chromium builds.

BUG=114302
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9316021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126715 0039d316-1c4b-4281-b951-d872f2087c98

API still not implemented.

BUG=None
TEST=Check there is no exception on attempt to pin a file.


Review URL: http://codereview.chromium.org/9696029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126714 0039d316-1c4b-4281-b951-d872f2087c98

Add BluetoothAdapter::GetDevice() so that the options handler can
retrieve a BluetoothDevice* for an address that it receives from
JavaScript, so it doesn't have to cache structures by itself.

Include a reference to the owning BluetoothAdapter* in BluetoothDevice
since the underlying CreateDevice and CreatePairedDevice method calls
are actually made on adapter clients, and need its object path. Make
BluetoothDevice a friend of BluetoothAdapter so it can retrieve that
object path (we don't want anything D-Bussy in the public API).

BluetoothDevice gains a BluetoothAgentServiceProvider member which is
set during pairing, and implements BluetoothAgentServiceProvider::Delegate
to receive the method calls passing them on to BluetoothOptionsHandler
via the BluetoothDevice::PairingDelegate interface it implements.

Rather than require the options handler to deal with callbacks, cache the
service provider callbacks within BluetoothDevice so that replies are done
with ordinary method calls asynchronously.

Use a weak pointer factory in BluetoothOptionsHandler in case error callbacks
are called after destruction. Declare constants for strings between the C++
code and JavaScript at the top, rather than inline.

Clean up JavaScript code to disambiguate "connect" vs. "accept" and
"cancel" vs. "reject".

BUG=chromium-os:21320
TEST=extensively on device

Change-Id: I941ca42f676e7a6e557c657b6213a74429eb4376


Review URL: http://codereview.chromium.org/9694054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126713 0039d316-1c4b-4281-b951-d872f2087c98

Now that all the new tests have landed, the old versions can be
removed. Also removes data files which are Chrome OS only, we can
add it back to ChromeOS specific tests when we have those.

BUG=110779,106263
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9666032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126712 0039d316-1c4b-4281-b951-d872f2087c98

In the File Browser if there are several actions available for a file then the most recently used one becomes the default (it is invoked on double click etc). On a fresh profile when all timestamps are equal this is a matter of chance. 
The patch gives higher priority to the actions of the File Browser (only as long as timestamps are equal).

BUG=chromium-os:27216
TEST=Start on a fresh profile, observe that "View" is shown for an image file, not "Upload to Picasa"


Review URL: http://codereview.chromium.org/9692049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126711 0039d316-1c4b-4281-b951-d872f2087c98

The new button assets have sharper edges, which better matches the look of the frame.  They are also more tightly spaced.

BUG=117433
TEST=visual

Review URL: https://chromiumcodereview.appspot.com/9707001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126710 0039d316-1c4b-4281-b951-d872f2087c98