GitLab

Revert of Refactoring of Cast-related crypto code (patchset #19 id:350001 of https://codereview.chromium.org/792353002/)

Reason for revert:
fails to compile on Linux ChromiumOS GN https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/6146/steps/compile/logs/stdio

Original issue's description:
> Refactoring of Cast-related crypto code to use the same certificate validation logic in chrome.networkingPrivate API and Cast Channel authentication.
>
> Here's what's being done here:
> * Code from cast_auth_util_nss/openssl formed the basis a common Cast device validation component in /src/extensions/common/cast/cast_cert_validator*, and is now being extensively cleaned up in response to rsleevi's comments in this CL.
> * Both networking_private_crypto* and cast_auth_util* have been updated to use the new common code.
> * The current D-Bus-based implementation of VerifyDestination is going away per discussion with ChromeOS team, and is replaced with in-Chrome code in networking_private crypto*.
>
> BUG=442650
>
> Committed: https://crrev.com/ed1e90f4f980709cef6a8a9c7e0f64cfe5578cdd
> Cr-Commit-Position: refs/heads/master@{#311460}

TBR=stevenjb@chromium.org,mef@chromium.org,rsleevi@chromium.org,vadimgo@chromium.org,mfoltz@chromium.org,kmarshall@chromium.org,rockot@chromium.org,brettw@chromium.org,sheretov@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=442650

Review URL: https://codereview.chromium.org/853663003

Cr-Commit-Position: refs/heads/master@{#311461}

Refactoring of Cast-related crypto code to use the same certificate validation logic in chrome.networkingPrivate API and Cast Channel authentication.

Here's what's being done here:
* Code from cast_auth_util_nss/openssl formed the basis a common Cast device validation component in /src/extensions/common/cast/cast_cert_validator*, and is now being extensively cleaned up in response to rsleevi's comments in this CL.
* Both networking_private_crypto* and cast_auth_util* have been updated to use the new common code.
* The current D-Bus-based implementation of VerifyDestination is going away per discussion with ChromeOS team, and is replaced with in-Chrome code in networking_private crypto*.

BUG=442650

Review URL: https://codereview.chromium.org/792353002

Cr-Commit-Position: refs/heads/master@{#311460}

 - suppress leaks from extensions::ApiTestBase::SetUp() and extensions::MojoPrivateApiTest_Define_Test::TestBody() (issue 448700)

BUG=448700
TBR=timurrrr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/850893002

Cr-Commit-Position: refs/heads/master@{#311459}

BUG=448323
TBR=raymes@chromium.org

Review URL: https://codereview.chromium.org/840373004

Cr-Commit-Position: refs/heads/master@{#311458}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/24e6399..5cf6e0e

TBR=zmo@chromium.org,yutak@chromium.org

Review URL: https://codereview.chromium.org/854553002

Cr-Commit-Position: refs/heads/master@{#311457}

789a019  Don't serialize linking for the make generator by default
8b69f7d  Add support for generating an Eclipse .classpath file (bug fix)

R=machenbach@chromium.org,thakis@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/851953002

Cr-Commit-Position: refs/heads/master@{#311456}

The system_wrappers target is already included due to the dependency
on the <(DEPTH)/third_party/webrtc/webrtc.gyp:webrtc target.

Review URL: https://codereview.chromium.org/851873004

Cr-Commit-Position: refs/heads/master@{#311455}

BUG=447440

Review URL: https://codereview.chromium.org/830673005

Cr-Commit-Position: refs/heads/master@{#311454}

This should make courgette_unittests green in this configuration.

BUG=345874
TBR=dgarrett@chromium.org

Review URL: https://codereview.chromium.org/850783002

Cr-Commit-Position: refs/heads/master@{#311453}

AddressSanitizer (ASan) uses code patching of every module of an application at startup / module load.
As a result, many tests that check the number of modified functions misbehave.
I'm disabling most of them and adjusting one that's easy to generalize.

I've also replaced some EXPECT_* macros with ASSERT_* per
https://code.google.com/p/googletest/wiki/V1_7_Primer#Assertions
"you should use ASSERT_* if it doesn't make sense to continue when the assertion in question fails"

BUG=345874

Review URL: https://codereview.chromium.org/848923004

Cr-Commit-Position: refs/heads/master@{#311452}

Hooray for not asking about style nits anymore!

R=vabr@chromium.org

Review URL: https://codereview.chromium.org/828163004

Cr-Commit-Position: refs/heads/master@{#311451}

Revert of Add accelerated video decoder interface, VP8 and H.264 implementations and hook up to V4L2SVDA. (patchset #10 id:220001 of https://chromiumcodereview.appspot.com/833063003/)

Reason for revert:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/6135/steps/compile/logs/stdio#error1

Original issue's description:
> Add accelerated video decoder interface, VP8 and H.264 implementations and hook up to V4L2SVDA.
>
> An AcceleratedVideoDecoder is a video decoder that requires support from an
> external accelerator (typically a hardware accelerator) to partially
> offload the decode process after parsing stream headers, and performing
> reference frame and state management.
>
> In this design, the hardware-independent decoder implementation interfaces
> with a HW-specific Accelerator to offload last stages of the decode process.
>
> Add the interface for AcceleratedVideoDecoder, decoders for VP8 and H264,
> V4L2-specific Accelerators for VP8 and H264 and a common accelerator/client
> class for V4L2.
>
> TEST=vdatest VP8/H264, mp4 local video playback, apprtc decode
> BUG=chrome-os-partner:33728
>
> Committed: https://crrev.com/04272d3017214b966feba379d78b195e2fd2193d
> Cr-Commit-Position: refs/heads/master@{#311448}

TBR=wuchengli@chromium.org,kcwu@chromium.org,owenlin@chromium.org,xhwang@chromium.org,scherkus@chromium.org,dalecurtis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=chrome-os-partner:33728

Review URL: https://codereview.chromium.org/850883002

Cr-Commit-Position: refs/heads/master@{#311450}

Convert the aborting callback to a simple closure, as we don't need to care
about the result code, nor about the completion. Note, that an error callback
with FILE_ERROR_ABORTED will be called for operations which are aborted.

TEST=unit_tests, browser_tests: *FileSystemProvider*
BUG=448298

Review URL: https://codereview.chromium.org/845083005

Cr-Commit-Position: refs/heads/master@{#311449}

An AcceleratedVideoDecoder is a video decoder that requires support from an
external accelerator (typically a hardware accelerator) to partially
offload the decode process after parsing stream headers, and performing
reference frame and state management.

In this design, the hardware-independent decoder implementation interfaces
with a HW-specific Accelerator to offload last stages of the decode process.

Add the interface for AcceleratedVideoDecoder, decoders for VP8 and H264,
V4L2-specific Accelerators for VP8 and H264 and a common accelerator/client
class for V4L2.

TEST=vdatest VP8/H264, mp4 local video playback, apprtc decode
BUG=chrome-os-partner:33728

Review URL: https://codereview.chromium.org/833063003

Cr-Commit-Position: refs/heads/master@{#311448}

BUG=448688
TBR=rtenneti@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/832583004

Cr-Commit-Position: refs/heads/master@{#311447}

The crash was happening because the wrong constructor of scoped_nsobject,
because the template parameter did not exactly match the declaration.
The automatic conversion to pointer was used, and the crash happened
because the object was not retained.
With the new code, the copy constructor is used instead, as was intended.

Review URL: https://codereview.chromium.org/793463004

Cr-Commit-Position: refs/heads/master@{#311446}

Revert of Update V8 to version 4.2.1 (based on cf09a5a1912e0b1ba3dd92e4e67358618736f6aa). (patchset #1 id:1 of https://codereview.chromium.org/847343002/)

Reason for revert:
Speculative revert due to build failure on Win8 GN debug builder http://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/2984

Original issue's description:
> Update V8 to version 4.2.1 (based on cf09a5a1912e0b1ba3dd92e4e67358618736f6aa).
>
> TBR=machenbach@chromium.org
>
> Committed: https://crrev.com/63aed1cdc517914528cbbe744b1ae89ba8dbdee6
> Cr-Commit-Position: refs/heads/master@{#311438}

TBR=machenbach@chromium.org,v8-autoroll@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/852753002

Cr-Commit-Position: refs/heads/master@{#311445}

BUG=335778
TEST=build and run media_unittests --gtest_filter=JpegParserTest.*
R=posciak@chromium.org, wuchengli@chromium.org

Review URL: https://codereview.chromium.org/748023002

Cr-Commit-Position: refs/heads/master@{#311444}

During migration to newest versions use_additional_auth column
should be removed form logins database. Since sqllite syntax doesn't
support column dropping, so we create new database without this column
and copy data there.

BUG=423716
R=gcasto@chromium.org

Review URL: https://codereview.chromium.org/818443004

Cr-Commit-Position: refs/heads/master@{#311443}

ScriptClientMap actually contains provider clients, not script clients.

BUG=n/a
TEST=compile

Review URL: https://codereview.chromium.org/854543002

Cr-Commit-Position: refs/heads/master@{#311442}

Add sdefresne as temporary OWNERS of favicon & favicon_base
for the duration of the componentization effort of favicon.

Add OWNERS file to //components/favicon_base with the same
OWNERS as //components/favicon since this component is there
to help split functionality shared by history and favicon
components.

Remove blundell@ as temporary OWNERS of //components/favicon*
since he is already OWNERS of //components.

BUG=359513

Review URL: https://codereview.chromium.org/821903003

Cr-Commit-Position: refs/heads/master@{#311441}

This is a preparation for defining some methods in an ios-specific
.cc file.

BUG=426870
R=sky@chromium.org

Review URL: https://codereview.chromium.org/848903002

Cr-Commit-Position: refs/heads/master@{#311440}

BUG=442514

Review URL: https://codereview.chromium.org/847083002

Cr-Commit-Position: refs/heads/master@{#311439}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/847343002

Cr-Commit-Position: refs/heads/master@{#311438}

Move select_favicon_frames_unittest.cc into the favicon_base
with the code that it is testing.

Add the unit_test to the components_unittests, including when
using gn build system.

BUG=359513

Review URL: https://codereview.chromium.org/851693003

Cr-Commit-Position: refs/heads/master@{#311437}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b0f21fa..24e6399

TBR=zmo@chromium.org,yutak@chromium.org

Review URL: https://codereview.chromium.org/852733003

Cr-Commit-Position: refs/heads/master@{#311436}

BUG=442514
R=sky@chromium.org

Review URL: https://codereview.chromium.org/828633002

Cr-Commit-Position: refs/heads/master@{#311435}

BUG=387064

Review URL: https://codereview.chromium.org/815643004

Cr-Commit-Position: refs/heads/master@{#311434}

As TilingSetEvictionQueue creation has been moved to
EvictionTilePriorityQueue, the TilingSetEvictionQueue default
constructor is not used any more but is dead code and can thus be
removed.

R=danakj, vmpstr

Review URL: https://codereview.chromium.org/852553002

Cr-Commit-Position: refs/heads/master@{#311433}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/63121f0..26a00de

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/812283006

Cr-Commit-Position: refs/heads/master@{#311432}

Please see https://groups.google.com/a/chromium.org/d/msg/chromium-dev/ZYL1fHRIy6I/Qh9ic5YrEq8J
for context.

BUG=none
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/833243009

Cr-Commit-Position: refs/heads/master@{#311431}

BUG=439515
TEST=none

Review URL: https://codereview.chromium.org/838463005

Cr-Commit-Position: refs/heads/master@{#311430}

Review URL: https://codereview.chromium.org/828853004

Cr-Commit-Position: refs/heads/master@{#311429}

- Prefix the error messages to indicate the operation
that failed (particularly helps when the error occurs
in a promise chain)
- Add more details to the error messages.

Example improvements:

Before: "URL too long"
After: "Failed to register a ServiceWorker: The
provided scriptURL or scope is too long."

Before: "The scope must be under the directory of the
script URL."
After: "Failed to register a ServiceWorker:
The path of the provided scope ('http://localhost:9898/mysecretpath')
is not under the directory of the provided scriptURL
('http://localhost:9898/resources/empty-worker.js')."

BUG=436928

Review URL: https://codereview.chromium.org/813673005

Cr-Commit-Position: refs/heads/master@{#311428}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8f672cd..b0f21fa

TBR=hayato@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/849033002

Cr-Commit-Position: refs/heads/master@{#311427}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/812c028..63121f0

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/812653004

Cr-Commit-Position: refs/heads/master@{#311426}

Cr-Commit-Position: refs/heads/master@{#311425}

Revert of Relanding this with font test fixes for gdi. (patchset #7 id:120001 of https://codereview.chromium.org/853553002/)

Reason for revert:
still fails on XP

https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/34996/steps/gfx_unittests/logs/DeriveFontWithHeight

Original issue's description:
> Relanding this with font test fixes for gdi.
>
> Get all font unittests running with DirectWrite on Windows 7+
>
> Fixes as per below:-
> 1. Remove the addition of the fLeading value when calculating the height for the font
>    with DirectWrite. fAscent + fDescent is the height of the font and adding the fLeading
>    value to it returns the spacing between lines which is not what we are looking for.
>
> 2. The FontListTest.Fonts_GetHeight_GetBaseline unittest has a condition which basically validates
>    whether the difference between the font height and the baseline is different for Arial and Symbol
>    fonts. This fails for DirectWrite and fails for GDI with font sizes like 50, etc. Replaced this check
>    with a check for the font heights are different.
>
> 3. Reworked the PlatformFontWinTest.DeriveFontWithHeight test to ensure it passes for DirectWrite and GDI.
>
> 4. Ensure that the PlatformFontWin::DeriveFontWithHeight function honors the minimum font size constraint
>    in all cases.
>
> BUG=442010
> R=msw
>
> Committed: https://crrev.com/3e05f41653bf36cce40718d8295ce2293218dab6
> Cr-Commit-Position: refs/heads/master@{#311388}

TBR=msw@chromium.org,ananta@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=442010

Review URL: https://codereview.chromium.org/847283003

Cr-Commit-Position: refs/heads/master@{#311424}

Previously we used the center of the bounding box, but this can cause problems if the center of the bounding box is outside the element.

This CL also changes the behavior of the GetElementLocationOnceScrolledIntoView command in the same way.

BUG=

Review URL: https://codereview.chromium.org/848483002

Cr-Commit-Position: refs/heads/master@{#311423}

As the completion callback is called externally it should be cleared first, to
avoid possible double cancellation.

TEST=None
BUG=None

Review URL: https://codereview.chromium.org/838023003

Cr-Commit-Position: refs/heads/master@{#311422}