GitLab

Bug: 650147
Change-Id: I4a158f600acb733477d33ebbd6a504490a5b54a4
Reviewed-on: https://chromium-review.googlesource.com/c/1341836
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609346}

This CL is making sure tracing categories are
activated as soon as the request for start tracing
is done. Background tracing (Slow-reports) is
sending a request to TraceLog which delegate it
to the tracing service. Starting tracing is not
synchronous. The categories are activated after
the tracing is started.

This CL is manually turning on the categories by
calling SetEnabled on TraceLog.

A manual trigger for session is added. This trigger
is reactive which means tracing won't be activated
on a normal usage of chrome. It will only be
activated during session restore (depending on the
background tracing configuration).


R=chrisha@chromium.org, oysteine@chromium.org

This CL can locally be tested with:

  out\build\chrome.exe --enable-background-tracing=c:\src\chromium\tracing-config.json --trace-upload-url=http://localhost:8080

==== trace-config.json ====
{
  "scenario_name": "Browser",
  "mode": "REACTIVE_TRACING_MODE",
  "configs": [
    {
      "rule": "TRACE_ON_NAVIGATION_UNTIL_TRIGGER_OR_FULL",
      "trigger_name": "session-restore-config",
      "category": "BENCHMARK_NAVIGATION",
      "trigger_delay": 5
    }
  ]
}


Change-Id: Ic9131440db98d260e1979f6cc7dc94cfc1a9c4fb
Reviewed-on: https://chromium-review.googlesource.com/c/1334548
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609345}

about:tracing UI calls TraceLog::GetKnownCategoryGroups() to get categories to
display in "Record" dialog. This function assumes that built-in categories
shouldn't be displayed.

However, the CL https://crrev.com/c/1251361 made almost all categories built-in,
thus a majority of categories isn't displayed in the UI.

This CL fixes this by narrowing the list of non-displayed categories to "meta"
categories.

Bug: 708990
Change-Id: Ic8ccfa396e890983afda96a20ebfe00557f319a9
Reviewed-on: https://chromium-review.googlesource.com/c/1341909Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609344}

Bug: 904983
Change-Id: I204ff2ba026c4f0b5f24cadc0382051f53d09e14
Reviewed-on: https://chromium-review.googlesource.com/c/1336002Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609343}

Currently when the script reads multiple results it overrites the
current result with last value read. It does not compute a mean
or standard deviation.

This change updates the script to keep a list of values. It then
computes a mean and standard deviation from the list.

The first attempt at fixing this returned a list of values. This
was incorrect. Also includes a comment an assert to prevent this.

Bug: 900677
Change-Id: Ided17ea36478128e003e6d9317ca5fb15128415a
Reviewed-on: https://chromium-review.googlesource.com/c/1341211
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#609342}

This is regression in crrev.com/c/1324092.

TBR=dcastagna@chromium.org

Bug: 906650
Test: Manually tested on slate.
Change-Id: I81c4250afd4e1aa1e588bea104d0225c17d038c1
Reviewed-on: https://chromium-review.googlesource.com/c/1342108
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609341}

This CL changes the way to NTP is animating the appearance of the
location bar in the toolbar when the device has a regular width.
It uses a transform instead of changing the bottom constraint of the
location bar.

Bug: 906176
Change-Id: Ia110cafd9d2093a82487b2e3c342337c8cf7ef12
Reviewed-on: https://chromium-review.googlesource.com/c/1341911Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609340}

Set the discardable memory allocator before fuzzing to avoid spurious
null derefs when discardable memory is allocated.
Also, move fuzzer build config to
//skia/tools/fuzzers/BUILD.gn

Bug: 903632, 904613
Change-Id: Ib987333706309eb470bcb988c53ddeebf5f5851e
Reviewed-on: https://chromium-review.googlesource.com/c/1336430
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609339}

This routes changes to MultiUserWindowManager that impact mus windows over
a mojom. This way the ash side can map these windows appropriately.

BUG=756085,875111
TEST=covered by test

Change-Id: Ie69732f290d919e591505234669328e69cc4afc9
Reviewed-on: https://chromium-review.googlesource.com/c/1330719
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609338}

TBR=pwnall@chromium.org

Bug: 906634
Change-Id: I0d457be636e330a06915bff1750da03d90746d16
Reviewed-on: https://chromium-review.googlesource.com/c/1341921Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609337}

Worker keeps encrypted entities until the decryption key is available.
Two tests are added to test verify this behavior.

Bug: 648705
Change-Id: I7e60fdc980eb72601864b98499590d4aae190d50
Reviewed-on: https://chromium-review.googlesource.com/c/1341847Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609336}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/af3328fc7a75..ae6836ecee57


git log af3328fc7a75..ae6836ecee57 --date=short --no-merges --format='%ad %ae %s'
2018-11-19 ehmaldonado@chromium.org Fix the option name for gclient setdep.


Created with:
  gclient setdep -r src/third_party/depot_tools@ae6836ecee57

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:906114
TBR=agable@chromium.org

Change-Id: Ia9a17247db60facd96c2812e946c48ad9631e2d6
Reviewed-on: https://chromium-review.googlesource.com/c/1341865Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609335}

This CL copies over EntityMetadata fields into EntityData for USS types
in ClientTagBasedModelTypeProcessor::MergeDataWithMetadataForDebugging()
so that the right values appear in chrome://sync-internals.

Bug: 904376
Change-Id: Ifd8ef57d32677770ac61f2d3fceaed5f939ba048
Reviewed-on: https://chromium-review.googlesource.com/c/1341993
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609334}

This reverts commit 25718190.

Reason for revert: It breaks FPS counter on Mac
https://bugs.chromium.org/p/chromium/issues/detail?id=906570

Original change's description:
> Using PaintCanvas for HUD
>
> To support OOPR, we need switch from SkCanvas to PaintCanvas which is for
> OOPR.
>
> Bug: 895568
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I94b5430c7ee8ed2f5140d352214ec43f2ff0f8ad
> Reviewed-on: https://chromium-review.googlesource.com/c/1286950
> Commit-Queue: Peng Huang <penghuang@chromium.org>
> Reviewed-by: enne <enne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609033}

TBR=penghuang@chromium.org,enne@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 895568, 906570
Change-Id: I935de60977c0374139ae1eb22670d234f85e0df6
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1342049
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609333}

This suppression was added for autofill assistant, but now that
https://crrev.com/c/1340160 has landed, it is no longer necessary.

Bug: 900912
Change-Id: I69cd099762c4c66d88b1c56ecd948cd2f12a1cd3
Reviewed-on: https://chromium-review.googlesource.com/c/1340512
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609332}

Bug: 751996
Change-Id: I969cd67059c6105f468dc56efe01c8de8869565b
Reviewed-on: https://chromium-review.googlesource.com/c/1202202
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609331}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e86231b9da1a..bfb70dcb5696


Created with:
  gclient setdep -r src-internal@bfb70dcb5696

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I1a7e1dd20a82bd9b68b82a430bfec8295ee46218
Reviewed-on: https://chromium-review.googlesource.com/c/1341863Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609330}

https://chromium.googlesource.com/angle/angle.git/+log/fde74c078f77..774fe563c663


git log fde74c078f77..774fe563c663 --date=short --no-merges --format='%ad %ae %s'
2018-11-19 matavenrath@nvidia.com Make all single line getter functions in State class inline functions.


Created with:
  gclient setdep -r src/third_party/angle@774fe563c663

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I8b7dbc223630ab4c5928b3d703218d570ca2379d
Reviewed-on: https://chromium-review.googlesource.com/c/1341867Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609329}

https://webrtc.googlesource.com/src.git/+log/72bba625d5f7..2058d52d475c


git log 72bba625d5f7..2058d52d475c --date=short --no-merges --format='%ad %ae %s'
2018-11-19 aleloi@webrtc.org Disabling test StunPortTest.TestPrepareAddressHostname on WIN.
2018-11-19 solenberg@webrtc.org Remove ChannelSendState
2018-11-19 mbonadei@webrtc.org Make api:create_peerconnection_factory public.
2018-11-19 solenberg@webrtc.org Remove ChannelReceiveState


Created with:
  gclient setdep -r src/third_party/webrtc@2058d52d475c

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ib2694667a42c02f3cf37419907230dc7cd720ab9
Reviewed-on: https://chromium-review.googlesource.com/c/1341864Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609328}

Navigation history removal was launched, so we don't need the
base::Feature any more.

Bug: 906585
Change-Id: I772539f1ad49d41a3dd949907fb251d15d8a39cc
Reviewed-on: https://chromium-review.googlesource.com/c/1341991
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609327}

Using wpt-import in Chromium 9f0d01c8.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-request

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I1a79dd552f4873a11c4a94573791a779690a14db
Reviewed-on: https://chromium-review.googlesource.com/c/1340515
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609326}

Bug: None
Change-Id: I108539cbf637e8120bed1ad448e0ac2d4060100b
Reviewed-on: https://chromium-review.googlesource.com/c/1327233
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609325}

for dynamic forms.

Change-Id: I9a93913f9b0b6548d05c148a7b8de2b5f671abf4
Reviewed-on: https://chromium-review.googlesource.com/c/1340830Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#609324}

https://chromium.googlesource.com/catapult.git/+log/352a0e0997b9..5913160a7d40


git log 352a0e0997b9..5913160a7d40 --date=short --no-merges --format='%ad %ae %s'
2018-11-19 eyaich@google.com Refactoring remaining diagnostics in histogram.py to diagnostics dir.


Created with:
  gclient setdep -r src/third_party/catapult@5913160a7d40

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:714231
TBR=sullivan@chromium.org

Change-Id: I144e9de671925da87b64dcbee2d0aa6f131eb7d4
Reviewed-on: https://chromium-review.googlesource.com/c/1341866Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609323}

[Autofill Assistant] Scrolling is now disabled when showing full-screen overlays (but remains enabled for partial-screen overlays).

Refactored the touch event filter to support setting full and partial overlays independently. This also fixes a screen flickering issue that could occur when a full overlay was disabled while a partial overlay was enabled.

Bug: 806868
Change-Id: Idac393d47293020ab76fb04aa55d08291a25f27d
Reviewed-on: https://chromium-review.googlesource.com/c/1340306Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#609322}

This way, there won't be a signedness issue when compared to the
internal codebase.

Merge internal change: 222066172

R=bnc@chromium.org

Change-Id: I5c528d96fa459b039582ba3852a16da158db1f70
Reviewed-on: https://chromium-review.googlesource.com/c/1341653Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609321}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/558ce607..655a9bc2

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I0f3c5a9cf1c2473261785477e3f75eda7eb882d3
Reviewed-on: https://chromium-review.googlesource.com/c/1340514Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609320}

chrome.audio is not available on chromecast. This caused
the background script to stop working.  Adding a guard
to make sure the api is available before use.

Test: Manual
Bug: 903924
Change-Id: I9f162d2f80074e72e44deca6d2893255fff37d2e
Reviewed-on: https://chromium-review.googlesource.com/c/1330220
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609319}

Bug: 889916
Change-Id: I552a8c4e7da4e3916a0e8bb5378d4f60252c4cd6
Reviewed-on: https://chromium-review.googlesource.com/c/1329797
Commit-Queue: Anna Malova <amalova@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609318}

https://skia.googlesource.com/skia.git/+log/e7b1a13a1e2a..f7376330d11e


git log e7b1a13a1e2a..f7376330d11e --date=short --no-merges --format='%ad %ae %s'
2018-11-19 rmistry@google.com Temporarily remove Android compile bot from CQ


Created with:
  gclient setdep -r src/third_party/skia@f7376330d11e

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=csmartdalton@chromium.org

Change-Id: I3045089e9733597ddd352a461f2dd83be7c3d5ff
Reviewed-on: https://chromium-review.googlesource.com/c/1341856Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609317}

The header was renamed to traced_value.h since this reflects
which class it really defines. trace_event_argument.h was left
as a forwarding header for those few clients that still depended
on it.

This CL updates these clients to include traced_value.h directly,
and removes trace_event_argument.h

BUG=898787
R=primiano@chromium.org, oysteine@chromium.org
TBR=reveman@chromium.org

Change-Id: I5254a95d4f57a2babba97161d793a0774ca35875
Reviewed-on: https://chromium-review.googlesource.com/c/1341544
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609316}

https://android.googlesource.com/platform/external/perfetto.git/+log/e867072a2353..c7a232c866ae


git log e867072a2353..c7a232c866ae --date=short --no-merges --format='%ad %ae %s'
2018-11-19 fmayer@google.com Merge "profiling: Simplify code to find pids."


Created with:
  gclient setdep -r src/third_party/perfetto@c7a232c866ae

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Id04758393929486a20cbabdae414aeb95d09336b
Reviewed-on: https://chromium-review.googlesource.com/c/1341861Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609315}

Some tests in ModelTypeWorkerTest are testing the behavior of the
worker across restarts. This functionality isn't implemented in the
production code. In addition, the data aren't wired in the test, and
obviously test expectations are commented out.

This CL is cleaning this up and removing those test and associated
plumbing code.

Bug: 648705
Change-Id: I6139ae531256ed2873244a07fdbdde5a2e511c04
Reviewed-on: https://chromium-review.googlesource.com/c/1341920Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609314}

base::AssertBlockingAllowedDeprecated is deprecated in favor of
ScopedBlockingCall, which serves as a precise annotation of
the scope that may/will block.

Please make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation:
      MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
      WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
        server synchronously).
    See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().
  - Calls to blocking //base APIs don't need to be annotated
    with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read,
    base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their
    own internal annotations.

Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1338391

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=rbpotter@chromium.org

Bug: 903957
Change-Id: Ia22660cd032410f40dba9f9f98ccff46d6eaaaf6
Reviewed-on: https://chromium-review.googlesource.com/c/1338488Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609313}

Most of these stem from the root, MessageTransferOperation, which no
longer uses this passed-in parameter.

R=hansberry@chromium.org

Bug: 903991
Test: none
Change-Id: Iedefb2a9cc56e922268aa0ddfec41eb310fc0709
Reviewed-on: https://chromium-review.googlesource.com/c/1340939
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609312}

Bug: 905114
Change-Id: Ib8300998f6f183d7ffd0378ada0fbf02f118b9a2
Reviewed-on: https://chromium-review.googlesource.com/c/1308769Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609311}

This makes sure we don't claim to have consent (or at least be
INITIALIZING) when we're running in standalone transport mode.
In practice, this probably wasn't a problem, since most data types
are disabled in transport mode anyway, but let's be cautious here.

Bug: 856081, 906609, 871221
Change-Id: Ie6d2d0ef4f81d0f51d66ddd9a2d55daba2c1093e
Reviewed-on: https://chromium-review.googlesource.com/c/1341916
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Florian Uunk <feuunk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609310}

This CL takes care of the boilerplate to pass upload data along.
The DownloadService will go through the Data Manager and get the request
body if the request is an upload.

Bug: 1329149
Change-Id: I8ae6664f7b0fe2735451cc5ddf14faa3562c00e1
Reviewed-on: https://chromium-review.googlesource.com/c/1329622
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609309}

This ensures that the same UI surface that is shown when going to
Settings > Passwords will also be shown when selecting one of the
following:
- The option to "Manage passwords" in the accessory sheet
- The option to "Manage passwords" the autofill dropdown
- A link pointing to where the generated password is
saved, in the GeneratedPasswordSavedInfobar

Bug: 903249
Change-Id: I0c718be6b6b3b6c70a96e860f434f88eebfe8777
Reviewed-on: https://chromium-review.googlesource.com/c/1337333Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609308}

Change-Id: I0243c3853632ec44a2e1e4ec4220ce4425e05e64
Bug: skia:2664
Reviewed-on: https://chromium-review.googlesource.com/c/1341217
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609307}