GitLab

BUG=125846
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10382155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137173 0039d316-1c4b-4281-b951-d872f2087c98

CID=103645
BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10382165

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137172 0039d316-1c4b-4281-b951-d872f2087c98

CID=103455
BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10386130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137171 0039d316-1c4b-4281-b951-d872f2087c98

R=aa@chromium.org
BUG=127316
TEST=ExtensionTest.GetResourceURLAndPath,WebIntentsRegistryTest.GetIntentServicesForExtensionFilter

Review URL: https://chromiumcodereview.appspot.com/10384072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137169 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124088
TEST=none
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10392096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137167 0039d316-1c4b-4281-b951-d872f2087c98

Disabling precompiled headers for official builds with msvs2010

Selectively disabling precompiled headers for release builds with msvs2010
Precompiled headers seem to interact badly with auto-sharding using the
msvs_shard option.

Incudes speculative fix for KeyError in Linux gyp builds (see http://build.chromium.org/p/chromium.pyauto/builders/Linux%20%28deb%29/builds/33094/steps/update/logs/stdio for details) that removes line 140 from http://codereview.chromium.org/10392091/diff/6/build/common.gypi

BUG=127875
TEST=builds on trybots.
R=kerz@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10332173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137166 0039d316-1c4b-4281-b951-d872f2087c98

Added CSP to GAIA auth extension. Needs to land after https://gerrit.chromium.org/gerrit/#change,22663.

BUG=chromium:127221
TEST=make sure ChromeOS auth + autotests still work


Review URL: https://chromiumcodereview.appspot.com/10398031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137165 0039d316-1c4b-4281-b951-d872f2087c98

Do not consume an ET_KEY_RELEASED event in NativeTextfieldViews and NativeComboboxViews so FocusManager could process an ET_KEY_RELEASED accelerator.

BUG=127520,123856
TEST=try

Review URL: https://chromiumcodereview.appspot.com/10389035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137164 0039d316-1c4b-4281-b951-d872f2087c98

Checks weren't taking into account the possibility of a later allocation re-using a
deleted pointer.

TBR=willchan@chromium.org
BUG=90971
BUG=100566
TEST="browser_tests --gtest_filter=BrowserCloseTest.DISABLED_DownloadsCloseCheck_1 --gtest_repeat=10 --gtest_also_run_disabled_tests" with no crash.


Review URL: https://chromiumcodereview.appspot.com/10389030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137163 0039d316-1c4b-4281-b951-d872f2087c98

This mostly reverts r135025 and does it correctly based on how it really works.

BUG=127749
TEST=as in bug


Review URL: https://chromiumcodereview.appspot.com/10388145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137162 0039d316-1c4b-4281-b951-d872f2087c98

TEST=still compiles
BUG=119473


Review URL: https://chromiumcodereview.appspot.com/10332148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137161 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137160 0039d316-1c4b-4281-b951-d872f2087c98

Change-Id: Ie6079866fb0b957e56aff2993745e8976c4fb10b

BUG=124402
TEST=Test system notifications (power, network, sms) especially around screen lock/unlock.

Review URL: https://chromiumcodereview.appspot.com/10382118

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137159 0039d316-1c4b-4281-b951-d872f2087c98

Take files out of ppapi_proxy_untrusted.gyp that have been removed. Roll googleurl DEPS.

BUG=116317
TEST=

Review URL: https://chromiumcodereview.appspot.com/10382138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137158 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137157 0039d316-1c4b-4281-b951-d872f2087c98

It broke Chromium OS test bots:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/3668

BUG=None
TEST=None
TBR=tkent@chromium.org, jianli@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10382173

TBR=mnissler@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10383188

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137156 0039d316-1c4b-4281-b951-d872f2087c98

This restores a hack that was in place in the old NativeTabContentsContainer code that seemed to clear focus during restoration (though the hack was for another purpose, the hack seemed to fix this bug too). I've isolated the hack to the re-activation code.

http://crbug.com/125976
TEST=see bug
Review URL: https://chromiumcodereview.appspot.com/10378043

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137040
Review URL: https://chromiumcodereview.appspot.com/10378043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137153 0039d316-1c4b-4281-b951-d872f2087c98

TBR=kalman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10384177

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137152 0039d316-1c4b-4281-b951-d872f2087c98

The touchpad can deliver multiple GestureFlingCancel events within the 
time window in which we would like to continue to suppress mouse events
after the GFC that actually halted the in-progress fling. This change
makes the TapSuppressionController stop resetting its state machine
on the receipt of such events such that tap suppression continues
throughout the time window following a fling-cancelling GFC regardless
of intervening GFC events.

BUG=122043
TEST=by hand


Review URL: https://chromiumcodereview.appspot.com/10399017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137150 0039d316-1c4b-4281-b951-d872f2087c98

This required a few smaller changes:
 * Refactor some code for creating the detailed view.
 * Change the layout code for the new layout in the mocks.
 * Add a way for re-using an existing bubble instead of creating a new one.

BUG=127430
TEST=aura_shell_unittests.BubbleCreationTypesTest

Review URL: https://chromiumcodereview.appspot.com/10384178

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137149 0039d316-1c4b-4281-b951-d872f2087c98

BUG=121574,79331
Review URL: https://chromiumcodereview.appspot.com/10383174

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137144 0039d316-1c4b-4281-b951-d872f2087c98

Run the devtools sanity tests as a browser_test instead of interactive_ui_test. These tests don't depend on being the foreground window, so better to run them as browser_tests because those are sharded.

BUG=121574
Review URL: https://chromiumcodereview.appspot.com/10383176

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137143 0039d316-1c4b-4281-b951-d872f2087c98

Furthermore GoogleOneShotRemoteEngineConfig struct has been renamed and moved into the (more generic) SpeechRecognitionEngineConfig, that will be shared with the streaming recognition engine implementation.


BUG=116954
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10233010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137141 0039d316-1c4b-4281-b951-d872f2087c98

Bug=124566
Test=Compiles on CrOS,Mac

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137075

Review URL: https://chromiumcodereview.appspot.com/10378009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137140 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:119671
TEST=None
TBR=jam@chromium.org, csilv@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10332175

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137139 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137138 0039d316-1c4b-4281-b951-d872f2087c98

This allows interposing the DownloadResourceThrottle on all web 
downloads, not just those occuring because of navigations.

BUG=127522
R=darin@chromium.org
TEST=Retry example in referenced issue; look for throttling message.


Review URL: https://chromiumcodereview.appspot.com/10381122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137137 0039d316-1c4b-4281-b951-d872f2087c98

- Make arm_float_abi (softfp/hard) gyp-time selectable.


Review URL: https://chromiumcodereview.appspot.com/10399019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137136 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=try
TBR=yoshiki@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10332166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137135 0039d316-1c4b-4281-b951-d872f2087c98

BUG=126861
TEST=See bug.
Review URL: https://chromiumcodereview.appspot.com/10387129

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137133 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:125170
TEST=Manual testing on an Alex device.


Review URL: https://chromiumcodereview.appspot.com/10389064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137131 0039d316-1c4b-4281-b951-d872f2087c98

With the current setup, if you have a header file my_class.h

class BASE_EXPORT MyClass {
 public:
  void MyInlineMethod() { /* do stuff, inline */ }
};

then every cc file that includes my_class.h will have a public symbol
for MyInlineMethod (because inline methods need to be emitted to
every translation unit, and the linker sorts them out). With the
components build, the linker can't decide to drop these inline methods,
so every .so that uses this header file will have the same public symbol.

With this proposed change, the symbol will only be visible in the target
the header file belongs to, and it will be hidden in all other components.
That's cleaner, and it also prevents accident hidden dependencies (say
target A depends on B, and B depends on C. A accidentally uses an inline
function from a class in C. With this change, that would result in a linker
error, and an explicit dependency from A on C would have to be added).

Also add a missing CHROMEOS_IMPLEMENTATION define which went
unnoticed until now.

BUG=90078
TEST=Things still build.
TBR=ben, tony, viettrungluu, thestig, agl, willchan

Review URL: https://chromiumcodereview.appspot.com/10386108

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137130 0039d316-1c4b-4281-b951-d872f2087c98

The EtwTraceConsumerRealtimeTest test fixture subclass contained a second instance of the
test_provider_ member variable. This occluded the initialized superclass instance's variable
and led to the test relying on uninitialized data.

BUG=127671
TEST=Unittests pass on Vista.


Review URL: https://chromiumcodereview.appspot.com/10386141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137129 0039d316-1c4b-4281-b951-d872f2087c98

Rename tests_run to test_isolation_mode.

TBR=mad@chromium.org
BUG=98636
TEST=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10392073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137127 0039d316-1c4b-4281-b951-d872f2087c98

Show credit card icons for the new Autofill Gtk popup.


BUG=51644
TEST=


Review URL: https://chromiumcodereview.appspot.com/10396003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137126 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137125 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10381153

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137124 0039d316-1c4b-4281-b951-d872f2087c98

Depends on https://bugs.webkit.org/show_bug.cgi?id=85976.
This is used by chrome on android.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10388045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137123 0039d316-1c4b-4281-b951-d872f2087c98

rateInMilliseconds should be rate_in_milliseconds.

BUG=Style
TEST=Existing


Review URL: https://chromiumcodereview.appspot.com/10381148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137122 0039d316-1c4b-4281-b951-d872f2087c98

It's the only plausible cause for UserManagerTest.RemoveAllExceptOwnerFromList failures.

BUG=None
TEST=Tree becomes greener.
TBR=bartfab@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10377147

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137121 0039d316-1c4b-4281-b951-d872f2087c98