- 04 Jun, 2019 40 commits
-
-
Sam Maier authored
Bug: 908988 Change-Id: I9cfe718d3754b92022c9045f860dee36c7e049bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635949 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#665957}
-
Takuto Ikuta authored
The test is slow on android. https://chromium-swarm.appspot.com/tasklist?c=name&c=duration&c=state&d=desc&f=pool-tag%3AChrome&f=state%3ACOMPLETED_SUCCESS&f=name-tag%3Apixel_test&k=name-tag&s=duration Bug: 941946 Change-Id: I142e57e41662d0ccfa8215c06e5ec6091c3c4cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642754 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#665956}
-
Erik Wolsheimer authored
Change-Id: I2d6d9628f752860afcc8bf13caecc36e2c10fc5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640788Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Erik Wolsheimer <ewol@google.com> Cr-Commit-Position: refs/heads/master@{#665955}
-
Jon Wilson authored
Bug: 950413 Change-Id: I6959707406d1830c5570321b24860441f8eca43a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642529Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Jon Wilson <jpwilson@google.com> Cr-Commit-Position: refs/heads/master@{#665954}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/886d9e9f735a..009bc1a74cf5 Created with: gclient setdep -r src-internal@009bc1a74cf5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=harringtond@google.com,orphis@google.com,shend@google.com Change-Id: Ief09636e2e1dc92ed265b11cd7caac9f91467b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643315Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665953}
-
Lowell Manners authored
Bug: 786836 Change-Id: I37d56bedccfeb2f59f908b63d6782dc976aba76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628732Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#665952}
-
W. James MacLean authored
This CL makes page-level state from Blink's TextAutosizer available to remote-frame renderers by plumbing it through the browser process and sending it back out using a PageMessage. While this CL does not fix TextAutosizing in OOPIF renderers, it makes the necessary information available in those renderers. Bug: 393285 Change-Id: I1bc04fb503821e1eeebfc8f2aa919007ed35a279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627930 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#665951}
-
danakj authored
This adds a ChromeBrowserTests java activity and application, based on content and components browser tests. It additionally sets up a ChromeBrowserInitializer which is needed before running the native setup of ChromeBrowserMainParts etc. The JNI_Onload runs the Chrome Android production path to set up a ContentShellDelegate, and unsets the product version number afterward as tests do no expect to have a version number. The test_activity.xml layout refers to a ShellManager as the java pieces are setting up the same UI as content-based browser tests for now. We will need to use more Chrome java pieces for the UI in order for tests to call out to java probably. But this gives a baseline framework that runs the //chrome C++ code in an Android browser test. We still need a BrowserTestBase subclass to provide the Test class so that we may begin writing browser tests on Android. We standardize the java code for content and components browser tests while writing the ChromeBrowserTestsApplication, based on the code in ChromeApplication and NativeUnitTest. In order to depend on NestedMessagePumpAndroid in browser tests, but not depend on WebTestSupport, we split the web_test_support target into two parts, and we depend on the NestedMessagePumpAndroid in each place it is used directly, which are the onload.cc files for each android browser test target. We remove dependencies on web_test_support from everywhere but content_shell_lib, where it is used. R=jam@chromium.org Bug: 961849 Change-Id: I4212482849eaf52dc8b8c22070806572215a8905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633212 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Yun Liu authored
Currently only set default output directory for instrumentation tests https://cs.chromium.org/chromium/src/build/config/android/internal_rules.gni?type=cs&q=%22--coverage-dir%22&sq=package:chromium&g=0&l=763-772 Should do the same for junit tests as well. Will use this default directory to collect coverage data on bot. Bug: 970021 Change-Id: I346a8a1493622e61634eebd340b4a8c1c64e93e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641379Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=mcasas@chromium.org Change-Id: I3c7f0757fba9484cd6a44f5bb2cdac434cdd3fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635814 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#665948}
-
Katie D authored
The widget had no insets in which to display the shadow. In this change, add insets to the widget, and ensure they are taken into account after calculating the preferred layout for the autoclick menu view. Bug: 966153 Change-Id: If43a4f3e91f20261195102018aad90c8427ac9a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636285Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#665947}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/525aa0ca60c8..62fd2c32bbe6 git log 525aa0ca60c8..62fd2c32bbe6 --date=short --no-merges --format='%ad %ae %s' 2019-06-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-06-04 brianosman@google.com Interpreter: Minor cleanup of opcodes 2019-06-04 jbroman@chromium.org Don't mark inline functions in SkString.h as static. 2019-06-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-06-04 borenet@google.com [infra] Supply revision as target_branch to bot_update 2019-06-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader bb575d48d5f9..79d4ac9ab695 (6 commits) Created with: gclient setdep -r src/third_party/skia@62fd2c32bbe6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: I7cb2f83a5aa7ffb030b4e5cd17def3a4458dcb57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643490Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665946}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=rsesek@chromium.org Change-Id: I0a25ecf615af7e81acf65422c7f91870395bb68c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636192Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#665945}
-
Alison Maher authored
This change fixes flaky test failures caused by the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/1591484/22 Flaky behavior is fixed for the following tests: -DumpAccessibilityTreeTest.AccessibilityIframePostEnable -DumpAccessibilityTreeTest.AccessibilityIframe DumpAccessibilityTreeTest.AccessibilityIframePostEnable is also re-enabled as a revert to the following change: https://chromium-review.googlesource.com/c/chromium/src/+/1638201 Bug: 969185 Change-Id: I1c961f215936a04ba54b5dd5ca6ba35205567648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638925Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#665944}
-
Jeremy Roman authored
Bug: 955171 Change-Id: Ie939ad338912fdfe7f54c30f0d416efc407a63b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638280 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#665943}
-
Jun Mukai authored
The LauncherAnimationsTest measures the performance for one-shot action. Recently the app-list widget will remain and be reused once created for the performance reason, but the existing one-shot scenario doesn't capture it properly. This CL adds new test scenarios which opens and closes the app-list in prior to the actual test scenario, so that we can measure the performance on both one-shot and reused. Here's the performance on 5 runs in nocturne:nocturne: one-shot Fullscreen: 13, 13, 13, 13, 13 Close: 79, 79, 39, 79, 73 Peeking: 58, 33, 49, 49, 33 Close: 100, 100, 100, 100, 91 Half: 33, 49, 33, 41, 41 Close: 58, 100, 91, 83, 100 FullscreenSearch: 46, 66, 59, 86, 66 Close: 79, 100, 93, 93, 93 reused Fullscreen: 66, 59, 59, 59, 66 Close: 93, 100, 100, 100, 93 Peeking: 83, 83, 91, 100, 74 Close: 100, 100, 100, 100, 100 Half: 74, 91, 91, 83, 91 Close: 100, 100, 100, 100, 100 FullscreenSearch: 86, 93, 93, 86, 86 Close: 93, 86, 93, 100, 86 So this CL reveals that the reusing improves the appearing animation smoothness. Fullscreen-app-apps isn't still ideal, but the numbers aren't bad. Bug: 961467 Test: cros_run_test on nocturne Change-Id: I69907f9c70b3dec3655b873ddcbe5611ab3432a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639558Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#665942}
-
Wojciech Dzierżanowski authored
Recreating the NetworkContext upon the network service process restart is a legitimate scenario where a new CustomProxyConfigClient ought to replace any old CustomProxyConfigClient set in DataReductionProxySettings. Bug: 970236 Change-Id: I849b8aebd5f94cab50d11318101e96ffc4c51589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642639Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#665941}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2c0111e6eba7..620197bd6535 git log 2c0111e6eba7..620197bd6535 --date=short --no-merges --format='%ad %ae %s' 2019-06-04 afdx@google.com Add fuzzer pass that adds useful constructs to a module (#2647) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@620197bd6535 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I31a59be26e9e5eb5b76c4c822d84a044fec2aebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643078Reviewed-by:
-
Caleb Raitto authored
See crrev.com/c/1590404 and the linked bug for context -- the goal is to fix the broken memory-leak checking in Chromium's ASAN (AddressSanitizer) trybots, which are supposed to also run LSAN (LeakSanitizer). Currently-leaking tests must be fixed or disabled before leak checking can be enabled in the ASAN trybot. WARNING: This will result in a loss of ASAN coverage for the affected tests given that LSAN runs as part of the ASAN trybot. If that's not acceptable, we can wait until the leaks are fixed before fixing leak detection in trybots, but keep in mind that newly-introduced leaks Chromium-wide won't be caught until then. Bug: 969789 Change-Id: I543d75510a71662b03bf1e75e7637a24da41b919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641545Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#665939}
-
Nate Chapin authored
https://html.spec.whatwg.org/multipage/browsing-the-web.html#navigate indicates that javascript: url handling should be modeled like a navigation as much as possible. The spec is slightly unworkable in places, but this CL changes our handling to greatly resemble traditional navigations. This also removes the sole case where a DocumentLoader would be associated with 2 different Documents over its lifetime. Change-Id: I169cab35a54bf87634e326fc0c400c01122c3512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553718Reviewed-by:
-
Gauthier Ambard authored
This CL changes the separator displayed on the iPad NTP. Instead of being always visible the separator is now fade in when the fake omnibox is reaching the real omnibox. Bug: 968520 Change-Id: I5421094499a57d023d1a5c533bab68a4a76b6e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643570 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#665937}
-
Steven Zhu authored
When |io_task_runner| is power managed, delayed tasks and timers running on it can wake up the system. Bug: internal b/132993317 Change-Id: Iee07e47e51e8c5f0ac011d351ba9fff3822f32b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637997Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Steven Zhu <jz@chromium.org> Cr-Commit-Position: refs/heads/master@{#665936}
-
Eric Orth authored
All DoH queries will be padded to the next multiple of 128 bytes. Implemented as a feature of DnsQuery to add the padding to the OPT record, rather than just having it specified in the |opt_rdata| passed to the DnsQuery constructor because adding the correct amount of padding requires knowledge of the DnsQuery being constructed. Bug: 967848 Change-Id: I6be13c24c770e80d06ac3f7e988cdf814ce5c00e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614454 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#665935}
-
Chris Harrelson authored
Bug: 957248 Change-Id: Iabd11d14ce835668b3c455c35ff5534189fb54b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638289Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#665934}
-
Vladimir Levin authored
Accessing the offset mapping with a locked subtree is not correct, since it may not have been laid out. The exceptions for this are things that force the layout before accessing them. This patch fixes a DCHECK/crash that happens when an element is locked while some text within it is selected. The general approach is to mimic the behavior of display: none (which doesn't generate a layout object), or visibility: hidden (which is explicitly checked in the code). R=chrishtr@chromium.org, rakina@chromium.org Bug: 966754 Change-Id: Ib67fa345d7554b9caf6307db33bfc26e0582c950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628871 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#665933}
-
Chris Hamilton authored
This builds a cheap RTTI for full casting between the 4 basic flavors a node can take in the graph: a Node, a NodeBase, a public FooNode, and a private FooNodeImpl. This casting is necessary for private graph internals to use the public observer interfaces, so we can avoid having to maintain separate public and private observer interfaces. A further CL will remove NodeBase entirely in favor of Node. BUG=910288 Change-Id: I542b01ab0af6d73297c39b4c2cf3205de4769b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637846Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#665932}
-
David Benjamin authored
Per https://crbug.com/795110#c3, newer fontconfigs are threadsafe. https://bugs.chromium.org/p/skia/issues/detail?id=1497 suggests the relevant version is 2.10.91. third_party/fontconfig is newer than that now, so remove the suppression. Bug: 795110 Change-Id: Ib9297814d682e75278c6d9d78d6c7d5315b5fce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643027 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#665931}
-
Nicolás Peña Moreno authored
This CL makes the implementation match the changes in the explainer: https://github.com/WICG/element-timing. In particular, name is now set to "image-paint" for image entries, and url is added. Bug: 879270 Change-Id: Id02e5305ac1e9bf9fa1fc18efe63d8cc280c5f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635733Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#665930}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d4e26bda..9672bf6d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I42687ecf102ef2ede57e7ed98e97653261f29d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643309Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665929}
-
Sean Gilhuly authored
Add enum option for Skia Vulkan, and enable filters pixeltests that are passing on X11 with vulkan Swiftshader. Bug: 963446 Change-Id: I31541555ef0123a3dd894180898d251720b807fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641382Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#665928}
-
Dominik Röttsches authored
Enable size reductions: * HB_NO_UCD ensures that UCDN is not built-in to avoid a size increase of around 60k * HB_NO_MATH to disable OT MATH table parsing until we need it, * HB_NO_NAME, since we currently do not use HarfBuzz' OT name table parsing, * HB_NO_BUFFER_SERIALIZE" since we are not making use of HarfBuzz buffer serialization, usually used by tools such as hb-view/hb-shape or for debugging. https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/c73d7ba75d45..97b926857759 $ git log c73d7ba75..97b926857 --date=short --no-merges --format='%ad %ae %s' 2019-06-01 ebrahim [ci] Downgrade Travis distribution upon Behdad request 2019-06-01 ebrahim [ci] Install ragel on appveyor mingw bots 2019-06-01 ebrahim [dwrite] Replace REPLACEME with release version the symbol had 2019-05-31 behdad 2.5.1 2019-05-31 behdad [docs] Fix dist 2019-05-31 behdad Fourth try at building VS bots 2019-05-31 behdad [ci] Disable VS 2013 2019-05-31 behdad Third try at fixing VS build 2019-05-31 behdad Second VS fix try 2019-05-31 behdad Try fixing VS builds 2019-05-31 behdad [ci] Enable other versions of Visual Studio 2019-05-31 behdad Whitespace 2019-05-31 rsheeter [subset] Correct calculation of max offset; fixes bug where loca would erroneously be short 2019-05-31 behdad [gsub] Minor 2019-05-31 behdad [gsub] Porting serialize to iterators 2019-05-31 behdad [serialize] Pass offset to serialize_subset() 2019-05-31 behdad [serialize] Pass offset to serialize_copy() 2019-05-30 behdad [math] Rename HB_MATH_GLYPH_PART_FLAG_EXTENDER 2019-05-29 ebrahim [ci] Clean up and add disabled bots of other msvc versions (#1733) 2019-05-28 bruce.mitchener Fix some typos. 2019-05-28 ebrahim [test] minor, fix copyright 2019-05-28 ebrahim [test] minor style improve 2019-05-26 corbett.dav [use] Allow U+1A60 TAI THAM SIGN SAKOT after vowel 2019-05-27 behdad [atomic] Fix warning, second time 2019-05-25 behdad [ucd] Update for latest packTab 2019-05-25 behdad [ucd] Update for recent packTab 2019-05-25 ebrahim [ci] minor 2019-05-25 ebrahim [ci] minor 2019-05-25 ebrahim [ci] Store dist-win result instead 2019-05-25 behdad [atomic] Fix warnings 2019-05-25 behdad [mingw] Update instructions 2019-05-25 behdad [mutex] Prefer pthread over windows 2019-05-25 behdad Look for pthread even if win32 2019-05-25 behdad [mingw] Some more tweaks 2019-05-25 behdad [mingw] Add "make dist-win" to toplevel Makefile 2019-05-25 behdad [mingw] More 2019-05-25 ebrahim [ci] Remove --without-icu now that we have it in ./mingw{32,64} scripts 2019-05-25 behdad [mingw] Force off ICU 2019-05-25 ebrahim [ci] Build mingw on Fedora and store .exe outputs 2019-05-25 behdad [ming2] Update instructions 2019-05-25 behdad [mingw] Rename README.wine 2019-05-25 behdad [mingw] Update for recent change 2019-05-25 behdad [mingw] Update for Fedora mingw installation location 2019-05-25 nwillis Usermanual; minor. 2019-05-24 behdad [win] Add mingw-ldd.py 2019-05-24 behdad 2.5.0 2019-05-24 behdad Put back Since: tags for hb_color_get_* 2019-05-24 nwillis Usermanual-buffers-chapter: trim out fallback-of-ufuncs talk and just mention that stuff exists if you care to go find it. 2019-05-24 qxliu Fix fuzzer crash testcase 2019-05-24 nwillis Usermanual-buffers-chapter: explain ICU fallback for Ufuncs. (...) 2019-05-15 behdad Use hb_map(hb_add(this)) to dereference OffsetTo<>'s 2019-05-15 behdad [algs] Rename hb_bind to hb_partial 2019-05-15 behdad [algs] Change hb_bind parameter number to be from one 2019-05-15 behdad Add back symmetric OffsetTo<>::friend operator+ 2019-05-15 behdad [algs] Partialize all operators 2019-05-15 behdad [algs] Rewrite bind API 2019-05-15 behdad [algs] Add hb_bind0 and hb_bind1 2019-05-15 behdad Fix clang build 2019-05-15 behdad Fix clang build 2019-05-15 behdad [algs] Remove pair copy constructor 2019-05-15 behdad Whitespace 2019-05-09 grieger [subset] Switch SingleSubst to use iterators in serialize. 2019-05-15 behdad Reduce captures of lambdas 2019-05-15 behdad Fix tests 2019-05-15 behdad Remove variadic form of hb_min/hb_max 2019-05-15 behdad Add arithmetic operators 2019-05-15 behdad Add hb_bitwise_* ops 2019-05-15 behdad [array] Adjust operator!= 2019-05-15 behdad More adjustment to OffsetTo<>::friend opeator+ 2019-05-15 behdad [iter] Simplify operator!= of iterator filters 2019-05-15 behdad Add all pair_t comparison operators 2019-05-15 behdad [iter] Use default operators instead of redefining empty ones 2019-05-15 corbett.dav Convert Consonant_Initial_Postfixed to CONS_MED 2019-05-15 corbett.dav Fix record-test.sh on machines without sha1sum 2019-05-15 ebrahim [ci][test] Ignore other gcov symbols also 2019-05-15 ebrahim [ci][travis] Update its distribution 2019-05-15 behdad Another try 2019-05-15 behdad Completely revert the thing back 2019-05-15 behdad Another try at fix 2019-05-15 behdad Ugh. How was the Travis bot happy before, but isn't now?! :( 2019-05-15 behdad Move OffsetTo operator+ back out of class 2019-05-15 behdad Revert "Revert symmetric OffsetTo overloads" 2019-05-15 behdad Revert symmetric OffsetTo overloads 2019-05-15 behdad Use implicit lambda return type 2019-05-14 behdad Add symmetric friend operator+ for OffsetTo 2019-05-14 behdad Move OffsetTo<> deref operators in-class as friends 2019-05-14 behdad Whitespace 2019-05-14 behdad [iter] Remove sort categorization 2019-05-14 behdad Start of gen-ucd.py, to replace UCDN 2019-05-13 qxliu [subset] retian nameids from STAT and fvar tables 2019-05-14 behdad Hopefully last warning fix 2019-05-14 ebrahim [ci] add HB_TINY to asmjs builder 2019-05-14 ebrahim Fix -Wunused-function on HB_NO_SHAPE_AAT 2019-05-11 nwillis Usermanual, fix up userfeatures example code in OpenType features section of shaping chapter. 2019-05-11 nwillis Usermanual, minor: flesh out invisible-glyph discussion in buffers chapter. 2019-04-30 nwillis [Docs] Usermanual; update XML manifest for new chapters. 2019-04-30 nwillis [Docs] Usermanual; add Utilities chapter. 2019-04-30 nwillis [Docs] Usermanual; add Shaping, Features, and Plans. 2019-04-30 nwillis [Docs] Usermanual; add Fonts And Faces chapter. 2019-04-30 nwillis [Docs] Usermanual; fill out Buffers chapter. Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org Bug: 969685 Change-Id: I1adff3c14741145ef228ff3990435928dd04c1ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640414 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#665927}
-
Chris Harrelson authored
Bug: 968928 Change-Id: I0d52b73349711cd85a930b35ae659662e18a899c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640827Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#665926}
-
Bill Budge authored
- Adds new net::CacheType values so the JS code cache can be distinguished from the WASM code cache. GENERATED_BYTE_CODE_CACHE refers to Javascript, GENERATED_NATIVE_CODE_CACHE refers to WebAssembly. - Changes SimpleBackendImpl::MaxFileSize to allow PNACL and WASM cache entries to take up to 1/2 of the cache. The previous limit was 1/8 of the cache. This CL makes it possible for apps with large WASM modules (150 MB) to benefit from code caching on desktop. The limit of 1/2 the cache size is somewhat conservative. PNACL entries are also native code and can occupy the entire cache (see BackEndImpl::MaxFileSize). Bug: chromium:719172 Change-Id: Id177862f00c138034d43a5256d317928a48aa467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636648Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#665925}
-
Etienne Bergeron authored
This CL is adding a test that will fail when the system doesn't have the default UI settings. Chrome unittests often rely on these default values. Previously, the EXPECT were running into: static void SetUpTestSuite() { ... } which does not make the test suite to fail on any error. We are proposing to add a separate test only for testing the computer states. R=tapted@chromium.org Bug: 963868 Change-Id: I08fc33e0fb35d278562e4bcbb977e5376f3d415e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637670Reviewed-by:Trent Apted <tapted@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#665924}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5e67c8e8ef64..886d9e9f735a Created with: gclient setdep -r src-internal@886d9e9f735a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=harringtond@google.com,orphis@google.com,shend@google.com Change-Id: I20083d4a75cd2a4b9f6f6af2f87bdc2784540335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643494Reviewed-by:
-
Adam Raine authored
CSSPaintImageGeneratorImpl::InputArgumentTypes required an extra case for off main thread CSS Paint to uses MainThreadDocumentPaintDefinition instead of DocumentPaintDefinition. This required MainThreadDocumentPaintDefinition to have an addition member to include the input argument types. An extra parameter was added to PaintWorklet::RegisterMainThreadDocumentPaintDefinition and its references were also changed to accommodate the extra member for the input argument types. Unit testing was added. Bug: 946519 Change-Id: I038e5146a5bb6f2d2cec96799f32eae9eb6f5dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635732Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Adam Raine <asraine@google.com> Cr-Commit-Position: refs/heads/master@{#665922}
-
Vladislav Kuzkokov authored
Add a check for signin time limit being reached while the device was in sleep mode. Bug: 871109 Change-Id: I463f8e344c443105ee128acb2383b89d2267357a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640556Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#665921}
-
Bryan McQuade authored
In my client, some devtools URLs have just "devtools://" scheme. This change filters those URLs from jank tracker debug logs. Change-Id: I48e5e63634e1f73fb2b1e9f70cb596f9a5d7a91d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642393Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#665920}
-
Colin Blundell authored
The Device Service needs to clean up parts of its internal state as part of browser shutdown, notably, BatteryStatusService. However, it also needs to run on the UI thread, and embedded services that run on the UI thread are not guaranteed to be destroyed as part of browser shutdown (tasks to destroy these services are posted from the IO thread by ServiceManagerConnectionImpl::ShutDownOnIOThread, but the UI thread is typically shut down before these posted tasks are run). To solve this issue we discussed adding plumbing wherein embedded services could inform //content that they wanted to be notified when shutdown was occurring on the main thread. However, on investigation this plumbing would be painful to implement: it is only EmbeddedInstanceManager that has direct information of these service instances, and that object lives far away from //content's ServiceManagerContext, the object that knows when shutdown is occurring on the main thread. This CL takes an alternative approach of having the BatteryStatusService object be stashed in a SequenceLocalStorageSlot to ensure that it is destroyed on browser shutdown. I have verified that its destruction is triggered on shutdown of content_shell. This CL is conceptually a reland. The original CL (which had the Device Service directly observe destruction of the UI thread) was reverted for the following reason: "crbug.com/856771 presents a crash that it introduced on ChromeOS: the Device Service instance is now shut down after the DBusThreadManager global instance, on which it implicitly depends." However, crbug.com/794105 has continued to be a problem on Windows, and there aren't active engineering resources for an alternative solution to this one. Hence, this CL relands an approach that is similar to the original fix with the shutdown not being applied on ChromeOS to avoid triggering crbug.com/856771. As I wrote in the revert, "this is all sad-making, but c'est la vie." The usage of SequenceLocalStorageSlot rather than direct observation of MessageLoop is thanks to a suggestion from rockot@. Bug: 794105, 856771 Change-Id: I85709113299ae329ed560e00b78303fe0beecad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605906 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
Mehran Mahmoudi authored
This fixes a crash that was caused by tapping on the cookies toggle in site settings. Bug: 968842 Change-Id: I5e57f2e3f201500ce79d4bda4dc2bf2ae2456186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640803Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#665918}
-
